slack_messaging 1.4.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3508ee5d59522e0a8d3c931e165bee408d707240fc4c3a1aadbabd2d5b6799f9
-  data.tar.gz: 67bc57eb2943f0f9f801eac68e25988ee4b06ac20835dd2f46b24b4599d213d5
+  metadata.gz: db2a04a6f53bd5e7d0d1017fe6fd5f6c715cc89d108be3dad1eb3a433f944be0
+  data.tar.gz: 5487fbcfcf279a48911d773c928826b8f7b2e021710d457c0fa256fa1660562e
 SHA512:
-  metadata.gz: 0aa1c61dcb454f5beef05a9ecc13da9e16a258812952013675d2bc5a4b3230d6f80f9b08d47d3de0168a6fb85a180fe1a9d2b78e6b68474c6ae615fdf7639081
-  data.tar.gz: dd9967c7e2347435a1194961f03f7d5329f45cb839a47130cc1bb901cd324234e854a457a274cfccc54c9903cd322157f06dc0b61baa9e283d21daa549c7dc51
+  metadata.gz: 76485ac006bb26c047e57e06283ced474b36c5924229dbd58b83a3ea8e2e30e92e8ca916fb7fd24b538ad235a54f427f29e03e4f1dcff382b57eb69d7b71e578
+  data.tar.gz: fe229444fe0b9a050d29a6b8c2fc653f287b85d49f965efc76cc81b5f7f3eb677fd79376a0fff012460febc1cd61d4896e9b6f0cf2098557b7a34130de155c42

data/Gemfile.lock

@@ -1,12 +1,13 @@
 PATH
   remote: .
   specs:
-    slack_messaging (1.4.0)
+    slack_messaging (2.0.0.pre.test)
       activesupport (~> 6.0)
       gli (~> 2.10)
       hashie (~> 4.1)
       highline (~> 2.0)
       httparty
+      json
       rack (~> 2.2)
 
 GEM
@@ -47,6 +48,7 @@ GEM
       multi_xml (>= 0.5.2)
     i18n (1.8.5)
       concurrent-ruby (~> 1.0)
+    json (2.3.1)
     listen (3.3.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
@@ -96,6 +98,7 @@ DEPENDENCIES
   bundler (~> 2.1)
   faker
   guard-rspec (~> 4.3)
+  pry
   rake (~> 13.0)
   rspec (~> 3.9)
   slack_messaging!

data/README.md

@@ -50,7 +50,7 @@ To print a friendly message to Slack, run:
 slack-messaging slack
 ```
 
-from the main directory. Here, no specific message is being given to print to Slack, so slack_messaging will choose a random quote, which are all defined in [`lib/slack_messaging/random_message.rb`](https://github.com/emmasax4/slack_messaging/blob/main/lib/slack_messaging/random_message.rb). Feel free to change the messages or add more to cater what you'd like slack_messaging to say.
+from the main directory. Here, no specific message is being given to print to Slack, so slack_messaging will choose a random quote. The random quotes are selected using the [Quotable API](http://api.quotable.io/).
 
 However, what if you wanted to print something specific? Well, you can! Just run:
 

data/lib/slack_messaging.rb

@@ -2,6 +2,7 @@ require 'yaml'
 require 'hashie'
 require 'httparty'
 require 'highline'
+require 'json'
 
 Dir[File.expand_path(File.join(File.dirname(File.absolute_path(__FILE__)), 'slack_messaging')) + '/**/*.rb'].each do |file|
   require_relative file

data/lib/slack_messaging/random_message.rb

@@ -1,30 +1,10 @@
 module SlackMessaging
   class RandomMessage
-    MESSAGE_ARRAY = [
-      "A true friend is someone who thinks that you are a good egg even though he knows that you are slightly cracked.\n--Bernard Meltzer",
-      "If you can't make it good, at least make it look good.\n--Bill Gates",
-      "I'm convinced of this: Good done anywhere is good done everywhere.\n--Maya Angelou",
-      "The real trouble with reality is that there's no background music.\n--Anonymous",
-      "Whatever you are, be a good one.\n--Abraham Lincoln",
-      "Good, better, best. Never let it rest. 'Til your good is better and your better is best.\n--St. Jerome",
-      "Despite everything, I believe that people are really good at heart.\n--Anne Frank",
-      "Life is 10% what happens to you and 90% how you react to it.\n--Charles R. Swindoll",
-      "The way to get started is to quit talking and begin doing.\n--Walt Disney",
-      "A creative man is motivated by the desire to achieve, not by the desire to beat others.\n--Ayn Rand",
-      "Problems are not stop signs, they are guidelines.\n--Robert H. Schuller",
-      "Correction does much, but encouragement does more.\n--Johann Wolfgang von Goethe",
-      "Positive anything is better than negative nothing.\n--Elbert Hubbard",
-      "To succeed, you need to find something to hold on to, something to motivate you, something to inspire you.\n--Joyce Meyer",
-      "If you're not making mistakes, then you're not doing anything. I'm positive that a doer makes mistakes.\n--John Wooden",
-      "The best way to deal with other people is to just let them be other people.\n--Anonymous",
-      "Talk to yourself like you would to someone you love.\n--Brenee Brown",
-      "Don't let small minds convince you that your dreams are too big.\n--Anonymous",
-    ]
-
-    attr_accessor :text
-
-    def initialize
-      self.text = MESSAGE_ARRAY[rand(MESSAGE_ARRAY.length)]
+    def self.acquire_random_quote
+      random_quote = HTTParty.get('http://api.quotable.io/random', headers: { 'Content-Type': 'application/json' }).body
+      quote_content = JSON.parse(random_quote)['content']
+      quote_author = JSON.parse(random_quote)['author']
+      return "\"#{quote_content}\"" + "\n" + "—#{quote_author}"
     end
   end
 end

data/lib/slack_messaging/slack.rb

@@ -4,8 +4,8 @@ module SlackMessaging
 
     def self.execute(args, options = nil)
       if args.empty?
-        message = SlackMessaging::RandomMessage.new
-        print_message(message.text)
+        message = SlackMessaging::RandomMessage.acquire_random_quote
+        print_message(message)
       else
         args.each do |message|
           print_message(message)
@@ -13,6 +13,8 @@ module SlackMessaging
       end
     end
 
+    private
+
     def self.print_message(message)
       SlackMessaging::NotifySlack.new(message).perform
     end

data/lib/slack_messaging/version.rb

@@ -1,3 +1,3 @@
 module SlackMessaging
-  VERSION = '1.4.0'
+  VERSION = '2.0.0'
 end

data/spec/slack_messaging/random_message_spec.rb

@@ -2,23 +2,42 @@ require 'spec_helper'
 require 'slack_messaging'
 
 describe SlackMessaging::RandomMessage do
+  let(:quote_object) { double(:quote_object, body: quote_json) }
+
+  let(:quote_json) do
+    "{\"_id\":\"4MRaRRKq4Tcg\",
+      \"tags\":[\"famous-quotes\"],
+      \"content\":\"There are two ways of spreading light: to be the candle or the mirror that reflects it.\",
+      \"author\":\"Edith Wharton\",\"length\":87
+    }"
+  end
+
+  before do
+    allow(HTTParty).to receive(:get).and_return(quote_object)
+  end
+
   it 'should get a string message' do
-    message = SlackMessaging::RandomMessage.new
-    expect(message.text).to be_instance_of(String)
+    message = SlackMessaging::RandomMessage.acquire_random_quote
+    expect(message).to be_instance_of(String)
+  end
+
+  it 'should get a message that includes a newline' do
+    message = SlackMessaging::RandomMessage.acquire_random_quote
+    expect(message.include?("\n")).to eq(true)
   end
 
-  it 'should get a message greater than 25 characters' do
-    message = SlackMessaging::RandomMessage.new
-    expect(message.text.length).to be >= 50
+  it 'should get a message that includes a —' do
+    message = SlackMessaging::RandomMessage.acquire_random_quote
+    expect(message.include?('—')).to eq(true)
   end
 
-  it 'should get a message that includes a new line' do
-    message = SlackMessaging::RandomMessage.new
-    expect(message.text.include?("\n")).to eq(true)
+  it 'should use HTTParty to ping an API' do
+    expect(HTTParty).to receive(:get)
+    SlackMessaging::RandomMessage.acquire_random_quote
   end
 
-  it 'should get a message that includes a --' do
-    message = SlackMessaging::RandomMessage.new
-    expect(message.text.include?('--')).to eq(true)
+  it 'should have the JSON parse the response content twice' do
+    expect(JSON).to receive(:parse).at_least(2).times.and_return(JSON.parse(quote_json))
+    SlackMessaging::RandomMessage.acquire_random_quote
   end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'faker'
+require 'pry'
 
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack_messaging
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Emma Sax
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-19 00:00:00.000000000 Z
+date: 2020-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +150,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.3'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement