slack_messaging 1.3.1 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21d4c79502e68eea2cf007a81f3a1e49a1f2b3fc670a68515f91d2671470c7b6
-  data.tar.gz: 013f88ec707d9bea10b2186962bd4b82e0106cb8754185f0fedb9448b8e3dfb4
+  metadata.gz: 3508ee5d59522e0a8d3c931e165bee408d707240fc4c3a1aadbabd2d5b6799f9
+  data.tar.gz: 67bc57eb2943f0f9f801eac68e25988ee4b06ac20835dd2f46b24b4599d213d5
 SHA512:
-  metadata.gz: d4cc5277991115cb449882eb7f069b6eb135c2c0d944692fbab654c2938c84441ab6bd3b0c9c47f748402d5b8390d34fe2a65ee433b165b3c10df1f230b4d672
-  data.tar.gz: bb984c22a6a030630daec5848b91fcc73dd5a08090a2711878895741f8cc3317dbc37182a918b00e33b0790a69024f4a251cbfd13aabf214a7ae39f1d24a9c70
+  metadata.gz: 0aa1c61dcb454f5beef05a9ecc13da9e16a258812952013675d2bc5a4b3230d6f80f9b08d47d3de0168a6fb85a180fe1a9d2b78e6b68474c6ae615fdf7639081
+  data.tar.gz: dd9967c7e2347435a1194961f03f7d5329f45cb839a47130cc1bb901cd324234e854a457a274cfccc54c9903cd322157f06dc0b61baa9e283d21daa549c7dc51

data/Gemfile.lock

@@ -1,18 +1,18 @@
 PATH
   remote: .
   specs:
-    slack_messaging (1.3.1)
+    slack_messaging (1.4.0)
       activesupport (~> 6.0)
       gli (~> 2.10)
       hashie (~> 4.1)
       highline (~> 2.0)
+      httparty
       rack (~> 2.2)
-      slack-notifier (~> 1.5.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3.3)
+    activesupport (6.0.3.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -21,6 +21,8 @@ GEM
     coderay (1.1.3)
     concurrent-ruby (1.1.7)
     diff-lcs (1.4.4)
+    faker (2.14.0)
+      i18n (>= 1.6, < 2)
     ffi (1.13.1)
     formatador (0.2.5)
     gli (2.19.2)
@@ -40,14 +42,21 @@ GEM
       rspec (>= 2.99.0, < 4.0)
     hashie (4.1.0)
     highline (2.0.3)
+    httparty (0.18.1)
+      mime-types (~> 3.0)
+      multi_xml (>= 0.5.2)
     i18n (1.8.5)
       concurrent-ruby (~> 1.0)
-    listen (3.2.1)
+    listen (3.3.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.8)
     method_source (1.0.0)
+    mime-types (3.3.1)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2020.1104)
     minitest (5.14.2)
+    multi_xml (0.6.0)
     nenv (0.3.0)
     notiffany (0.1.3)
       nenv (~> 0.1)
@@ -60,32 +69,32 @@ GEM
     rb-fsevent (0.10.4)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.3)
-      rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.2)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.0)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.3)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.0)
     shellany (0.0.1)
-    slack-notifier (1.5.1)
     thor (1.0.1)
     thread_safe (0.3.6)
-    tzinfo (1.2.7)
+    tzinfo (1.2.8)
       thread_safe (~> 0.1)
-    zeitwerk (2.4.0)
+    zeitwerk (2.4.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bundler (~> 2.1)
+  faker
   guard-rspec (~> 4.3)
   rake (~> 13.0)
   rspec (~> 3.9)

data/Guardfile

@@ -1,5 +1,5 @@
 guard :rspec, cmd: 'bundle exec rspec', all_on_start: true, all_after_pass: true  do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb')  { "spec" }
+  watch('spec/spec_helper.rb')  { 'spec' }
 end

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2014 Elliot Hursh
+Copyright (c) 2014 Emma Sax
 
 MIT License
 

data/README.md

@@ -1,4 +1,4 @@
-# Slack Messaging [![Maintainability](https://api.codeclimate.com/v1/badges/c74baada70ad96048dc7/maintainability)](https://codeclimate.com/github/emmasax4/slack_messaging/maintainability) ![Develop](https://github.com/emmasax4/slack_messaging/workflows/Develop/badge.svg)
+# Slack Messaging [![Maintainability](https://api.codeclimate.com/v1/badges/c74baada70ad96048dc7/maintainability)](https://codeclimate.com/github/emmasax4/slack_messaging/maintainability) ![Default](https://github.com/emmasax4/slack_messaging/workflows/Default/badge.svg)
 
 This is a simple project designed to post messages to a given Slack channel as a bot.
 
@@ -12,11 +12,15 @@ gem 'slack_messaging'
 
 And then execute:
 
-    $ bundle
+```bash
+bundle install
+```
 
 Or install it yourself as:
 
-    $ gem install slack_messaging
+```bash
+gem install slack_messaging
+```
 
 ### Usage
 

data/Rakefile

@@ -1 +1 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'

data/bin/slack-messaging

@@ -19,7 +19,7 @@ DOCUMENTATION
 desc 'Prints a variety of messages to Slack'
 command 'slack' do |c|
   c.action do |global_options, options, args|
-    SlackMessaging::Slack.execute(args, options) # args are optional string to print
+    SlackMessaging::Slack.execute(args, options)
   end
 end
 

data/lib/slack_messaging.rb

@@ -1,4 +1,9 @@
-Dir[File.expand_path(File.join(File.dirname(File.absolute_path(__FILE__)), 'slack_messaging')) + "/**/*.rb"].each do |file|
+require 'yaml'
+require 'hashie'
+require 'httparty'
+require 'highline'
+
+Dir[File.expand_path(File.join(File.dirname(File.absolute_path(__FILE__)), 'slack_messaging')) + '/**/*.rb'].each do |file|
   require_relative file
 end
 

data/lib/slack_messaging/config.rb

@@ -1,43 +1,27 @@
-require 'yaml'
-require 'hashie'
-
 module SlackMessaging
-  class DefaultPaths
-    class << self
-      def config
-        File.join(self.home,'.slack_messaging.yml')
-      end
-
-      def home
-        ENV['HOME'] ? ENV['HOME'] : "."
-      end
-    end
-  end
-
   class Config
-    class << self
+    def self.config
+      config_data.to_hash
+    end
 
-      def config
-        config_data.to_hash
-      end
+    def self.load(path)
+      load_config(path)
+      config
+    end
 
-      def load(path)
-        load_config(path)
-        config
-      end
+    private
 
-      private def config_data
-        @config_data ||= Hashie::Mash.new
-      end
+    def self.config_data
+      @config_data ||= Hashie::Mash.new
+    end
 
-      private def method_missing(method, args=false)
-        config_data.send(method, args)
-      end
+    def self.method_missing(method, args = false)
+      config_data.send(method, args)
+    end
 
-      private def load_config(file)
-        raise MissingConfig, "Missing configuration file: #{file}" unless File.exist?(file)
-        YAML.load_file(file).each{ |key,value| config_data.assign_property(key, value) }
-      end
+    def self.load_config(file)
+      raise MissingConfig, "Missing configuration file: #{file}" unless File.exist?(file)
+      YAML.load_file(file).each { |key, value| config_data.assign_property(key, value) }
     end
   end
 end

data/lib/slack_messaging/default_paths.rb

@@ -0,0 +1,13 @@
+module SlackMessaging
+  class DefaultPaths
+    def self.config
+      File.join(self.home, '.slack_messaging.yml')
+    end
+
+    private
+
+    def self.home
+      ENV['HOME'] ? ENV['HOME'] : '.'
+    end
+  end
+end

data/lib/slack_messaging/notify_slack.rb

@@ -1,5 +1,3 @@
-require 'slack-notifier'
-
 module SlackMessaging
   class NotifySlack
     attr_accessor :text, :channel, :webhook_url, :username, :icon_url, :icon_emoji
@@ -8,19 +6,19 @@ module SlackMessaging
       self.text = text
       self.channel = SlackMessaging::Config.slack[:channel]
       self.webhook_url = SlackMessaging::Config.slack[:webhook_url]
-      self.username = SlackMessaging::Config.slack[:username] || "MessageMe"
-      self.icon_emoji = SlackMessaging::Config.slack[:icon_emoji] || ":mailbox_with_mail"
+      self.username = SlackMessaging::Config.slack[:username] || 'MessageMe'
+      self.icon_emoji = SlackMessaging::Config.slack[:icon_emoji] || ':mailbox_with_mail'
     end
 
     def perform
       options = {
-        webhook_url: webhook_url,
         channel: channel,
         username: username,
         icon_emoji: icon_emoji,
-        http_options: { open_timeout: 10 }
+        text: text
       }
-      ::Slack::Notifier.new(webhook_url, options).ping(text)
+
+      HTTParty.post(webhook_url, body: options.to_json)
     end
   end
 end

data/lib/slack_messaging/random_message.rb

@@ -1,7 +1,5 @@
 module SlackMessaging
   class RandomMessage
-    attr_accessor :text
-
     MESSAGE_ARRAY = [
       "A true friend is someone who thinks that you are a good egg even though he knows that you are slightly cracked.\n--Bernard Meltzer",
       "If you can't make it good, at least make it look good.\n--Bill Gates",
@@ -23,12 +21,10 @@ module SlackMessaging
       "Don't let small minds convince you that your dreams are too big.\n--Anonymous",
     ]
 
+    attr_accessor :text
+
     def initialize
       self.text = MESSAGE_ARRAY[rand(MESSAGE_ARRAY.length)]
     end
-
-    def get_text
-      return self.text
-    end
   end
 end

data/lib/slack_messaging/slack.rb

@@ -1,15 +1,11 @@
-require 'highline'
-
 module SlackMessaging
   class Slack
-    class << self
-      attr_accessor :options
-    end
+    attr_accessor :options
 
-    def self.execute(args, options=nil)
+    def self.execute(args, options = nil)
       if args.empty?
-        message = SlackMessaging::RandomMessage.new # generate a new random message
-        print_message(message.get_text)
+        message = SlackMessaging::RandomMessage.new
+        print_message(message.text)
       else
         args.each do |message|
           print_message(message)
@@ -18,8 +14,7 @@ module SlackMessaging
     end
 
     def self.print_message(message)
-      slack_job = SlackMessaging::NotifySlack.new(message)
-      slack_job.perform
+      SlackMessaging::NotifySlack.new(message).perform
     end
   end
 end

data/lib/slack_messaging/version.rb

@@ -1,3 +1,3 @@
 module SlackMessaging
-  VERSION = "1.3.1"
+  VERSION = '1.4.0'
 end

data/spec/slack_messaging/config_spec.rb

@@ -1,44 +1,53 @@
 require 'spec_helper'
 require 'slack_messaging'
 
-module SlackMessaging
-  describe Config do
+describe SlackMessaging::Config do
+  context 'config key methods' do
+    it 'should return nil when not set' do
+      expect(SlackMessaging::Config.doesnt_exist).to eql(nil)
+      expect(SlackMessaging::Config.doesnt_exist?).to eql(false)
+    end
 
-    context "config key methods" do
-      it "should return nil when not set" do
-        expect(SlackMessaging::Config.doesnt_exist).to eql(nil)
-        expect(SlackMessaging::Config.doesnt_exist?).to eql(false)
-      end
-      it "should return the config value when set" do
-        SlackMessaging::Config.new_value = "testing"
-        expect(SlackMessaging::Config.new_value).to eql("testing")
-      end
+    it 'should return the config value when set' do
+      config_value = Faker::Lorem.word
+      SlackMessaging::Config.new_value = config_value
+      expect(SlackMessaging::Config.new_value).to eql(config_value)
     end
+  end
 
-    context "after loading a config file" do
-      before do
-        config_file = {"domain" => "example_domain",
-                       "slack" => {"slack_option" => true,
-                                   "username" => "Rspec Tester",
-                                   "icon_url" => "http://fake.url",
-                                   "channel" => "#test-channel",
-                                   "webhook" => "https://slack.web.hook"}}
-        allow(YAML).to receive(:load_file).and_return(config_file)
-        allow(File).to receive(:exist?).and_return(true)
-        SlackMessaging::Config.load("dummy/path")
-      end
+  context 'after loading a config file' do
+    let(:domain) { Faker::Internet.domain_name }
+    let(:sentence) { Faker::Lorem.sentence }
+
+    let(:config_file) do
+      {
+        'domain': domain,
+        'slack': {
+          'slack_option': true,
+          'username': Faker::Name.name,
+          'icon_url': Faker::Internet.url,
+          'channel': Faker::Lorem.word,
+          'webhook': Faker::Internet.url
+        }
+      }
+    end
 
-      it "calling a method corresponding to a key in the file should return the value" do
-        expect(SlackMessaging::Config.domain).to eql("example_domain")
-        expect(SlackMessaging::Config.slack).to be_kind_of(Hash)
-        expect(SlackMessaging::Config.slack[:slack_option]).to eql(true)
-      end
+    before do
+      allow(YAML).to receive(:load_file).and_return(config_file)
+      allow(File).to receive(:exist?).and_return(true)
+      SlackMessaging::Config.load(Faker::Lorem.word)
+    end
+
+    it 'calling a method corresponding to a key in the file should return the value' do
+      expect(SlackMessaging::Config.domain).to eql(domain)
+      expect(SlackMessaging::Config.slack).to be_kind_of(Hash)
+      expect(SlackMessaging::Config.slack[:slack_option]).to eql(true)
+    end
 
-      it "overwriting values should work" do
-        expect(SlackMessaging::Config.slack).to be_kind_of(Hash)
-        SlackMessaging::Config.slack = "this is a string now"
-        expect(SlackMessaging::Config.slack).to eql("this is a string now")
-      end
+    it 'overwriting values should work' do
+      expect(SlackMessaging::Config.slack).to be_kind_of(Hash)
+      SlackMessaging::Config.slack = sentence
+      expect(SlackMessaging::Config.slack).to eql(sentence)
     end
   end
 end

data/spec/slack_messaging/notify_slack_spec.rb

@@ -1,34 +1,43 @@
 require 'spec_helper'
 require 'slack_messaging'
 
-module SlackMessaging
-  describe NotifySlack do
-    before :each do
-      config_file = {"slack" => {"channel" => "#random-test-channel",
-                                 "username" => "Random User",
-                                 "webhook_url" => "https://hooks.slack.com/services/totallyrandom/fakewebhookurl",
-                                 "icon_emoji" => ":wine_glass:"}
-                    }
-      allow(YAML).to receive(:load_file).and_return(config_file)
-      allow(File).to receive(:exist?).and_return(true)
-      SlackMessaging::Config.load("dummy/path")
-    end
+describe SlackMessaging::NotifySlack do
+  let(:sentence) { Faker::Lorem.sentence }
+  let(:channel) { Faker::Lorem.word }
+  let(:username) { Faker::Name.name }
+  let(:webhook) { Faker::Internet.url }
+  let(:emoji) { Faker::Internet.url }
 
-    it 'should ping Slack Notifier' do
-      notifier = double('notifier', ping: true)
-      allow(::Slack::Notifier).to receive(:new).and_return(notifier)
-      expect(notifier).to receive(:ping).and_return(true)
-      message = NotifySlack.new("Test message")
-      message.perform
-    end
+  let(:config_file) do
+    {
+      'slack': {
+        'slack_option': true,
+        'username': username,
+        'icon_emoji': emoji,
+        'channel': channel,
+        'webhook_url': webhook
+      }
+    }
+  end
+
+  before :each do
+    allow(YAML).to receive(:load_file).and_return(config_file)
+    allow(File).to receive(:exist?).and_return(true)
+    SlackMessaging::Config.load(Faker::Lorem.word)
+  end
+
+  it 'should call HTTParty' do
+    expect(HTTParty).to receive(:post)
+    message = SlackMessaging::NotifySlack.new(sentence)
+    message.perform
+  end
 
-     it 'should define certain values' do
-      message = NotifySlack.new("Test message")
-      expect(message.text).to eq("Test message")
-      expect(message.channel).to eq("#random-test-channel")
-      expect(message.username).to eq("Random User")
-      expect(message.webhook_url).to eq("https://hooks.slack.com/services/totallyrandom/fakewebhookurl")
-      expect(message.icon_emoji).to eq(":wine_glass:")
-    end
+    it 'should define certain values' do
+    message = SlackMessaging::NotifySlack.new(sentence)
+    expect(message.text).to eq(sentence)
+    expect(message.channel).to eq(channel)
+    expect(message.username).to eq(username)
+    expect(message.webhook_url).to eq(webhook)
+    expect(message.icon_emoji).to eq(emoji)
   end
 end

data/spec/slack_messaging/random_message_spec.rb

@@ -1,27 +1,24 @@
 require 'spec_helper'
 require 'slack_messaging'
 
-module SlackMessaging
-  describe RandomMessage do
-
-    it "should get a string message" do
-      message = RandomMessage.new
-      expect(message.get_text).to be_instance_of(String)
-    end
+describe SlackMessaging::RandomMessage do
+  it 'should get a string message' do
+    message = SlackMessaging::RandomMessage.new
+    expect(message.text).to be_instance_of(String)
+  end
 
-    it "should get a message greater than 25 characters" do
-      message = RandomMessage.new
-      expect(message.get_text.length).to be >= 50
-    end
+  it 'should get a message greater than 25 characters' do
+    message = SlackMessaging::RandomMessage.new
+    expect(message.text.length).to be >= 50
+  end
 
-    it "should get a message that includes a new line" do
-      message = RandomMessage.new
-      expect(message.get_text.include?("\n")).to eq(true)
-    end
+  it 'should get a message that includes a new line' do
+    message = SlackMessaging::RandomMessage.new
+    expect(message.text.include?("\n")).to eq(true)
+  end
 
-    it "should get a message that includes a '--'" do
-      message = RandomMessage.new
-      expect(message.get_text.include?("--")).to eq(true)
-    end
+  it 'should get a message that includes a --' do
+    message = SlackMessaging::RandomMessage.new
+    expect(message.text.include?('--')).to eq(true)
   end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+require 'faker'
+
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
 # The generated `.rspec` file contains `--require spec_helper` which will cause

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack_messaging
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.4.0
 platform: ruby
 authors:
 - Emma Sax
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-02 00:00:00.000000000 Z
+date: 2020-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -67,33 +67,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: rack
+  name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: slack-notifier
+  name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +108,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.1'
+- !ruby/object:Gem::Dependency
+  name: faker
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -168,8 +182,8 @@ files:
 - bin/slack-messaging
 - lib/slack_messaging.rb
 - lib/slack_messaging/config.rb
+- lib/slack_messaging/default_paths.rb
 - lib/slack_messaging/notify_slack.rb
-- lib/slack_messaging/output.rb
 - lib/slack_messaging/random_message.rb
 - lib/slack_messaging/slack.rb
 - lib/slack_messaging/version.rb
@@ -196,7 +210,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: Personalized Slack Messages

data/lib/slack_messaging/output.rb

@@ -1,13 +0,0 @@
-require 'highline'
-
-module SlackMessaging
-  module Output
-    def self.terminal
-      @terminal ||= HighLine.new
-    end
-
-    def self.ask(*args, &block)
-      terminal.ask(*args, &block)
-    end
-  end
-end