slack_message 1.8.1 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94e7433c5374c318cd955ad43f6a02705b62876498253c4e7587a7ba5ae5277f
-  data.tar.gz: 0ca96c1266c9dc55af30c6df7f07e2ea86a64bc5fad99258a10efe10e4127e9b
+  metadata.gz: f4d33554e024d1c51aeb2bb6ee5397c16142dbcc1a314720f30e7fab3d12325d
+  data.tar.gz: 6e297c58c27ca6109d51fc5b267c3248928deaf7422d57e6b9e9aa0533e525b5
 SHA512:
-  metadata.gz: 2f4c15c91c6a7741c1f387b820cc36689cd7530233e9582fb3db73407d9f39eb69656a071b65789cd33ec359d5fa1478efe212336a3834202c30f96269885895
-  data.tar.gz: ed86a645c481c0c91510acedc5b0abd2bf3923f9ea33e9a23671db0e107005c07f64a1dfc52f4f5f47f826630712756bd5ce43ddfd06622a10ed24afa7731465
+  metadata.gz: bf1e3caebf3d58c238c46be5f3b62a925ade7d077998a7a73ac1c9fdb3d5f0859ecb6c0f338ad2cc666a7157d166cd8cda4fa91e9e5dacb3a77bf168cb9ccf50
+  data.tar.gz: '08de1a2fe10e3da489169e11d478e7afb93fd557e6da00d1af1a42f6697a351f3b281ea66aafd80594738f6b25457fdb18c9a5bf766caee339d2b7cc5db51e02'

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## [Unreleased]
 
+## [1.9.0] - 2021-10-27
+- Add many validations so that trying to add e.g. empty text won't succeed.
+  Previously that would be accepted but return `invalid_blocks` from the API.
+
 ## [1.8.1] - 2021-10-08
 - Cleaned that rspec code a bit, added more matchers for real world use.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    slack_message (1.8.0)
+    slack_message (1.9.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -237,6 +237,18 @@ some custom matchers:
 expect {
   SlackMessage.post_to('#general') { text "foo" }
 }.to post_slack_message_to('#general').with_content_matching(/foo/)
+
+expect {
+  SlackMessage.post_as(:schmoebot) { text "foo" }
+}.to post_slack_message_as(:schmoebot)
+
+expect {
+  SlackMessage.post_as(:schmoebot) { text "foo" }
+}.to post_slack_message_as('Schmoe Bot')
+ 
+expect {
+  SlackMessage.post_to('#general') { text "foo" }
+}.to post_to_slack
 ```
 
 Be forewarned, I'm frankly not that great at more complicated RSpec matchers,

data/lib/slack_message/dsl.rb

@@ -52,6 +52,10 @@ class SlackMessage::Dsl
   def context(text)
     finalize_default_section
 
+    if text == "" || text.nil?
+      raise ArgumentError, "tried to create a context block without a value"
+    end
+
     @body.push({ type: "context", elements: [{
       type: "mrkdwn", text: text
     }]})
@@ -110,6 +114,10 @@ class SlackMessage::Dsl
     end
 
     def text(msg)
+      if msg == "" || msg.nil?
+        raise ArgumentError, "tried to create text node without a value"
+      end
+
       if @body.include?(:text)
         @body[:text][:text] << "\n#{msg}"
 
@@ -119,14 +127,16 @@ class SlackMessage::Dsl
     end
 
     def ul(elements)
-      raise Arguments, "please pass an array" unless elements.respond_to?(:map)
+      raise ArgumentError, "please pass an array" unless elements.respond_to?(:map)
+
       text(
         elements.map { |text| "#{EMSPACE}• #{text}" }.join("\n")
       )
     end
 
     def ol(elements)
-      raise Arguments, "please pass an array" unless elements.respond_to?(:map)
+      raise ArgumentError, "please pass an array" unless elements.respond_to?(:map)
+
       text(
         elements.map.with_index(1) { |text, idx| "#{EMSPACE}#{idx}. #{text}" }.join("\n")
       )
@@ -186,6 +196,10 @@ class SlackMessage::Dsl
     end
 
     def list_item(title, value)
+      if value == "" || value.nil?
+        raise ArgumentError, "can't create a list item for '#{title}' without a value"
+      end
+
       @list.add(title, value)
     end
 

data/slack_message.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name        = 'slack_message'
-  gem.version     = "1.8.1"
+  gem.version     = "1.9.0"
   gem.summary     = "A nice DSL for composing rich messages in Slack"
   gem.authors     = ["Joe Mastey"]
   gem.email       = 'hello@joemastey.com'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack_message
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: 1.9.0
 platform: ruby
 authors:
 - Joe Mastey
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-10-08 00:00:00.000000000 Z
+date: 2021-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec