slack_log_device 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f7c2fbccccb4df5730e6f9ea792d23df250aeaae
-  data.tar.gz: 03700bccd9ef1366dfe3035d8ba31db4aa87002b
+  metadata.gz: e489a5ee3f73f7e9e12d6ec7b7c0fd0c4013b768
+  data.tar.gz: e209bf2e8df911376b3b0624dfeb75986b25970e
 SHA512:
-  metadata.gz: 951dc372a3de3848fa203ad903e4bb5c2efde689a28f52249730cadd8555b0137365b845f1fd089f6860857e9faeb957702f110d8e7ca6bdcc105e73423b9993
-  data.tar.gz: 9735f2db5fd0ea7332023c9c8211d7974d07fc6365fc15e01bf87d66782dfc232c041792850ceb991b093ff9d08ae223c1c68ad444e3687fbc63307be777a99a
+  metadata.gz: f3ca47f4d8f1d983e0750e4314d7e9cfcf4930fce71d93edaa6c0f5bd5535ad2eacc0eed2476cb3536a1dc00dc902ee720bfa63801e44b8e7783e913634379db
+  data.tar.gz: d24fce09e62726004440dca80ff5dd6ce9be076a0118864f1e813c5f89f337ce8628ffeb6cea0d6fec45e14d0999169987814ce3a621ed97ca06a88881c69906

data/VERSION

@@ -1 +1 @@
-2.1.0
+2.1.1

data/lib/slack_log_device.rb

@@ -40,6 +40,7 @@ class SlackLogDevice
   end
 
   def flush
+    kill_flush_thread
     return if @buffer.empty?
     message = ''
     @mutex.synchronize do
@@ -96,7 +97,7 @@ class SlackLogDevice
     @mutex.synchronize do
       @buffer << message
     end
-    @flush_thread.kill if @flush_thread
+    kill_flush_thread
     @flush_thread = Thread.new do
       sleep(flush_delay) unless auto_flush?
       flush
@@ -104,4 +105,13 @@ class SlackLogDevice
     nil
   end
 
+  private
+
+  def kill_flush_thread
+    if @flush_thread
+      @flush_thread.kill
+      @flush_thread = nil
+    end
+  end
+
 end

data/spec/slack_log_device_spec.rb

@@ -3,13 +3,16 @@ require 'spec_helper'
 describe SlackLogDevice do
 
   let(:device) { SlackLogDevice.new(options) }
-  let(:logger) { Logger.new(device).tap { |logger| logger.level = Logger::INFO } }
   let(:options) { { username: 'MyApp', webhook_url: 'https://hooks.slack.com/services/test' } }
 
   before :each do
     allow(HTTParty).to receive(:post)
   end
 
+  it 'is not a LogDevice instance' do
+    expect(device).not_to be_a(Logger::LogDevice)
+  end
+
   describe '#auto_flush?' do
 
     it 'is false by default' do
@@ -134,6 +137,16 @@ describe SlackLogDevice do
       expect(device.flush).to be_nil
     end
 
+    it 'clears buffer' do
+      device.write('BAM!')
+      device.write('BIM!')
+      expect {
+        device.flush
+      }.to change { device.instance_variable_get(:@buffer) }.to([])
+      expect(HTTParty).not_to receive(:post)
+      device.flush
+    end
+
   end
 
   describe '#flush?' do
@@ -419,12 +432,6 @@ describe SlackLogDevice do
       expect(device.write('BAM!')).to be_nil
     end
 
-    it 'does nothing if log level is lower than specified one' do
-      expect(HTTParty).not_to receive(:post)
-      logger.debug('BIM!')
-      device.flush
-    end
-
     it 'strips message' do
       device.write("     BAM  !\n")
       expect(device.instance_variable_get(:@buffer)).to eq(['BAM  !'])
@@ -448,6 +455,23 @@ describe SlackLogDevice do
       expect(device.instance_variable_get(:@buffer)).to eq([])
     end
 
+    it 'does not post HTTP message if auto flush is false' do
+      expect(HTTParty).not_to receive(:post)
+      device.write('BAM!')
+    end
+
+  end
+
+  describe Logger, 'with slack log device' do
+
+    let(:logger) { Logger.new(device).tap { |logger| logger.level = Logger::INFO } }
+
+    it 'does nothing if log level is lower than specified one' do
+      expect(HTTParty).not_to receive(:post)
+      logger.debug('BIM!')
+      device.flush
+    end
+
     it 'send HTTP request if log level is equal to specified one' do
       expect(HTTParty).to receive(:post)
       logger.info('BIM!')
@@ -460,9 +484,42 @@ describe SlackLogDevice do
       device.flush
     end
 
-    it 'does not post HTTP message if auto flush is false' do
-      expect(HTTParty).not_to receive(:post)
-      device.write('BAM!')
+    describe '#close' do
+
+      it 'does not raise any error' do
+        expect {
+          logger.close
+        }.not_to raise_error
+      end
+
+    end
+
+    describe '#reopen' do
+
+      it 'does not raise any error' do
+        expect {
+          logger.reopen
+        }.not_to raise_error
+      end
+
+    end
+
+    describe '@logdev' do
+
+      let(:logdev) { logger.instance_variable_get(:@logdev) }
+
+      it 'is a LogDevice instance' do
+        expect(logdev).to be_a(Logger::LogDevice)
+      end
+
+      describe '#filename' do
+
+        it 'is nil' do
+          expect(logdev.filename).to be_nil
+        end
+
+      end
+
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack_log_device
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Alexis Toulotte
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-18 00:00:00.000000000 Z
+date: 2017-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport