slack-ruby-bot 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f872fa7b4cc7c405bc25e0802e243826672c098f
-  data.tar.gz: ed6a6038cf90aea81894759e73b2991a484f0d09
+  metadata.gz: d1348b71125e07ba882c91f785c185b39fd6f169
+  data.tar.gz: be83b12cf72deed88f2b7a85bf4cb68dcb6bf6fa
 SHA512:
-  metadata.gz: 2823b93a71bd803ebdbd3d753785e457250275dc2a0bb9eee72a4b7e9986f9060fa42487676d7ca6ed32513173c5ee51cc33274f69fc6c1e43d5c7311fce1386
-  data.tar.gz: 6d08cab72ee6db777d275550654154d9186b35643107529ee25c59e449fb19b52f6a7dde58bcef583dba4c19fb201bfe140cfe832daff91f07321e6cec0483c2
+  metadata.gz: ce40f511fb328ea0574b6189ad8dcef5de8401ac79a7c1bee9fb0c06d1bfcf0ccb6744e9fe71c29b302973ac8af713628229cf1a85aea41ae2ec910b185b37da
+  data.tar.gz: 89df71def40ed033436c1703cd15ac08e6f2999f4187c4996101ae022651a6c52a8e60e78466ce4551b357e6f5b53fe95e50b08d650be73677fd744ade9125ce

data/CHANGELOG.md

@@ -1,4 +1,8 @@
-### 0.8.1 (6/10/2016)
+### 0.8.2 (7/10/2016)
+
+* [#85](https://github.com/dblock/slack-ruby-bot/issues/85): Fix: regression in bot instance logging - [@dblock](https://github.com/dblock).
+
+### 0.8.1 (7/10/2016)
 
 * [#69](https://github.com/dblock/slack-ruby-bot/pull/69): Ability to add help info to bot and commands - [@accessd](https://github.com/accessd).
 * [#75](https://github.com/dblock/slack-ruby-bot/issues/75): Guarantee order of command evaluation - [@dblock](https://github.com/dblock).

data/README.md

@@ -19,7 +19,7 @@ If you are not familiar with Slack bots or Slack API concepts, you might want to
 
 ## Stable Release
 
-You're reading the documentation for the **stable** release of slack-ruby-bot, 0.8.1. See [CHANGELOG](CHANGELOG.md) for a history of changes and [UPGRADING](UPGRADING.md) for how to upgrade to more recent versions.
+You're reading the documentation for the **stable** release of slack-ruby-bot. See [CHANGELOG](CHANGELOG.md) for a history of changes and [UPGRADING](UPGRADING.md) for how to upgrade to more recent versions.
 
 ## Usage
 

data/lib/slack-ruby-bot/support/loggable.rb

@@ -1,21 +1,23 @@
 module SlackRubyBot
   module Loggable
     def self.included(base)
-      base.send :include, LoggingMethods
-      base.extend(LoggingMethods)
+      base.send :include, InstanceMethods
+      base.extend(ClassMethods)
     end
 
-    def self.logger
-      @logger ||= begin
-                    $stdout.sync = true
-                    Logger.new(STDOUT)
-                  end
+    module ClassMethods
+      def logger
+        @logger ||= begin
+          $stdout.sync = true
+          Logger.new(STDOUT)
+        end
+      end
     end
-  end
 
-  module LoggingMethods
-    def logger
-      Loggable.logger
+    module InstanceMethods
+      def logger
+        self.class.logger
+      end
     end
   end
 end

data/lib/slack-ruby-bot/version.rb

@@ -1,3 +1,3 @@
 module SlackRubyBot
-  VERSION = '0.8.1'.freeze
+  VERSION = '0.8.2'.freeze
 end

data/spec/slack-ruby-bot/support/loggable_spec.rb

@@ -8,15 +8,28 @@ describe SlackRubyBot::Loggable do
       end
     end
   end
+  let! :child_class_with_logger do
+    Class.new(class_with_logger) do
+      def public_logger
+        logger
+      end
+    end
+  end
   describe 'logger for class' do
     it do
       expect(class_with_logger.logger).to be_kind_of Logger
+      expect(child_class_with_logger.logger).to be_kind_of Logger
     end
     it 'should be cached' do
       first_logger = class_with_logger.logger
       second_logger = class_with_logger.logger
       expect(first_logger.object_id).to eq second_logger.object_id
     end
+    it 'should not be shared by a child class' do
+      first_logger = class_with_logger.logger
+      second_logger = child_class_with_logger.logger
+      expect(first_logger.object_id).to_not eq second_logger.object_id
+    end
   end
   describe 'logger for instance' do
     it do
@@ -27,5 +40,10 @@ describe SlackRubyBot::Loggable do
       second_logger = class_with_logger.new.public_logger
       expect(first_logger.object_id).to eq second_logger.object_id
     end
+    it 'should not be shared by a child class' do
+      first_logger = class_with_logger.new.public_logger
+      second_logger = child_class_with_logger.new.public_logger
+      expect(first_logger.object_id).to_not eq second_logger.object_id
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: slack-ruby-bot
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Daniel Doubrovkine