slack-notifier 2.1.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2de365236adc9d11e81ff2d438f8f8623de09e8a
-  data.tar.gz: cdf04ae41bb99465317aa0be35aecb9fa841d52b
+  metadata.gz: f5599f6fb6901d7b9c7009d6343288916829b97a
+  data.tar.gz: 60d21036bd104a7bda04b8dbb9da0b4a0747a8b7
 SHA512:
-  metadata.gz: a83b5175eacbc6694b640ccdb42dbf11f7fcd46d35ee91c59da8d0cb48972f77fcaef35a2caa4175bf6e95b9480b51ed4a36a4bcff39e789f0b744ec5b56f06c
-  data.tar.gz: 1f0fa17db345193cf89a412934743bc2b972c434e19557a6f64cbebbda15149b6690507306767a3ec4906b4f7811b0b38ef4fd753f4f2c22861940001ddaf7e8
+  metadata.gz: b6199f52c950a2470e651937f2f91ceb67abf95d0987b3c7cf441f9fe3e2e8b405a14a3570d110f367c308bdebafe7bd4f797661c9ce6f563d1ec5d54ea077bf
+  data.tar.gz: 9b7efc69cbeaa137a68e6240f94a198e8932ec4ea7deb48b45d9b46b5091b8118a1ad511d455c4eb91de7d38471c5e54119f5122586d7fed6b9463b6b4525daa

data/lib/slack-notifier/util/http_client.rb

@@ -2,8 +2,11 @@
 
 require "net/http"
 
+
 module Slack
   class Notifier
+    class APIError < StandardError; end
+
     module Util
       class HTTPClient
         class << self
@@ -21,7 +24,14 @@ module Slack
         end
 
         def call
-          http_obj.request request_obj
+          http_obj.request(request_obj).tap do |response|
+            unless response.is_a?(Net::HTTPSuccess)
+              raise Slack::Notifier::APIError, <<-MSG
+The slack API returned an error: #{response.body} (HTTP Code #{response.code})
+Check the "Handling Errors" section on https://api.slack.com/incoming-webhooks for more information
+MSG
+            end
+          end
         end
 
         private

data/lib/slack-notifier/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module Slack
   class Notifier
-    VERSION = "2.1.0".freeze # rubocop:disable Style/RedundantFreeze
+    VERSION = "2.2.1".freeze # rubocop:disable Style/RedundantFreeze
   end
 end

data/spec/lib/slack-notifier/util/http_client_spec.rb

@@ -24,11 +24,31 @@ RSpec.describe Slack::Notifier::Util::HTTPClient do
 
       allow(Net::HTTP).to receive(:new).and_return(net_http_double)
       allow(net_http_double).to receive(:use_ssl=)
-      allow(net_http_double).to receive(:request)
+      allow(net_http_double).to receive(:request).with(anything) do
+        Net::HTTPOK.new("GET", "200", "OK")
+      end
 
       expect(net_http_double).to receive(:open_timeout=).with(5)
 
       http_client.call
     end
   end
+
+  describe "#call" do
+    it "raises an error when the response is unsuccessful" do
+      net_http_double = instance_double("Net::HTTP")
+      http_client = described_class.new URI.parse("http://example.com"), {}
+      bad_request = Net::HTTPBadRequest.new("GET", "400", "Bad Request")
+
+      allow(bad_request).to receive(:body).and_return("something_bad")
+      allow(Net::HTTP).to receive(:new).and_return(net_http_double)
+      allow(net_http_double).to receive(:use_ssl=)
+      allow(net_http_double).to receive(:request).with(anything) do
+        bad_request
+      end
+
+      expect { http_client.call }.to raise_error(Slack::Notifier::APIError,
+                                                 /something_bad \(HTTP Code 400\)/)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack-notifier
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Steven Sloan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-03 00:00:00.000000000 Z
+date: 2017-05-29 00:00:00.000000000 Z
 dependencies: []
 description: " A slim ruby wrapper for posting to slack webhooks "
 email: