slack-notifier 0.6.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 64899197a10189dcf547d2145599c9cd2f58dc58
-  data.tar.gz: 760a4379a03ce8171fa78c41f903bd718ee6469e
+  metadata.gz: a423a9d3657e72895726732371162ca6999c1cb6
+  data.tar.gz: d929fe769de577f03331eebac18796eb2ab06b28
 SHA512:
-  metadata.gz: 43b0dba726b3e0d06b8616bbcfe8f3dc4f742f480794c59a4bd6f2c1a4a1fa2e1628bf28258315be502c3ca3248d661e56f34fadc39258b0ccd911ffa4a94a60
-  data.tar.gz: 24a89065f0d7f010c09bd8f71f89989a1b824c6ab483cfeeeed1e6507a362c9acabfd011471ed66cbba7fef584a57fa55cf4ca8b95a6ef33af07dd9adfa3753b
+  metadata.gz: 74aa5dfc1e49ab07922382bc69e8357ac5a7f5cca7ca9df110bee939da04a77eccb719db27c49864d65a317a4f3d224876b210bb5cebf2a5b14018064d950139
+  data.tar.gz: a4716f34f9e618a016d691830a82ee6b589e51af8b53a3d44625585b042b0c47b17f57db8426bcabaed5a798839a4d984a31dc213bc530e8a4da2a10a970f606

data/lib/slack-notifier.rb

@@ -7,14 +7,11 @@ require_relative 'slack-notifier/link_formatter'
 
 module Slack
   class Notifier
-    attr_reader :team, :token, :http_client,
-                :hook_name, :default_payload
-
-    def initialize team, token, options={} # hook_name=default_hook_name, default_payload={}
-      @team      = team
-      @token     = token
-      @http_client = options.delete(:http_client) || DefaultHTTPClient
-      @hook_name   = options.delete(:hook_name) || default_hook_name
+    attr_reader :endpoint, :http_client, :default_payload
+
+    def initialize webhook_url, options={}
+      @endpoint        = URI.parse webhook_url
+      @http_client     = options.delete(:http_client) || DefaultHTTPClient
       @default_payload = options
     end
 
@@ -42,15 +39,5 @@ module Slack
       default_payload[:username] = username
     end
 
-    private
-
-      def default_hook_name
-        'incoming-webhook'
-      end
-
-      def endpoint
-        URI.parse "https://#{team}.slack.com/services/hooks/#{hook_name}?token=#{token}"
-      end
-
   end
 end

data/lib/slack-notifier/version.rb

@@ -1,5 +1,5 @@
 module Slack
   class Notifier
-    VERSION = "0.6.1"
+    VERSION = "1.0.0"
   end
-end
+end

data/spec/integration/ping_integration_test.rb

@@ -1,5 +1,5 @@
 require_relative '../../lib/slack-notifier'
 
-notifier = Slack::Notifier.new ENV['SLACK_TEAM'], ENV['SLACK_TOKEN'], username: 'notifier'
+notifier = Slack::Notifier.new ENV['SLACK_WEBHOOK_URL'], username: 'notifier'
 puts "testing with ruby #{RUBY_VERSION}"
 notifier.ping "hello from notifier test script on ruby: #{RUBY_VERSION}"

data/spec/lib/slack-notifier_spec.rb

@@ -1,38 +1,23 @@
 require 'spec_helper'
 
 describe Slack::Notifier do
-  subject { described_class.new 'team', 'token' }
+  subject { described_class.new 'http://example.com' }
 
   describe "#initialize" do
-    it "sets the given team" do
-      expect( subject.team ).to eq 'team'
-    end
-
-    it "sets the given token" do
-      expect( subject.token ).to eq 'token'
-    end
-
-    it "sets the optional service hook name" do
-      subject = described_class.new 'team', 'token', hook_name: 'custom_hook_name'
-      expect( subject.hook_name ).to eq 'custom_hook_name'
+    it "sets the given hook_url to the endpoint URI" do
+      expect( subject.endpoint ).to eq URI.parse 'http://example.com'
     end
 
     it "sets the default_payload options" do
-      subject = described_class.new 'team', 'token', channel: 'foo'
+      subject = described_class.new 'http://example.com', channel: 'foo'
       expect( subject.channel ).to eq 'foo'
     end
 
     it "sets a custom http client" do
       client  = double("CustomClient")
-      subject = described_class.new 'team', 'token', http_client: client
+      subject = described_class.new 'http://example.com', http_client: client
       expect( subject.http_client ).to eq client
     end
-
-    it "can set service hook & default_payload options" do
-      subject = described_class.new 'team', 'token', hook_name: 'hook_name', channel: 'foo'
-      expect( subject.channel ).to eq 'foo'
-      expect( subject.hook_name ).to eq 'hook_name'
-    end
   end
 
   describe "#ping" do
@@ -44,7 +29,7 @@ describe Slack::Notifier do
       expect( Slack::Notifier::LinkFormatter ).to receive(:format)
                                               .with("the message")
 
-      described_class.new('team','token').ping "the message", channel: 'foo'
+      described_class.new('http://example.com').ping "the message", channel: 'foo'
     end
 
     context "with a default channel set" do
@@ -84,29 +69,14 @@ describe Slack::Notifier do
       it "posts with the correct endpoint & data" do
           @endpoint_double = instance_double "URI::HTTP"
           allow( URI ).to receive(:parse)
-                      .with("https://team.slack.com/services/hooks/incoming-webhook?token=token")
+                      .with("http://example.com")
                       .and_return(@endpoint_double)
 
           expect( Slack::Notifier::DefaultHTTPClient ).to receive(:post)
                             .with @endpoint_double,
                                   payload: '{"text":"the message","channel":"channel"}'
 
-          described_class.new("team","token").ping "the message", channel: "channel"
-      end
-    end
-
-    context "with custom webhook name" do
-      it "posts with the correct endpoint & data" do
-        @endpoint_double = instance_double "URI::HTTP"
-        allow( URI ).to receive(:parse)
-                    .with("https://team.slack.com/services/hooks/custom_hook_name?token=token")
-                    .and_return(@endpoint_double)
-
-        expect( Slack::Notifier::DefaultHTTPClient ).to receive(:post)
-                          .with @endpoint_double,
-                                payload: '{"text":"the message","channel":"channel"}'
-
-        described_class.new("team","token", hook_name: "custom_hook_name").ping "the message", channel: "channel"
+          described_class.new("http://example.com").ping "the message", channel: "channel"
       end
     end
 
@@ -114,14 +84,14 @@ describe Slack::Notifier do
       it "uses it" do
         endpoint_double = instance_double "URI::HTTP"
         allow( URI ).to receive(:parse)
-                    .with("https://team.slack.com/services/hooks/incoming-webhook?token=token")
+                    .with("http://example.com")
                     .and_return(endpoint_double)
         client = double("CustomClient")
         expect( client ).to receive(:post)
                         .with endpoint_double,
                         payload: '{"text":"the message"}'
 
-        described_class.new('team','token',http_client: client).ping "the message"
+        described_class.new('http://example.com',http_client: client).ping "the message"
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack-notifier
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Steven Sloan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-21 00:00:00.000000000 Z
+date: 2014-10-23 00:00:00.000000000 Z
 dependencies: []
 description: " A slim ruby wrapper for posting to slack webhooks "
 email: