slack-notifier 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ed944b7001667e3e533abc25325fec4d7bfa99b
-  data.tar.gz: 4d0ae7eb667f225b42b5621afdc2ffbac463f471
+  metadata.gz: f3a07aa79b784ac446857af4e6256d467d0d09ab
+  data.tar.gz: 9d41a7a8c98ac9b9a780c1398c07b7a1988db111
 SHA512:
-  metadata.gz: 53703f1a9413e12505c0d2338776738eb25c5383c1448fd4e2efeb65f71eaccd4b6bf101263639e25bc957c588af4d4b094c77ae45f61ffb3adf0e8707db20d0
-  data.tar.gz: f35eb71b3e57950f2e648e241682a054fbe98d6a7c96719f766d478c704d8afdefd96b853d8237f9dcbef2ebbf3a69195196b717a4242128f58db5ef2e84436a
+  metadata.gz: 9ce9ea031ea4f5e996a784ebd43b22896ddc49b7d258ef353cfb59b7d30e6250178255390933322c146cebf46686f4cd333548df0a4cd3ebfd339c3180f9148e
+  data.tar.gz: d03f6d11af25cc31083478893f95be4c6172aa8533b2acf9b18cfa4e11c33dd096b6489dabeacf6a131b3553b1ff95c4683653af27b93133687be4abdd32dc40

data/lib/slack-notifier.rb

@@ -2,31 +2,28 @@ require 'net/http'
 require 'uri'
 require 'json'
 
-require_relative 'slack-notifier/http_post'
+require_relative 'slack-notifier/default_http_client'
 require_relative 'slack-notifier/link_formatter'
 
 module Slack
   class Notifier
-    attr_reader :team, :token, :hook_name, :default_payload
-
-    def initialize team, token, hook_name=default_hook_name, default_payload={}
-      @team  = team
-      @token = token
-
-      if hook_name.is_a? Hash
-        @hook_name = default_hook_name
-        @default_payload = hook_name
-      else
-        @hook_name = hook_name
-        @default_payload = default_payload
-      end
+    attr_reader :team, :token, :http_client,
+                :hook_name, :default_payload
+
+    def initialize team, token, options={} # hook_name=default_hook_name, default_payload={}
+      @team      = team
+      @token     = token
+      @http_client = options.delete(:http_client) || DefaultHTTPClient
+      @hook_name   = options.delete(:hook_name) || default_hook_name
+      @default_payload = options
     end
 
     def ping message, options={}
       message = LinkFormatter.format(message)
       payload = { text: message }.merge(default_payload).merge(options)
 
-      HTTPPost.to endpoint, payload: payload.to_json
+
+      http_client.post endpoint, payload: payload.to_json
     end
 
     def channel

data/lib/slack-notifier/{http_post.rb → default_http_client.rb}

@@ -1,11 +1,11 @@
 module Slack
   class Notifier
 
-    class HTTPPost
+    class DefaultHTTPClient
 
       class << self
-        def to uri, params
-          HTTPPost.new( uri, params ).call
+        def post uri, params
+          DefaultHTTPClient.new( uri, params ).call
         end
       end
 

data/lib/slack-notifier/version.rb

@@ -1,5 +1,5 @@
 module Slack
   class Notifier
-    VERSION = "0.5.0"
+    VERSION = "0.6.0"
   end
 end

data/spec/lib/slack-notifier/{http_post_spec.rb → default_http_client_spec.rb}

@@ -1,17 +1,17 @@
 require 'spec_helper'
 
-describe Slack::Notifier::HTTPPost do
+describe Slack::Notifier::DefaultHTTPClient do
 
-  describe "::to" do
-    it "initializes HTTPPost with the given uri and params then calls" do
-      http_post_double = instance_double("Slack::Notifier::HTTPPost")
+  describe "::post" do
+    it "initializes DefaultHTTPClient with the given uri and params then calls" do
+      http_post_double = instance_double("Slack::Notifier::DefaultHTTPClient")
 
       expect( described_class ).to receive(:new)
                                .with( 'uri', 'params' )
                                .and_return( http_post_double )
       expect( http_post_double ).to receive(:call)
 
-      described_class.to 'uri', 'params'
+      described_class.post 'uri', 'params'
     end
 
     # http_post is really tested in the integration spec,

data/spec/lib/slack-notifier_spec.rb

@@ -13,7 +13,7 @@ describe Slack::Notifier do
     end
 
     it "sets the optional service hook name" do
-      subject = described_class.new 'team', 'token', 'custom_hook_name'
+      subject = described_class.new 'team', 'token', hook_name: 'custom_hook_name'
       expect( subject.hook_name ).to eq 'custom_hook_name'
     end
 
@@ -22,8 +22,14 @@ describe Slack::Notifier do
       expect( subject.channel ).to eq 'foo'
     end
 
+    it "sets a custom http client" do
+      client  = double("CustomClient")
+      subject = described_class.new 'team', 'token', http_client: client
+      expect( subject.http_client ).to eq client
+    end
+
     it "can set service hook & default_payload options" do
-      subject = described_class.new 'team', 'token', 'hook_name', channel: 'foo'
+      subject = described_class.new 'team', 'token', hook_name: 'hook_name', channel: 'foo'
       expect( subject.channel ).to eq 'foo'
       expect( subject.hook_name ).to eq 'hook_name'
     end
@@ -31,7 +37,7 @@ describe Slack::Notifier do
 
   describe "#ping" do
     before :each do
-      allow( Slack::Notifier::HTTPPost ).to receive(:to)
+      allow( Slack::Notifier::DefaultHTTPClient ).to receive(:post)
     end
 
     it "passes the message through LinkFormatter" do
@@ -57,7 +63,7 @@ describe Slack::Notifier do
       end
 
       it "uses default channel" do
-        expect( Slack::Notifier::HTTPPost ).to receive(:to)
+        expect( Slack::Notifier::DefaultHTTPClient ).to receive(:post)
                           .with @endpoint_double,
                                 payload: '{"text":"the message","channel":"#default"}'
 
@@ -65,7 +71,7 @@ describe Slack::Notifier do
       end
 
       it "allows override channel to be set" do
-        expect( Slack::Notifier::HTTPPost ).to receive(:to)
+        expect( Slack::Notifier::DefaultHTTPClient ).to receive(:post)
                           .with @endpoint_double,
                                 payload: '{"text":"the message","channel":"new"}'
 
@@ -81,7 +87,7 @@ describe Slack::Notifier do
                       .with("https://team.slack.com/services/hooks/incoming-webhook?token=token")
                       .and_return(@endpoint_double)
 
-          expect( Slack::Notifier::HTTPPost ).to receive(:to)
+          expect( Slack::Notifier::DefaultHTTPClient ).to receive(:post)
                             .with @endpoint_double,
                                   payload: '{"text":"the message","channel":"channel"}'
 
@@ -96,11 +102,26 @@ describe Slack::Notifier do
                     .with("https://team.slack.com/services/hooks/custom_hook_name?token=token")
                     .and_return(@endpoint_double)
 
-        expect( Slack::Notifier::HTTPPost ).to receive(:to)
+        expect( Slack::Notifier::DefaultHTTPClient ).to receive(:post)
                           .with @endpoint_double,
                                 payload: '{"text":"the message","channel":"channel"}'
 
-        described_class.new("team","token","custom_hook_name").ping "the message", channel: "channel"
+        described_class.new("team","token", hook_name: "custom_hook_name").ping "the message", channel: "channel"
+      end
+    end
+
+    context "with a custom http_client set" do
+      it "uses it" do
+        endpoint_double = instance_double "URI::HTTP"
+        allow( URI ).to receive(:parse)
+                    .with("https://team.slack.com/services/hooks/incoming-webhook?token=token")
+                    .and_return(endpoint_double)
+        client = double("CustomClient")
+        expect( client ).to receive(:post)
+                        .with endpoint_double,
+                        payload: '{"text":"the message"}'
+
+        described_class.new('team','token',http_client: client).ping "the message"
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack-notifier
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Steven Sloan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-14 00:00:00.000000000 Z
+date: 2014-08-24 00:00:00.000000000 Z
 dependencies: []
 description: " A slim ruby wrapper for posting to slack webhooks "
 email:
@@ -18,11 +18,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/slack-notifier.rb
-- lib/slack-notifier/http_post.rb
+- lib/slack-notifier/default_http_client.rb
 - lib/slack-notifier/link_formatter.rb
 - lib/slack-notifier/version.rb
 - spec/integration/ping_integration_test.rb
-- spec/lib/slack-notifier/http_post_spec.rb
+- spec/lib/slack-notifier/default_http_client_spec.rb
 - spec/lib/slack-notifier/link_formatter_spec.rb
 - spec/lib/slack-notifier_spec.rb
 - spec/spec_helper.rb
@@ -52,8 +52,7 @@ specification_version: 4
 summary: A slim ruby wrapper for posting to slack webhooks
 test_files:
 - spec/integration/ping_integration_test.rb
-- spec/lib/slack-notifier/http_post_spec.rb
+- spec/lib/slack-notifier/default_http_client_spec.rb
 - spec/lib/slack-notifier/link_formatter_spec.rb
 - spec/lib/slack-notifier_spec.rb
 - spec/spec_helper.rb
-has_rdoc: