slack-notifier 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62117fcfa420e6b62d6c4982c33b27b7ada1174a
-  data.tar.gz: d475b9280f822a8f0eb67005b209a324b178891e
+  metadata.gz: 2f1ec45bf7b33fbafc47854195adbd58ef447820
+  data.tar.gz: 5f941b10ca31632805e4029cc432fee25dbe4de6
 SHA512:
-  metadata.gz: 49d78c4b6cc439d904c41024958fb46aa529b654ce1ff7f4aba4351cfacbb82137a722817e989bd1228c75ad6143c9556347c61e9ef82947f56c51138728a1ba
-  data.tar.gz: 0654d3a34c0223693109bed7badd4a99c4c162e140abe18995b8caa02c43b35ffe6789c2fb6ac538839dacae91531bfda298fbf4f596326450c373600a7ae2ec
+  metadata.gz: 2869813080b6254ae2bd41124ea10003b2a863721baa26710c4f86c455d15490f37f9660d7486465b11d3a0785c11e24b62f92200de4943ddbc42995a0f10fcb
+  data.tar.gz: 27943e0d35aedeee68ef5576419a4d4cbc79073f1f2ca21ce92a779eadc473f3f993dc289f10c232edb9f03e03d83069e043f678ad515a968eaa99f2c93f3aa5

data/lib/slack-notifier.rb

@@ -27,6 +27,14 @@ module Slack
       HTTPPost.to endpoint, payload: payload.to_json
     end
 
+    def channel=(channel)
+      @channel = if channel.start_with?('#')
+        channel
+      else
+        "##{channel}"
+      end
+    end
+
     private
 
       def default_hook_name

data/lib/slack-notifier/version.rb

@@ -1,5 +1,5 @@
 module Slack
   class Notifier
-    VERSION = "0.3.2"
+    VERSION = "0.4.0"
   end
 end

data/spec/lib/slack-notifier_spec.rb

@@ -1,15 +1,14 @@
 require 'spec_helper'
 
 describe Slack::Notifier do
+  subject { described_class.new 'team', 'token' }
 
   describe "#initialize" do
     it "sets the given team" do
-      subject = described_class.new 'team', 'token'
       expect( subject.team ).to eq 'team'
     end
 
     it "sets the given token" do
-      subject = described_class.new 'team', 'token'
       expect( subject.token ).to eq 'token'
     end
 
@@ -37,22 +36,21 @@ describe Slack::Notifier do
         @endpoint_double = instance_double "URI::HTTP"
         allow( URI ).to receive(:parse)
                     .and_return(@endpoint_double)
-        @subject = described_class.new('team','token')
-        @subject.channel = 'default'
+        subject.channel = '#default'
       end
 
       it "does not require a channel to ping" do
         expect{
-          @subject.ping "the message"
+          subject.ping "the message"
         }.not_to raise_error
       end
 
       it "uses default channel" do
         expect( Slack::Notifier::HTTPPost ).to receive(:to)
                           .with @endpoint_double,
-                                payload: '{"text":"the message","channel":"default"}'
+                                payload: '{"text":"the message","channel":"#default"}'
 
-        @subject.ping "the message"
+        subject.ping "the message"
       end
 
       it "allows override channel to be set" do
@@ -60,7 +58,7 @@ describe Slack::Notifier do
                           .with @endpoint_double,
                                 payload: '{"text":"the message","channel":"new"}'
 
-        @subject.ping "the message", channel: "new"
+        subject.ping "the message", channel: "new"
       end
 
     end
@@ -96,4 +94,15 @@ describe Slack::Notifier do
     end
   end
 
+  describe "#channel=" do
+    it "sets the given channel" do
+      subject.channel = "#foo"
+      expect( subject.channel ).to eql "#foo"
+    end
+
+    it "adds # prefix to channel" do
+      subject.channel = "foo"
+      expect( subject.channel ).to eql "#foo"
+    end
+  end
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: slack-notifier
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Steven Sloan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-27 00:00:00.000000000 Z
+date: 2014-03-28 00:00:00.000000000 Z
 dependencies: []
-description: ' A slim ruby wrapper for posting to slack webhooks '
+description: " A slim ruby wrapper for posting to slack webhooks "
 email:
 - stevenosloan@gmail.com
 executables: []
@@ -36,12 +36,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -56,3 +56,4 @@ test_files:
 - spec/lib/slack-notifier/link_formatter_spec.rb
 - spec/lib/slack-notifier_spec.rb
 - spec/spec_helper.rb
+has_rdoc: