slack-notifier 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 74be6686d197c0285dad45f56a46c77dfedeae9b
-  data.tar.gz: 0df6fa89e9f255d7c531d94b591759e02dd72663
+  metadata.gz: 62117fcfa420e6b62d6c4982c33b27b7ada1174a
+  data.tar.gz: d475b9280f822a8f0eb67005b209a324b178891e
 SHA512:
-  metadata.gz: 4fc10076579789f5e6ce385daa35230728bb070ed0173eb9aaa19452bfd3ac68659a3014f08320623c179d62b61c446da4942124e09151e80aca6612fcca883d
-  data.tar.gz: 02baddde738bd21635fe9c266c678c7cb2ac3fb42ced0238a1494c666d7a2309496040861f0e4e4afb07eb488b6aed32cb46cb9b819b838ff78805d35df01f21
+  metadata.gz: 49d78c4b6cc439d904c41024958fb46aa529b654ce1ff7f4aba4351cfacbb82137a722817e989bd1228c75ad6143c9556347c61e9ef82947f56c51138728a1ba
+  data.tar.gz: 0654d3a34c0223693109bed7badd4a99c4c162e140abe18995b8caa02c43b35ffe6789c2fb6ac538839dacae91531bfda298fbf4f596326450c373600a7ae2ec

data/lib/slack-notifier/http_post.rb

@@ -0,0 +1,42 @@
+module Slack
+  class Notifier
+
+    class HTTPPost
+
+      class << self
+        def to uri, params
+          HTTPPost.new( uri, params ).call
+        end
+      end
+
+      attr_reader :uri, :params
+
+      def initialize uri, params
+        @uri    = uri
+        @params = params
+      end
+
+      def call
+        http_obj.request request_obj
+      end
+
+      private
+
+        def request_obj
+          req = Net::HTTP::Post.new uri.request_uri
+          req.set_form_data params
+
+          return req
+        end
+
+        def http_obj
+          http = Net::HTTP.new uri.host, uri.port
+          http.use_ssl = (uri.scheme == "https")
+
+          return http
+        end
+
+    end
+
+  end
+end

data/lib/slack-notifier/version.rb

@@ -1,5 +1,5 @@
 module Slack
   class Notifier
-    VERSION = "0.3.1"
+    VERSION = "0.3.2"
   end
 end

data/lib/slack-notifier.rb

@@ -2,6 +2,7 @@ require 'net/http'
 require 'uri'
 require 'json'
 
+require_relative 'slack-notifier/http_post'
 require_relative 'slack-notifier/link_formatter'
 
 module Slack
@@ -23,7 +24,7 @@ module Slack
       message = LinkFormatter.format(message)
       payload = { text: message }.merge(default_payload).merge(options)
 
-      Net::HTTP.post_form endpoint, payload: payload.to_json
+      HTTPPost.to endpoint, payload: payload.to_json
     end
 
     private

data/spec/integration/ping_integration_test.rb

@@ -0,0 +1,5 @@
+require_relative '../../lib/slack-notifier'
+
+notifier = Slack::Notifier.new ENV['SLACK_TEAM'], ENV['SLACK_TOKEN']
+puts "testing with ruby #{RUBY_VERSION}"
+notifier.ping "hello from notifier test script on ruby: #{RUBY_VERSION}"

data/spec/lib/slack-notifier/http_post_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Slack::Notifier::HTTPPost do
+
+  describe "::to" do
+    it "initializes HTTPPost with the given uri and params then calls" do
+      http_post_double = instance_double("Slack::Notifier::HTTPPost")
+
+      expect( described_class ).to receive(:new)
+                               .with( 'uri', 'params' )
+                               .and_return( http_post_double )
+      expect( http_post_double ).to receive(:call)
+
+      described_class.to 'uri', 'params'
+    end
+
+    # http_post is really tested in the integration spec,
+    # where the internals are run through
+  end
+
+end

data/spec/lib/slack-notifier_spec.rb

@@ -21,7 +21,7 @@ describe Slack::Notifier do
 
   describe "#ping" do
     before :each do
-      allow( Net::HTTP ).to receive(:post_form)
+      allow( Slack::Notifier::HTTPPost ).to receive(:to)
     end
 
     it "passes the message through LinkFormatter" do
@@ -48,7 +48,7 @@ describe Slack::Notifier do
       end
 
       it "uses default channel" do
-        expect( Net::HTTP ).to receive(:post_form)
+        expect( Slack::Notifier::HTTPPost ).to receive(:to)
                           .with @endpoint_double,
                                 payload: '{"text":"the message","channel":"default"}'
 
@@ -56,7 +56,7 @@ describe Slack::Notifier do
       end
 
       it "allows override channel to be set" do
-        expect( Net::HTTP ).to receive(:post_form)
+        expect( Slack::Notifier::HTTPPost ).to receive(:to)
                           .with @endpoint_double,
                                 payload: '{"text":"the message","channel":"new"}'
 
@@ -72,7 +72,7 @@ describe Slack::Notifier do
                       .with("https://team.slack.com/services/hooks/incoming-webhook?token=token")
                       .and_return(@endpoint_double)
 
-          expect( Net::HTTP ).to receive(:post_form)
+          expect( Slack::Notifier::HTTPPost ).to receive(:to)
                             .with @endpoint_double,
                                   payload: '{"text":"the message","channel":"channel"}'
 
@@ -87,7 +87,7 @@ describe Slack::Notifier do
                     .with("https://team.slack.com/services/hooks/custom_hook_name?token=token")
                     .and_return(@endpoint_double)
 
-        expect( Net::HTTP ).to receive(:post_form)
+        expect( Slack::Notifier::HTTPPost ).to receive(:to)
                           .with @endpoint_double,
                                 payload: '{"text":"the message","channel":"channel"}'
 

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: slack-notifier
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Steven Sloan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-25 00:00:00.000000000 Z
+date: 2014-03-27 00:00:00.000000000 Z
 dependencies: []
-description: " A slim ruby wrapper for posting to slack webhooks "
+description: ' A slim ruby wrapper for posting to slack webhooks '
 email:
 - stevenosloan@gmail.com
 executables: []
@@ -18,8 +18,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/slack-notifier.rb
+- lib/slack-notifier/http_post.rb
 - lib/slack-notifier/link_formatter.rb
 - lib/slack-notifier/version.rb
+- spec/integration/ping_integration_test.rb
+- spec/lib/slack-notifier/http_post_spec.rb
 - spec/lib/slack-notifier/link_formatter_spec.rb
 - spec/lib/slack-notifier_spec.rb
 - spec/spec_helper.rb
@@ -33,12 +36,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -48,7 +51,8 @@ signing_key:
 specification_version: 4
 summary: A slim ruby wrapper for posting to slack webhooks
 test_files:
+- spec/integration/ping_integration_test.rb
+- spec/lib/slack-notifier/http_post_spec.rb
 - spec/lib/slack-notifier/link_formatter_spec.rb
 - spec/lib/slack-notifier_spec.rb
 - spec/spec_helper.rb
-has_rdoc: