slack-notifier 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 343978628e7a8085818befad991f0c3629527237
-  data.tar.gz: c05543a0c0385f954bd79bd64def1743b2d8e346
+  metadata.gz: 4c25d21ad14b892d64f85243a8efbe8ae44b0afe
+  data.tar.gz: d503745569e2e3c73b68d3f58103b37bd47f3e27
 SHA512:
-  metadata.gz: cb4ab2e7781936a0d9829e5426848a89832063f2e9791ab5531f89df244acfc29d01b814ac8e2f6d7d36797d7229f8d1acdf2e8b27992a13255980f29bf66d06
-  data.tar.gz: c21154be148aa4e44d432f3006229989e29a889b4302de2f7b5170a15e481150fe733809ea98ec5971eca428ce70fe3a2599e88fb490bd1e8ecb39de1d17dfbb
+  metadata.gz: 8eb400bf7af214c7d85e066948fd76e412513d3f19b703c039fd91c99ed9275510cb1111d157463021c7d2166e4eafb232465ca091aef6b1ebc4daf482c8617b
+  data.tar.gz: 659801d155a85f5ade8c509be7fa70019943801fb5bb173696ff5d64ce7feffb944eeddb1d2ae8932165f799865a0ad0c21a57eb1732a5f54ee77b45fc023af8

data/lib/slack-notifier.rb

@@ -1,4 +1,5 @@
-require 'httparty'
+require 'net/http'
+require 'uri'
 require 'json'
 
 require_relative 'slack-notifier/link_formatter'
@@ -25,7 +26,7 @@ module Slack
         raise ArgumentError, "You must set a channel"
       end
 
-      HTTParty.post( endpoint, body: "payload=#{payload.to_json}" )
+      Net::HTTP.post_form endpoint, payload: payload.to_json
     end
 
     private
@@ -38,7 +39,7 @@ module Slack
       end
 
       def endpoint
-        "https://#{team}.slack.com/services/hooks/incoming-webhook?token=#{token}"
+        URI.parse "https://#{team}.slack.com/services/hooks/incoming-webhook?token=#{token}"
       end
 
   end

data/lib/slack-notifier/version.rb

@@ -1,5 +1,5 @@
 module Slack
   class Notifier
-    VERSION = "0.1.1"
+    VERSION = "0.2.0"
   end
 end

data/spec/lib/slack-notifier_spec.rb

@@ -15,8 +15,15 @@ describe Slack::Notifier do
   end
 
   describe "#ping" do
+    before :each do
+      allow( Net::HTTP ).to receive(:post_form)
+      @endpoint_double = instance_double "URI::HTTP"
+      allow( URI ).to receive(:parse)
+                  .with("https://team.slack.com/services/hooks/incoming-webhook?token=token")
+                  .and_return(@endpoint_double)
+    end
+
     it "passes the message through LinkFormatter" do
-      allow( HTTParty ).to receive(:post)
       expect( Slack::Notifier::LinkFormatter ).to receive(:format)
                                               .with("the message")
 
@@ -24,8 +31,6 @@ describe Slack::Notifier do
     end
 
     it "requires a channel to be set" do
-      allow( HTTParty ).to receive(:post)
-
       expect{
         described_class.new('team','token').ping "the message"
       }.to raise_error
@@ -34,7 +39,6 @@ describe Slack::Notifier do
     context "with a default channel set" do
 
       before :each do
-        allow( HTTParty ).to receive(:post)
         @subject = described_class.new('team','token')
         @subject.channel = 'default'
       end
@@ -46,17 +50,17 @@ describe Slack::Notifier do
       end
 
       it "uses default channel" do
-        expect( HTTParty ).to receive(:post)
-                          .with "https://team.slack.com/services/hooks/incoming-webhook?token=token",
-                                body: 'payload={"text":"the message","channel":"default"}'
+        expect( Net::HTTP ).to receive(:post_form)
+                          .with @endpoint_double,
+                                payload: '{"text":"the message","channel":"default"}'
 
         @subject.ping "the message"
       end
 
       it "allows override channel to be set" do
-        expect( HTTParty ).to receive(:post)
-                          .with "https://team.slack.com/services/hooks/incoming-webhook?token=token",
-                                body: 'payload={"text":"the message","channel":"new"}'
+        expect( Net::HTTP ).to receive(:post_form)
+                          .with @endpoint_double,
+                                payload: '{"text":"the message","channel":"new"}'
 
         @subject.ping "the message", channel: "new"
       end
@@ -64,9 +68,9 @@ describe Slack::Notifier do
     end
 
     it "posts with the correct endpoint & data" do
-        expect( HTTParty ).to receive(:post)
-                          .with "https://team.slack.com/services/hooks/incoming-webhook?token=token",
-                                body: 'payload={"text":"the message","channel":"channel"}'
+        expect( Net::HTTP ).to receive(:post_form)
+                          .with @endpoint_double,
+                                payload: '{"text":"the message","channel":"channel"}'
 
         described_class.new("team","token").ping "the message", channel: "channel"
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: slack-notifier
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Steven Sloan
@@ -9,22 +9,8 @@ autorequire:
 bindir: bin
 cert_chain: []
 date: 2014-03-02 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: httparty
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.11'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.11'
-description: ' A slim ruby wrapper for posting to slack channels '
+dependencies: []
+description: ' A slim ruby wrapper for posting to slack webhooks '
 email:
 - stevenosloan@gmail.com
 executables: []
@@ -60,7 +46,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: A slim ruby wrapper for posting to slack channels
+summary: A slim ruby wrapper for posting to slack webhooks
 test_files:
 - spec/lib/slack-notifier/link_formatter_spec.rb
 - spec/lib/slack-notifier_spec.rb