skywalker 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2694a53679e9a4856529718e3d7a80108aa32273
-  data.tar.gz: 030762cf30ce2e24fef88a41098744ab65036965
+  metadata.gz: 409bd338e84e6633417f194fe89fd1ea74b12fc5
+  data.tar.gz: 51beb6b911c2b142f74900bfa59420cca6b26848
 SHA512:
-  metadata.gz: ceed550cb8e32449ba3897c46a8b53ca4d89dc96874d66ebef9aa142227fddf928d8f2f4c6bfde3982239d348732035e31e90f472b6cb60a97b6d78b9ba422b5
-  data.tar.gz: 550fdeacbc19bebc36bab1eaf51c5171eb638f7a7364fa3d3d2079b9139e2244362fa1b8cc4b5ce4742c4010c63d9e8115d6e3526a8d58264dcfc4a75154e8f9
+  metadata.gz: e237880ca6fc003a627c071922a3c345679f85f7db88b0026f3641c421b4feb8f703898134323c5e84b47164f028d07e1304fa2e7c1f180852a48d4b61b37520
+  data.tar.gz: 0a0de39ec25816c5272d0c15f56cfd973c532526de8d21b0799312b9d9e13d19aa53dce794784eb491d4fa7fe5453bc2398a3ccb207b5d839adf45fc50ba40ed

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 All commits by Rob Yurkowski unless otherwise noted.
 
+## 1.2.1 (2014-11-23)
+
+- Fix a bug where callbacks would be called even if they were nil.
+
+## 1.2.0 (2014-11-16)
+
+- Add `required_args`, which allows marking certain attributes as required at initialization. Defaults to an empty list.
+- Add testing section of README.
+- Add example files.
 
 ## 1.1.0 (2014-11-03)
 

data/README.md

@@ -241,6 +241,12 @@ command = AddGroupCommand.call(
 
 You can pass any object responding to `#call` to the `on_success` and `on_failure` handlers, including procs, lambdas, controller methods, or other commands themselves.
 
+### What happens when callbacks fail?
+
+Exceptions thrown inside the success callbacks (`on_success` or your own callbacks defined in `run_success_callbacks`) will cause the command to fail and run the failure callbacks.
+
+Exceptions thrown inside the failure callbacks (`on_failure` or your own callbacks defined in `run_failure_callbacks`) will not be caught and will bubble out of the command.
+
 ### Overriding Methods
 
 The following methods are overridable for easy customization:

data/examples/Gemfile.lock

@@ -1,20 +1,20 @@
 PATH
   remote: ../
   specs:
-    skywalker (1.1.1)
+    skywalker (1.2.1)
       activerecord (~> 4.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (4.1.7)
-      activesupport (= 4.1.7)
+    activemodel (4.1.8)
+      activesupport (= 4.1.8)
       builder (~> 3.1)
-    activerecord (4.1.7)
-      activemodel (= 4.1.7)
-      activesupport (= 4.1.7)
+    activerecord (4.1.8)
+      activemodel (= 4.1.8)
+      activesupport (= 4.1.8)
       arel (~> 5.0.0)
-    activesupport (4.1.7)
+    activesupport (4.1.8)
       i18n (~> 0.6, >= 0.6.9)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)

data/lib/skywalker/command.rb

@@ -101,7 +101,7 @@ module Skywalker
 
 
     private def run_success_callbacks
-      on_success.call(self) if self.respond_to?(:on_success)
+      on_success.call(self) unless on_success.nil?
     end
 
 
@@ -115,7 +115,7 @@ module Skywalker
 
 
     private def run_failure_callbacks
-      on_failure.call(self) if self.respond_to?(:on_failure)
+      on_failure.call(self) unless on_failure.nil?
     end
   end
 end

data/lib/skywalker/version.rb

@@ -1,3 +1,3 @@
 module Skywalker
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/lib/skywalker/command_spec.rb

@@ -83,18 +83,30 @@ module Skywalker
         end
 
         describe "on_success" do
-          context "when on_success is defined" do
+          context "when on_success is not nil" do
             it "calls the on_success callback with itself" do
               expect(on_success).to receive(:call).with(command)
               command.call
             end
+
+            context "when on_success is not callable" do
+              let(:on_failure) { double("on_failure") }
+              let(:command) { Command.new(on_success: "a string", on_failure: on_failure) }
+
+              it "confirms failure if the on_success callback fails" do
+                expect(on_failure).to receive(:call).with(command)
+                command.call
+              end
+            end
           end
 
-          context "when on_success is not defined" do
-            let(:command) { Command.new }
+          context "when on_success is nil" do
+            let(:nil_callback) { double("fakenil", nil?: true) }
+            let(:command) { Command.new(on_success: nil_callback) }
 
             it "does not call on_success" do
-              expect(command).not_to receive(:on_success)
+              expect(nil_callback).not_to receive(:call)
+              command.call
             end
           end
         end
@@ -131,18 +143,28 @@ module Skywalker
             allow(command).to receive(:error=)
           end
 
-          context "when on_failure is defined" do
+          context "when on_failure is not nil" do
             it "calls the on_failure callback with itself" do
               expect(on_failure).to receive(:call).with(command)
               command.call
             end
+
+            context "when on_failure is not callable" do
+              let(:command) { Command.new(on_failure: "a string") }
+
+              it "raises an error" do
+                expect { command.call }.to raise_error
+              end
+            end
           end
 
-          context "when on_failure is not defined" do
-            let(:command) { Command.new }
+          context "when on_failure is nil" do
+            let(:nil_callback) { double("fakenil", nil?: true) }
+            let(:command) { Command.new(on_failure: nil_callback) }
 
             it "does not call on_failure" do
-              expect(command).not_to receive(:on_failure)
+              expect(nil_callback).not_to receive(:call)
+              command.call
             end
           end
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skywalker
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Rob Yurkowski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-16 00:00:00.000000000 Z
+date: 2014-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord