skylight 1.0.0.beta5 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4cc154a1ba48ba4464fde882dc8fe46dc8134613
-  data.tar.gz: 4e6ad10d34bdc717cb73a3df2bb96ef6df8e7dd9
+  metadata.gz: 28dd7214b4627640a19b45a6e5fc331fbfacf27c
+  data.tar.gz: 024db5832f07bc150605be92ab4e08dd564d5e17
 SHA512:
-  metadata.gz: f29f9b1c1a8fd5d33e27bb0aa9593fa2cda1971661f2bb2e485bbcb462a4c2a65cbc7ae4ac99effaae3d089810781ee89c3bdc5c68abaddd2e5f318b95b037d8
-  data.tar.gz: 8affdbb2297f3aa1d18927d7a63aefabab7a244c7884935d248fe96f5536aec494a35aab42a79112d7727405da0501753fa2c636eb91aa60f262d0cb7cf9ba2d
+  metadata.gz: e061ebe3cb082688bf4b1986aa48bd6cb9ed3810097f1eced4f0c96c589d53eb3072c394fa163c5d792ce8c271efb9202931f02b68f325c8d36d19ce4f2e283e
+  data.tar.gz: 51def9a798e16514df5de9eecb62ad70ed78d00770837ef73c81805a5b6b6d948c707cecd6011515eb9b6f8fa3d61b7a052394b8134938515315478a445c9ebf

data/CHANGELOG.md

@@ -1,13 +1,16 @@
-## 1.0.0-beta5 (June 29, 2016)
+## 1.0.0 (October 19, 2016)
 
 * [BETA FEATURE] Track separate segments for endpoints. Contact support@skylight.io to have this feature enabled for your account.
 * [FEATURE] Initial 'skylight doctor' command
 * [BREAKING] Removed old `skylight setup` without creation token
 * [BREAKING] Remove Ruby based SQL lexer
 * [IMPROVEMENT] Internal refactors
-* [IMPROVEMENT] On Heroku, log to STDOUT instead of logfile
 * [BUGFIX] Correctly pass 'false' config values to Rust agent
 
+## 0.10.6 (August 10, 2016)
+
+* [BUGFIX] Turn off -Werror and -pedantic for builds. [Issue #64](https://github.com/skylightio/skylight-ruby/issues/64)
+
 ## 0.10.5 (June 22, 2016)
 
 * [BUGFIX] Fix issue with Grape multi-method naming

data/ext/extconf.rb

@@ -24,6 +24,8 @@ SKYLIGHT_SOURCE_URL = ENV['SKYLIGHT_SOURCE_URL']
 SKYLIGHT_VERSION = ENV['SKYLIGHT_VERSION']
 SKYLIGHT_CHECKSUM = ENV['SKYLIGHT_CHECKSUM']
 
+SKYLIGHT_EXT_STRICT = ENV.key?("SKYLIGHT_EXT_STRICT") && ENV['SKYLIGHT_EXT_STRICT'] =~ /^true$/i
+
 # Setup logger
 LOG = Logger.new(MultiIO.new(STDOUT, File.open(SKYLIGHT_INSTALL_LOG, 'a')))
 
@@ -185,9 +187,16 @@ unless have_func('rb_thread_call_without_gvl', 'ruby/thread.h')
   have_func('rb_thread_blocking_region') or abort "Ruby is unexpectedly missing rb_thread_blocking_region. This should not happen."
 end
 
-# Some extra checks
-# -Werror is needed for the fast thread local storage
-$CFLAGS << " -Werror"
+# Previous comment stated:
+#   -Werror is needed for the fast thread local storage
+#
+# Despite this comment, everything appears to build fine without the flag on. Since this
+#   flag can cause issues for some customers we're turning it off by default. However,
+#   in development and CI, we still have the option of turning it back on to help catch
+#   potential issues.
+if SKYLIGHT_EXT_STRICT
+  $CFLAGS << " -Werror"
+end
 
 checking_for 'fast thread local storage' do
   if try_compile("__thread int foo;")
@@ -196,17 +205,13 @@ checking_for 'fast thread local storage' do
   end
 end
 
-#     spec = nil
-#     checking_for('thread_specific', '%s') do
-#       spec = %w[__declspec(thread) __thread].find {|th|
-#         try_compile("#{th} int foo;", "", :werror => true)
-#       }
-#       spec or 'no'
-#     end
-#     $defs << "-DRB_THREAD_SPECIFIC=#{spec}" if spec
-
 # Flag -std=c99 required for older build systems
-$CFLAGS << " -std=c99 -pedantic -Wall -fno-strict-aliasing"
+$CFLAGS << " -std=c99 -Wall -fno-strict-aliasing"
+
+# Allow stricter checks to be turned on for development or debugging
+if SKYLIGHT_EXT_STRICT
+  $CFLAGS << " -pedantic"
+end
 
 # TODO: Compute the relative path to the location
 create_makefile 'skylight_native', File.expand_path('..', __FILE__) # or fail "could not create makefile"

data/lib/skylight/version.rb

@@ -1,4 +1,4 @@
 module Skylight
-  VERSION = '1.0.0-beta5'
+  VERSION = '1.0.0'
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skylight
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta5
+  version: 1.0.0
 platform: ruby
 authors:
 - Tilde, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-06 00:00:00.000000000 Z
+date: 2016-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -180,9 +180,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.5.1
@@ -190,4 +190,3 @@ signing_key:
 specification_version: 4
 summary: Skylight is a smart profiler for Rails apps
 test_files: []
-has_rdoc: