skylight 0.10.5 → 0.10.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: b493d2bd2640af0664051fabec05cb868ff84b95
4
- data.tar.gz: f5d1f59e9653f75e13d6235c9b0edd2e41316f62
3
+ metadata.gz: 773ffa2d7890941c87af2e1ba08c0a0f4009d1c0
4
+ data.tar.gz: 6f9799920986f0b5f90153cf7bf32036490828a7
5
5
  SHA512:
6
- metadata.gz: c9b9b7ab7b673ce41b1e48caa14fd75e4ed89e4761272eed68b3541d1ca70d76e451033f515f748d2ffc5c2e08e68ab41e5bc6166c19b8cd9ac9b75539929a62
7
- data.tar.gz: 8aba7b9f73bae5cefaf1b7c772c7687bb3a8b0103378c93350aefb111d51600db0af90055c7c5b29908ba8bb213433f243a1775bbfca31ad44cff402d5de8219
6
+ metadata.gz: 120e99f711d7b608daa826f6514d96b0b4d3c184d9fa94b89c3b607f94646604e813d6d1233f3c43660fd400968a0b5610b2cf510a6baca102e52ddb55575ad6
7
+ data.tar.gz: ea0f555fed4c920cc4df9eb898b3710102e7a9541ea629bc3b4c3443dcf06a8afd1f20d5fdeab3a534e059d76fa4a902f39760a9889509b31a861cbbf5fd739a
@@ -1,3 +1,7 @@
1
+ ## 0.10.6 (August 10, 2016)
2
+
3
+ * [BUGFIX] Turn off -Werror and -pedantic for builds. [Issue #64](https://github.com/skylightio/skylight-ruby/issues/64)
4
+
1
5
  ## 0.10.5 (June 22, 2016)
2
6
 
3
7
  * [BUGFIX] Fix issue with Grape multi-method naming
@@ -24,6 +24,8 @@ SKYLIGHT_SOURCE_URL = ENV['SKYLIGHT_SOURCE_URL']
24
24
  SKYLIGHT_VERSION = ENV['SKYLIGHT_VERSION']
25
25
  SKYLIGHT_CHECKSUM = ENV['SKYLIGHT_CHECKSUM']
26
26
 
27
+ SKYLIGHT_EXT_STRICT = ENV.key?("SKYLIGHT_EXT_STRICT") && ENV['SKYLIGHT_EXT_STRICT'] =~ /^true$/i
28
+
27
29
  # Setup logger
28
30
  LOG = Logger.new(MultiIO.new(STDOUT, File.open(SKYLIGHT_INSTALL_LOG, 'a')))
29
31
 
@@ -185,9 +187,16 @@ unless have_func('rb_thread_call_without_gvl', 'ruby/thread.h')
185
187
  have_func('rb_thread_blocking_region') or abort "Ruby is unexpectedly missing rb_thread_blocking_region. This should not happen."
186
188
  end
187
189
 
188
- # Some extra checks
189
- # -Werror is needed for the fast thread local storage
190
- $CFLAGS << " -Werror"
190
+ # Previous comment stated:
191
+ # -Werror is needed for the fast thread local storage
192
+ #
193
+ # Despite this comment, everything appears to build fine without the flag on. Since this
194
+ # flag can cause issues for some customers we're turning it off by default. However,
195
+ # in development and CI, we still have the option of turning it back on to help catch
196
+ # potential issues.
197
+ if SKYLIGHT_EXT_STRICT
198
+ $CFLAGS << " -Werror"
199
+ end
191
200
 
192
201
  checking_for 'fast thread local storage' do
193
202
  if try_compile("__thread int foo;")
@@ -196,17 +205,13 @@ checking_for 'fast thread local storage' do
196
205
  end
197
206
  end
198
207
 
199
- # spec = nil
200
- # checking_for('thread_specific', '%s') do
201
- # spec = %w[__declspec(thread) __thread].find {|th|
202
- # try_compile("#{th} int foo;", "", :werror => true)
203
- # }
204
- # spec or 'no'
205
- # end
206
- # $defs << "-DRB_THREAD_SPECIFIC=#{spec}" if spec
207
-
208
208
  # Flag -std=c99 required for older build systems
209
- $CFLAGS << " -std=c99 -pedantic -Wall -fno-strict-aliasing"
209
+ $CFLAGS << " -std=c99 -Wall -fno-strict-aliasing"
210
+
211
+ # Allow stricter checks to be turned on for development or debugging
212
+ if SKYLIGHT_EXT_STRICT
213
+ $CFLAGS << " -pedantic"
214
+ end
210
215
 
211
216
  # TODO: Compute the relative path to the location
212
217
  create_makefile 'skylight_native', File.expand_path('..', __FILE__) # or fail "could not create makefile"
@@ -1,4 +1,4 @@
1
1
  module Skylight
2
- VERSION = '0.10.5'
2
+ VERSION = '0.10.6'
3
3
  end
4
4
 
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: skylight
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.10.5
4
+ version: 0.10.6
5
5
  platform: ruby
6
6
  authors:
7
7
  - Tilde, Inc.
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2016-06-22 00:00:00.000000000 Z
11
+ date: 2016-08-11 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activesupport
@@ -186,9 +186,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
186
186
  version: '0'
187
187
  requirements: []
188
188
  rubyforge_project:
189
- rubygems_version: 2.5.2
189
+ rubygems_version: 2.5.1
190
190
  signing_key:
191
191
  specification_version: 4
192
192
  summary: Skylight is a smart profiler for Rails apps
193
193
  test_files: []
194
- has_rdoc: