skylight 0.10.5 → 0.10.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b493d2bd2640af0664051fabec05cb868ff84b95
-  data.tar.gz: f5d1f59e9653f75e13d6235c9b0edd2e41316f62
+  metadata.gz: 773ffa2d7890941c87af2e1ba08c0a0f4009d1c0
+  data.tar.gz: 6f9799920986f0b5f90153cf7bf32036490828a7
 SHA512:
-  metadata.gz: c9b9b7ab7b673ce41b1e48caa14fd75e4ed89e4761272eed68b3541d1ca70d76e451033f515f748d2ffc5c2e08e68ab41e5bc6166c19b8cd9ac9b75539929a62
-  data.tar.gz: 8aba7b9f73bae5cefaf1b7c772c7687bb3a8b0103378c93350aefb111d51600db0af90055c7c5b29908ba8bb213433f243a1775bbfca31ad44cff402d5de8219
+  metadata.gz: 120e99f711d7b608daa826f6514d96b0b4d3c184d9fa94b89c3b607f94646604e813d6d1233f3c43660fd400968a0b5610b2cf510a6baca102e52ddb55575ad6
+  data.tar.gz: ea0f555fed4c920cc4df9eb898b3710102e7a9541ea629bc3b4c3443dcf06a8afd1f20d5fdeab3a534e059d76fa4a902f39760a9889509b31a861cbbf5fd739a

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.10.6 (August 10, 2016)
+
+* [BUGFIX] Turn off -Werror and -pedantic for builds. [Issue #64](https://github.com/skylightio/skylight-ruby/issues/64)
+
 ## 0.10.5 (June 22, 2016)
 
 * [BUGFIX] Fix issue with Grape multi-method naming

data/ext/extconf.rb

@@ -24,6 +24,8 @@ SKYLIGHT_SOURCE_URL = ENV['SKYLIGHT_SOURCE_URL']
 SKYLIGHT_VERSION = ENV['SKYLIGHT_VERSION']
 SKYLIGHT_CHECKSUM = ENV['SKYLIGHT_CHECKSUM']
 
+SKYLIGHT_EXT_STRICT = ENV.key?("SKYLIGHT_EXT_STRICT") && ENV['SKYLIGHT_EXT_STRICT'] =~ /^true$/i
+
 # Setup logger
 LOG = Logger.new(MultiIO.new(STDOUT, File.open(SKYLIGHT_INSTALL_LOG, 'a')))
 
@@ -185,9 +187,16 @@ unless have_func('rb_thread_call_without_gvl', 'ruby/thread.h')
   have_func('rb_thread_blocking_region') or abort "Ruby is unexpectedly missing rb_thread_blocking_region. This should not happen."
 end
 
-# Some extra checks
-# -Werror is needed for the fast thread local storage
-$CFLAGS << " -Werror"
+# Previous comment stated:
+#   -Werror is needed for the fast thread local storage
+#
+# Despite this comment, everything appears to build fine without the flag on. Since this
+#   flag can cause issues for some customers we're turning it off by default. However,
+#   in development and CI, we still have the option of turning it back on to help catch
+#   potential issues.
+if SKYLIGHT_EXT_STRICT
+  $CFLAGS << " -Werror"
+end
 
 checking_for 'fast thread local storage' do
   if try_compile("__thread int foo;")
@@ -196,17 +205,13 @@ checking_for 'fast thread local storage' do
   end
 end
 
-#     spec = nil
-#     checking_for('thread_specific', '%s') do
-#       spec = %w[__declspec(thread) __thread].find {|th|
-#         try_compile("#{th} int foo;", "", :werror => true)
-#       }
-#       spec or 'no'
-#     end
-#     $defs << "-DRB_THREAD_SPECIFIC=#{spec}" if spec
-
 # Flag -std=c99 required for older build systems
-$CFLAGS << " -std=c99 -pedantic -Wall -fno-strict-aliasing"
+$CFLAGS << " -std=c99 -Wall -fno-strict-aliasing"
+
+# Allow stricter checks to be turned on for development or debugging
+if SKYLIGHT_EXT_STRICT
+  $CFLAGS << " -pedantic"
+end
 
 # TODO: Compute the relative path to the location
 create_makefile 'skylight_native', File.expand_path('..', __FILE__) # or fail "could not create makefile"

data/lib/skylight/version.rb

@@ -1,4 +1,4 @@
 module Skylight
-  VERSION = '0.10.5'
+  VERSION = '0.10.6'
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skylight
 version: !ruby/object:Gem::Version
-  version: 0.10.5
+  version: 0.10.6
 platform: ruby
 authors:
 - Tilde, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-22 00:00:00.000000000 Z
+date: 2016-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -186,9 +186,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Skylight is a smart profiler for Rails apps
 test_files: []
-has_rdoc: