skylight 0.1.3 → 0.1.4.alpha1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5fa6f7a23ed460ec9e8a504a7a7037aa6b149b6e
-  data.tar.gz: b18f06a7640507138ac6b72dd218e7aa6632ee03
+  metadata.gz: 6312c24e2ef0a54be711b60410888886646f65a0
+  data.tar.gz: a3dc0c4c3e2374722153c9efe12317955a37fc28
 SHA512:
-  metadata.gz: 6e1df38e803461a12dad4df99780fbfb93308b47fa7c16304ffaac7073cd13f5e8d4d9bb9d36a084636e15bb4bf516a42042a8809e499369b6c1c9831c6dd88b
-  data.tar.gz: 48b0b867f8f02c24c7de705040770f9e0b9a72c58260845ca52f5d0e1f5bdb55a521a54cc08b66ad5427cf30e5866c17a81d231626127f7f97b06a4ab6ccd989
+  metadata.gz: d1fedcb75d67f27aa003b8926e40ea1b5eab792b07e486f3e7d1387471e388dc97b2ab85ff8239c13e1eaee593ef6a3fea468c2afd48cabbae57243a95a7b2bd
+  data.tar.gz: b79ffd3549eb6b0381e86707ae42fbefb2e1e74e05d622681599cfee7c3a1dc37f6edcfd24f353fb7c12546e9d7367c352edc348fb2c76097b2e6205dd84764f

data/CHANGELOG.md

@@ -1,5 +1,7 @@
 ## unreleased ##
 
+* [BUG] Fix some errors caused by floating point rounding.
+
 ## 0.1.3 (May 29, 2013)
 
 * [BUG] Require net/https and openssl

data/lib/skylight/gc.rb

@@ -17,7 +17,7 @@ module Skylight
       if win = Thread.current[TH_KEY]
         win.time
       else
-        0.0
+        0
       end
     end
 
@@ -27,7 +27,7 @@ module Skylight
       @listeners = []
       @config    = config
       @lock      = Mutex.new
-      @time      = 0.0
+      @time      = 0
 
       if METHODS.all? { |m| profiler.respond_to?(m) }
         @profiler = profiler
@@ -98,7 +98,7 @@ module Skylight
       diff  = time - @time
       @time = time
 
-      if diff > 0.0
+      if diff > 0
         @listeners.each do |l|
           l.add(diff)
         end
@@ -110,7 +110,7 @@ module Skylight
 
       def initialize(global)
         @global = global
-        @time   = 0.0
+        @time   = 0
       end
 
       def update

data/lib/skylight/instrumenter.rb

@@ -79,7 +79,7 @@ module Skylight
         return yield(trace)
       end
 
-      trace = Messages::Trace::Builder.new(endpoint, Util::Clock.now, @config)
+      trace = Messages::Trace::Builder.new(endpoint, Util::Clock.micros, @config)
 
       begin
 
@@ -112,7 +112,8 @@ module Skylight
   private
 
     def process(trace)
-      t { fmt "processing trace; spans=%d", trace.spans.length }
+      t { fmt "processing trace; spans=%d; duration=%d",
+            trace.spans.length, trace.spans[-1].duration }
       unless @worker.submit(trace)
         warn "failed to submit trace to worker"
       end

data/lib/skylight/messages/trace.rb

@@ -19,7 +19,7 @@ module Skylight
         attr_accessor :endpoint
         attr_reader   :spans, :config
 
-        def initialize(endpoint = "Unknown", start = Util::Clock.now, config = nil)
+        def initialize(endpoint = "Unknown", start = Util::Clock.micros, config = nil)
           @endpoint = endpoint
           @busted   = false
           @config   = config
@@ -44,12 +44,13 @@ module Skylight
               yield
             ensure
               unless @busted
-                now = Util::Clock.now
+                now = Util::Clock.micros
 
                 GC.update
                 gc_time = GC.time
 
                 if gc_time > 0
+                  t { fmt "tracking GC time; duration=%d", gc_time }
                   start(now - gc_time, 'noise.gc')
                   stop(now)
                 end
@@ -170,9 +171,9 @@ module Skylight
 
         def relativize(time)
           if parent = @parents[-1]
-            (10_000 * (time - parent.absolute_time)).to_i
+            ((time - parent.absolute_time) / 100).to_i
           else
-            (10_000 * (time - @start)).to_i
+            ((time - @start) / 100).to_i
           end
         end
 

data/lib/skylight/subscriber.rb

@@ -54,7 +54,7 @@ module Skylight
     end
 
     def now
-      Util::Clock.default.now
+      Util::Clock.micros
     end
 
   end

data/lib/skylight/util/clock.rb

@@ -2,13 +2,21 @@ module Skylight
   module Util
     class Clock
 
-      def now
+      def micros
         n = Time.now
-        n.to_i + n.usec.to_f / 1_000_000
+        n.to_i * 1_000_000 + n.usec
       end
 
-      def self.now
-        default.now
+      def secs
+        micros / 1_000_000
+      end
+
+      def self.micros
+        default.micros
+      end
+
+      def self.secs
+        default.secs
       end
 
       def self.default

data/lib/skylight/version.rb

@@ -1,4 +1,4 @@
 module Skylight
-  VERSION = '0.1.3'
+  VERSION = '0.1.4.alpha1'
 end
 

data/lib/skylight/vm/gc.rb

@@ -31,7 +31,7 @@ module Skylight
 
       class GC
         def initialize
-          @total = 0.0
+          @total = 0
         end
 
         def enable
@@ -39,7 +39,8 @@ module Skylight
         end
 
         def total_time
-          run = ::GC::Profiler.total_time
+          # Reported in seconds
+          run = (::GC::Profiler.total_time * 1_000_000).to_i
 
           if run > 0
             ::GC::Profiler.clear
@@ -59,7 +60,7 @@ module Skylight
         end
 
         def total_time
-          0.0
+          0
         end
       end
 

data/lib/skylight/worker/collector.rb

@@ -22,7 +22,7 @@ module Skylight
         t { fmt "starting collector; interval=%d; size=%d", @interval, @size }
       end
 
-      def handle(msg, now = Util::Clock.now)
+      def handle(msg, now = Util::Clock.secs)
         @batch ||= new_batch(now)
 
         if @batch.should_flush?(now)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skylight
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4.alpha1
 platform: ruby
 authors:
 - Tilde, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-29 00:00:00.000000000 Z
+date: 2013-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -156,9 +156,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.0.3