skunk 0.5.4 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0fc5fca985be539efe139317e8c6e94221f322a85ff1425ecb6111ac37a6b08a
-  data.tar.gz: 5286ff3133b6f9d3d9a17d117d275db45049f2e82470730f4abc224ae47adf96
+  metadata.gz: 9ae89820e2645a8356092c358e5f5e2c6e89a61aa6420ba77dc60e79c64fdd8a
+  data.tar.gz: 47762e6f7666c98cfd41c1a104c62c0aa3041acf4ac64db7f6f32040aebb1390
 SHA512:
-  metadata.gz: f4d0ad320ae6ac543bd86dca2beb7deca48a33b3f6ef418492b077460cff45245af9c8f10bb71bb42b5d1962b5e7a6784e2c28fabef83787703b48e2ec296d46
-  data.tar.gz: a469d5f01b8c97e68a8a1ce7e7d906a001d8a21a174afe469795b827aca2dfea06ea7a0179e2da533847969202d35343b6c147a8bd14221ffec8ecfb6e316e5c
+  metadata.gz: d7d8759277c1bc4b150cb31d9e7b5d6a04e63d79ec57ee455f0c6f3011dc96ba6448a62e9108c7169aa6320aebc12c2f706d1f2f3226438d67cc58ae8e320489
+  data.tar.gz: 47bd94df98ac6e5170eb8030f86c88a7d72d28d74621e8296f5372d788d28a0360593302e339392dba4915d7446af1d2091156838e52fa79709bfe69d9b070e7

data/.github/workflows/main.yml

@@ -6,10 +6,16 @@ on: [push, pull_request]
 jobs:
   test-ruby:
     runs-on: ${{ matrix.os }}-latest
+    continue-on-error: ${{ matrix.experimental || false }}
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu]
-        ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
+        ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3", "3.4", "4.0"]
+        include:
+          - os: ubuntu
+            ruby-version: "head"
+            experimental: true
     steps:
       - uses: actions/checkout@v2
       - name: Setup Ruby ${{ matrix.ruby-version }}
@@ -19,6 +25,6 @@ jobs:
           bundler-cache: true
       - name: Build and run tests
         run: |
-          gem install bundler -v 2.4.6
+          gem install bundler -v 2.4.22
           bundle install --jobs 4 --retry 3
           bundle exec rake

data/.gitignore

@@ -12,3 +12,5 @@
 
 .ruby-version
 .tool-versions
+
+Gemfile.lock

data/.reek.yml

@@ -7,6 +7,7 @@ detectors:
   FeatureEnvy:
     exclude:
     - Skunk::Command::StatusReporter#table
+    - Skunk::Generator::HtmlReport#create_directories_and_files
   InstanceVariableAssumption:
     exclude:
     - Skunk::Cli::Options::Argv
@@ -22,9 +23,37 @@ detectors:
     - initialize
     - Skunk::Cli::Application#execute
     - Skunk::Cli::Options::Argv#parse
+    - Skunk::Analysis#test_module?
+    - add_mock_methods_to_module
+  TooManyInstanceVariables:
+    exclude:
+    - Skunk::Generator::Html::FileData
+    - Skunk::Generator::Html::SkunkData
   UtilityFunction:
     exclude:
     - capture_output_streams
     - Skunk::Command::Compare#analyse_modified_files
     - Skunk::Command::Compare#build_details_path
     - Skunk::Command::Shareable#sharing?
+    - Skunk::Command::Shareable#share_enabled?
+    - Skunk::Command::StatusSharer#share_enabled?
+    - Skunk::Command::StatusSharer#share_url_empty?
+    - Skunk::Configuration#supported_format?
+    - Skunk::Configuration#supported_formats
+    - Skunk::Analysis#test_module?
+    - Skunk::ConfigTest#setup
+  ManualDispatch:
+    exclude:
+    - Skunk::Config#self.method_missing
+    - Skunk::Config#self.respond_to_missing?
+  BooleanParameter:
+    exclude:
+    - Skunk::Config#self.respond_to_missing?
+  DuplicateMethodCall:
+    exclude:
+    - Skunk::ConfigTest#test_add_format_ignores_duplicates
+  FeatureEnvy:
+    exclude:
+    - Skunk::Command::StatusReporter#table
+    - Skunk::Generator::HtmlReport#create_directories_and_files
+    - add_mock_methods_to_module

data/.rubocop_todo.yml

@@ -1,51 +1,44 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-05-02 20:16:50 UTC using RuboCop version 1.75.4.
+# on 2025-11-14 17:50:37 UTC using RuboCop version 1.81.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 1
-# Configuration parameters: Severity, Include.
-# Include: **/*.gemspec
+# Configuration parameters: Severity.
 Gemspec/RequiredRubyVersion:
   Exclude:
     - 'skunk.gemspec'
 
 # Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/ClosingHeredocIndentation:
+Lint/IneffectiveAccessModifier:
   Exclude:
-    - 'lib/skunk/commands/status_reporter.rb'
+    - 'lib/skunk/generators/console/simple.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/HeredocIndentation:
-  Exclude:
-    - 'lib/skunk/commands/status_reporter.rb'
-
-# Offense count: 1
+# Offense count: 2
 # Configuration parameters: AllowedParentClasses.
 Lint/MissingSuper:
   Exclude:
     - 'lib/skunk/cli/application.rb'
+    - 'lib/skunk/generators/html/overview.rb'
 
-# Offense count: 1
+# Offense count: 5
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 18
+  Max: 24
 
-# Offense count: 7
+# Offense count: 13
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 # AllowedMethods: refine
 Metrics/BlockLength:
-  Max: 76
+  Max: 208
 
-# Offense count: 2
+# Offense count: 7
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 13
+  Max: 20
 
 # Offense count: 1
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
@@ -55,6 +48,16 @@ Naming/VariableNumber:
   Exclude:
     - 'lib/skunk/commands/status_sharer.rb'
 
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules.
+# SupportedStyles: nested, compact
+# SupportedStylesForClasses: ~, nested, compact
+# SupportedStylesForModules: ~, nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'test/test_helper.rb'
+
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.

data/CHANGELOG.md

@@ -5,10 +5,24 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## main [(unreleased)](https://github.com/fastruby/skunk/compare/v0.5.4...HEAD)
+## main [(unreleased)](https://github.com/fastruby/skunk/compare/v0.6.0...HEAD)
 
 * <INSERT YOUR FEATURE OR BUGFIX HERE>
 
+## v0.6.0 / 2026-10-12 [(commits)](https://github.com/fastruby/skunk/compare/v0.5.4...v0.6.0)
+
+* [BREAKING: `-o/--out` now takes an output directory instead of a file. Reports, and `skunk_report.txt` with the console output, are written there. The HTML report is renamed from `skunk_overview.html` to `skunk_report.html`](https://github.com/fastruby/skunk/pull/131)
+* [FEATURE: Add sortable columns to the Skunk HTML report](https://github.com/fastruby/skunk/pull/142)
+* [ENHANCEMENT: Support SimpleCov 1.0](https://github.com/fastruby/skunk/pull/140)
+* BUGFIX: Pin path_expander < 2.0 for Ruby 2.7 compatibility
+* [FEATURE: Add `--formats` CLI flag to select report formats (json, html, console)](https://github.com/fastruby/skunk/pull/130)
+* [REFACTOR: Move Console Report](https://github.com/fastruby/skunk/pull/128)
+* [BUGFIX: Set the right content type in the share HTTP request](https://github.com/fastruby/skunk/pull/129)
+* [REFACTOR: Centralize Skunk analysis into RubyCritic module](https://github.com/fastruby/skunk/pull/127)
+* [FEATURE: Add Skunk HTML Report](https://github.com/fastruby/skunk/pull/123)
+* [FEATURE: Add Skunk::Config class](https://github.com/fastruby/skunk/pull/123)
+* [FEATURE: Add Ruby 3.4 compatibility](https://github.com/fastruby/skunk/pull/124)
+
 ## v0.5.4 / 2025-05-05 [(commits)](https://github.com/fastruby/skunk/compare/v0.5.3...v0.5.4)
 
 * [FEATURE: Generate JSON report in background](https://github.com/fastruby/skunk/pull/119)

data/CONTRIBUTING.md

@@ -14,6 +14,12 @@ Here's what you need to do:
 - [Make sure the test suite passes on GitHub Actions and make any necessary changes to your branch to bring it to green.](#continuous-integration).
 - Check out the [Help Wanted](#help-wanted) section for suggestions on how to support Skunk.
 
+## Requirements
+For a Linux distro called Pop!_OS, running Ruby 3.0 and up might require installing the following packages:
+```bash
+sudo apt install libyaml-dev
+```
+
 ## Setting up your environment
 To install the dependencies, run:
 
@@ -81,4 +87,4 @@ The SkunkScore of a module should be the average of the SkunkScores of all of it
 
 Feel free to review and submit your suggestions to improve the method [RubyCritic::AnalysedModule#skunk_score](https://github.com/fastruby/skunk/blob/main/lib/skunk/rubycritic/analysed_module.rb#L33).
 
-📘 Read [Escaping The Tar Pit: Introducing Skunk v0.3.2 at RubyConf 2019](https://www.fastruby.io/blog/code-quality/escaping-the-tar-pit-at-rubyconf.html) and [Churn vs. Complexity vs. Code Coverage](https://www.fastruby.io/blog/code-quality/churn-vs-complexity-vs-coverage.html) for more details about the `skunk_score` method.
+📘 Read [Escaping The Tar Pit: Introducing Skunk v0.3.2 at RubyConf 2019](https://www.fastruby.io/blog/code-quality/escaping-the-tar-pit-at-rubyconf.html) and [Churn vs. Complexity vs. Code Coverage](https://www.fastruby.io/blog/code-quality/churn-vs-complexity-vs-coverage.html) for more details about the `skunk_score` method.

data/Gemfile

@@ -7,6 +7,11 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 # Specify your gem's dependencies in skunk.gemspec
 gemspec
 
-gem "reek", "~> 6.1"
-gem "rubocop", "~> 1.48"
-gem "vcr", "~> 6.1.0"
+gem "reek"
+
+# Pinned so the CI matrix lints against one RuboCop instead of each Ruby
+# resolving whatever version it happens to support. Rubies older than 3.1 cannot
+# install it: reek and rubycritic hold parser below 3.3 there, while RuboCop
+# 1.60 and up require it, so those rubies get no RuboCop and the Rakefile drops
+# the lint task for them. They still run the tests and reek.
+gem "rubocop", "~> 1.81.0" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.1")

data/README.md

@@ -14,6 +14,8 @@ Skunk is a RubyCritic extension to calculate a SkunkScore for a file or project.
     * [Help commands](#help-commands)
     * [Generate the SkunkCore for your project](#generate-the-skunkcore-for-your-project)
     * [Comparing Feature Branches](#comparing-feature-branches)
+* [Configuration](#configuration)
+    * [Setting Output Formats](#setting-output-formats)
 * [Sharing your SkunkScore](#sharing-your-skunkscore)
 * [Contributing](#contributing)
 * [Sponsorship](#sponsorship)
@@ -63,7 +65,7 @@ Run `skunk -h` to check out the help options:
 ```
 Usage: skunk [options] [paths]
     -b, --branch BRANCH              Set branch to compare
-    -o, --out FILE                   Output report to file
+    -o, --out PATH                   Output directory for reports
     -v, --version                    Show gem's version
     -h, --help                       Show this message
 ```
@@ -125,7 +127,9 @@ To only run skunk on specific folders, pass a list of directories in the command
 
 ### Generate JSON report in background
 
-When the Skunk command is run, it will generate a JSON report file in the `RubyCritic::Config.root` location.
+When the Skunk command is run, it will generate a JSON report file in the configured output path.
+
+When `--out PATH` is given, Skunk also writes the console report to `skunk_report.txt` in that directory.
 
 ### Comparing feature branches
 
@@ -152,6 +156,53 @@ Score: 340.3
 
 This should give you an idea if you're moving in the direction of maintaining the code quality or not. In this case, the feature branch is decreasing the code quality because it has a higher SkunkScore than the main branch.
 
+## Configuration
+
+### Setting Output Formats
+
+Skunk supports multiple output formats and you can select them via CLI or programmatically.
+
+**Supported formats:**
+- `:json` - JSON report
+- `:html` - HTML report with visual charts and tables
+- `:console` - Console output (default)
+
+#### CLI flag
+
+You can choose one or more formats from the command line:
+
+```
+skunk --formats=json
+skunk -f json,html
+skunk --formats console,json
+```
+
+If omitted, Skunk defaults to `console`.
+
+#### Programmatic configuration
+
+You can also configure formats in code using `Skunk::Config`:
+
+```ruby
+require 'skunk/config'
+
+# Set multiple formats (equivalent to `--formats=json,html`)
+Skunk::Config.formats = [:json, :html]
+
+# Add a format to the existing list
+Skunk::Config.add_format(:html)
+
+# Remove a format
+Skunk::Config.remove_format(:json)
+
+# Check supported formats
+Skunk::Config.supported_formats # => [:json, :html, :console]
+Skunk::Config.supported_format?(:json) # => true
+
+# Reset to defaults
+Skunk::Config.reset
+```
+
 ## Sharing your SkunkScore
 
 If you want to share the results of your Skunk report with the Ruby community, run:

data/Rakefile

@@ -2,7 +2,6 @@
 
 require "bundler/gem_tasks"
 require "rake/testtask"
-require "rubocop/rake_task"
 require "reek/rake/task"
 require "rubycritic/rake_task"
 
@@ -12,12 +11,20 @@ Rake::TestTask.new do |task|
   task.pattern = "test/**/*_test.rb"
 end
 
-RuboCop::RakeTask.new
-
 Reek::Rake::Task.new
 
 RubyCritic::RakeTask.new do |task|
   task.paths = FileList["lib/**/*.rb"]
 end
 
-task default: %i[test reek rubocop]
+lint_tasks = []
+
+begin
+  require "rubocop/rake_task"
+  RuboCop::RakeTask.new
+  lint_tasks << :rubocop
+rescue LoadError
+  # RuboCop is not installed on the rubies the Gemfile skips the pin for.
+end
+
+task default: %i[test reek] + lint_tasks

data/lib/skunk/cli/application.rb

@@ -5,6 +5,7 @@ require "rubycritic/cli/application"
 
 require "skunk"
 require "skunk/rubycritic/analysed_module"
+require "skunk/rubycritic/analysed_modules_collection"
 require "skunk/cli/options"
 require "skunk/command_factory"
 require "skunk/commands/status_sharer"
@@ -24,19 +25,20 @@ module Skunk
       def execute
         warn_coverage_info unless File.exist?(COVERAGE_FILE)
 
+        Skunk::Config.reset
         # :reek:NilCheck
         @parsed_options = @options.parse.to_h
         command = Skunk::CommandFactory.create(@parsed_options)
         reporter = command.execute
 
-        print(reporter.status_message)
+        $stdout.puts(reporter.status_message)
         if command.sharing?
           share_status_message = command.share(reporter)
-          print(share_status_message)
+          $stdout.puts(share_status_message)
         end
 
         reporter.status
-      rescue OptionParser::InvalidOption => e
+      rescue OptionParser::ParseError => e
         warn "Error: #{e}"
         STATUS_ERROR
       end
@@ -47,16 +49,6 @@ module Skunk
         warn "warning: Couldn't find coverage info at #{COVERAGE_FILE}."
         warn "warning: Having no coverage metrics will make your SkunkScore worse."
       end
-
-      # :reek:NilCheck
-      def print(message)
-        filename = @parsed_options[:output_filename]
-        if filename.nil?
-          $stdout.puts(message)
-        else
-          File.open(filename, "a") { |file| file << message }
-        end
-      end
     end
   end
 end

data/lib/skunk/cli/options/argv.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "rubycritic/cli/options/argv"
+require "skunk/config"
 
 module Skunk
   module Cli
@@ -9,21 +10,21 @@ module Skunk
       # Extends RubyCritic::Cli::Options::Argv to parse a subset of the
       # parameters accepted by RubyCritic
       class Argv < RubyCritic::Cli::Options::Argv
-        # :reek:Attribute
-        attr_accessor :output_filename
-
-        def parse # rubocop:disable Metrics/MethodLength
+        def parse
           parser.new do |opts|
             opts.banner = "Usage: skunk [options] [paths]\n"
-
             opts.on("-b", "--branch BRANCH", "Set branch to compare") do |branch|
               self.base_branch = String(branch)
               set_current_branch
               self.mode = :compare_branches
             end
 
-            opts.on("-o", "--out FILE", "Output report to file") do |filename|
-              self.output_filename = filename
+            opts.on("-o", "--out PATH", "Output directory for reports") do |path|
+              self.output_path = path
+            end
+
+            opts.on("-f", "--formats json,html,console", Array, "Output formats: json,html,console") do |list|
+              Skunk::Config.formats = Array(list).map(&:to_sym)
             end
 
             opts.on_tail("-v", "--version", "Show gem's version") do
@@ -36,8 +37,15 @@ module Skunk
           end.parse!(@argv)
         end
 
-        def to_h
-          super.merge(output_filename: output_filename)
+        private
+
+        # Moves only Skunk's reports. RubyCritic::Config.root stays under
+        # RubyCritic's control, and Skunk::Config.root falls back to it
+        def output_path=(path)
+          raise OptionParser::InvalidArgument, "expects a directory" if path.to_s.strip.empty?
+          raise OptionParser::InvalidArgument, "expects a directory, but #{path} is a file" if File.file?(path)
+
+          Skunk::Config.root = path
         end
       end
     end

data/lib/skunk/commands/compare.rb

@@ -5,6 +5,7 @@ require "skunk/rubycritic/analysed_modules_collection"
 require "skunk/commands/output"
 require "skunk/commands/shareable"
 require "skunk/commands/compare_score"
+require "skunk/config"
 
 # nodoc #
 module Skunk
@@ -51,13 +52,22 @@ module Skunk
           ::RubyCritic::Config.feature_branch_score.to_f.round(2)
         ).message
 
-        Skunk::Command::Output.create_directory(::RubyCritic::Config.compare_root_directory)
+        Skunk::Command::Output.create_directory(compare_directory)
         File.open(build_details_path, "w") { |file| file.write(details) }
         puts details
       end
 
       def build_details_path
-        "#{::RubyCritic::Config.compare_root_directory}/build_details.txt"
+        "#{compare_directory}/build_details.txt"
+      end
+
+      # Uses --out (Skunk::Config.root) when given, otherwise RubyCritic's
+      # compare directory
+      # :reek:UtilityFunction
+      def compare_directory
+        return ::RubyCritic::Config.compare_root_directory unless Skunk::Config.root_set?
+
+        File.join(Skunk::Config.root, "compare")
       end
     end
   end

data/lib/skunk/commands/default.rb

@@ -26,8 +26,6 @@ module Skunk
       #
       # @return [Skunk::Command::StatusReporter]
       def execute
-        RubyCritic::Config.formats = [:json]
-
         report(critique)
 
         status_reporter
@@ -41,7 +39,6 @@ module Skunk
         Reporter.generate_report(analysed_modules)
 
         status_reporter.analysed_modules = analysed_modules
-        status_reporter.score = analysed_modules.score
       end
     end
   end

data/lib/skunk/commands/shareable.rb

@@ -18,6 +18,13 @@ module Skunk
       # @return [Boolean] If the environment is set to share to an external
       # service
       def sharing?
+        share_enabled?
+      end
+
+      private
+
+      # @return [Boolean] Check if sharing is enabled via environment variable
+      def share_enabled?
         ENV["SHARE"] == "true"
       end
     end

data/lib/skunk/commands/status_reporter.rb

@@ -1,96 +1,19 @@
 # frozen_string_literal: true
 
-require "erb"
 require "rubycritic/commands/status_reporter"
-require "terminal-table"
 
 module Skunk
   module Command
-    # Knows how to report status for stinky files
+    # Extends RubyCritic::Command::StatusReporter to silence the status message
     class StatusReporter < RubyCritic::Command::StatusReporter
       attr_accessor :analysed_modules
 
-      HEADINGS = %w[file skunk_score churn_times_cost churn cost coverage].freeze
-      HEADINGS_WITHOUT_FILE = HEADINGS - %w[file]
-      HEADINGS_WITHOUT_FILE_WIDTH = HEADINGS_WITHOUT_FILE.size * 17 # padding
-
-      TEMPLATE = ERB.new(<<-TEMPL
-<%= _ttable %>\n
-SkunkScore Total: <%= total_skunk_score %>
-Modules Analysed: <%= analysed_modules_count %>
-SkunkScore Average: <%= skunk_score_average %>
-<% if worst %>Worst SkunkScore: <%= worst.skunk_score %> (<%= worst.pathname %>)<% end %>
-
-Generated with Skunk v<%= Skunk::VERSION %>
-TEMPL
-                        )
-
-      # Returns a status message with a table of all analysed_modules and
-      # a skunk score average
-      def update_status_message
-        opts = table_options.merge(headings: HEADINGS, rows: table)
-
-        _ttable = Terminal::Table.new(opts)
-
-        @status_message = TEMPLATE.result(binding)
-      end
-
-      private
-
-      def analysed_modules_count
-        @analysed_modules_count ||= non_test_modules.count
-      end
-
-      def non_test_modules
-        @non_test_modules ||= analysed_modules.reject do |a_module|
-          module_path = a_module.pathname.dirname.to_s
-          module_path.start_with?("test", "spec") || module_path.end_with?("test", "spec")
-        end
-      end
-
-      def worst
-        @worst ||= sorted_modules.first
+      def initialize(options = {})
+        super(options)
       end
 
-      def sorted_modules
-        @sorted_modules ||= non_test_modules.sort_by(&:skunk_score).reverse!
-      end
-
-      def total_skunk_score
-        @total_skunk_score ||= non_test_modules.sum(&:skunk_score)
-      end
-
-      def total_churn_times_cost
-        non_test_modules.sum(&:churn_times_cost)
-      end
-
-      def skunk_score_average
-        return 0 if analysed_modules_count.zero?
-
-        (total_skunk_score.to_d / analysed_modules_count).to_f.round(2)
-      end
-
-      def table_options
-        max = sorted_modules.max_by { |a_mod| a_mod.pathname.to_s.length }
-        width = max.pathname.to_s.length + HEADINGS_WITHOUT_FILE_WIDTH
-        {
-          style: {
-            width: width
-          }
-        }
-      end
-
-      def table
-        sorted_modules.map do |a_mod|
-          [
-            a_mod.pathname,
-            a_mod.skunk_score,
-            a_mod.churn_times_cost,
-            a_mod.churn,
-            a_mod.cost.round(2),
-            a_mod.coverage.round(2)
-          ]
-        end
+      def update_status_message
+        @status_message = ""
       end
     end
   end