skrill_payments 0.0.4 → 0.0.5

data/README.md

@@ -28,18 +28,18 @@ With following content.
 
 ## Usage
 
-  ### SEND MONEY USING AN HTTPS REQUEST
+### SEND MONEY USING AN HTTPS REQUEST
 
-  Put this code into your Payment class.
+Put this code into your Payment class.
 
     include SkrillPayment
 
-  Your payment class must contain all attributes/methods which is required for transfer money.
+Your payment class must contain all attributes/methods which is required for transfer money.
 
     [:amount, :currency, :recipient_email, :subject, :note, :reference_id]
     # :reference_id is optional attribute
 
-  For example:
+For example:
 
     class Payment
 
@@ -76,7 +76,21 @@ With following content.
     def pay_for_service
       payment = Payment.find(params[:id])
       begin
-        SkrillPayments.pay!(payment)
+        payment.pay!
+      rescue SkrillPaymentsException => e
+        # do stuff
+      end
+      redirect_to payments_path
+    end
+
+### SEND MONEY FROM DIFFERENT SKRILL ACCOUNT
+
+If you want to send money from different Skrill account (different email and password than from the config). Just add following params in pay! method.
+  
+    def pay_for_service
+      payment = Payment.find(params[:id])
+      begin
+        payment.pay!(email: 'account_2@macejko.sk', password: 'sadnuasndasdasd')
       rescue SkrillPaymentsException => e
         # do stuff
       end

data/lib/skrill_payments.rb

@@ -1,13 +1,5 @@
 module SkrillPayments
 
-  def self.pay!(payment)
-    prepare_transfer = PrepareTransfer.new(payment).call
-
-    payment.sid = prepare_transfer['sid'][0]
-
-    !!ExecuteTransfer.new(payment).call
-  end
-
   class << self
     attr_writer :configuration
   end

data/lib/skrill_payments/api.rb

@@ -1,8 +1,8 @@
-module Api
+class Api
 
   BASE_URL = 'https://www.moneybookers.com/app/pay.pl'
 
-  attr_reader :payment
+  attr_reader :payment, :account
 
   def call
     response  = connection.get '', params.merge(default_params)
@@ -27,8 +27,8 @@ module Api
 
   def default_params
     {
-      email:    SkrillPayments.configuration.email,
-      password: SkrillPayments.configuration.password
+      email:    account[:email]    || SkrillPayments.configuration.email,
+      password: account[:password] || SkrillPayments.configuration.password
     }
   end
 

data/lib/skrill_payments/execute_transfer.rb

@@ -1,11 +1,10 @@
-class ExecuteTransfer
-
-  include Api
+class ExecuteTransfer < Api
 
   ATTRIBUTES = [:sid]
 
-  def initialize(payment)
+  def initialize(payment, account = {})
     @payment = payment
+    @account = account
   end
 
   def params

data/lib/skrill_payments/prepare_transfer.rb

@@ -1,11 +1,10 @@
-class PrepareTransfer
-
-  include Api
+class PrepareTransfer < Api
 
   ATTRIBUTES = [:amount, :currency, :bnf_email, :subject, :note, :frn_trn_id]
 
-  def initialize(payment)
+  def initialize(payment, account = {})
     @payment = payment
+    @account = account
   end
 
   def params

data/lib/skrill_payments/skrill_payment.rb

@@ -10,4 +10,12 @@ module SkrillPayment
     reference_id
   end
 
+  def pay!(account = {})
+    prepare_transfer = PrepareTransfer.new(self, account).call
+
+    self.sid = prepare_transfer['sid'][0]
+
+    !!ExecuteTransfer.new(self, account).call
+  end
+
 end

data/lib/skrill_payments/version.rb

@@ -1,3 +1,3 @@
 module SkrillPayments
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/models/api_spec.rb

@@ -1,7 +1,12 @@
 require 'spec_helper'
 
-class Dummie
-  include Api
+class Dummie < Api;
+
+  def initialize(payment, account = {})
+    @payment = payment
+    @account = account
+  end
+
 end
 
 describe Api do
@@ -10,14 +15,15 @@ describe Api do
 
     object      = double('Payment', currency: 'CZK', amount: 10, user_id: 20)
     attributes  = [:currency, :amount]
-    params      = Dummie.new.send(:params, object, attributes)
+    dummie      = Dummie.new(Payment.new)
+    params      = dummie.send(:params, object, attributes)
 
     expect(params).to eq({ currency: 'CZK', amount: 10 })
   end
 
   it 'creates default params from config' do
 
-    params = Dummie.new.send(:default_params)
+    params = Dummie.new(Payment.new).send(:default_params)
 
     expect(params).to eq(
       {
@@ -26,4 +32,17 @@ describe Api do
       }
     )
   end
+
+  it 'creates default params from account parameter' do
+
+    account = { email: 'michal@macejko.sk', password: 'stefan' }
+    params  = Dummie.new(Payment.new, account).send(:default_params)
+
+    expect(params).to eq(
+      {
+        email:    'michal@macejko.sk',
+        password: 'stefan'
+      }
+    )
+  end
 end

data/spec/models/skrill_payments_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe SkrillPayments do
+describe SkrillPayment do
 
   before do
     @payment = Payment.new
@@ -17,7 +17,7 @@ describe SkrillPayments do
     '<response><error><error_msg>M_AMOUNT</error_msg></error></response>'
   end
 
-  describe '.pay!' do
+  describe '#pay!' do
 
     it 'raise error -> Prepare transfer error' do
 
@@ -25,7 +25,7 @@ describe SkrillPayments do
         with(headers: { 'Accept'=>'*/*' }).
         to_return(status: 200, body: @prepare_error_response, headers: {})
 
-      expect{ SkrillPayments.pay!(@payment) }.to raise_error(SkrillPaymentsException)
+      expect{ @payment.pay! }.to raise_error(SkrillPaymentsException)
     end
 
     it 'raise error -> Execute transfer error' do
@@ -38,7 +38,7 @@ describe SkrillPayments do
         with(headers: { 'Accept'=>'*/*' }).
         to_return(status: 200, body: @execute_error_response, headers: {})
 
-      expect{ SkrillPayments.pay!(@payment) }.to raise_error(SkrillPaymentsException)
+      expect{ @payment.pay! }.to raise_error(SkrillPaymentsException)
     end
 
     context 'success responses' do
@@ -55,12 +55,12 @@ describe SkrillPayments do
       end
 
       it 'returns true' do
-        expect(SkrillPayments.pay!(@payment)).to eq true
+        expect(@payment.pay!).to eq true
       end
 
       it 'set attribute sid for payment' do
 
-        SkrillPayments.pay!(@payment)
+        @payment.pay!
 
         expect(@payment.sid).to_not eq nil
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: skrill_payments
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors: