skeptic 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8c8d44e3011bf063dbd07ae0e073e78516f7d0fa
-  data.tar.gz: 6a8bf2b2a6fdbfad9e0ec6171c85d51d7a63c81e
+  metadata.gz: b6e1fc6b21c5b3fa8b5ba3c556552cdcce8086ba
+  data.tar.gz: 31ce95b2d523a1043f8048b50f196a3e8beab10b
 SHA512:
-  metadata.gz: 89d4f4062d23107211f796f5170d46c4d0a3c5b02ee1a0537c50dd3e8eeb78f3a1c40d3856c6eefa4f5033907a52256ab98814777c552c0d9eee41ef70cce702
-  data.tar.gz: af0e4aed0d92d169417d603f8f152811b5656b56b1fab714cafdec12ba60048469feb6137361f1aada03b0bfdace17533d9d4aba7e1c2bb9e23178abea41b8b2
+  metadata.gz: 8eb3496b7e1e23ec3e8f7ec89a7b84e5de5bdf95f0f33a5f5eb1a24608e716381c9bf7b0343e5eb2265af64a021f2f98e07ed535f9418e273de34747e4228b29
+  data.tar.gz: acc962c666098071ead2296fa73f415b4fc62e6d9fd8a8f06544e2a9794a3f542ba5a698dabfaf50f93b54ba958891c22c9d47b4332d224549e2babc52b16ecd

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.0.12 (2015-10-14)
+Bugfixes:
+  - Fix range operators handling and stop detecting splat operators in beginning of collection literals
+
 ## 0.0.11 (2014-10-27)
 Bugfixes:
   - Fix issue with using mixed parameter types ([s2gatev](https://github.com/s2gatev))

data/README.markdown

@@ -34,8 +34,14 @@ Skeptic checks if the code complies to a number of rules and reports the violati
 * **Line length** - line length does not exceed a certain number.
 * **Lines per method** - methods are at most N lines long. Ignores empty lines and lines with `end`
 * **Max nesting depth** - at most N levels of nesting. Blocks, conditions and loops are considered a level of nesting.
+* **Methods per class** - the number of methods per class does not exceed a certain number
 * **No semicolons** - stops you from using semicolons as expression delimiters.
 * **No trailing whitespace** - points out if your lines end on whitespace.
+* **Naming conventions** - checks if the names of variables/methods/classes follow the conventions
+* **No global variables** - does not allow the use of global variables
+* **Max method arity** - limits the arguments count per method
+* **Spaces around operators** - checks for spaces around operators
+* **English words for names** - detection of non-English words in names
 
 ## Copyright
 

data/VERSION

@@ -1 +1 @@
-0.0.11
+0.0.12

data/lib/skeptic/rules/spaces_around_operators.rb

@@ -7,6 +7,8 @@ module Skeptic
 
       OPERATORS_WITHOUT_SPACES_AROUND_THEM = ['**', '::', '...', '..']
       IGNORED_TOKEN_TYPES = [:on_sp, :on_ignored_nl, :on_nl, :on_lparen, :on_symbeg, :on_lbracket, :on_lbrace]
+      LEFT_LIMIT_TOKEN_TYPES = [:on_lparen, :on_lbracket]
+      RIGHT_LIMIT_TOKEN_TYPES = [:on_rparen, :on_rbracket]
 
       def initialize(data)
         @violations = []
@@ -19,8 +21,7 @@ module Skeptic
         @violations = tokens.each_cons(3).select do |_, token, _|
           operator_expecting_spaces? token
         end.select do |left, operator, right|
-          no_spaces_on_left_of?(operator, left) or
-          no_spaces_on_right_of?(operator, right)
+          no_spaces_around? operator, left, right
         end.map do |_, operator, _|
           [operator.last, operator.first[0]]
         end
@@ -44,20 +45,38 @@ module Skeptic
           not OPERATORS_WITHOUT_SPACES_AROUND_THEM.include? token.last
       end
 
+      def no_spaces_around?(operator, left, right)
+        if LEFT_LIMIT_TOKEN_TYPES.include?(left[1])
+          mark_special_tokens right.first
+        end
+        if range_operator?(left)
+          mark_special_tokens left.last
+        end
+        no_spaces_on_left_of?(operator, left) or
+        no_spaces_on_right_of?(operator, right)
+      end
+
       def no_spaces_on_left_of?(operator, neighbour)
-        neighbour.first[0] == operator.first[0] and neighbour[1] != :on_lparen and
-        !special_token? neighbour
+        neighbour.first[0] == operator.first[0] and
+        !LEFT_LIMIT_TOKEN_TYPES.include?(neighbour[1]) and
+        !range_operator?(neighbour) and
+        !special_token?(neighbour)
       end
 
       def no_spaces_on_right_of?(operator, neighbour)
-        neighbour.first[0] == operator.first[0] and neighbour[1] != :on_rparen and
-        !special_token? neighbour
+        neighbour.first[0] == operator.first[0] and
+        !RIGHT_LIMIT_TOKEN_TYPES.include?(neighbour[1]) and
+        !special_token?(neighbour)
       end
 
       def whitespace_token?(token)
         token[1] == :on_sp or token[1] == :on_ignored_nl
       end
 
+      def range_operator?(operator)
+        operator.last[0..1] == '..'
+      end
+
       def mark_special_tokens(*token_locations)
         @special_tokens_locations.concat(token_locations)
       end

data/lib/skeptic/sexp_visitor.rb

@@ -77,19 +77,18 @@ module Skeptic
 
       def extract_param_idents(tree)
         type, first, second = *tree
+        
         case type
           when :params, :mlhs_add_star
-            tree[1..-1].compact.map { |node| extract_param_idents node }.reduce [], :+
+            tree[1..-1].select { |e| e }.map { |node| extract_param_idents node }.reduce [], :+
           when :mlhs_paren, :blockarg, :rest_param
             extract_param_idents first
           when :@ident, :@label
             [tree]
           when Symbol
             []
-          when nil, false
-            []
           else
-            tree.compact.map { |node| extract_param_idents node }.reduce [], :+
+            tree.select { |e| e }.map { |node| extract_param_idents node }.reduce [], :+
         end
       end
     end

data/skeptic.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: skeptic 0.0.11 ruby lib
+# stub: skeptic 0.0.12 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "skeptic"
-  s.version = "0.0.11"
+  s.version = "0.0.12"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Stefan Kanev"]
-  s.date = "2014-10-27"
+  s.date = "2015-10-13"
   s.description = "An experimental, half-assed, bug-ridden and highly opinionated code analyzer."
   s.email = "stefan.kanev@gmail.com"
   s.executables = ["skeptic"]
@@ -30,7 +30,6 @@ Gem::Specification.new do |s|
     "Rakefile",
     "VERSION",
     "bin/skeptic",
-    "e.rb",
     "features/skeptic.feature",
     "lib/skeptic.rb",
     "lib/skeptic/critic.rb",
@@ -51,12 +50,11 @@ Gem::Specification.new do |s|
     "lib/skeptic/rules/spaces_around_operators.rb",
     "lib/skeptic/scope.rb",
     "lib/skeptic/sexp_visitor.rb",
-    "skeptic-0.0.9.gem",
     "skeptic.gemspec"
   ]
   s.homepage = "http://github.com/skanev/skeptic"
   s.licenses = ["MIT"]
-  s.rubygems_version = "2.2.2"
+  s.rubygems_version = "2.4.8"
   s.summary = "Skeptic points out annoying things in your code"
 
   if s.respond_to? :specification_version then

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skeptic
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Stefan Kanev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-27 00:00:00.000000000 Z
+date: 2015-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trollop
@@ -141,7 +141,6 @@ files:
 - Rakefile
 - VERSION
 - bin/skeptic
-- e.rb
 - features/skeptic.feature
 - lib/skeptic.rb
 - lib/skeptic/critic.rb
@@ -162,7 +161,6 @@ files:
 - lib/skeptic/rules/spaces_around_operators.rb
 - lib/skeptic/scope.rb
 - lib/skeptic/sexp_visitor.rb
-- skeptic-0.0.9.gem
 - skeptic.gemspec
 homepage: http://github.com/skanev/skeptic
 licenses:
@@ -184,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Skeptic points out annoying things in your code

data/e.rb

@@ -1,10 +0,0 @@
-def e
-  w(&b.d.f.e)
-end
-
-class Proc
-  def ssdfe
-  	2
-  end
-end
-