sitehub 0.4.3 → 0.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7a6e0a6953fd3b5d361c2e65e2b0b015a22a36b8
-  data.tar.gz: 76336ecd1253d8cf8e593e6bc67a1912b9fde469
+  metadata.gz: fb7cd90f333ade307a9dd901fb5922709263f78a
+  data.tar.gz: f843541b0caa8a76238aa299158c84a12616bfd8
 SHA512:
-  metadata.gz: ecd3cd69815ab6d8755e222e0fbd17ee4b92f09472f67272da3b5f407be8b4a9954009d6b5563e7320ffda0db6b7b5aa8dce8e71e4d39e72f108fa5c522687d0
-  data.tar.gz: e17c0f2deb78badac60445ac189103bb193687ed073202edcf1e12282aaff4e22e77c7bc74596133f3b8d069796bcefda52a01b0d1b19368c8ce966ec9095b07
+  metadata.gz: 0f0ea72647bbab0b92f166ade2d2f48eb6621c335bcc0c8ac711017dbb24540e40ced8327e7e67204f5a40439e318b840a27d76bdc30cb5eb73eb1b3a381be33
+  data.tar.gz: cafdd5cae62c9a8036adc64a7ab567ede50ef287f25983039374dd7bca7b9db3da7cffbd2d4d3fb8d9e8e0575d7962d462b2534f054d583823da361136777317

data/.codeclimate.yml

@@ -0,0 +1,31 @@
+---
+engines:
+  bundler-audit:
+    enabled: true
+  duplication:
+    enabled: true
+    config:
+      languages:
+      - ruby
+      - javascript
+      - python
+      - php
+  fixme:
+    enabled: true
+  rubocop:
+    enabled: true
+  reek:
+    enabled: true
+ratings:
+  paths:
+  - Gemfile.lock
+  - "**.inc"
+  - "**.js"
+  - "**.jsx"
+  - "**.module"
+  - "**.php"
+  - "**.py"
+  - "**.rb"
+  - "**.rake"
+exclude_paths:
+- spec/

data/.gitignore

@@ -3,4 +3,5 @@
 test.rb
 coverage
 .ruby-gemset
-.ruby-version
+.ruby-version
+pkg

data/.reek

@@ -0,0 +1,41 @@
+---
+IrresponsibleModule:
+  enabled: false
+
+UtilityFunction:
+  exclude:
+  - NilProxy
+  - collect_middleware
+  - env_for
+  - "Rack::Response#cookie_data"
+  - 'SiteHub::CookieRewriting'
+  - format_as_rack_header_name
+
+TooManyStatements:
+  enabled: true
+  exclude:
+  - "Builder#add_default_middleware"
+  - "ForwardProxy#initialize"
+  - "SiteHub::ForwardProxyBuilder#initialize"
+
+FeatureEnvy:
+  exclude:
+  - "SiteHub::DownstreamClient#call"
+  - "SiteHub::LocationRewriters"
+  - 'Rack::Response#cookies'
+  - 'format_http_to_rack_headers'
+
+TooManyMethods:
+  exclude:
+  - "SiteHub::Request"
+LongParameterList:
+  exclude:
+  - env_for
+  - "SiteHub::ForwardProxy#initialize"
+
+TooManyInstanceVariables:
+  exclude:
+  - ForwardProxyBuilder
+  - "SiteHub::Request"
+  - "SiteHub::ForwardProxy"
+

data/.simplecov

@@ -0,0 +1,7 @@
+require "codeclimate-test-reporter"
+
+SimpleCov.formatters  = [SimpleCov::Formatter::HTMLFormatter,CodeClimate::TestReporter::Formatter]
+
+SimpleCov.start do
+  add_filter '/spec/'
+end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sitehub (0.4.3)
+    sitehub (0.4.6)
       em-http-request
       em-synchrony
       faraday
@@ -14,44 +14,58 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.3.8)
-    ast (2.2.0)
+    addressable (2.4.0)
+    ast (2.3.0)
+    axiom-types (0.1.1)
+      descendants_tracker (~> 0.0.4)
+      ice_nine (~> 0.11.0)
+      thread_safe (~> 0.3, >= 0.3.1)
     builder (3.2.2)
-    cookiejar (0.3.0)
+    codeclimate-engine-rb (0.3.1)
+      virtus (~> 1.0)
+    codeclimate-test-reporter (0.5.2)
+      simplecov (>= 0.7.1, < 1.0.0)
+    coercible (1.0.0)
+      descendants_tracker (~> 0.0.1)
+    cookiejar (0.3.3)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     daemons (1.2.3)
+    descendants_tracker (0.0.4)
+      thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.2.5)
     docile (1.1.5)
-    em-http-request (1.1.3)
+    em-http-request (1.1.4)
       addressable (>= 2.3.4)
-      cookiejar (<= 0.3.0)
+      cookiejar (!= 0.3.1)
       em-socksify (>= 0.3)
       eventmachine (>= 1.0.3)
       http_parser.rb (>= 0.6.0)
     em-socksify (0.3.1)
       eventmachine (>= 1.0.0.beta.4)
-    em-synchrony (1.0.4)
+    em-synchrony (1.0.5)
       eventmachine (>= 1.0.0.beta.1)
-    eventmachine (1.0.8)
+    equalizer (0.0.11)
+    eventmachine (1.2.0.1)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
-    geminabox (0.12.4)
+    geminabox (0.13.1)
       builder
       faraday
       httpclient (>= 2.2.7)
       nesty
       sinatra (>= 1.2.7)
-    hashdiff (0.2.3)
+    hashdiff (0.3.0)
     http_parser.rb (0.6.0)
-    httpclient (2.7.1)
+    httpclient (2.8.0)
+    ice_nine (0.11.2)
     json (1.8.3)
     macaddr (1.7.1)
       systemu (~> 2.6.2)
     memory_profiler (0.9.6)
     multipart-post (2.0.0)
     nesty (1.0.2)
-    parser (2.3.1.0)
+    parser (2.3.1.2)
       ast (~> 2.2)
     powerpack (0.1.1)
     rack (1.6.4)
@@ -62,20 +76,24 @@ GEM
     rack-test (0.6.3)
       rack (>= 1.0)
     rainbow (2.1.0)
-    rake (10.4.2)
-    rspec (3.2.0)
-      rspec-core (~> 3.2.0)
-      rspec-expectations (~> 3.2.0)
-      rspec-mocks (~> 3.2.0)
-    rspec-core (3.2.3)
-      rspec-support (~> 3.2.0)
-    rspec-expectations (3.2.1)
+    rake (11.2.2)
+    reek (4.0.5)
+      codeclimate-engine-rb (~> 0.3.1)
+      parser (~> 2.3.1, >= 2.3.1.2)
+      rainbow (~> 2.0)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.4)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.2.0)
-    rspec-mocks (3.2.1)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.2.0)
-    rspec-support (3.2.2)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
     rubocop (0.40.0)
       parser (>= 2.3.1.0, < 3.0)
       powerpack (~> 0.1)
@@ -85,26 +103,33 @@ GEM
     ruby-prof (0.15.9)
     ruby-progressbar (1.8.1)
     safe_yaml (1.0.4)
-    simplecov (0.11.1)
+    simplecov (0.11.2)
       docile (~> 1.1.0)
       json (~> 1.8)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.0)
-    sinatra (1.4.6)
-      rack (~> 1.4)
+    sinatra (1.4.7)
+      rack (~> 1.5)
       rack-protection (~> 1.4)
       tilt (>= 1.3, < 3)
     systemu (2.6.5)
-    thin (1.6.4)
+    thin (1.7.0)
       daemons (~> 1.0, >= 1.0.9)
       eventmachine (~> 1.0, >= 1.0.4)
-      rack (~> 1.0)
-    tilt (2.0.2)
+      rack (>= 1, < 3)
+    thread_safe (0.3.5)
+    tilt (2.0.5)
+    timecop (0.8.1)
     unicode-display_width (1.0.5)
     uuid (2.3.8)
       macaddr (~> 1.0)
-    webmock (1.22.5)
-      addressable (< 2.4.0)
+    virtus (1.0.5)
+      axiom-types (~> 0.1)
+      coercible (~> 1.0)
+      descendants_tracker (~> 0.0, >= 0.0.3)
+      equalizer (~> 0.0, >= 0.0.9)
+    webmock (2.1.0)
+      addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff
 
@@ -113,15 +138,18 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (~> 1.5)
+  codeclimate-test-reporter
   geminabox
   memory_profiler
   rack-test
   rake
-  rspec (~> 3.2.0)
+  reek
+  rspec (~> 3.4.0)
   rubocop
   ruby-prof
   simplecov
   sitehub!
+  timecop
   webmock
 
 BUNDLED WITH

data/README.md

@@ -1,4 +1,8 @@
 # SiteHub
+[![CircleCI](https://circleci.com/gh/lvl-up/sitehub.svg?style=shield&circle-token=da10bde2f25581f01839fb7078fc2a098a98ca13)](https://circleci.com/gh/lvl-up/sitehub)
+[![Code Climate](https://codeclimate.com/github/lvl-up/sitehub/badges/gpa.svg)](https://codeclimate.com/github/lvl-up/sitehub)
+[![Test Coverage](https://codeclimate.com/github/lvl-up/sitehub/badges/coverage.svg)](https://codeclimate.com/github/lvl-up/sitehub/coverage)
+
 SiteHub is a HTTP proxy written in Ruby with support for A|B testing baked in. SiteHub sits in front of your web application(s) routing all HTTP traffics between it and your users. 
 
 Wouldn't it be cool to write something like: 

data/Rakefile

@@ -2,4 +2,4 @@ Dir["#{__dir__}/tasks/*.rake"].each do |tasks|
   import tasks
 end
 
-task default: [:clean, :spec, :coverage_check, 'rubocop:auto_correct', 'rubocop']
+task default: [:clean, :spec, :coverage_check, 'rubocop:auto_correct', 'rubocop', 'reek']

data/circle.yml

@@ -1,6 +1,6 @@
 machine:
   ruby:
-    version: '2.1'
+    version: '2.2'
 test:
   override:
     - bundle exec rake

data/lib/sitehub/builder.rb

@@ -1,20 +1,20 @@
-require 'sitehub/forward_proxies'
-require 'sitehub/transaction_id'
-require 'sitehub/middleware'
+require 'sitehub/getter_setter_methods'
 require 'sitehub/forward_proxy_builder'
-require 'sitehub/reverse_proxy'
-require 'rack/ssl-enforcer'
-require 'sitehub/logging'
-require 'rack/fiber_pool'
+require 'sitehub/middleware'
 require 'logger'
 
 class SiteHub
   class InvalidProxyDefinitionException < Exception
   end
+
   class Builder
     attr_reader :sitehub, :forward_proxies, :reverse_proxies
 
     include Middleware
+    extend GetterSetterMethods
+
+    getter_setters :access_logger, :error_logger
+    getter_setter :sitehub_cookie_name, RECORDED_ROUTES_COOKIE
 
     def force_ssl(except: [])
       @force_ssl = true
@@ -27,23 +27,6 @@ class SiteHub
       instance_eval(&block) if block
     end
 
-    def access_logger(logger = nil)
-      return @access_logger unless logger
-      @access_logger = logger
-    end
-
-    def error_logger(logger = nil)
-      return @error_logger unless logger
-      @error_logger = logger
-    end
-
-    def sitehub_cookie_name(name = nil)
-      @sitehub_cookie_name ||= RECORDED_ROUTES_COOKIE
-
-      return @sitehub_cookie_name unless name
-      @sitehub_cookie_name = name
-    end
-
     def build
       forward_proxies.init
       add_default_middleware
@@ -52,27 +35,27 @@ class SiteHub
     end
 
     def add_default_middleware
-      use ReverseProxy, reverse_proxies
-      use TransactionId
-      use Logging::AccessLogger, access_logger || ::Logger.new(STDOUT)
-      use Logging::ErrorLogger, error_logger || ::Logger.new(STDERR)
+      use Middleware::ReverseProxy, reverse_proxies
+      use Middleware::TransactionId
+      use Middleware::ErrorHandling
+      use Middleware::Logging::AccessLogger, access_logger || ::Logger.new(STDOUT)
+      use Middleware::Logging::ErrorLogger, error_logger || ::Logger.new(STDERR)
       use Rack::FiberPool
       use Rack::SslEnforcer, except: @ssl_exclusions if @force_ssl
     end
 
     def proxy(opts = {}, &block)
-      args = { sitehub_cookie_name: sitehub_cookie_name }
-
       if opts.is_a?(Hash)
-        mapped_path = opts.keys.first
-        url = opts.values.first
-        args[:url] = url
-        args[:mapped_path] = mapped_path
+        mapped_path, url = *opts.to_a.flatten
       else
-        args[:mapped_path] = opts
+        mapped_path = opts
+        url = nil
       end
 
-      forward_proxies << ForwardProxyBuilder.new(args, &block)
+      forward_proxies << ForwardProxyBuilder.new(sitehub_cookie_name: sitehub_cookie_name,
+                                                 url: url,
+                                                 mapped_path: mapped_path,
+                                                 &block)
     end
 
     def reverse_proxy(hash)

data/lib/sitehub/collection/split_route_collection.rb

@@ -8,6 +8,9 @@ class SiteHub
 
       FIXNUM_ERR_MSG = 'splits must be a Fixnum'.freeze
       SPLIT_ERR_MSG = 'total split percentages can not be greater than 100%'.freeze
+      INVALID_SPILTS_MSG = 'splits do not add up to 100% and no default has been specified'.freeze
+      MAX = 100
+      MIN = 0
 
       def initialize(hash = {})
         hash.each do |value, percentage|
@@ -17,37 +20,39 @@ class SiteHub
 
       def add(id, value, percentage)
         raise InvalidSplitException, FIXNUM_ERR_MSG unless percentage.is_a?(Fixnum)
-        lower = values.last ? values.last.upper : 0
-        upper = lower + percentage
+        upper_bound = lower_bound + percentage
 
-        raise InvalidSplitException, SPLIT_ERR_MSG if upper > 100
-        self[id] = Split.new(lower, upper, value)
+        raise InvalidSplitException, SPLIT_ERR_MSG if upper_bound > MAX
+        self[id] = Split.new(lower_bound, upper_bound, value)
       end
 
       def resolve(*args)
-        random = rand(100)
+        random = rand(MAX)
         result = values.find { |split| random >= split.lower && random < split.upper }
         result ? result.value.resolve(*args) : nil
       end
 
-      def transform
-        values.each do |split|
-          split.value = yield(split.value)
-        end
+      def transform(&block)
+        values.each { |split| split.update_value(&block) }
       end
 
       def [](key)
-        result = super(key)
-        result && result.value
+        key?(key) ? super(key).value : nil
       end
 
       def valid?
         last = values.last
-        return true if last && last.upper == 100
+        return true if last && last.upper == MAX
 
-        warn('splits do not add up to 100% and no default has been specified')
+        warn(INVALID_SPILTS_MSG)
         false
       end
+
+      private
+
+      def lower_bound
+        values.empty? ? MIN : values.last.upper
+      end
     end
   end
 end