site_prism 2.3 → 2.4

data/README.md

@@ -29,6 +29,10 @@ class SearchResults < SitePrism::Page
 
   section :menu, MenuSection, "#gbx3"
   sections :search_results, SearchResultSection, "#results li"
+  
+  def search_result_links
+    search_results.map {|sr| sr.title['href']}
+  end
 end
 
 # define sections used on multiple pages or multiple times on one page
@@ -75,7 +79,7 @@ Then /^the search results page contains 10 individual search results$/ do
 end
 
 Then /^the search results contain a link to the wikipedia sausages page$/ do
-  @results_page.search_results.map {|sr| sr.title['href']}.should include "http://en.wikipedia.org/wiki/Sausage"
+  @results_page.search_result_links.should include "http://en.wikipedia.org/wiki/Sausage"
 end
 ```
 
@@ -414,6 +418,26 @@ Then /^the search field exists$/ do
 end
 ```
 
+#### Testing that an element does not exist
+
+To test that an element does not exist on the page, it is not possible to just call
+`#should_not have_search_field`. SitePrism supplies the `#has_no_<element>?` method
+that should be used to test for non-existence. Using the above example:
+
+```ruby
+@home = Home.new
+@home.load
+@home.has_no_search_field? #=> returns true if it doesn't exist, false if it does
+```
+
+...which makes for nice test code:
+
+```ruby
+Then /^the search field exists$/ do
+  @home.should have_no_search_field #NB: NOT => @home.should_not_ have_search_field
+end
+```
+
 #### Waiting for an element to exist on a page
 
 Another method added by calling `element` is the `wait_for_<element_name>` method.
@@ -499,6 +523,7 @@ end
 ```ruby
 @home.search_field
 @home.has_search_field?
+@home.has_no_search_field?
 @home.wait_for_search_field
 @home.wait_for_search_field(10)
 @home.wait_until_search_field_visible
@@ -1269,7 +1294,7 @@ class App
   end
 
   def results_page
-      SearchResults.new
+    SearchResults.new
   end
 
   def maps
@@ -1290,6 +1315,10 @@ When /^I search for Sausages$/ do
   @app.home.search_button.click
 end
 
+Then /^I am on the results page$/ do
+  @app.results_page.should be_displayed
+end
+
 # etc...
 ```
 

data/lib/site_prism/element_container.rb

@@ -38,6 +38,7 @@ module SitePrism::ElementContainer
   def iframe(iframe_name, iframe_page_class, iframe_id)
     add_to_mapped_items iframe_name
     create_existence_checker iframe_name, iframe_id
+    create_nonexistence_checker iframe_name, iframe_id
     create_waiter iframe_name, iframe_id
     define_method iframe_name do |&block|
       within_frame iframe_id.split("#").last do
@@ -69,6 +70,7 @@ module SitePrism::ElementContainer
 
   def add_helper_methods(name, *find_args)
     create_existence_checker name, *find_args
+    create_nonexistence_checker name, *find_args
     create_waiter name, *find_args
     create_visibility_waiter name, *find_args
     create_invisibility_waiter name, *find_args
@@ -93,13 +95,24 @@ module SitePrism::ElementContainer
     end
   end
 
+  def create_nonexistence_checker(element_name, *find_args)
+    method_name = "has_no_#{element_name.to_s}?"
+    create_helper_method method_name, *find_args do
+      define_method method_name do
+        Capybara.using_wait_time 0 do
+          element_does_not_exist? *find_args
+        end
+      end
+    end
+  end
+
   def create_waiter(element_name, *find_args)
     method_name = "wait_for_#{element_name.to_s}"
     create_helper_method method_name, *find_args do
       define_method method_name do |timeout = Capybara.default_wait_time|
-        Capybara.using_wait_time timeout do
-          element_exists? *find_args
-        end
+      Capybara.using_wait_time timeout do
+        element_exists? *find_args
+      end
       end
     end
   end
@@ -108,13 +121,12 @@ module SitePrism::ElementContainer
     method_name = "wait_until_#{element_name.to_s}_visible"
     create_helper_method method_name, *find_args do
       define_method method_name do |timeout = Capybara.default_wait_time|
-        Capybara.using_wait_time timeout do
-          element_exists? *find_args
-        end
-        Timeout.timeout timeout, SitePrism::TimeOutWaitingForElementVisibility do
-          sleep 0.1 until find_first(*find_args).visible?
+      Timeout.timeout timeout, SitePrism::TimeOutWaitingForElementVisibility do
+        Capybara.using_wait_time 0 do
+          sleep 0.05 while not element_exists? *find_args, visible: true
         end
       end
+      end
     end
   end
 
@@ -122,12 +134,12 @@ module SitePrism::ElementContainer
     method_name = "wait_until_#{element_name.to_s}_invisible"
     create_helper_method method_name, *find_args do
       define_method method_name do |timeout = Capybara.default_wait_time|
-        Timeout.timeout timeout, SitePrism::TimeOutWaitingForElementInvisibility do
-          Capybara.using_wait_time 0 do
-            sleep 0.05 while element_exists?(*find_args) && find_first(*find_args).visible?
-          end
+      Timeout.timeout timeout, SitePrism::TimeOutWaitingForElementInvisibility do
+        Capybara.using_wait_time 0 do
+          sleep 0.05 while element_exists? *find_args, visible: true
         end
       end
+      end
     end
   end
 

data/lib/site_prism/page.rb

@@ -44,15 +44,10 @@ module SitePrism
       !current_url.match(/^https/).nil?
     end
 
-    def title
-      title_selector = 'html > head > title'
-      using_wait_time(0) { page.find(title_selector).text if page.has_selector?(title_selector) }
-    end
-
     private
 
     def find_first *find_args
-      first *find_args
+      find *find_args
     end
 
     def find_all *find_args
@@ -62,6 +57,10 @@ module SitePrism
     def element_exists? *find_args
       has_selector? *find_args
     end
+
+    def element_does_not_exist? *find_args
+      has_no_selector? *find_args
+    end
   end
 end
 

data/lib/site_prism/section.rb

@@ -33,7 +33,7 @@ module SitePrism
     private
 
     def find_first *find_args
-      root_element.first *find_args
+      root_element.find *find_args
     end
 
     def find_all *find_args
@@ -45,6 +45,12 @@ module SitePrism
         root_element.has_selector? *find_args
       end
     end
+
+    def element_does_not_exist? *find_args
+      unless root_element.nil?
+        root_element.has_no_selector? *find_args
+      end
+    end
   end
 end
 

data/lib/site_prism/version.rb

@@ -1,4 +1,4 @@
 module SitePrism
-  VERSION = "2.3"
+  VERSION = "2.4"
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: site_prism
 version: !ruby/object:Gem::Version
-  version: '2.3'
+  version: '2.4'
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-05 00:00:00.000000000 Z
+date: 2013-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: '2.1'
     - - <
       - !ruby/object:Gem::Version
         version: '3.0'
@@ -29,7 +29,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: '2.1'
     - - <
       - !ruby/object:Gem::Version
         version: '3.0'
@@ -101,7 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: A Page Object Model DSL for Capybara