site_prism 2.16 → 2.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 91f1632193e711e5407036c5674c839746dc6411bd9d4b851f5872aff13f67dc
-  data.tar.gz: 0847ba2fe40e538940888176910aad356357f6fad87e2d7bff87af20a2b03f67
+  metadata.gz: 6285ddbcaebdf2970ed1d74ff56800c196124e984ea6973ab4d9f083dcff8b10
+  data.tar.gz: cc137169a3dcaf0f3b05eb9fdaae5bdb31970a53ebc8e8c3bf88e65658c56a31
 SHA512:
-  metadata.gz: bc11978a37f85598d22081d96ede596181866c9533357bf42e5fe17530c4082780c9272186e3b579eff61d89d5d1ef6afa6e5a009eba26f655d6eefa70d41ca4
-  data.tar.gz: c609309f64ba914756fffcb9038345741e14c73f07d508fe246a96e5b7697e7e8486011e4d95d7a6dd8145d58113e07fab533ce503b4eee3ec54240f230e9db6
+  metadata.gz: 870e2b8e512b5b5deeeb909598ca20d032ef35b4b153ae4c3f6b832336aaa873ad416fd73005e2f5715739150f67b0e61cb57a724603998aa8343a631020870f
+  data.tar.gz: 0df084b3f02295206ecc82154209cd83c6b1208810fba3cc8b2c8f828333a6b4baf4b87ec919c575503ea72c8cf833a958e9d50b460efb0b2000d560331a2bc8

data/lib/site_prism/element_container.rb

@@ -30,6 +30,7 @@ module SitePrism
     def raise_wait_for_if_failed(obj, name, timeout, failed)
       return unless SitePrism.raise_on_wait_fors && failed
 
+      deprecate('Listening for TimeOutWaitingForExistenceError')
       raise SitePrism::TimeOutWaitingForExistenceError, \
             "Timed out after #{timeout}s waiting for #{obj.class}##{name}"
     end
@@ -37,6 +38,7 @@ module SitePrism
     def raise_wait_for_no_if_failed(obj, name, timeout, failed)
       return unless SitePrism.raise_on_wait_fors && failed
 
+      deprecate('Listening for TimeOutWaitingForNonExistenceError')
       raise SitePrism::TimeOutWaitingForNonExistenceError, \
             "Timed out after #{timeout}s waiting for no #{obj.class}##{name}"
     end
@@ -64,6 +66,11 @@ module SitePrism
       SitePrism.use_implicit_waits || options.key?(:wait)
     end
 
+    def deprecate(previous, new = nil)
+      warn "Usage of #{previous} is now deprecated and should be not used."
+      warn "Use #{new} instead." if new
+    end
+
     # rubocop:disable Metrics/ModuleLength
     module ClassMethods
       attr_reader :mapped_items, :expected_items
@@ -86,12 +93,6 @@ module SitePrism
         end
       end
 
-      def collection(name, *find_args)
-        warn 'Using collection is now deprecated and will be removed.'
-        warn 'Use elements DSL notation instead.'
-        elements(name, *find_args)
-      end
-
       def expected_elements(*elements)
         @expected_items = elements
       end
@@ -199,6 +200,7 @@ module SitePrism
         method_name = "wait_for_#{element_name}"
         create_helper_method(method_name, *find_args) do
           define_method(method_name) do |timeout = wait_time, *runtime_args|
+            deprecate('wait_for methods', 'wait key assignment at runtime')
             visibility_args = { wait: timeout }
             args = merge_args(find_args, runtime_args, visibility_args)
             result = element_exists?(*args)
@@ -212,6 +214,7 @@ module SitePrism
         method_name = "wait_for_no_#{element_name}"
         create_helper_method(method_name, *find_args) do
           define_method(method_name) do |timeout = wait_time, *runtime_args|
+            deprecate('wait_for_no methods', 'wait key assignment at runtime')
             visibility_args = { wait: timeout }
             args = merge_args(find_args, runtime_args, visibility_args)
             result = element_does_not_exist?(*args)

data/lib/site_prism/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SitePrism
-  VERSION = '2.16'.freeze
+  VERSION = '2.17'.freeze
 end

data/lib/site_prism.rb

@@ -12,13 +12,44 @@ module SitePrism
   autoload :AddressableUrlMatcher, 'site_prism/addressable_url_matcher'
 
   class << self
-    attr_accessor :use_implicit_waits,
-                  :raise_on_wait_fors,
-                  :default_load_validations
-
     def configure
       yield self
     end
+
+    def use_implicit_waits
+      show_removed_config_warning_messages
+      @use_implicit_waits
+    end
+
+    def use_implicit_waits=(value)
+      show_removed_config_warning_messages
+      @use_implicit_waits = value
+    end
+
+    def raise_on_wait_fors
+      show_removed_config_warning_messages
+      @raise_on_wait_fors
+    end
+
+    def raise_on_wait_fors=(value)
+      show_removed_config_warning_messages
+      @raise_on_wait_fors = value
+    end
+
+    def default_load_validations
+      show_removed_config_warning_messages
+      @default_load_validations
+    end
+
+    def default_load_validations=(value)
+      show_removed_config_warning_messages
+      @default_load_validations = value
+    end
+
+    def show_removed_config_warning_messages
+      warn 'This config option is being removed in SitePrism v3. See UPGRADING.md on the repo for more details.'
+      warn 'Going forwards the configuration / configurability will more closely mimic Capybara.'
+    end
   end
 
   @default_load_validations = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: site_prism
 version: !ruby/object:Gem::Version
-  version: '2.16'
+  version: '2.17'
 platform: ruby
 authors:
 - Nat Ritmeyer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-22 00:00:00.000000000 Z
+date: 2018-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable