sisow_ideal 0.0.2 → 0.0.3

data/README.md

@@ -35,8 +35,11 @@ response = client.setup_transaction(
 order.update_attributes(:trxid => response.trxid)
 redirect_to response.url
 
-# How to handle report on the report url
+# How to handle report on the notifyurl
 # For safety reasons sisow calls a notify url for updating payment status before redirecting back to the application
+
+# You have 2 options:
+# 1. Do a status request
 order = Order.find_by_trxid(params[:trxid])
 response = client.status_request(
   :trxid  => order.trxid,
@@ -44,6 +47,12 @@ response = client.status_request(
 )
 order.update_attributes(:status => response.status)
 
+# 2. Validate the response
+if client.valid_response?(params)
+  order = Order.find_by_trxid(params[:trxid])
+  order.update_attributes(:status => params[:status])
+end
+
 # When sisow redirects the user back you can check if the payment was succesfull bij finding the order object
 @order = Order.find_by_trxid(params[:trxid])
 ```

data/lib/sisow_ideal/client.rb

@@ -35,7 +35,7 @@ module SisowIdeal
 
       response = Hashie::Mash.new(
         self.class.get('/TransactionRequest',
-        :query  => merge_query(options, sha1),
+        :query  => merge_options(options, sha1),
         :format => :xml
       ).parsed_response)
 
@@ -61,7 +61,7 @@ module SisowIdeal
 
       response = Hashie::Mash.new(
         self.class.get('/StatusRequest',
-        :query  => merge_query(options, sha1),
+        :query  => merge_options(options, sha1),
         :format => :xml
       ).parsed_response)
 
@@ -72,10 +72,22 @@ module SisowIdeal
       end
     end
 
+    def valid_response?(params)
+      sha1 = [
+        params.fetch(:trxid),
+        params.fetch(:ec),
+        params.fetch(:status),
+        @options.fetch(:merchantid),
+        @options.fetch(:merchantkey)
+      ].join
+
+      Digest::SHA1.hexdigest(sha1) == params[:sha1]
+    end
+
     private
 
       # Merge options in query
-      def merge_query(hash, sha1)
+      def merge_options(hash, sha1)
         @options.merge!(hash).merge!(:sha1 => Digest::SHA1.hexdigest(sha1))
       end
 

data/lib/sisow_ideal/version.rb

@@ -1,3 +1,3 @@
 module SisowIdeal
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/client_spec.rb

@@ -71,5 +71,37 @@ describe SisowIdeal::Client do
 
   end
 
+  describe :valid_response? do
+
+    subject { @client.valid_response?(params) }
+
+    context 'invalid' do
+
+      let!(:params) { {
+        :trxid  => '0050001157723256',
+        :ec     => '123',
+        :status => 'Open',
+        :sha1   => 'f334d33574f5b9244f8e434a7e4bc3cee12f6284'
+      } }
+
+      it { subject.should be_false }
+
+    end
+
+    context 'valid' do
+
+      let!(:params) { {
+        :trxid  => '0050001157723256',
+        :ec     => '1',
+        :status => 'Open',
+        :sha1   => 'f334d33574f5b9244f8e434a7e4bc3cee12f6284'
+      } }
+
+      it { subject.should be_true }
+
+    end
+
+  end
+
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sisow_ideal
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-14 00:00:00.000000000 Z
+date: 2012-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler