sisow 0.9.3 → 0.9.4

data/.gitignore

@@ -1,8 +1,7 @@
 *.gem
 .bundle
-Gemfile.lock
 pkg/*
 spec/sisow.yml
 coverage/
 spec/vcr_cassettes
-.rvmrc
+vendor

data/.rvmrc

@@ -0,0 +1 @@
+rvm 1.9.3-p194@sisow

data/Gemfile.lock

@@ -0,0 +1,46 @@
+PATH
+  remote: .
+  specs:
+    sisow (0.9.3)
+      hashie
+      httparty
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    diff-lcs (1.1.3)
+    fakeweb (1.3.0)
+    hashie (1.2.0)
+    httparty (0.8.3)
+      multi_json (~> 1.0)
+      multi_xml
+    multi_json (1.3.5)
+    multi_xml (0.5.1)
+    rake (0.9.2.2)
+    rspec (2.10.0)
+      rspec-core (~> 2.10.0)
+      rspec-expectations (~> 2.10.0)
+      rspec-mocks (~> 2.10.0)
+    rspec-core (2.10.0)
+    rspec-expectations (2.10.0)
+      diff-lcs (~> 1.1.3)
+    rspec-mocks (2.10.1)
+    simplecov (0.6.4)
+      multi_json (~> 1.0)
+      simplecov-html (~> 0.5.3)
+    simplecov-html (0.5.3)
+    simplecov-rcov (0.2.3)
+      simplecov (>= 0.4.1)
+    vcr (2.1.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  fakeweb
+  rake
+  rspec
+  simplecov
+  simplecov-rcov
+  sisow!
+  vcr

data/README.rdoc

@@ -1,7 +1,9 @@
 = Sisow
 {<img src="https://secure.travis-ci.org/marceldegraaf/sisow.png" />}[http://travis-ci.org/marceldegraaf/sisow]
 
-*NOTE* This gem is work in progress. I'm planning to have it ready somewhere in March.
+*WARNING* There is an issue in the <tt>httparty</tt> gem that breaks the <tt>debug_mode</tt> of this Sisow gem. The only work-around at this time is to not enable <tt>debug_mode</tt>. I'll keep an eye on the <tt>httparty</tt> issue and update the Readme if anything changes. Sorry for the inconvenience.
+
+-------
 
 This gem provides an interface to interact with the Sisow payment provider. Sisow offers payments through the iDeal (Dutch),
 Bancontact/Mister Cash (Belgian) and Sofort (German) online payment systems.
@@ -66,7 +68,8 @@ Setting up a payment looks like this:
   }
 
   payment = Sisow::IdealPayment.new(payment_attributes)
-  redirect_url = payment.payment_url
+  redirect_url   = payment.payment_url
+  transaction_id = payment.transaction_id # this value corresponds with Sisow's "trxid"
 
 === Supported payment methods
 

data/lib/sisow/payment.rb

@@ -18,12 +18,13 @@ module Sisow
     end
 
     def payment_url
-      request = Sisow::Api::TransactionRequest.new(self)
-      response = request.perform
-
       CGI::unescape(response.issuerurl) if response.issuerurl?
     end
 
+    def transaction_id
+      response.trxid if response.trxid?
+    end
+
     def shop_id
       Sisow.configuration.shop_id
     end
@@ -36,5 +37,15 @@ module Sisow
 
     def payment_method; raise 'Implement me in a subclass'; end
 
+    private
+
+      def response
+        @raw_response ||= request.perform
+      end
+
+      def request
+        @request ||= Sisow::Api::TransactionRequest.new(self)
+      end
+
   end
 end

data/lib/sisow/version.rb

@@ -1,3 +1,3 @@
 module Sisow
-  VERSION = "0.9.3"
+  VERSION = "0.9.4"
 end

data/script/bundler

@@ -0,0 +1,10 @@
+#!/bin/bash
+set -e
+
+echo "--- Making sure bundler is installed"
+
+gem which bundler &> /dev/null || gem install bundler --no-ri --no-rdoc
+
+echo "--- Installing gems"
+
+bundle check --no-color || time bundle install --no-color

data/script/ci

@@ -0,0 +1,14 @@
+#!/bin/bash
+export RAILS_ENV=test
+
+run() {
+  time bundle exec $*
+}
+
+echo "--- Starting continuous integration build"
+
+./script/bundler
+
+cp ./spec/sisow.yml.example ./spec/sisow.yml
+
+run rspec

data/sisow.gemspec

@@ -26,4 +26,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'vcr'
   s.add_development_dependency 'fakeweb'
   s.add_development_dependency 'simplecov'
+  s.add_development_dependency 'simplecov-rcov'
 end

data/spec/models/ideal_payment_spec.rb

@@ -26,4 +26,10 @@ describe Sisow::IdealPayment do
     end
   end
 
+  it "should contain a transaction ID from Sisow" do
+    VCR.use_cassette("ideal_payment") do
+      @payment.transaction_id.should =~ /TEST\d{12}/
+    end
+  end
+
 end

data/spec/spec_helper.rb

@@ -1,6 +1,14 @@
 require 'bundler/setup'
 require 'simplecov'
-SimpleCov.start
+require 'simplecov-rcov'
+
+SimpleCov.start do
+  add_filter 'vendor'
+end
+
+if ENV['BUILD_NUMBER'] && ENV['BUILD_ID']
+  SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter
+end
 
 require 'vcr_setup'
 

metadata

@@ -1,97 +1,140 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: sisow
-version: !ruby/object:Gem::Version 
+version: !ruby/object:Gem::Version
+  version: 0.9.4
   prerelease: 
-  version: 0.9.3
 platform: ruby
-authors: 
+authors:
 - Marcel de Graaf
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-03-16 00:00:00 +01:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-06-04 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: httparty
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: hashie
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: hashie
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: vcr
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: fakeweb
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: fakeweb
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov-rcov
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id006
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This gem implements the REST API of the Sisow payment provider.
-email: 
+email:
 - mail@marceldegraaf.net
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
+- .rvmrc
 - .travis.yml
 - Gemfile
+- Gemfile.lock
 - README.rdoc
 - Rakefile
 - lib/sisow.rb
@@ -112,6 +155,8 @@ files:
 - lib/sisow/payment/sofort_payment.rb
 - lib/sisow/ping.rb
 - lib/sisow/version.rb
+- script/bundler
+- script/ci
 - sisow.gemspec
 - spec/models/bancontact_payment_spec.rb
 - spec/models/callback_spec.rb
@@ -129,35 +174,31 @@ files:
 - spec/sisow.yml.example
 - spec/spec_helper.rb
 - spec/vcr_setup.rb
-has_rdoc: true
 homepage: http://github.com/marceldegraaf/sisow
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: sisow
-rubygems_version: 1.5.0
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Rails gem for payments through Sisow.
-test_files: 
+test_files:
 - spec/models/bancontact_payment_spec.rb
 - spec/models/callback_spec.rb
 - spec/models/configuration_spec.rb