sis_core 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a88af09f30c54f634169a0051ad20db0e505581463a8b94af3baf6cfc10b9f17
-  data.tar.gz: ebe53808d2a44ab226f2bc4f8d9e087e9504586eac604286bbe1c16b9d35dad0
+  metadata.gz: 743af7d896e433bed5589a15d4d71d33e439591e95c4eb498acb8311daa19c4d
+  data.tar.gz: d6d5bec16bb9bcdc8dbfd97f6b53ede9d7cb01018709406b34721e0cd42b3cb6
 SHA512:
-  metadata.gz: a422801f3afecd6e9e7ca9f2b7c5aeb03caebdf0dcbdffe10e446b9aa4f7f87cbfc8f882a40879d21533fd3a049e04a91885d263c4b67c6656d7b25f411094c9
-  data.tar.gz: 27c8b0c2091c608f81193b01af3973769e9281c161a2f6283b568fb6bca725bbe38543d6c00e814fc155774285d752e46e021524bc40e040dcb617e3abd2feee
+  metadata.gz: 024c7d8e0adc5404a3b17a695f16aeeed1055f1a9fcba94d61d1ce1959282fae2610513c8c62752d8cd31534f6335add61d8f21516afdba69cfabec352656564
+  data.tar.gz: 51114f1222ac1c838424d215bc02aa9954a591dbd8a3e2c2204b2f8eea20bffcb2792ebb60ee76f92f79d9a8a02a7d74c386057defdb46aa14593dff1766da85

data/app/models/sis/core/academic_programme.rb

@@ -1,7 +1,9 @@
-module Sis::Core
-  class AcademicProgramme < ApplicationRecord
-    belongs_to :programme
-    belongs_to :programme_type
-    belongs_to :programme_level
+module Sis
+  module Core
+    class AcademicProgramme < ApplicationRecord
+      belongs_to :programme
+      belongs_to :programme_type
+      belongs_to :programme_level
+    end
   end
 end

data/app/models/sis/core/application.rb

@@ -16,7 +16,7 @@ module Sis
         end
 
         event :review do
-          transitions from: [:submitted, :rejected, :accepted], to: :under_review
+          transitions from: %i[submitted rejected accepted], to: :under_review
         end
 
         event :accept do
@@ -34,7 +34,6 @@ module Sis
         event :select_for_admission do
           transitions from: :selected_for_exam, to: :selected_for_admission
         end
-
       end
 
       validates :full_name, :email, :age, :gender, :nationality, :status, presence: true

data/app/models/sis/core/application_setup.rb

@@ -1,14 +1,15 @@
-module Sis::Core
-  class ApplicationSetup < ApplicationRecord
-    OPEN = 'Open'.freeze
-    CLOSED = 'Closed'.freeze
+module Sis
+  module Core
+    class ApplicationSetup < ApplicationRecord
+      OPEN = 'Open'.freeze
+      CLOSED = 'Closed'.freeze
 
-    belongs_to :academic_programme
-    belongs_to :target_semester, class_name: 'Sis::Core::Semester'
-    has_many :document_requirements
-
-    validates :start_date, :end_date, :status, presence: true
-    validates :status, inclusion: [OPEN, CLOSED]
+      belongs_to :academic_programme
+      belongs_to :target_semester, class_name: 'Sis::Core::Semester'
+      has_many :document_requirements
 
+      validates :start_date, :end_date, :status, presence: true
+      validates :status, inclusion: [OPEN, CLOSED]
+    end
   end
 end

data/app/models/sis/core/document_requirement.rb

@@ -7,4 +7,4 @@ module Sis
       validates :original, :copy, presence: true
     end
   end
-end
+end

data/app/models/sis/core/exam.rb

@@ -8,7 +8,7 @@ module Sis
       before_validation :set_pass_point
 
       def set_pass_point
-        self.pass_point = self.points / 2 unless self.pass_point || !self.points
+        self.pass_point = points / 2 unless pass_point || !points
       end
     end
   end

data/app/models/sis/core/exam_result.rb

@@ -12,7 +12,11 @@ module Sis
       before_validation :set_status
 
       def set_status
-        self.status = (exam && exam.pass_point >= points) ? PASS : FAIL
+        self.status = if exam && exam.pass_point >= points
+                        PASS
+                      else
+                        FAIL
+                      end
       end
     end
   end

data/app/models/sis/core/exam_setup.rb

@@ -1,7 +1,9 @@
-module Sis::Core
-  class ExamSetup < ApplicationRecord
-    belongs_to :application_setup
+module Sis
+  module Core
+    class ExamSetup < ApplicationRecord
+      belongs_to :application_setup
 
-    validates :date, :hours, :venue, presence: true
+      validates :date, :hours, :venue, presence: true
+    end
   end
 end

data/app/models/sis/core/programme_level.rb

@@ -3,4 +3,4 @@ module Sis
     class ProgrammeLevel < Lookup
     end
   end
-end
+end

data/lib/sis/core/version.rb

@@ -1,5 +1,5 @@
 module Sis
   module Core
-    VERSION = '1.0.4'.freeze
+    VERSION = '1.0.5'.freeze
   end
 end

data/lib/sis_core.rb

@@ -2,4 +2,4 @@ require 'sis/core'
 require 'sis/core/engine'
 require 'devise_token_auth'
 require 'aasm'
-require 'active_model_serializers'
+require 'active_model_serializers'

data/spec/factories/sis/core/staffs.rb

@@ -1,6 +1,5 @@
 FactoryBot.define do
   factory :staff, class: 'Sis::Core::Staff' do
-
   end
   # SINGLE = 'Single'.freeze
   # MARRIED = 'Married'.freeze

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sis_core
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Henock L.