siren_client 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 64e224e64dc04f3274a0bf852c0db04ea38ef36d
-  data.tar.gz: b9a44d4d0d8c04fda5d9abe932516afb00b71a71
+  metadata.gz: 6a253bc2fd4e72e714faf829cc0f271d13b4f5ba
+  data.tar.gz: f6b6070713bcccca1cb21d82e779f10721059d7c
 SHA512:
-  metadata.gz: a55f189f389e87f9f6bd03e6146140a876cacb753915dd86e7ccc021dcd26c61beb4068fcb6b6ba931a952c770bd2ce11851b83708d0ead04086bb724ba60823
-  data.tar.gz: d2593af969d9d4b5ef024055b1cd19a7c309d05d8ed52cfda2890b7724c2cf80dfa5e4aa7f3a53852702a674ba41dda0b2d75b951a6fad84e90da135783780e6
+  metadata.gz: 332a452ba08d4dfe61c9d72c50c8ebf5ebc116cc9028699d01848ee0b05609b368fd0d4889f7143437f7c991b008aaa18aeba5da76a0f37782f0d7decbae4e84
+  data.tar.gz: '092c322d52c5f28f07dffd66ea1ede17fc442ac7ea22c2ab45f36c0d2379ada853e398ce0919c135817abdf795dde03c809c8ef8bdf6026d5854c16e2a3dc772'

data/lib/siren_client/action.rb

@@ -26,13 +26,16 @@ module SirenClient
     end
 
     def where(params = {})
-      options = { headers: {}, query: {}, body: {} }.merge @config
+      options = { headers: {} }.merge @config
       if @method == 'get'
         options[:query] = params
       else
         options[:body] = params
+
+        # Only set the Content-Type if we have a body
+        options[:headers]['Content-Type'] = @type
       end
-      options[:headers]['Content-Type'] = @type
+
       begin
         resp = generate_raw_response(@method, self.href, options)
         if next_response_is_raw?

data/lib/siren_client/version.rb

@@ -1,3 +1,3 @@
 module SirenClient
-  VERSION = "2.0.0"
+  VERSION = "2.0.1"
 end

data/spec/unit/action_spec.rb

@@ -14,16 +14,24 @@ describe SirenClient::Action do
       end
   end
 
+  let (:output_buffer) {
+    StringIO.new
+  }
   let (:action) {
     SirenClient::Action.new(action_data, {
-      headers: { "Accept" => "application/json" }
+      headers: { "Accept" => "application/json" },
+      debug_output: output_buffer
     })
   }
   let (:action_post) {
-    SirenClient::Action.new(action_data_post)
+    SirenClient::Action.new(action_data_post, {
+      debug_output: output_buffer
+    })
   }
   let (:action_delete) {
-    SirenClient::Action.new(action_data_delete)
+    SirenClient::Action.new(action_data_delete, {
+      debug_output: output_buffer
+    })
   }
   describe '.config' do
     it 'is a hash' do
@@ -96,10 +104,18 @@ describe SirenClient::Action do
       # I'm expecting an error here, all I want to see is that the url it being traversed.
       expect { action.where(test: 'hi') }.to raise_error SirenClient::InvalidResponseError
     end
+    it 'GET action does not send the Content-Type header' do
+      expect { action.where(test: 'hi') }.to raise_error SirenClient::InvalidResponseError
+      expect(output_buffer.string).not_to include('Content-Type: application/x-www-form-urlencoded')
+    end
     it 'executes the POST action' do
       # I'm expecting an error here, all I want to see is that the url it being traversed.
       expect { action_post.where(test: 'hi') }.to raise_error SirenClient::InvalidResponseError
     end
+    it 'POST action does send the Content-Type header' do
+      expect { action_post.where(test: 'hi') }.to raise_error SirenClient::InvalidResponseError
+      expect(output_buffer.string).to include('Content-Type: application/x-www-form-urlencoded')
+    end
     it 'executes the DELETE action' do
       expect { action_delete.submit }.to raise_error SirenClient::InvalidResponseError
     end

data/spec/unit/entity_spec.rb

@@ -127,7 +127,7 @@ describe SirenClient::Entity do
       expect(entity.go).to eq(nil)
     end
     it 'initiate a request if it IS an entity sub-link' do
-      expect { graph.entities[0].go }.to raise_error Errno::ECONNREFUSED
+      expect { graph.entities[0].go }.to raise_error SystemCallError
     end
   end
   describe '.invalidkey' do
@@ -145,10 +145,10 @@ describe SirenClient::Entity do
   describe '.validkey' do
     let (:graph) { entity[0] }
     it 'can access an entity sub-link within the entity' do
-      expect { graph.messages }.to raise_error Errno::ECONNREFUSED
+      expect { graph.messages }.to raise_error SystemCallError
     end
     it 'can access a link directly on the entity' do
-      expect { entity.next }.to raise_error Errno::ECONNREFUSED
+      expect { entity.next }.to raise_error SystemCallError
     end
     it 'can access an action directly on the entity' do
       expect(entity.filter_concepts).to be_a SirenClient::Action
@@ -226,14 +226,14 @@ describe SirenClient::Entity do
   describe 'underscore support' do
     it 'can access entity sub-links' do
       # Since this will trigger the sub-link. We expect an error
-      expect { graph.user_preferences }.to raise_error Errno::ECONNREFUSED
+      expect { graph.user_preferences }.to raise_error SystemCallError
     end
     it 'can access actions' do
       expect(entity.filter_messages).to be_a SirenClient::Action
     end
     it 'can access links' do
       # Since this will trigger the link. We expect an error
-      expect { entity.prev_page }.to raise_error Errno::ECONNREFUSED
+      expect { entity.prev_page }.to raise_error SystemCallError
     end
   end
   describe '.with_raw_response' do
@@ -246,7 +246,7 @@ describe SirenClient::Entity do
     end
     it 'should still allow a network request to be made' do
       entity.with_raw_response
-      expect { entity.with_raw_response.prev_page }.to raise_error Errno::ECONNREFUSED
+      expect { entity.with_raw_response.prev_page }.to raise_error SystemCallError
     end
   end
   # Entities enumerable support

metadata

@@ -1,150 +1,164 @@
 --- !ruby/object:Gem::Specification
 name: siren_client
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Chason Choate
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-22 00:00:00.000000000 Z
+date: 2017-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
+  name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.13'
-  name: httparty
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.13'
 - !ruby/object:Gem::Dependency
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4'
-  name: activesupport
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4'
 - !ruby/object:Gem::Dependency
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: bundler
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
-  name: rack
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: rake
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: sinatra
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: sinatra
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: rspec
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: guard
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: guard-rspec
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: coveralls
+  type: :development
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -197,7 +211,7 @@ homepage: https://github.com/cha55son/siren_client
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -212,9 +226,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.6.8
-signing_key:
+rubyforge_project: 
+rubygems_version: 2.6.14
+signing_key: 
 specification_version: 4
 summary: A client to traverse Siren APIs https://github.com/kevinswiber/siren
 test_files: