sinatra-paypal 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b91fdfe678e28fe0fad663c05afb3fa259ca40ad
-  data.tar.gz: 5f899b739d302480dbfb512f2f3dbae4a7a6c213
+  metadata.gz: dbbe8b8b2351d5cf7d643aabff1146ea783b4729
+  data.tar.gz: 6095033aa3049ec0307a63960c936b025bc91b11
 SHA512:
-  metadata.gz: c37ec074ce4d8a115ed91808fee99109da1effc7003fce4ed43ecc868a350cecf34d8515fef0ca9a20365aab2fce98028b8dc5378d61de5fca7f55d3eb1605f0
-  data.tar.gz: 951e171455b7369bc5324fb29a4974f1602c2ce2bfb7b60ac3c98c98568ac14cc6ba82a3fc9d20fed76aa53947e9a5b63dca4d5d7933a0c2f60a057f8196e1d0
+  metadata.gz: e6bba20dbb1049f2ccd157a7331bae400bcb495ef316eb18cadac06876d6dc1ca717982bc3a6e25aa1501448a5f05777fb1a766b21959efb7977fb9063cca87a
+  data.tar.gz: cdc5ac4baf40951a567cdeccdaec36abdab8ef7a16ab03d38c51088054b0ab573b88603381e57f59a3a94a53b4bdbd9c5487b22d0fb6f4dda6eb7d7dd7128d35

data/Rakefile

@@ -1,8 +1,7 @@
 require "bundler/gem_tasks"
-require "rake/testtask"
+require 'rake/testtask'
 
 Rake::TestTask.new do |t|
-    ENV['RUBYOPT'] = '-W0'
-    t.warning = false
-    t.test_files = FileList['test/*_test.rb']
+  t.libs << 'test'
+  t.pattern = "test/*_test.rb"
 end

data/lib/sinatra/paypal.rb

@@ -9,7 +9,7 @@ PAYPAL_BLOCKS = {}
 module PayPal
 
 	module Helpers
-		def paypal_block(name)
+		def _paypal_block(name)
 			return Proc.new{} if !PAYPAL_BLOCKS.key? name
 			PAYPAL_BLOCKS[name]
 		end
@@ -18,16 +18,21 @@ module PayPal
 			PaypalHelper.form_url(settings.paypal.sandbox?)
 		end
 
-		def html_payment_form(offer_data, data = nil)
-			data ||= {}
-			data[:username] = session[:reddit_user] if !data.nil? && data[:username].nil?
-			data[:offer_code] = offer_data.code if !offer_data.nil?
+		def html_payment_form(item, data = {})
+			# it is valid to send a nil item through - we might be going to set the fields in
+			# javascript - but if it isn't null then there are certain fields that need to be
+			# set
+			if !item.nil?
+				raise 'item.code required' if !item.respond_to?(:code) || item.code.nil?
+				raise 'item.price required' if !item.respond_to?(:price) || item.price.nil?
+				raise 'item.price must be a number above zero' if item.price.to_f <= 0
+			end
 
 			raise 'cannot generate a payment form without settings.paypal.email' if settings.paypal.email.nil?
 
 			erb :_payment, :views => File.join(File.dirname(__FILE__), '/paypal'), :locals => {
 				:custom_data => data,
-				:offer_data => offer_data
+				:item => item
 			}
 		end
 	end
@@ -54,30 +59,35 @@ module PayPal
 			halt 400, 'no username provided' if paypal_request.username.nil?
 			
 			# check transaction log to make sure this not a replay attack
-			if instance_exec(paypal_request, &paypal_block(:repeated?))
-				# we want to log this, so we know about it, but we also want to return 200, because
-				# if it is paypal sending this, it will send it again and again until it gets a 200
-				# back
-				log_error 'already processed' if respond_to? :log_error
+			if instance_exec(paypal_request, &_paypal_block(:repeated?))
+				# we also want to return 200, because if it is paypal sending this, it will send 
+				# it again and again until it gets a 200 back
 				halt 200, 'already processed'
-			else
-				instance_exec(paypal_request, &paypal_block(:save))
 			end
 
-			instance_exec(paypal_request, &paypal_block(:validate!))
+			instance_exec(paypal_request, &_paypal_block(:validate!))
 			
 			# check that the payment is complete. we still return 200 if not, but
 			# we don't need to do anymore processing (except for marking it as accountable, if it is)
 			if paypal_request.complete?
-				instance_exec(paypal_request, &paypal_block(:complete))
+				instance_exec(paypal_request, &_paypal_block(:complete))
 			end
 
-			instance_exec(paypal_request, &paypal_block(:finish))
+			instance_exec(paypal_request, &_paypal_block(:finish))
 
 			return 200
 		end
 	end
 
+	# Register a payment callback. All callbacks are called
+	# with a single argument of the type +PaypalRequest+ containing all the
+	# data for the notification.
+	#
+	# 	payment :complete do |p|
+	# 		# process the payment here
+	# 		# don't forget to check that the price is correct!
+	# 	end
+	#
 	def payment(name, &block)
 		PAYPAL_BLOCKS[name] = block
 	end
@@ -86,4 +96,4 @@ end
 
 module Sinatra
 	register PayPal
-end
+end

data/lib/sinatra/paypal/_payment.erb

@@ -1,5 +1,5 @@
 
-<form id='paypal-form' action="<%= paypal_form_url %>" method="post" style='display:none'>
+<form class='sinatra-paypal-form' action="<%= paypal_form_url %>" method="post">
 	<input type="hidden" name="cmd" value="_xclick">
 
 	<input type="hidden" name="business" value="<%= settings.paypal.email %>">
@@ -7,14 +7,14 @@
 	<input type="hidden" name="return" value="<%= url(settings.paypal.return_url) %>">
 	<input type="hidden" name="notify_url" value="<%= url(settings.paypal.notify_url) %>">
 
-	<% if offer_data.nil? %>
-		<input type="hidden" name="item_number" id='paypal-item-number' value="0">
-		<input type="hidden" name="item_name" id='paypal-item-name' value="0">
+	<% if item.nil? %>
+		<input type="hidden" name="item_number" id='paypal-item-number' value="NO_ITEM">
+		<input type="hidden" name="item_name" id='paypal-item-name' value="NO_ITEM">
 		<input type="hidden" name="amount" id='paypal-amount' value="1.00">
 	<% else %>
-		<input type="hidden" name="item_number" id='paypal-item-number' value="<%= offer_data.offer.item_code %>">
-		<input type="hidden" name="item_name" id='paypal-item-name' value="<%= offer_data.item.name %>">
-		<input type="hidden" name="amount" id='paypal-amount' value="<%= offer_data.offer.amount %>">
+		<input type="hidden" name="item_number" id='paypal-item-number' value="<%= item.code %>">
+		<input type="hidden" name="item_name" id='paypal-item-name' value="<%= item.name || item.code %>">
+		<input type="hidden" name="amount" id='paypal-amount' value="<%= item.price %>">
 	<% end %>
 
 	<input type="hidden" name="no_shipping" value="1">

data/lib/sinatra/paypal/paypal-helper.rb

@@ -5,6 +5,12 @@ class PaypalHelper
 		@use_sandbox = use_sandbox
 	end
 
+	# returns the url that the payment forms must be submitted to so they can be
+	# processed by paypal. If the sandbox attribute is set, then it will return the
+	# url for the sandbox
+	#
+	# 	form_url # => https://www.paypal.com/cgi-bin/webscr
+	#
 	def form_url
 		@use_sandbox ? 'https://www.sandbox.paypal.com/cgi-bin/webscr' : 'https://www.paypal.com/cgi-bin/webscr'
 	end
@@ -13,6 +19,8 @@ class PaypalHelper
 		new(use_sandbox).form_url
 	end
 
+	# validates the ipn request with paypal to make sure it is genuine. +params+ should contain
+	# the exact params object that was sent as part of the IPN POST
 	def ipn_valid?(params)
 		return false if params.nil?
 

data/lib/sinatra/paypal/paypal-request.rb

@@ -1,3 +1,4 @@
+require 'json'
 
 class PaypalRequest
 	def initialize(params)
@@ -9,17 +10,26 @@ class PaypalRequest
 		@custom_data = nil
 	end
 
-	
+	# a unique id for the transaction (event if the paypal transaction_id is the
+	# same)
+	#
+	# 	payment.id # => 661295c9cbf9d6b2f6428414504a8deed3020641
+	#
 	def id
 		self.transaction_hash
 	end
 
-	# the same transaction id can come in mulitple times with different statuses
-	# so we need to check both of them in order to see if the txn is unquie
+	# alias for +id+
 	def transaction_hash
+		# the same transaction id can come in mulitple times with different statuses
+		# so we need to check both of them in order to see if the txn is unquie
 		"#{self.transaction_id}-#{@fields[:payment_status]}".sha1
 	end
 
+	# the paypal transaction_id
+	#
+	# 	payment.transaction_id # => 6FH51066BB6306017
+	#
 	def transaction_id
 		@fields[:txn_id]
 	end
@@ -44,7 +54,7 @@ class PaypalRequest
 	end
 
 	def item_number
-		@fields[:item_number] || @fields[:item_number1]
+		@fields[:item_number]
 	end
 
 	def amount
@@ -55,17 +65,39 @@ class PaypalRequest
 		Float(@fields[:mc_fee] || 0)
 	end
 
-	# defined as the gross amount, minus transaction fees
-	# could also subtract shipping and tax here as well, but we don't have to deal with
-	# any of that yet
+	# The payment amount minus any fees, giving the net profit
+	#
+	# 	payment.profit # => 1.63
+	#
 	def profit
+		# defined as the gross amount, minus transaction fees
+		# could also subtract shipping and tax here as well, but we don't have to deal with
+		# any of that yet
 		self.amount - self.payment_fee
 	end
 
+	# One of the most common peices of data to send through with the payment is the
+	# username that the payment applies to. This method will return the username from
+	# the custom_data field, if it contains one
+	#
+	# 	payment.username # => reednj
+	#
 	def username
 		self.custom_data[:username]
 	end
 
+	# Whatever is put in the custom_data field on the payment form will be sent back
+	# in the payment notification. This is useful for tracking the username and other
+	# information that is required to process the payment.
+	#
+	# The sinatra-paypal module expects this to be either a plain string containing 
+	# the username or a json string that can be parse into a ruby object.
+	#
+	# Note that this field can be modified by the user before submitting the form, 
+	# so you should verify the contents of it before using it.
+	#
+	# payment.custom_data # => { :username => 'dave' }
+	#
 	def custom_data
 		if @custom_data.nil?
 			if @fields[:custom].strip.start_with? '{'
@@ -81,29 +113,97 @@ class PaypalRequest
 		return @custom_data
 	end
 
+	# an alias for +custom_data+
 	def data
 		custom_data
 	end
 
+	# The payment status. The most common is Completed, but you might also see
+	#
+	#  - Refunded 
+	#  - Pending
+	#  - Reversed
+	#  - Canceled_Reversal
+	#  - Completed
+	#
+	# 	payment.status # => Pending
+	#
 	def status
 		@fields[:payment_status]
 	end
 
+	# Returns true if +status+ is Completed
 	def complete?
 		self.status == 'Completed'
 	end
 
-	# these are payment statues that actually result in the paypal balance changing, so we should set them as
-	# accountable in the payment_log
+	# Returns true if the transaction results in a change of the merchant account balance. This
+	# doesn't apply to all IPN notifications - some (such as those with status Pending) are simply
+	# notifications that do not actually result in money chaning hands
 	def is_accountable?
+		# these are payment statues that actually result in the paypal balance changing, so we should set them as
+		# accountable in the payment_log
 		(self.complete? || self.status == 'Refunded' || self.status == 'Reversed' || self.status == 'Canceled_Reversal')
 	end
 
+	# returns the reason code for noticiations that have one (usually Pending or Refunded transactions)
+	# if a reason code is not applicable, this will return nil
 	def reason_code
 		@fields[:reason_code] || @fields[:pending_reason]
 	end
 
+	# A Hash with the raw data for the paypal transaction, this contains many less useful
+	# fields not listed above
+	#
+	# Here is a list of the fields for a Completed transaction. These fields differ slightly
+	# between the main transaction types.
+	#
+	# 	:business: you@yourcompany.com
+	# 	:charset: UTF-8
+	# 	:cmd: _notify-validate
+	# 	:custom: ! '{"thread_id":"3f3fc5","username":"customer_user_name"}'
+	# 	:first_name: Bill
+	# 	:handling_amount: '0.00'
+	# 	:ipn_track_id: a5d596fffd057
+	# 	:item_name: Describe your item
+	# 	:item_number: I01
+	# 	:last_name: Davies
+	# 	:mc_currency: USD
+	# 	:mc_fee: '0.37'
+	# 	:mc_gross: '2.00'
+	# 	:notify_version: '3.8'
+	# 	:payer_email: customer@gmail.com
+	# 	:payer_id: 9AFYVBV9TTT5L
+	# 	:payer_status: verified
+	# 	:payment_date: 18:01:26 Jul 29, 2015 PDT
+	# 	:payment_fee: '0.37'
+	# 	:payment_gross: '2.00'
+	# 	:payment_status: Completed
+	# 	:payment_type: instant
+	# 	:protection_eligibility: Ineligible
+	# 	:quantity: '1'
+	# 	:receiver_email: you@yourcompany.com
+	# 	:receiver_id: 4SUZXXXXFMC28
+	# 	:residence_country: US
+	# 	:shipping: '0.00'
+	# 	:tax: '0.00'
+	# 	:transaction_subject: ! '{"thread_id":"3f3fc5","username":"customer_user_name"}'
+	# 	:txn_id: 6FH51036BB6776017
+	# 	:txn_type: web_accept
+	# 	:verify_sign: AmydMwaMHzmxRimnFMnKy3o9n-ElAWWRtiJ9TEixE0iGouC6EaMS0mWI
+	#
+	# See https://developer.paypal.com/docs/classic/ipn/integration-guide/IPNandPDTVariables/ for
+	# a full description of the notification fields
+	#
 	def fields
 		@fields
 	end
 end
+
+# extensions needed for the paypal request to work
+class String
+	def sha1
+		Digest::SHA1.hexdigest self
+	end
+end
+

data/lib/sinatra/paypal/version.rb

@@ -1,5 +1,5 @@
 module Sinatra
   module Paypal
-    VERSION = "0.1.1"
+    VERSION = "0.2.0"
   end
 end

data/sinatra-paypal.gemspec

@@ -14,14 +14,17 @@ Gem::Specification.new do |spec|
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.9"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "test-unit"
   spec.add_development_dependency "rack-test"
+  spec.add_development_dependency "minitest"
+  
   spec.add_runtime_dependency "sinatra"
   spec.add_runtime_dependency "rest-client"
 end

data/test/app.rb

@@ -0,0 +1,57 @@
+
+require 'bundler'
+Bundler.require
+
+require 'sinatra'
+require 'sinatra/paypal'
+
+# this allows us to handle errors in test without the default page
+# getting generated (which isn't very useful inside unit-tests)
+set :raise_errors, false
+set :show_exceptions, false
+
+# dump the error description - this will make it appear nicely in the 
+# unit test description
+error do
+	e = request.env['sinatra.error']
+	return "#{e.class}: #{e.message}" unless e.nil?
+	return "unknown error"
+end
+
+payment :repeated? do |p|
+	path = '/tmp/test.sinatra-payment.log'
+	data = File.read path
+	id = "#{p.id}\n"
+
+	if data.include? id
+		true
+	else
+		File.append path, "#{p.id}\n"
+		false
+	end
+end
+
+get '/payment/form/empty' do
+	return html_payment_form nil
+end
+
+get '/payment/form' do
+	item = {}
+	item[:code] = params[:item_code]
+	item[:price] = params[:item_price]
+	item[:name] = params[:item_name]
+	item = OpenStruct.new item
+
+	return html_payment_form(item)
+end
+
+#
+# Extensions to make the the test app simpler
+# 
+class File
+	def self.append(path, data)
+		File.open(path, 'a:UTF-8') do |file| 
+			file.write data 
+		end
+	end
+end

data/test/form_test.rb

@@ -0,0 +1,93 @@
+ENV['RACK_ENV'] = 'development'
+
+require 'rubygems'
+require 'minitest/autorun'
+require 'rack/test'
+require 'test/unit'
+
+require_relative './app'
+
+class RedditStreamTest < Test::Unit::TestCase
+	include Rack::Test::Methods
+
+	def app
+		Sinatra::Application
+	end
+	
+	def page_error(desc)
+		"#{desc} (HTTP #{last_response.status})\n" + 
+		"#{last_response.body.truncate 256}"
+	end
+
+	def test_form_helper_no_email
+		app.paypal.email = nil
+
+		begin
+			get '/payment/form/empty'
+			assert false, 'no email payment form didn\'t raise an exception'
+		rescue => e
+			raise if !e.message.include? 'email'
+		end
+	end
+
+	def test_form_helper_no_item_code
+		app.paypal.email = 'reednj@gmail.com'
+
+		get '/payment/form'
+		assert !last_response.ok?, 'form created without item code'
+		assert last_response.body.include?('item.code'), 'no error about missing item.code'
+	end
+
+	def test_form_helper_invalid_price
+		app.paypal.email = 'reednj@gmail.com'
+
+		get '/payment/form', { :item_code => 'ITEM-0', :item_price => 'xxx'}
+		assert !last_response.ok?, 'form created with invalid price'
+		assert last_response.body.include?('item.price'), 'no error about invalid price'
+	end
+
+	def test_empty_form_helper
+		app.paypal.email = 'reednj@gmail.com'
+		
+		get '/payment/form/empty'
+		assert last_response.ok?, page_error('could not generate payment form')
+		assert last_response.body.include?(app.paypal.email), 'account email not found in form'
+	end
+
+	def test_form_helper_with_item
+		app.paypal.email = 'reednj@gmail.com'
+		
+		code = 'ITEM-0'
+		get '/payment/form', { :item_code => code, :item_price => '5.00'}
+		assert last_response.ok?, page_error('could not generate payment form')
+		assert last_response.body.include?(app.paypal.email), 'account email not found in form'
+		assert last_response.body.include?(code), 'item_code not found in form'
+	end
+
+	def test_form_helper_with_item_description
+		app.paypal.email = 'reednj@gmail.com'
+		
+		code = 'ITEM-0'
+		desc = 'item description'
+		get '/payment/form', { :item_code => code, :item_price => '5.00', :item_name => desc}
+		assert last_response.ok?, page_error('could not generate payment form')
+		assert last_response.body.include?(app.paypal.email), 'account email not found in form'
+		assert last_response.body.include?(code), 'item_code not found in form'
+		assert last_response.body.include?(desc), 'item_name not found in form'
+	end
+
+end
+
+class Array
+	def rand
+		self[Object.send(:rand, self.length)]
+	end
+end
+
+class String
+	def truncate(max_len = 32)
+		append = '...'
+		return self if self.length < max_len
+		return self[0...(max_len - append.length)] + append
+	end
+end

data/test/paypal_test.rb

@@ -0,0 +1,135 @@
+ENV['RACK_ENV'] = 'development'
+
+require 'rubygems'
+require 'minitest/autorun'
+require 'rack/test'
+require 'test/unit'
+
+require_relative './app'
+
+class RedditStreamTest < Test::Unit::TestCase
+	include Rack::Test::Methods
+
+	def app
+		Sinatra::Application
+	end
+
+	def standard_payment_data
+		{			
+			:tax=>"0.00", 
+			:receiver_email=>"accounts@reddit-stream.com", 
+			:payment_gross=>"1.49", 
+			:transaction_subject=>"rs-test", 
+			:receiver_id=>"TDCZRKH9NXETE", 
+			:quantity=>"1", 
+			:business=>"accounts@reddit-stream.com", 
+			:mc_currency=>"USD", 
+			:payment_fee=>"0.44", 
+			:notify_version=>"3.7", 
+			:shipping=>"0.00", 
+			:verify_sign=>"AVQ7PVd2w7LAwpsg5Yh7hFxe9SywAuiBQIp9fScf77n48fA8WF21KG2i", 
+			:cmd=>"_notify-validate", 
+			:test_ipn=>"1", 
+			:txn_type=>"web_accept", 
+			:charset=>"UTF-8", 
+			:payer_id=>"649KQR22GAU4W", 
+			:payer_status=>"verified", 
+			:ipn_track_id=>"d1992aaea45a",
+			:handling_amount=>"0.00", 
+			:residence_country=>"US", 
+			:payer_email=>"user1@reddit-stream.com", 
+			:payment_date=>"09:26:13 Sep 23, 2013 PDT", 
+			:protection_eligibility=>"Ineligible", 
+			:payment_type=>"instant",
+
+			:first_name=>"Nathan",
+			:last_name=>"Reed",
+			:custom=>"rs-test",
+			
+			:txn_id=>random_string(),
+			:payment_status=>"Completed",
+			:item_number=>"RS1",
+			:item_name=>"reddit-stream.com Unlimited Account",
+			:mc_gross=>"1.49",
+			:mc_fee=>"0.44"		
+		}
+	end
+
+	def random_string(len = 5)
+		space = ['a', 'b', 'c', 'd', 'e','f', '1', '2', '3', '4', '5', '6', '7', '8', '9']
+		return (0..5).map {|a| space.rand }.join
+	end
+	
+	def page_error(desc)
+		"#{desc} (HTTP #{last_response.status})\n" + 
+		"#{last_response.body.truncate 256}"
+	end
+
+	#
+	# Now we start the testing of the payment processing
+	#
+	def test_payment_rejects_double_processing
+		data = standard_payment_data
+
+		post '/payment/validate', data
+		assert last_response.ok?, page_error("Payment rejected")
+		assert !last_response.body.include?('already processed')
+
+		post '/payment/validate', data
+		assert last_response.ok?
+		assert last_response.body.include?('already processed'), "duplicate payment accepted!"
+	end
+
+	def test_payment_thread_id
+		data = standard_payment_data
+		data[:custom] = {
+			:username => 'njr123',
+			:thread_id => '2hqk1o'
+		}.to_json
+
+		header 'Accept', 'text/plain'
+		post '/payment/validate', data
+		assert last_response.ok?, page_error("Payment not accepted")
+	end
+
+	def test_payment_thread_id_only
+		data = standard_payment_data
+		data[:custom] = {
+			:thread_id => '2hqk1o'
+		}.to_json
+
+		post '/payment/validate', data
+		assert_equal last_response.status, 400
+	end
+
+	def test_payment_accepted_json_custom_data
+		data = standard_payment_data
+		data[:custom] = {:username => data[:custom]}.to_json
+
+		post '/payment/validate', data
+		assert last_response.ok?, page_error("Payment not accepted")
+	end
+
+	def test_payment_accepted
+		data = standard_payment_data
+		username = data[:custom]
+
+		post '/payment/validate', data
+		assert last_response.ok?, page_error("Payment not accepted")
+	end
+
+end
+
+class Array
+	def rand
+		self[Object.send(:rand, self.length)]
+	end
+end
+
+class String
+	def truncate(max_len = 32)
+		append = '...'
+		return self if self.length < max_len
+		return self[0...(max_len - append.length)] + append
+	end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sinatra-paypal
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Nathan Reed
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-12 00:00:00.000000000 Z
+date: 2015-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -26,6 +26,20 @@ dependencies:
         version: '1.9'
 - !ruby/object:Gem::Dependency
   name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: test-unit
+  name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rack-test
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -115,6 +129,9 @@ files:
 - lib/sinatra/paypal/paypal-request.rb
 - lib/sinatra/paypal/version.rb
 - sinatra-paypal.gemspec
+- test/app.rb
+- test/form_test.rb
+- test/paypal_test.rb
 homepage: http://github.com/reednj/sinatra-paypal
 licenses:
 - MIT
@@ -135,8 +152,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Easy validation and processing of Paypal IPN payments
-test_files: []
+test_files:
+- test/app.rb
+- test/form_test.rb
+- test/paypal_test.rb