simplycop 1.7.5 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2e77533f1f1e2ab183ee38e0b154de2b531366aa67c112eda000e2a2a6da9dc
-  data.tar.gz: 176e07e981b3747f42b4b275c49fcc4c13193ad1a44dc37c7e85bfce0b79fa8b
+  metadata.gz: 7186eac4e8a769e55cefe3738cfbf45c967a6b2aab0f4744191d92b932175ea7
+  data.tar.gz: 604182eff86928d921da2831b08a1bb880b1a21660a252610619012f7059fa34
 SHA512:
-  metadata.gz: 1158d81c907c57ca389d6638cdc39ee86fb4f0f277f6e071f3a62b42d8e7a5420432a82444ce4897a3f946d859b16ee31fcd4e9da92879a15bc544ac3ed9c323
-  data.tar.gz: f13026040f02ec6b2e199fd2a75e1a57cc3cc975fb2155431d522658ca7c397db8f20e2ab23d46312000dd9cb3cf893741a6dcf2563c5d946a0235854f58b448
+  metadata.gz: 0be2768aceb033e5625ebd342c86c1ae8cbe356d348f8ad27d7cd9ef9d9faecb78907ff4a6f17f6369eade666f99b8e1697a35143b43b768b7ef73609024de0b
+  data.tar.gz: 0a09ff8fccde37b4b8f9eea6241a2c64ca76e5a775f34777eebfb7eda8751ec7471c7d080319d1cd420c67f28cf386a220f4870435b0b8d059a5ef8f6119aa37

data/.custom_simplycop.yml

@@ -1,6 +1,7 @@
 require:
   - './lib/simplycop/custom_cops/timecop_without_block.rb'
   - './lib/simplycop/custom_cops/dont_print_all_env.rb'
+  - './lib/simplycop/custom_cops/variable_name_shadowing_method.rb'
 
 AllCops:
   ExtraDetails: true

data/lib/simplycop/custom_cops/variable_name_shadowing_method.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module CustomCops
+  class VariableNameShadowingMethod < RuboCop::Cop::Cop
+    # For each source file, Rubocop calls on_new_investigation, then walks the abstract syntax
+    # tree calling on_foo methods for each "foo" AST node - e.g on_begin, on_def, on_args,
+    # on_int, etc.
+
+    # We need to do two passes over the source so that we can find all the method names before
+    # we start looking at the nodes that assign local variables (some methods may be defined
+    # _after_ code that assigns shadowing local variables. We do the first one in
+    # on_new_investigation
+
+    def_node_search :method_names, <<~PATTERN
+      (:def $_ ...)
+    PATTERN
+
+    def on_new_investigation
+      @declared_method_names = method_names(processed_source.ast).to_a
+    end
+
+    def on_lvasgn(node)
+      if @declared_method_names.include?(node.name)
+        add_offense(
+          node,
+          message: "Shadowing method name - `#{node.name}`."
+        )
+      end
+    end
+  end
+end

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.7.5'
+  VERSION = '1.8.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.7.5
+  version: 1.8.0
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-19 00:00:00.000000000 Z
+date: 2021-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -132,6 +132,7 @@ files:
 - lib/simplycop/custom_cops/instance_eval.rb
 - lib/simplycop/custom_cops/method_missing.rb
 - lib/simplycop/custom_cops/timecop_without_block.rb
+- lib/simplycop/custom_cops/variable_name_shadowing_method.rb
 - lib/simplycop/security/check_for_vulnerable_code.rb
 - lib/simplycop/security/csrf_token_validation.rb
 - lib/simplycop/security/reject_all_requests_local.rb