simplycop 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 266e346cb15a66ac2a156e5aa7f9baa95db52601c74759ebf8de088e65d5555a
-  data.tar.gz: 4c59e192a0733f3311c104868ab9b70a746310c58b1f58515334e9b366127d6a
+  metadata.gz: 7362f9d8422f344163d22b674dc3fdb8d9f4b2e2d585388b7f6b5a1881d82fd6
+  data.tar.gz: 6469456915a8038c072feddfabab005d6e16820b7a3e313e0d32500d3b919e38
 SHA512:
-  metadata.gz: e5c2b709e412069b735d778df516789fce3253a6aa8fc6e691f412639d7b8cde5adaf36ca09a62bb82b326e44480d98358b4c4480d707bda8e4f12c2a1a3269b
-  data.tar.gz: 8da07133883fda0eefcd34f750dacc2f0d43e3480ddb719a32d943de61ec089b91641c28935ccf3fc498ecc79cbe962c2f88fbc4210b3afc91d62f363e9ee539
+  metadata.gz: 8117e1a3def558122e55504c58d03ed82fa92d8998c3246db79c7d4ed4b60ac9b04c64496727f2470e4d32570f714a4b65e9b66942f4d27e0183c419ee39e4bf
+  data.tar.gz: 7be3e664e083ac3dcc1dc82c44e819f44536bb987926687937b8c4b4b7ece9ff506e0748ea4f22a68acdb9a9b58ad842c596f18d010eb842706693dce418c96f

data/.simplycop.yml

@@ -18,6 +18,7 @@ AllCops:
   DisplayStyleGuide: true
   UseCache: true
   MaxFilesInCache: 5000
+  ExtraDetails: true
 # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
 
 Naming/VariableName:
@@ -216,6 +217,10 @@ Style/LambdaCall:
 Metrics/ModuleLength:
   Enabled: true
 
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*.rb
+
 Style/For:
   Enabled: true
 

data/.simplycop_rails.yml

@@ -1,64 +1,20 @@
 require:
   - rubocop-rails
 
-AllCops:
-  Exclude:
-    - 'db/schema.rb'
-    - 'vendor/**/*'
-
-  # Cop names are not displayed in offense messages by default. Change behavior
-  # by overriding DisplayCopNames, or by giving the -D/--display-cop-names
-  # option.
-  DisplayCopNames: true
-  # Style guide URLs are not displayed in offense messages by default. Change
-  # behavior by overriding DisplayStyleGuide, or by giving the
-  # -S/--display-style-guide option.
-  DisplayStyleGuide: true
-  UseCache: true
-  MaxFilesInCache: 5000
-# Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
-
-Rails:
-  Enabled: true
-
-## Rails Cops
-Rails/TimeZone:
-  Enabled: true
-  Severity: warning
-
-Rails/Date:
-  Enabled: true
-  Severity: warning
-
-Rails/Delegate:
-  Enabled: false
-
-Rails/Output:
-  Enabled: true
-
-Rails/Validation:
-  Enabled: true
-
-Rails/FindBy:
-  Enabled: true
-
-Rails/ActionFilter:
-  Enabled: true
-
-Rails/ReadWriteAttribute:
+Rails/ActiveRecordCallbacksOrder:
   Enabled: true
 
-Rails/PluralizationGrammar:
+Rails/AfterCommitOverride:
   Enabled: true
 
-Rails/SkipsModelValidations:
+Rails/AttributeDefaultBlockValue:
   Enabled: true
 
-Rails/ActiveRecordCallbacksOrder:
+Rails/DefaultScope:
   Enabled: true
 
-Rails/AfterCommitOverride:
-  Enabled: true
+Rails/Delegate:
+  Enabled: false
 
 Rails/FindById:
   Enabled: true
@@ -75,9 +31,11 @@ Rails/MatchRoute:
 Rails/NegateInclude:
   Enabled: true
 
+# Conflicts with Mongoid
 Rails/Pluck:
   Enabled: false
 
+# Conflicts with Mongoid
 Rails/PluckInWhere:
   Enabled: false
 
@@ -93,17 +51,13 @@ Rails/ShortI18n:
 Rails/SquishedSQLHeredocs:
   Enabled: true
 
+Rails/WhereEquals:
+  Enabled: true
+
+# Conflicts with Mongoid
 Rails/WhereExists:
   Enabled: false
 
+# Conflicts with Mongoid
 Rails/WhereNot:
   Enabled: false
-
-Rails/WhereEquals:
-  Enabled: true
-
-Rails/AttributeDefaultBlockValue:
-  Enabled: true
-
-Rails/ArelStar:
-  Enabled: true

data/.simplycop_rspec.yml

@@ -1,234 +1,48 @@
 require:
   - rubocop-rspec
 
-RSpec/ContextMethod:
-  Enabled: false
-
-RSpec/LeakyConstantDeclaration:
-  Enabled: false
-
-RSpec/EmptyLineAfterExample:
-  Enabled: false
-
-RSpec/AnyInstance:
-  Description: Check that instances are not being stubbed globally.
-  Enabled: true
-
-RSpec/AroundBlock:
-  Description: Checks that around blocks actually run the test.
-  Enabled: true
-
-RSpec/BeEql:
-  Description: Check for expectations where `be(...)` can replace `eql(...)`.
-  Enabled: true
-
 RSpec/BeforeAfterAll:
-  Description: Check that before/after(:all) isn't being used.
   Enabled: false
 
 RSpec/DescribeClass:
-  Description: Check that the first argument to the top level describe is a constant.
-  Enabled: false
-
-RSpec/DescribedClass:
-  Description: Checks that tests use `described_class`.
-  SkipBlocks: false
   Enabled: false
-  EnforcedStyle: described_class
-  SupportedStyles:
-    - described_class
-    - explicit
 
 RSpec/DescribeMethod:
-  Description: Checks that the second argument to `describe` specifies a method.
-  Enabled: false
-
-RSpec/DescribeSymbol:
-  Description: Avoid describing symbols.
   Enabled: false
 
-RSpec/IteratedExpectation:
-  Description: Check that `all` matcher is used instead of iterating over an array.
-  Enabled: true
-
-RSpec/EmptyExampleGroup:
-  Description: Checks if an example group does not include any tests.
-  Enabled: true
-
-RSpec/EmptyLineAfterFinalLet:
-  Description: Checks if there is an empty line after the last let block.
-  Enabled: false
-
-RSpec/EmptyLineAfterSubject:
-  Description: Checks if there is an empty line after subject block.
+RSpec/DescribedClass:
   Enabled: false
 
 RSpec/ExampleLength:
-  Description: Checks for long examples.
   Enabled: false
-  Max: 5
-
-RSpec/ExampleWording:
-  Description: Checks for common mistakes in example descriptions.
-  Enabled: true
-  CustomTransform:
-    be: is
-    BE: IS
-    have: has
-    HAVE: HAS
-  IgnoredWords: []
-
-RSpec/ExpectActual:
-  Description: Checks for `expect(...)` calls containing literal values.
-  Enabled: true
 
 RSpec/ExpectOutput:
-  Description: Checks for opportunities to use `expect { ... }.to output`.
   Enabled: false
 
 RSpec/FilePath:
-  Description: Checks that spec file paths are consistent with the test subject.
-  Enabled: false
-  CustomTransform:
-    RuboCop: rubocop
-    RSpec: rspec
-  IgnoreMethods: false
-
-RSpec/Focus:
-  Description: Checks if examples are focused.
-  Enabled: false
-
-RSpec/HookArgument:
-  Description: Checks the arguments passed to `before`, `around`, and `after`.
-  Enabled: true
-  EnforcedStyle: implicit
-  SupportedStyles:
-    - implicit
-    - each
-    - example
-
-RSpec/ImplicitExpect:
-  Description: Check that a consistent implicit expectation style is used.
-  Enabled: true
-  EnforcedStyle: is_expected
-  SupportedStyles:
-    - is_expected
-    - should
-
-RSpec/InstanceSpy:
-  Description: Checks for `instance_double` used with `have_received`.
   Enabled: false
 
 RSpec/InstanceVariable:
-  Description: Checks for instance variable usage in specs.
-  AssignmentOnly: false
   Enabled: false
 
-RSpec/ItBehavesLike:
-  Description: Checks that only one `it_behaves_like` style is used.
-  Enabled: true
-  EnforcedStyle: it_behaves_like
-  SupportedStyles:
-    - it_behaves_like
-    - it_should_behave_like
-
-RSpec/LeadingSubject:
-  Description: Checks for `subject` definitions that come after `let` definitions.
-  Enabled: true
-
-RSpec/LetSetup:
-  Description: Checks unreferenced `let!` calls being used for test setup.
-  Enabled: true
-
-RSpec/MessageChain:
-  Description: Check that chains of messages are not being stubbed.
-  Enabled: true
-
-RSpec/MessageExpectation:
-  Description: Checks for consistent message expectation style.
-  Enabled: false
-  EnforcedStyle: allow
-  SupportedStyles:
-    - allow
-    - expect
-
 RSpec/MessageSpies:
-  Description: Checks that message expectations are set using spies.
   Enabled: false
-  EnforcedStyle: have_received
-  SupportedStyles:
-    - have_received
-    - receive
-
-RSpec/MultipleDescribes:
-  Description: Checks for multiple top level describes.
-  Enabled: true
 
 RSpec/MultipleExpectations:
-  Description: Checks if examples contain too many `expect` calls.
   Enabled: false
-  Max: 1
 
 RSpec/MultipleMemoizedHelpers:
   Enabled: false
 
-RSpec/NamedSubject:
-  Description: Checks for explicitly referenced test subjects.
-  Enabled: true
-
 RSpec/NestedGroups:
-  Description: Checks for nested example groups.
   Enabled: true
   Max: 4
 
 RSpec/NotToNot:
-  Description: Checks for consistent method usage for negating expectations.
-  EnforcedStyle: not_to
-  SupportedStyles:
-    - not_to
-    - to_not
   Enabled: false
 
-RSpec/OverwritingSetup:
-  Enabled: true
-  Description: Checks if there is a let/subject that overwrites an existing one.
-
-RSpec/RepeatedDescription:
-  Enabled: true
-  Description: Check for repeated description strings in example groups.
-
-RSpec/RepeatedExample:
-  Enabled: true
-  Description: Check for repeated examples within example groups.
-
-RSpec/SharedContext:
-  Description: Checks for proper shared_context and shared_examples usage.
-  Enabled: true
-
-RSpec/SingleArgumentMessageChain:
-  Description: Checks that chains of messages contain more than one element.
-  Enabled: true
-
-RSpec/ScatteredLet:
-  Description: Checks for let scattered across the example group.
-  Enabled: true
-
 RSpec/ScatteredSetup:
-  Description: Checks for setup scattered across multiple hooks in an example group.
-  Enabled: false
-
-RSpec/SubjectStub:
-  Description: Checks for stubbed test subjects.
-  Enabled: true
-
-RSpec/VerifiedDoubles:
-  Description: Prefer using verifying doubles over normal doubles.
   Enabled: false
-  IgnoreSymbolicNames: true
-
-Metrics/BlockLength:
-  Exclude:
-    - 'spec/**/*.rb'
 
 RSpec/StubbedMock:
   Enabled: false

data/.simplycop_security.yml

@@ -3,9 +3,6 @@ require:
   - './lib/simplycop/security/reject_all_requests_local.rb'
   - './lib/simplycop/security/check_for_vulnerable_code.rb'
 
-AllCops:
-  ExtraDetails: true
-
 Security/CSRFTokenValidation:
   Enabled: true
   Details: >-

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.3.0'
+  VERSION = '1.4.0'
 end

data/simplycop.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'rubocop', '~> 1.6.1'
   spec.add_dependency 'rubocop-rails', '~> 2.9.0'
-  spec.add_dependency 'rubocop-rspec', '~> 2.0.1'
+  spec.add_dependency 'rubocop-rspec', '~> 2.1.0'
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.10'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-17 00:00:00.000000000 Z
+date: 2021-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: 2.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement