simplycop 1.12.21 → 1.12.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68e568f306249b37bfb255cdd58ec03e209b2f1e0d81be18c8ef015dab756c4d
-  data.tar.gz: 84681f62a6470b474340dc9ab33310721a2caf41ada7245d2ab17c39e37b9038
+  metadata.gz: 4300fe0cef92b1860b5f9778f1841ebd1db3341ef2a752dfc2d5033c4d9e4beb
+  data.tar.gz: 78b46b78d6f1dce94788fde32a06531c037857547d2b1c6ef98e87b700545c93
 SHA512:
-  metadata.gz: f139da031074eb065eb31ecf446da61ce67c4fb33e7286dd601e8a236d44cdf3473e048b20f3936f615236e4a7ac866cfdb614bca263236fc17b33b04072898e
-  data.tar.gz: 8a02a4aef2f054cec5b66af68d2a922bf6cd0481c6337c51d3aff1de4ca82bbdfb6b0cd978537d639889475aec737e88f2bae86482bbc39b37d05caf7e402a84
+  metadata.gz: 4f19dd0c98414a22df7d38285caeb140b92d80618dad5c462e93939d270090dbf623002d18f43088d9f57ce2b68b199b612d8172329e47442efeef104c70e08e
+  data.tar.gz: aed4ed02ab4fba9da43e3ae962f2f8b55a327f1af0881f98734eae7d3bd2e4d8bf07e183f15aa300b639438bf5228fa1e1145e4c51464214e0790f19622cafb9

data/.simplycop.yml

@@ -21,8 +21,52 @@ AllCops:
   ExtraDetails: true
 # Adapted from: https://github.com/simplybusiness/how-we-roll/blob/master/development/RUBYSTYLEGUIDE.markdown
 
+Bundler/DuplicatedGem:
+  Enabled: true
+
+Bundler/GemComment:
+  Enabled: false
+
+Bundler/GemFilename:
+  Enabled: true
+
+# To discuss: Suggest true but 103 fails on Chopin, 10 on Rater
+# Bundler/GemVersion:
+#   Enabled: true
+
+Bundler/InsecureProtocolSource:
+  Enabled: true
 
-Gemspec/DeprecatedAttributeAssignment: # new in 1.30
+Bundler/OrderedGems:
+  Enabled: true
+
+# To discuss: Suggest true but 3 fails on Chopin, 21 on Rater
+# Gemspec/DependencyVersion:
+#   Enabled: true
+
+# TODO: 1 autocorrectable in Rater and it would pass
+# Gemspec/DeprecatedAttributeAssignment:
+#   Enabled: true
+
+# To discuss: Suggest true but 2 fails on Chopin, 10 on Rater
+# Gemspec/DevelopmentDependencies:
+#   Enabled: true
+
+Gemspec/DuplicatedAssignment:
+  Enabled: true
+
+Gemspec/OrderedDependencies:
+  Enabled: true
+
+# TODO: Suggest true but 4 fails on Chopin, 3 on Rater 
+# Gemspec/RequireMFA:
+#   Enabled: true
+
+# TODO: Suggest true but 3 fails on Chopin
+# Gemspec/RequiredRubyVersion:
+#   Enabled: true
+
+Gemspec/RubyVersionGlobalsUsage:
   Enabled: true
 
 Layout/AccessModifierIndentation:
@@ -438,18 +482,99 @@ Metrics/ParameterLists:
   CountKeywordArgs: false
   Enabled: true
 
-Naming/BlockForwarding: # new in 1.24
+Migration/DepartmentName:
+  Enabled: true
+
+# Suggest true but causes 17 fails in Chopin, 6 in Rater, 2 in CoCo
+# Naming/AccessorMethodName:
+#   Enabled: true
+
+Naming/AsciiIdentifiers:
+  Enabled: true
+
+Naming/BinaryOperatorParameterName:
+  Enabled: true
+
+Naming/BlockForwarding:
+  Enabled: true
+
+Naming/BlockParameterName:
+  Enabled: true
+
+Naming/ClassAndModuleCamelCase:
+  Enabled: true
+
+Naming/ConstantName:
+  Enabled: true
+
+Naming/FileName:
+  Enabled: true
+
+Naming/HeredocDelimiterCase:
+  Enabled: true
+
+Naming/HeredocDelimiterNaming:
   Enabled: true
 
 Naming/InclusiveLanguage:
   Enabled: true
 
+# To discuss: suggest true but 86 fails on Chopin
+# Naming/MemoizedInstanceVariableName:
+#   Enabled: true
+
+Naming/MethodName:
+  Enabled: true
+
+# To discuss: suggest true with possible allowed exceptions as below (10 fails on Chopin, exceptions would allow 4)
+# Naming/MethodParameterName:
+#   Enabled: true
+#   AllowedNames:
+#     - e
+#     - ex
+#     - n
+
+# To discuss: suggest true but 52 fails in Chopin, 8 in Coco (consider with Naming/AccessorName)
+# Naming/PredicateName:
+#   Enabled: true
+
+# To discuss: Should decide on a style. Default e instead of err causes 47 fails on Chopin, none on Rater, CoCo
+# Naming/RescuedExceptionsVariableName:
+#   Enabled: true
+
+Naming/VariableName:
+  Enabled: true
+
+# To discuss: suggest enforce snake_case as this seems to be the preferred style
+# Default normalcase causes 
+# Naming/VariableNumber:
+#   Enabled: true
+#   EnforcedStyle: snake_case
+
 Security/CompoundHash:
   Enabled: true
 
+# Should probably be set to true but 13 offences in chopin spec
+# Security/Eval:
+#   Enabled: true
+
 Security/IoMethods:
   Enabled: true
 
+# Should probably be set to true but 18 offences in chopin spec
+# Security/JSONLoad:
+#   Enabled: true
+
+Security/MarshalLoad:
+  Enabled: true
+
+Security/Open:
+  Enabled: true
+
+# Two fails on ContinuousCover, others fine
+# Security/YAMLLoad:
+#   Enabled: true
+
 Style/AccessModifierDeclarations:
   Enabled: false
 

data/lib/simplycop/version.rb

@@ -7,5 +7,5 @@
 #
 
 module Simplycop
-  VERSION = '1.12.21'
+  VERSION = '1.12.22'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simplycop
 version: !ruby/object:Gem::Version
-  version: 1.12.21
+  version: 1.12.22
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-23 00:00:00.000000000 Z
+date: 2023-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop