simplify_api 0.1.5 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aa46f1c19a2fc27848b6ca7996a2236f41be75f03c564aaa6379d9e91155d584
-  data.tar.gz: f4e4bb806bba725c1e0b18e1a2f9a05bd090a10a863c458187d346e405570975
+  metadata.gz: 196c95f46fa19384bf18b33268ddac0a731553619cbad3b08259c3ea419a2c00
+  data.tar.gz: 883d8462fb80c8f1d5d06e721d9f86fb7ef65f3356ff5804d3bb7f3601719849
 SHA512:
-  metadata.gz: a2f320fb58f8271982cf26ec991817a8d69112ae9d172e3c20f67db9f24dca95fd66f2d2a9776ac07108aae6db08ae1a1d6c57d74de23c0a490d774c106c5df2
-  data.tar.gz: 70a2af56feb3166118be45922f4ed66ccd7d4c42d73eb22df2cca141b0936fc623cd41dacc7a62061f3271ee8c0c296f96dbf59af7405fbebf099e1c95882905
+  metadata.gz: dabb66174fd6d576d4216723af5c2887e35c2a7b2f1e985d9fabde9709acd95bb6258cabe14ca1d576c69f22fc6757f276e62e17f12945b035b4ee69b76f8a7a
+  data.tar.gz: 643fecead6ea85ff6a8ab185fa5ca4919df5411e54183dc78c3ea194f035944f442fb02fcabda4ccdbf01027117b273e3c69e836b6227f5f508015a203cfd061

data/lib/simplify_api/simplify_api.rb

@@ -26,25 +26,12 @@ module SimplifyApi
         type: { Class => type, Array => Array }[type.class] || Object,
         params: args
       }
-      attributes[attr]
+      attr
     end
   end
 
   def initialize(opts = {})
     opts.symbolize_keys!
-    # opts = { klass_attr.first[0] => opts } if opts.class == Array
-    klass_attr.each_pair do |name, spec|
-      params = spec[:params]
-      if opts.key?(name)
-        value = process_value(name, opts[name])
-        opts.delete(name)
-      else
-        value = params[:default]
-      end
-      raise ArgumentError, "Missing mandatory attribute => #{name}" if params[:mandatory] & value.nil?
-
-      create_and_set_instance_variable(name.to_s, value)
-    end
 
     opts.each_pair do |key, value|
       expanded_value = process_value(key, value)
@@ -80,13 +67,15 @@ module SimplifyApi
   #   Called in case an unexisting method is called.
   #
   #   To an assignment call it will create the instance variable.
+  #   To an getter of a specified attribute, return the default value.
   #   Every other call will be passed to super.
   #
   def method_missing(method_name, *args, &block)
-    case method_name
-    when /(.*)\=$/
+    if method_name.match(/(.*)\=$/)
       create_and_set_instance_variable($1.to_s, args[0])
     else
+      return klass_attr.dig(method_name.to_sym, :params, :default) if klass_attr.key?(method_name.to_sym)
+
       super(method_name, args, block)
     end
   end
@@ -94,16 +83,23 @@ module SimplifyApi
   # respond_to_mssing?
   #   Called to check if an instance respond to a message.
   #
-  #   It should respond to any assignment call.
+  #   It should respond to any defined attribute (getter & setter).
   #   Every other type should be passed to super.
   #
   def respond_to_missing?(method_name, *args)
-    case method_name
-    when /(.*)\=$/
-      true # always respond to assignment methods
-    else
-      super(method_name, args)
+    return true if method_name.match(/(.*)\=$/)
+
+    return true if klass_attr.key?(method_name.to_sym)
+
+    super(method_name, args)
+  end
+
+  def valid?
+    klass_attr.each_pair do |key, value|
+      puts "Key: #{key}"
+      return false if value.dig(:params, :mandatory) & !instance_variable_defined?("@#{key.to_s}".to_sym)
     end
+    true
   end
 
   private

data/lib/simplify_api/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SimplifyApi
-  VERSION = '0.1.5'
+  VERSION = '0.2.0'
 end

data/simplify_api.gemspec

@@ -20,6 +20,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'rspec', '~> 3.8'
   spec.add_development_dependency 'rspec-collection_matchers', '~> 1.1'
-  spec.add_development_dependency 'rubocop', '~> 0'
+  spec.add_development_dependency 'rubocop', '>= 0.49.0'
   spec.add_development_dependency 'rubocop-performance', '~> 1.4'
 end

data/spec/simplify_api_spec.rb

@@ -40,7 +40,7 @@ describe SimplifyApi do
     it 'should fullfil class description' do
       subject = Test.new(name: 'João da Silva')
 
-      expect{ Test.new }.to raise_error ArgumentError
+      expect(Test.new.valid?).to be false
       expect(subject).to respond_to :name
       expect(subject).to respond_to :surname
       expect(subject).to respond_to :country

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simplify_api
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.2.0
 platform: ruby
 authors:
 - Rodrigo Garcia Couto
@@ -56,16 +56,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.49.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.49.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement