simplificator-withings 0.2.1 → 0.2.2

data/README.rdoc

@@ -2,9 +2,6 @@
 
 This is a ruby implementation for the Withings API. Description of the API can be found here: http://www.withings.com/en/api
 
-== Status
-The gem is still under development and the API might change a bit.
-
 == Installation
 
 gem install simplificator-withings
@@ -19,8 +16,14 @@ user_id and public_key attributes populated and you can store them for further u
 As soon as you have user_id/public_key available you can either use User.info or User.new to create a User instance. While User.info
 will make an API call to populate the attributes, User.new just requires user_id/public_key.
 
+== TODO
+
+* Need to test parameter generation for get measurement
+* Integration Test? But i don't want to share my credentials... Perhaps with a test account on withings?
+
 == Remarks
 
+* The gem is still under development and the API might change a bit.
 * Authentication by user_id/public_key is only supported when the user has activated sharing. He can do this either in the sharing overlay on my.withings.com or through the api (user.share = true) after authentication by email/password
 * As soon as the user sets sharing to false (user.share = false) the public_key is reset and upon next activation of sharing (user.share = true) a new public_key is assigned.
 * All the methods making remote calls can throw Withing::ApiError if something goes wrong (wrong public_key, missing parameters, ...). You can find more details on the error by looking at the status code in the error.

data/lib/withings/user.rb

@@ -46,25 +46,26 @@ class Withings::User
 
 
   # list measurement groups
-  # - :per_page
-  # - :page
-  # - :category
-  # - :measurement_type
-  # - :start_at
-  # - :end_at
-  # - :last_udpated_at
+  # The limit and offset parameters are converted to will_paginate style parameters (:per_page, :page)
+  # - :per_page           (default: 100)
+  # - :page               (default: 1)
+  # - :category           (default: empty)
+  # - :measurement_type   (default: empty)
+  # - :start_at           (default: empty)
+  # - :end_at             (default: empty)
+  # - :last_udpated_at    (default: empty)
   #
-  # Parameters are described in WBS api, names are "rubyfied" (startdate -> start_at and so on)
+  # Parameters are described in WBS api
   def measurement_groups(params = {})
     params = params.stringify_keys
     options = {:limit => 100, :offset => 0}
-    options[:meastype] = params[:measurement_type] if params.has_key?(:measurement_type)
-    options[:category] = params[:category] if params.has_key?(:category)
-    options[:limit] =  params[:per_page] if params.has_key?(:per_page)
-    options[:offset] = ((params[:page] || 1) - 1) * options[:limit]
-    options[:startdate] = params[:start_at].to_i if params[:start_at]
-    options[:enddate] = params[:end_at].to_i if params[:end_at]
-    options[:lastupdate] = params[:last_update].to_i if params[:last_updated_at]
+    options[:limit] =  params['per_page'] if params.has_key?('per_page')
+    options[:offset] = ((params['page'] || 1) - 1) * options[:limit]
+    options[:category] = params['category'] if params.has_key?('category')
+    options[:meastype] = params['measurement_type'] if params.has_key?('measurement_type')
+    options[:startdate] = params['start_at'].to_i if params['start_at']
+    options[:enddate] = params['end_at'].to_i if params['end_at']
+    options[:lastupdate] = params['last_updated_at'].to_i if params['last_updated_at']
 
     response = connection.get_request('/measure', options.merge(:action => :getmeas))
     response['measuregrps'].map do |group|

data/simplificator-withings.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{simplificator-withings}
-  s.version = "0.2.1"
+  s.version = "0.2.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["pascalbetz"]

data/test/users_test.rb

@@ -70,6 +70,55 @@ class UsersTest < Test::Unit::TestCase
     end
   end
 
+  context 'measurement_groups' do
+    setup do
+      @user = User.new(:user_id => 'lala', :public_key => 'lili')
+      @returns = {'measuregrps' => []}
+    end
+    should 'not require parameters' do
+      Connection.any_instance.expects(:get_request).with('/measure', :action => :getmeas, :limit => 100, :offset => 0).returns(@returns)
+      @user.measurement_groups
+    end
+    should 'set page and current_page A' do
+      Connection.any_instance.expects(:get_request).with('/measure', :action => :getmeas, :limit => 10, :offset => 10).returns(@returns)
+      @user.measurement_groups(:page => 2, :per_page => 10)
+    end
+    should 'set page and current_page B' do
+      Connection.any_instance.expects(:get_request).with('/measure', :action => :getmeas, :limit => 5, :offset => 15).returns(@returns)
+      @user.measurement_groups(:page => 4, :per_page => 5)
+    end
+    should 'set page and current_page C' do
+      Connection.any_instance.expects(:get_request).with('/measure', :action => :getmeas, :limit => 23, :offset => 207).returns(@returns)
+      @user.measurement_groups(:page => 10, :per_page => 23)
+    end
+
+    should 'limit the category' do
+      Connection.any_instance.expects(:get_request).with('/measure', :action => :getmeas, :limit => 100, :offset => 0, :category => 1).returns(@returns)
+      @user.measurement_groups(:page => 1, :per_page => 100, :category => 1)
+    end
+
+    should 'limit the measurement_type' do
+      Connection.any_instance.expects(:get_request).with('/measure', :action => :getmeas, :limit => 100, :offset => 0, :meastype => 1).returns(@returns)
+      @user.measurement_groups(:page => 1, :per_page => 100, :measurement_type => 1)
+    end
+
+    should 'limit start at' do
+      Connection.any_instance.expects(:get_request).with('/measure', :action => :getmeas, :limit => 100, :offset => 0, :startdate => 1234).returns(@returns)
+      @user.measurement_groups(:page => 1, :start_at => Time.at(1234))
+    end
+
+    should 'limit end at' do
+      Connection.any_instance.expects(:get_request).with('/measure', :action => :getmeas, :limit => 100, :offset => 0, :enddate => 1234).returns(@returns)
+      @user.measurement_groups(:page => 1, :end_at => Time.at(1234))
+    end
+
+    should 'limit last updated at' do
+      Connection.any_instance.expects(:get_request).with('/measure', :action => :getmeas, :limit => 100, :offset => 0, :lastupdate => 1234).returns(@returns)
+      @user.measurement_groups(:page => 1, :last_updated_at => Time.at(1234))
+    end
+
+  end
+
 
   context 'constructor' do
     should 'assign short_name' do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: simplificator-withings
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: false
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - pascalbetz