simplificator-withings 0.2.0 → 0.2.1

data/README.rdoc

@@ -1,6 +1,6 @@
 = simplificator-withings
 
-This is a ruby implementation for the Withings API. Description of the API can be found here: http://www.withings.com/en/api/
+This is a ruby implementation for the Withings API. Description of the API can be found here: http://www.withings.com/en/api
 
 == Status
 The gem is still under development and the API might change a bit.
@@ -28,38 +28,30 @@ will make an API call to populate the attributes, User.new just requires user_id
 == How To
 
 Require the API implementation
-
   require 'rubygems'
   require 'withings'
 
 All classes are name-spaced, if your other code allows you can include Withings
-
   include Withings
 
 A user can be authenticated with email address and password
-
   user = User.authenticate('<YOUR EMAIL ADDRESS>', '<YOUR PASSWORD>')
 
 Or you can fetch details if you have the user id and public key
-
   user = User.info('<YOUR USER ID>', '<YOUR PUBLIC KEY>')
 
 If you already have user id and public key and you do not need further information on the user
-
   user = User.new(:user_id => '<YOUR USER ID>', :public_key => '<YOUR PUBLIC_KEY>')
 
 enable/disable sharing, disabling it will reset the public key
-
   user.share=true
 
 You can handle subscriptions through the API
-
   user.subscribe_notification('http://foo.bar.com', 'test subscription')
   user.describe_notification('http://foo.bar.com')
   user.revoke_notification('http://foo.bar.com')
 
 And finally you can get measurements, after all it's a scale
-
   user.measurement_groups(:per_page => 10, :page => 1, :end_at => Time.now)
   user.measurement_groups(:category => MeasurementGroup::CATEGORY_TARGET)
   user.measurement_groups(:last_updated_at => Time.at(12345))

data/lib/withings/error.rb

@@ -7,13 +7,12 @@ class Withings::ApiError < StandardError
     293	  => "The callback URL is either absent or incorrect",
     294	  => "No such subscription could be deleted",
     304	  => "The comment is either absent or incorrect",
-    2554  => "Invalid Parameters . Not sure about this error message, it's not documented",
     2555	=> "An unknown error occurred",
   }
 
   attr_reader :status
   def initialize(status)
-    super(STATUS_CODES[status] || 'Undefined status code')
+    super(STATUS_CODES[status] || "Undefined status code. We do not have any description about the code #{status}. If you know more, then please let me know.")
     @status = status
   end
 

data/lib/withings/measurement_group.rb

@@ -16,7 +16,7 @@ class Withings::MeasurementGroup
   attr_reader :group_id, :attribution, :created_at, :category
   attr_reader :weight, :height, :fat, :ratio, :fat_free
   def initialize(params)
-    params = params.keys_as_string
+    params = params.stringify_keys
     @group_id = params['grpid']
     @attribution = params['attrib']
     @created_at = Time.at(params['date'])
@@ -49,7 +49,7 @@ class Withings::MeasurementGroup
   end
 
   def to_s
-    "[ Weight: #{self.weight}, Fat: #{self.fat}, Height: #{self.height}, BMI: #{self.bmi}, Ratio: #{self.fat_ratio}, Free: #{self.fat_free_weight}, ID: #{self.group_id}]"
+    "[ Weight: #{self.weight}, Fat: #{self.fat}, Height: #{self.height}, BMI: #{self.bmi}, Ratio: #{self.ratio}, Free: #{self.fat_free}, ID: #{self.group_id}]"
   end
 
   def inspect

data/lib/withings/user.rb

@@ -9,7 +9,7 @@ class Withings::User
   end
 
   def self.info(user_id, public_key)
-    response = Connection.get_request('/account', :action => :getbyuserid, :userid => user_id, :publickey => public_key)
+    response = Connection.get_request('/user', :action => :getbyuserid, :userid => user_id, :publickey => public_key)
     User.new(response['users'].first)
   end
 
@@ -31,7 +31,7 @@ class Withings::User
     @fat_method = params['fatmethod']
   end
 
-  def subscribe_to_notification(callback_url, description)
+  def subscribe_notification(callback_url, description)
     connection.get_request('/notify', :action => :subscribe, :callbackurl => callback_url, :comment => description)
   end
 

data/simplificator-withings.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{simplificator-withings}
-  s.version = "0.2.0"
+  s.version = "0.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["pascalbetz"]

data/test/helper.rb

@@ -5,7 +5,7 @@ require 'mocha'
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'withings'
+require File.join(File.dirname(__FILE__), '..', 'lib', 'withings')
 
 class Test::Unit::TestCase
 end

data/test/users_test.rb

@@ -14,7 +14,7 @@ class UsersTest < Test::Unit::TestCase
 
     should 'subscribe to notification' do
       Withings::Connection.any_instance.expects(:get_request).with('/notify', :action => :subscribe, :callbackurl => 'http://schni.com', :comment => 'descri')
-      @user.subscribe_to_notification('http://schni.com', 'descri')
+      @user.subscribe_notification('http://schni.com', 'descri')
     end
 
     should 'revoke notification' do
@@ -62,7 +62,7 @@ class UsersTest < Test::Unit::TestCase
     setup do
       user_id = 'kongking'
       public_key = 'abcdef'
-      Connection.expects(:get_request).with('/account', :action => :getbyuserid, :userid => user_id, :publickey => public_key).
+      Connection.expects(:get_request).with('/user', :action => :getbyuserid, :userid => user_id, :publickey => public_key).
         returns({'users' => [{}]})
     end
     should 'authenticate with hashed password' do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: simplificator-withings
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 2
-  - 0
-  version: 0.2.0
+  - 1
+  version: 0.2.1
 platform: ruby
 authors: 
 - pascalbetz