simple_validation 0.1.6 → 0.2.1

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    YmJkZGM2N2M1MzI2OTA1YzNkYTEyNjlkYTg2YTU3OTg4ZTNkMTM1NQ==
-  data.tar.gz: !binary |-
-    YzQwOTJmZDZlMDZlMDMwOTZkNWRmZmFlNmI1MTM2NTY2YjFmNjIyZg==
+SHA1:
+  metadata.gz: 6b7c206d961ee6ebca1d4a3a79b0af5173ca6208
+  data.tar.gz: c80fcd3c7df138cea081bd3fe6e4bb8f01251230
 SHA512:
-  metadata.gz: !binary |-
-    M2QzMzU5NDE0ODc1NGNkYzNmNDkyZWI1YTNiZDBhMzUxMTNiYmZjNGUyNTQ3
-    MjViZTk3MTAyNzRmNTI3NWZjYTIzMjZlMzNmNDc3NDQ2Y2Q5MWZjNmI3NzNh
-    NTM3MGEyM2RhOWIwNWRiM2IwM2E4Yzc3YThhZjIwODUxNjc3YWY=
-  data.tar.gz: !binary |-
-    NTMwMmMzYTAyZjAwMjg0OTNjNjE0MDFlNTczMmNjYWUxNDZlZTZhMDAxOWRl
-    M2NiMTcwMGM5MjgxZjQzNmVlMDc3MjM4NzgwNmZiZjlkMzQ4ZDQ5YjMzODFh
-    ZWQ3NzA3YzBhMTMwNDEwYzM5MWJiMGE0MTAwNTdkMDZhYjE5NzM=
+  metadata.gz: 3536a5744450d61d8ebd18884dc6113391c1e9c9d23648a5d2e74a9c28a8f906243db933a335dafd1eb72eed77e6f629aafc9e3c81e86c7a6cc9d245228b2c81
+  data.tar.gz: e48850cb854f178cdebb18e7a7c328d1b1c9a8cbd799063dd4686abab15ea96928101794c692e46244e4378a82afbb082a372af97c4a01f61a661a42e37cb0bf

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+v0.2.1
+------
+
+* Drop support for ruby 1.8
+* Style - pass rubocop style checks
+
 v0.1.6
 ------
 

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012-2013 Chirantan Mitra
+Copyright (c) 2012-2015 Chirantan Mitra
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 

data/README.md

@@ -1,5 +1,8 @@
 [![Build Status](https://secure.travis-ci.org/chiku/simple_validation.png?branch=master)](https://travis-ci.org/chiku/simple_validation)
+[![Build Status](https://drone.io/github.com/chiku/simple_validation/status.png)](https://drone.io/github.com/chiku/simple_validation/latest)
+[![Gem Version](https://badge.fury.io/rb/simple_validation.svg)](http://badge.fury.io/rb/simple_validation)
 [![Code Climate](https://codeclimate.com/github/chiku/simple_validation.png)](https://codeclimate.com/github/chiku/simple_validation)
+[![Coverage Status](https://coveralls.io/repos/chiku/simple_validation/badge.png?branch=master)](https://coveralls.io/r/chiku/simple_validation?branch=master)
 
 Overview
 --------
@@ -9,7 +12,8 @@ This is very simple gem to allow custom validations in a ruby object. You are su
 Dependencies
 ------------
 
-These are no runtime dependencies for this gem. You need minitest to run the tests for this gem.
+There are no runtime dependencies for this gem. This gem runs with ruby 1.9+ or compatible versions. Ruby 1.8 isn't supported.
+Please use version 0.1.6 og simple_validation if you wish to use ruby 1.8.
 
 Installation
 ------------
@@ -79,7 +83,9 @@ another_invalid_number.value # 17
 Running tests
 -------------
 
-Clone the repository and run `rake` from the root directory.
+1. Clone the repository.
+2. run `bundle` from the root directory.
+3. run `rake` from the root directory.
 
 Contributing
 ------------

data/lib/simple_validation.rb

@@ -1,7 +1,7 @@
 # simple_validation.rb
 #
 # Created by Chirantan Mitra on 2012-11-20
-# Copyright 2012-2013. All rights reserved
+# Copyright 2012-2015. All rights reserved
 #
 # See LICENSE for license
 #
@@ -48,17 +48,18 @@
 #   invalid_number.errors # ["-1 is negative", "12 is greater than 9"]
 #   invalid_number.value # 11
 
-module SimpleValidation
+module SimpleValidation # :nodoc:
   def self.included(base) # :nodoc:
     base.class_eval do
       base.extend SimpleValidation::ClassMethods
     end
   end
 
-  module ClassMethods
+  module ClassMethods # :nodoc:
     # Add a validation method
     # The object to validate should be able to invoke the method supplied
-    # You can pass a list of conditions that the object must satisfy for the validations to run
+    # You can pass a list of conditions that the object must satisfy for
+    # the validations to run
     #
     # Example:
     #   class AlienNumber
@@ -79,11 +80,10 @@ module SimpleValidation
 
   # Run all validations associated with the object
   def validate # :nodoc:
-    unless @validated ||= false
-      @validated = true
-      self.class.validation_methods.each do |method_name, conditions|
-        send method_name if conditions.all? { |condition| send condition }
-      end
+    return if @validated ||= false
+    @validated = true
+    self.class.validation_methods.each do |method_name, conditions|
+      send method_name if conditions.all? { |condition| send condition }
     end
   end
 
@@ -95,7 +95,7 @@ module SimpleValidation
 
   # Runs all validations and returns _true_ if the object is invalid
   def invalid?
-    not valid?
+    !valid?
   end
 
   # Adds an error to the errors collection

data/lib/simple_validation/version.rb

@@ -1,10 +1,10 @@
 # version.rb
 #
 # Created by Chirantan Mitra on 2012-11-20
-# Copyright 2012-2013. All rights reserved
+# Copyright 2012-2015. All rights reserved
 #
 # See LICENSE for license
 
-module SimpleValidation
-  VERSION = "0.1.6"
+module SimpleValidation # :nodoc:
+  VERSION = '0.2.1'
 end

data/spec/simple_validation_spec.rb

@@ -1,13 +1,13 @@
 # simple_validation_spec.rb
 #
 # Created by Chirantan Mitra on 2012-11-20
-# Copyright 2012-2013. All rights reserved
+# Copyright 2012-2015. All rights reserved
 #
 # See LICENSE for license
 
-require File.expand_path("spec_helper", File.dirname(__FILE__))
+require File.expand_path('spec_helper', File.dirname(__FILE__))
 
-require File.expand_path("../lib/simple_validation", File.dirname(__FILE__))
+require File.expand_path('../lib/simple_validation', File.dirname(__FILE__))
 
 class TestEntity
   include SimpleValidation
@@ -33,7 +33,7 @@ class TestEntityWithValidation
 
   def always_invalid
     @always_invalid_invoked_count += 1
-    add_error "Always invalid"
+    add_error 'Always invalid'
   end
 end
 
@@ -44,9 +44,9 @@ class TestEntityWithConditionalValidation
   attr_reader :statement_two_invoked_count
   attr_reader :statement_three_invoked_count
 
-  validate :statement_one, :if => [:condition_one?]
-  validate :statement_two, :if => [:condition_two?]
-  validate :statement_three, :if => [:condition_one?, :condition_two?]
+  validate :statement_one, if: [:always_true?]
+  validate :statement_two, if: [:always_false?]
+  validate :statement_three, if: [:always_true?, :always_false?]
 
   def initialize
     @statement_one_invoked_count = 0
@@ -66,170 +66,152 @@ class TestEntityWithConditionalValidation
     @statement_three_invoked_count += 1
   end
 
-  def condition_one?
+  def always_true?
     true
   end
 
-  def condition_two?
+  def always_false?
     false
   end
 end
 
-describe "A validatable entity" do
-  describe "with an error" do
-    before do
-      @entity = TestEntity.new
-      @entity.add_error("An error")
-    end
+describe 'A validatable entity' do
+  describe 'with an error' do
+    subject { TestEntity.new }
+    before  { subject.add_error('An error') }
 
-    it "is invalid" do
-      @entity.invalid?.must_equal true
+    it 'is invalid' do
+      subject.invalid?.must_equal true
     end
 
-    it "is not valid" do
-      @entity.valid?.must_equal false
+    it 'is not valid' do
+      subject.valid?.must_equal false
     end
 
-    it "exposes its errors" do
-      @entity.errors.must_equal ["An error"]
+    it 'exposes its errors' do
+      subject.errors.must_equal ['An error']
     end
   end
 
-  describe "whithout any errors" do
-    before do
-      @entity = TestEntity.new
-    end
+  describe 'whithout any errors' do
+    subject { TestEntity.new }
 
-    it "is not invalid" do
-      @entity.invalid?.must_equal false
+    it 'is not invalid' do
+      subject.invalid?.must_equal false
     end
 
-    it "is valid" do
-      @entity.valid?.must_equal true
+    it 'is valid' do
+      subject.valid?.must_equal true
     end
 
-    it "exposes its errors as an empty array" do
-      @entity.errors.must_equal []
+    it 'exposes its errors as an empty array' do
+      subject.errors.must_equal []
     end
   end
 
-  describe "with custom validation" do
-    before do
-      @entity = TestEntityWithValidation.new
-    end
+  describe 'with custom validation' do
+    subject { TestEntityWithValidation.new }
 
-    describe "#valid?" do
-      before do
-        @entity.valid?
-      end
+    describe '#valid?' do
+      before { subject.valid? }
 
-      it "invokes its validations" do
-        @entity.always_valid_invoked_count.must_equal 1
-        @entity.always_invalid_invoked_count.must_equal 1
+      it 'invokes its validations' do
+        subject.always_valid_invoked_count.must_equal 1
+        subject.always_invalid_invoked_count.must_equal 1
       end
 
-      it "has errors added during validation" do
-        @entity.errors.must_equal ["Always invalid"]
+      it 'has errors added during validation' do
+        subject.errors.must_equal ['Always invalid']
       end
 
-      describe "on another #valid?" do
-        before do
-          @entity.valid?
-        end
+      describe 'on another #valid?' do
+        before { subject.valid? }
 
         it "doesn't duplicate its errors" do
-          @entity.errors.must_equal ["Always invalid"]
+          subject.errors.must_equal ['Always invalid']
         end
 
         it "doesn't re-run validation" do
-          @entity.always_valid_invoked_count.must_equal 1
-          @entity.always_invalid_invoked_count.must_equal 1
+          subject.always_valid_invoked_count.must_equal 1
+          subject.always_invalid_invoked_count.must_equal 1
         end
       end
     end
 
-    describe "#errors" do
-      before do
-        @entity.errors
-      end
+    describe '#errors' do
+      before { subject.errors }
 
-      it "invokes its validations" do
-        @entity.always_valid_invoked_count.must_equal 1
-        @entity.always_invalid_invoked_count.must_equal 1
+      it 'invokes its validations' do
+        subject.always_valid_invoked_count.must_equal 1
+        subject.always_invalid_invoked_count.must_equal 1
       end
 
-      it "has errors added during validation" do
-        @entity.errors.must_equal ["Always invalid"]
+      it 'has errors added during validation' do
+        subject.errors.must_equal ['Always invalid']
       end
 
-      describe "on another #error" do
-        before do
-          @entity.errors
-        end
+      describe 'on another #error' do
+        before { subject.errors }
 
         it "doesn't duplicate its errors" do
-          @entity.errors.must_equal ["Always invalid"]
+          subject.errors.must_equal ['Always invalid']
         end
 
         it "doesn't re-run validation" do
-          @entity.always_valid_invoked_count.must_equal 1
-          @entity.always_invalid_invoked_count.must_equal 1
+          subject.always_valid_invoked_count.must_equal 1
+          subject.always_invalid_invoked_count.must_equal 1
         end
       end
     end
   end
 
-  describe "with conditional validation" do
-    before do
-      @entity = TestEntityWithConditionalValidation.new
-    end
+  describe 'with conditional validation' do
+    subject { TestEntityWithConditionalValidation.new }
 
-    describe "#valid?" do
-      before do
-        @entity.valid?
-      end
+    describe '#valid?' do
+      before { subject.valid? }
 
-      it "invokes its validations that passes all conditions" do
-        @entity.statement_one_invoked_count.must_equal 1
+      it 'invokes its validations that passes all conditions' do
+        subject.statement_one_invoked_count.must_equal 1
       end
 
       it "doesn't invoke its validations that fail all conditions" do
-        @entity.statement_two_invoked_count.must_equal 0
+        subject.statement_two_invoked_count.must_equal 0
       end
 
       it "doesn't invoke its validations that fail conditions partially" do
-        @entity.statement_three_invoked_count.must_equal 0
+        subject.statement_three_invoked_count.must_equal 0
       end
     end
   end
 
-  describe "with already existing errors" do
+  describe 'with already existing errors' do
+    subject { TestEntityWithValidation.new }
+
     it "doesn't lose its older errors on validation" do
-      entity = TestEntityWithValidation.new
-      entity.add_error("An error")
-      entity.errors.sort.must_equal ["An error", "Always invalid"].sort
+      subject.add_error('An error')
+      subject.errors.sort.must_equal ['An error', 'Always invalid'].sort
     end
 
     it "doesn't duplicate errors" do
-      entity = TestEntityWithValidation.new
-      entity.add_error("An error")
-      entity.add_error("An error")
-      entity.errors.sort.must_equal ["Always invalid", "An error"].sort
+      subject.add_error('An error')
+      subject.add_error('An error')
+      subject.errors.sort.must_equal ['Always invalid', 'An error'].sort
     end
   end
 
-  describe "#add_error" do
-    it "can accept multiple errors" do
-      entity = TestEntity.new
-      entity.add_errors(["An error", "Another error"])
-      entity.errors.sort.must_equal ["An error", "Another error"].sort
+  describe '#add_error' do
+    subject { TestEntity.new }
+
+    it 'can accept multiple errors' do
+      subject.add_errors(['An error', 'Another error'])
+      subject.errors.sort.must_equal ['An error', 'Another error'].sort
     end
 
     it "doesn't duplicate errors" do
-      entity = TestEntity.new
-      entity.add_errors(["An error", "Another error"])
-      entity.add_errors(["An error", "Another error"])
-      entity.errors.sort.must_equal ["An error", "Another error"].sort
+      subject.add_errors(['An error', 'Another error'])
+      subject.add_errors(['An error', 'Another error'])
+      subject.errors.sort.must_equal ['An error', 'Another error'].sort
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,18 +1,23 @@
 # spec_helper.rb
 #
 # Created by Chirantan Mitra on 2012-11-20
-# Copyright 2012-2013. All rights reserved
+# Copyright 2012-2015. All rights reserved
 #
 # See LICENSE for license
 
 begin
   require 'simplecov'
+  require 'coveralls'
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new [
+    SimpleCov::Formatter::HTMLFormatter,
+    Coveralls::SimpleCov::Formatter
+  ]
   SimpleCov.start do
-    add_filter "/spec|test|vendor/"
+    add_filter '/spec|test|vendor/'
   end
 rescue LoadError
-  puts "\nPlease install simplecov to generate coverage report!\n\n"
+  puts "\nPlease install simplecov & coveralls to generate coverage report!\n\n"
 end
 
-require "minitest/autorun"
-require "minitest/spec"
+require 'minitest/autorun'
+require 'minitest/spec'

metadata

@@ -1,59 +1,86 @@
 --- !ruby/object:Gem::Specification
 name: simple_validation
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.2.1
 platform: ruby
 authors:
 - Chirantan Mitra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-10 00:00:00.000000000 Z
+date: 2015-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ! 'A simple way to validate custom ruby objects using validation defined
-  in the class.
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: 'Validate custom ruby objects using validation defined in the class
 
 '
 email:
@@ -62,11 +89,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/simple_validation/version.rb
-- lib/simple_validation.rb
+- CHANGELOG.md
 - LICENSE
 - README.md
-- CHANGELOG.md
+- lib/simple_validation.rb
+- lib/simple_validation/version.rb
 - spec/simple_validation_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/chiku/simple_validation
@@ -79,17 +106,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: simple_validation
-rubygems_version: 2.1.10
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Validations for a ruby object