simple_slug 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a288220a77771ee9ef0b7578d6831e83dfa9e8fe
-  data.tar.gz: 9ecf9b7e5d4cabc46e09aff7dc2738533eb04029
+  metadata.gz: 42fa741cbe466a58681cb3cefadc7b6d0b51b482
+  data.tar.gz: 14481b78f88550c22b0d2de99fc57cca767d18f3
 SHA512:
-  metadata.gz: 8980a48ed1d7db74e82f1baf19ba7d2b2fed3380123b9cd44028771adbbb14346b8e7b7031c8bd5d25d03da136afe5458b4f5dab380352f4a01d7189aed31b6f
-  data.tar.gz: 680168768188b1fd55f03010a2b660269347f72b1d38b5cda9dd5ec1a1fdfd0ffdcb0d5e049b71c6dee06076fd045976a80e5ba40522517dce319995c2791115
+  metadata.gz: decf2bb240b092b883d6de908ac75840d04e51bc60ffa198eea175e1e380c511f1d990b2ba200a14e84acc8ba38126f4284a1b87eea610027e6367c1a4c18d59
+  data.tar.gz: fed2de665fbd48727cb9e1f3ff1c5ae233b5bcd12c60d980a6364f03c0e30f3762f3a5e46af7a8f277917b27f550f5f7e4c92ad8ed493b8fecf275d0328aac4e

data/.travis.yml

@@ -1,4 +1,4 @@
 language: ruby
 
 rvm:
-  - 2.1.0
+  - 2.3.0

data/lib/simple_slug/model_addition.rb

@@ -8,7 +8,7 @@ module SimpleSlug
       def simple_slug(*args)
         class_attribute :simple_slug_options, instance_writer: false
         options = args.extract_options!
-        self.simple_slug_options = options.reverse_merge(slug_column: SimpleSlug.slug_column, slug_method: args)
+        self.simple_slug_options = options.reverse_merge(slug_column: SimpleSlug.slug_column, slug_method: args, max_length: SimpleSlug.max_length)
 
         include InstanceMethods
         extend ClassMethods
@@ -51,6 +51,7 @@ module SimpleSlug
 
       def simple_slug_generate(force=false)
         simple_slug = simple_slug_normalize(simple_slug_base)
+        simple_slug = simple_slug.first(simple_slug_options[:max_length]) if simple_slug_options[:max_length]
         return true if !force && simple_slug == send(simple_slug_options[:slug_column]).to_s.sub(/--\d+\z/, '')
         resolved_simple_slug = simple_slug_resolve(simple_slug)
         send "#{simple_slug_options[:slug_column]}=", resolved_simple_slug
@@ -61,8 +62,8 @@ module SimpleSlug
       end
 
       def simple_slug_normalize(base)
-        normalized = I18n.transliterate(base).parameterize('-').downcase
-        normalized.to_s =~ /\A\d+/ ? "_#{normalized}" : normalized
+        normalized = I18n.transliterate(base).parameterize(separator: '-').downcase
+        normalized.to_s =~ SimpleSlug::STARTS_WITH_NUMBER_REGEXP ? "_#{normalized}" : normalized
       end
 
       def simple_slug_resolve(slug_value)

data/lib/simple_slug/version.rb

@@ -1,3 +1,3 @@
 module SimpleSlug
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/lib/simple_slug.rb

@@ -15,6 +15,11 @@ module SimpleSlug
   mattr_accessor :slug_column
   @@slug_column = 'slug'
 
+  mattr_accessor :max_length
+  @@max_length = 240
+
+  STARTS_WITH_NUMBER_REGEXP =/\A\d+/
+
   def self.setup
     yield self
   end

data/simple_slug.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activerecord', '>= 4.0.0', '< 5.0'
-  spec.add_dependency 'i18n', '~> 0.6'
+  spec.add_dependency 'activerecord', '>= 4.0.0', '< 5.1'
+  spec.add_dependency 'i18n', '~> 0.7'
 
   spec.add_development_dependency 'bundler', '~> 1.5'
   spec.add_development_dependency 'rake'

data/spec/simple_slug/base_spec.rb

@@ -13,5 +13,9 @@ describe SimpleSlug do
     it 'exclude regexps' do
      expect( SimpleSlug.exclude_regexp).to eq /\A\d+\z/
     end
+
+    it 'max length' do
+     expect( SimpleSlug.max_length).to eq 240
+    end
   end
 end

data/spec/simple_slug/model_addition_spec.rb

@@ -75,4 +75,28 @@ describe SimpleSlug::ModelAddition do
       SlugGenerationRspecModel.friendly_find('title')
     end
   end
+
+  describe 'max length' do
+    before do
+      allow_any_instance_of(SlugGenerationRspecModel).to receive(:simple_slug_exists?).and_return(false)
+    end
+
+    after do
+      SlugGenerationRspecModel.simple_slug_options.delete(:max_length)
+    end
+
+    it 'cuts slug to max length' do
+      expect(SlugGenerationRspecModel.new(name: 'Hello' * 100).simple_slug_generate.length).to eq 240
+    end
+
+    it 'use max length from per model options' do
+      SlugGenerationRspecModel.simple_slug_options[:max_length] = 100
+      expect(SlugGenerationRspecModel.new(name: 'Hello' * 100).simple_slug_generate.length).to eq 100
+    end
+
+    it 'omit max length' do
+      SimpleSlug.max_length = nil
+      expect(SlugGenerationRspecModel.new(name: 'Hello' * 100).simple_slug_generate.length).to eq 500
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_slug
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Alex Leschenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-21 00:00:00.000000000 Z
+date: 2016-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -19,7 +19,7 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,21 +29,21 @@ dependencies:
         version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -130,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Friendly url generator with history.