simple_roles 0.0.8 → 0.0.9

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
+  - 1.8.7
   - 1.9.3
 script: "rake"
 gemfile:

data/CHANGELOG.md

@@ -1,8 +1,12 @@
-# master
+# CHANGELOG
 
-...
+## 0.0.9
 
-# Version 0.0.6
+### Changed
+
+* Many strategy (persistence): setter `roles=` does not call save anymore, so it does not persist new records! 
+
+## 0.0.6
 
 ### Added
 
@@ -16,6 +20,6 @@
 
 * Removed RolesArray presenter in "Many" strategy
 
-# Versions <= 0.0.5 
+## Prior to 0.0.6 
 
 Long-long history here undocumented...

data/README.md

@@ -2,7 +2,7 @@
 
 SimpleRoles is a Rails Engine providing simple Role System for any Rails 3 app. 
 
-Initially, it was created as demo role-system to accompany [CanTango gem](https://github.com/kristianmandrup/cantango) initial installiation and usage, and intended to be very easy to setup & use.
+Initially it was created as demo role-system to accompany [CanTango gem](https://github.com/kristianmandrup/cantango) initial installiation and usage, and intended to be very easy to setup & use.
 
 Now it is good to be used as a real role system inspite of or due to its almost maximum simplicity.
 
@@ -12,7 +12,10 @@ Now it is good to be used as a real role system inspite of or due to its almost
 
 ### Prerequisites
 
-SimpleRoles requires you have have User model in your Rails app. That's all.
+* Ruby 1.8.7 or 1.9.3
+* Rails 3
+* ActiveRecord with MySQL or SQLite
+* ```User``` model in your Rails app.
 
 ### It is a Gem
 
@@ -24,7 +27,7 @@ gem 'simple_roles'
 
 ### Set up valid roles you're gonna have in your app and choose a Strategy. 
 
-Create file simple_roles.rb in config/initializers and write there:
+Create file simple_roles.rb in config/initializers and write in it:
 
 ```ruby
 # config/initializers/simple_roles.rb
@@ -47,7 +50,7 @@ end
 Now it is time to choose beetween two strategies possible:
 
 * One - each of your users has only one role. It is the most common
-  choise for the most of the apps.
+  choice for the most of the apps.
 * Many - your user can be _:editor_ and _:curator_ and _:instructor_ all
   at the same time. More rare one, setup is slightly more complex.
 
@@ -61,7 +64,6 @@ class CreateUsers < ActiveRecord::Migration
     create_table(:users) do |t|
       # ...
       t.string :role
-      # ... 
     end
   end
 

data/Rakefile

@@ -42,8 +42,6 @@ APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
 
 load 'rails/tasks/engine.rake'
 
-Bundler::GemHelper.install_tasks
-
 require 'rspec/core'
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec) do |spec|

data/lib/simple_roles/many/persistence.rb

@@ -18,8 +18,6 @@ module SimpleRoles
         rolez.to_symbols!.flatten!
 
         super retrieve_roles(rolez)
-
-        save!
       end
 
       private

data/lib/simple_roles/many/roles_methods.rb

@@ -52,7 +52,6 @@ module SimpleRoles
       def has_roles? *rolez
         rolez.flatten!
 
-        # rrr roles
         rolez.all? do |role|
           roles.include? role
         end

data/lib/simple_roles/version.rb

@@ -1,3 +1,3 @@
 module SimpleRoles
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/simple_roles.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "simple_roles"
-  s.version = "0.0.8"
+  s.version = "0.0.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["stanislaw"]
-  s.date = "2012-06-28"
+  s.date = "2013-02-22"
   s.description = "Simple Role System for Rails Apps"
   s.email = "s.pankevich@gmail.com"
   s.extra_rdoc_files = [
@@ -23,7 +23,6 @@ Gem::Specification.new do |s|
     "MIT-LICENSE",
     "README.md",
     "Rakefile",
-    "VERSION",
     "app/assets/images/simple_roles/.gitkeep",
     "app/assets/javascripts/simple_roles/.gitkeep",
     "app/assets/stylesheets/simple_roles/.gitkeep",
@@ -156,7 +155,7 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/stanislaw/simple_roles"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.19"
+  s.rubygems_version = "1.8.24"
   s.summary = "Rails Engine providing Role System for Rails apps"
 
   if s.respond_to? :specification_version then

data/spec/simple_roles/many_spec.rb

@@ -35,11 +35,11 @@ describe SimpleRoles::Many do
 
     it "#has_role?, #has_roles?" do
       subject.roles = [:admin]
-      
+
       subject.has_role?(:admin).should be_true
       subject.has_role?(:admin, :user).should be_false
       subject.has_roles?(:editor).should be_false
-      
+
       subject.roles = [ :admin, :user ]
 
       subject.has_role?(:admin, :user).should be_true
@@ -75,15 +75,29 @@ describe SimpleRoles::Many do
       subject.roles = ['user', 'editor']
       subject.roles.should == Array.new([:user, :editor])
     end
-    
+
+    it "#roles= should not persist the user when being set" do
+      unsaved_user = build :user
+      unsaved_user.roles = [:admin]
+      unsaved_user.roles.should == [:admin]
+      unsaved_user.should_not be_persisted
+    end
+
+    it "#roles= should store the roles to be saved when user is persisted" do
+      unsaved_user = build :user
+      unsaved_user.roles = [:admin]
+      unsaved_user.save!
+      unsaved_user.reload.roles.should == [:admin]
+    end
+
     it "#remove_roles should remove roles" do
       subject.roles = [ :admin, :user, :editor ]
 
       subject.roles.should == Array.new([:admin, :user, :editor])
- 
+
       subject.remove_roles :admin
       subject.roles.should == Array.new([:user, :editor])
-  
+
       subject.remove_roles :admin, :user, :editor
       subject.roles.should == Array.new([])
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_roles
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-28 00:00:00.000000000 Z
+date: 2013-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: require_all
@@ -201,7 +201,6 @@ files:
 - MIT-LICENSE
 - README.md
 - Rakefile
-- VERSION
 - app/assets/images/simple_roles/.gitkeep
 - app/assets/javascripts/simple_roles/.gitkeep
 - app/assets/stylesheets/simple_roles/.gitkeep
@@ -345,7 +344,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -339353645
+      hash: -1674272083089527838
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -354,7 +353,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.19
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Rails Engine providing Role System for Rails apps

data/VERSION

@@ -1 +0,0 @@
-0.0.5