simple_record 1.1.28 → 1.1.29

data/lib/simple_record.rb

@@ -600,17 +600,25 @@ module SimpleRecord
         def save(options={})
             #    puts 'SAVING: ' + self.inspect
             clear_errors
+            # todo: decide whether this should go before pre_save or after pre_save? pre_save dirties "updated" and perhaps other items due to callbacks
+            if options[:dirty] # Only used in simple_record right now
+                puts '@dirty=' + @dirty.inspect
+                return true if @dirty.size == 0 # Nothing to save so skip it
+                options[:dirty_atts] = @dirty
+            end
             is_create = self[:id].nil?
             ok = pre_save(options)
             if ok
                 begin
                     #        puts 'is frozen? ' + self.frozen?.to_s + ' - ' + self.inspect
-                    if options[:dirty] # Only used in simple_record right now
-                        return true if @dirty.size == 0 # Nothing to save so skip it
-                        options[:dirty_atts] = @dirty
-                    end
+#                    if options[:dirty] # Only used in simple_record right now
+#                        puts '@dirty=' + @dirty.inspect
+#                        return true if @dirty.size == 0 # Nothing to save so skip it
+#                        options[:dirty_atts] = @dirty
+#                    end
                     to_delete = get_atts_to_delete # todo: this should use the @dirty hash now
 #                    puts 'done to_delete ' + to_delete.inspect
+                    SimpleRecord.stats.puts += 1
                     if super(options)
 #          puts 'SAVED super'
                         self.class.cache_results(self)

data/test/test_simple_record.rb

@@ -148,8 +148,15 @@ class TestSimpleRecord < Test::Unit::TestCase
         mm2.name = "Travis 2"
         mm2.save(:dirty=>true)
 
-        # todo: how do we assert this?  perhaps change a value directly in sdb and see that it doesn't get overwritten
+        # todo: how do we assert this?  perhaps change a value directly in sdb and see that it doesn't get overwritten.
+        # or check stats and ensure only 1 attribute was put
 
+        # Test to ensure that if an item is not dirty, sdb doesn't get hit
+        puts SimpleRecord.stats.puts.to_s
+        SimpleRecord.stats.clear
+        mm2.save(:dirty=>true)
+        puts SimpleRecord.stats.puts.to_s
+        assert SimpleRecord.stats.puts == 0
     end
 
     # http://api.rubyonrails.org/classes/ActiveRecord/Dirty.html#M002136

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: simple_record
 version: !ruby/object:Gem::Version 
-  version: 1.1.28
+  version: 1.1.29
 platform: ruby
 authors: 
 - Travis Reeder
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-05 00:00:00 -08:00
+date: 2009-11-06 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency