simple_phone_number 0.1.8 → 0.1.9

data/Rakefile

@@ -1,8 +1,20 @@
 require 'rubygems'
 require 'rake'
+require 'rake/testtask'
 require 'echoe'
 
-Echoe.new('simple_phone_number', '0.1.8') do |p|
+desc 'Default: run unit tests.'
+task :default => :test
+
+desc 'Test the simple_phone_number plugin.'
+Rake::TestTask.new(:test) do |t|
+  t.libs << 'lib'
+  t.libs << 'test'
+  t.pattern = 'test/**/*_test.rb'
+  t.verbose = true
+end
+
+Echoe.new('simple_phone_number', '0.1.9') do |p|
   p.description        = "Validate and set phone number format"
   p.url                = "http://github.com/akennedy/simple_phone_number"
   p.author             = 'Andrew Kennedy'

data/simple_phone_number.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{simple_phone_number}
-  s.version = "0.1.8"
+  s.version = "0.1.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Andrew Kennedy"]
@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.description = %q{Validate and set phone number format}
   s.email = %q{andrew@jackrussellsoftware.com}
   s.extra_rdoc_files = ["README.md", "lib/simple_phone_number.rb"]
-  s.files = ["Manifest", "README.md", "Rakefile", "init.rb", "lib/simple_phone_number.rb", "simple_phone_number.gemspec"]
+  s.files = ["Manifest", "README.md", "Rakefile", "init.rb", "lib/simple_phone_number.rb", "simple_phone_number.gemspec", "test/attributes_test.rb", "test/test_helper.rb", "test/validations_test.rb"]
   s.homepage = %q{http://github.com/akennedy/simple_phone_number}
   s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Simple_phone_number", "--main", "README.md"]
   s.require_paths = ["lib"]
@@ -19,6 +19,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = %q{1.3.6}
   s.signing_key = %q{/Users/andrew/gems/gem-private_key.pem}
   s.summary = %q{Validate and set phone number format}
+  s.test_files = ["test/attributes_test.rb", "test/test_helper.rb", "test/validations_test.rb"]
 
   if s.respond_to? :specification_version then
     current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION

data/test/attributes_test.rb

@@ -0,0 +1,71 @@
+require 'test_helper'
+
+class AttributesTest < Test::Unit::TestCase
+  context 'Setting simple_phone_number' do
+    setup do
+      @attribute_names = %w(phone_number telephone phone_not_validated phone_with_validation_options phone_validated_elsewhere)
+      @user = User.new(:name => 'Test User')
+      
+      # generates a phone number in the form: nnn-nnn-nnnn
+      def generate_phone_number
+        "#{(x = ('000'..'999').to_a)[rand(x.length - 1)]}-#{x[rand(x.length - 1)]}-#{(y = ('0000'..'9999').to_a)[rand(y.length - 1)]}"
+      end
+    end
+
+    should 'add attributes names to the phone_number_attributes array' do
+      assert_same_elements @user.class.phone_number_attributes.map {|a| a.to_s}, @attribute_names
+    end
+
+    should 'automatically use :phone_number if no attribute names are given' do
+      %w(phone_number).each do |name|
+        assert_contains   @user.class.phone_number_attributes, name.to_sym
+        assert_respond_to @user, "#{name}="
+        assert_respond_to @user, name
+        assert_nothing_raised do
+          @user.send(name)
+        end
+      end
+    end
+    
+    should 'create a setter method' do
+      @attribute_names.each do |name|
+        assert_respond_to @user, "#{name}="
+      end
+    end
+    
+    should 'create a getter method' do
+      @attribute_names.each do |name|
+        assert_respond_to @user, name
+      end
+    end
+          
+    should 'properly set a phone number using setter method' do
+      @attribute_names.each do |name|
+        assert_send [@user, "#{name}=", number = generate_phone_number]
+        assert_equal number.gsub(/^(?:\+?1[-. ]?)?\(?([0-9]{3})\)?[-. ]?([0-9]{3})[-. ]?([0-9]{4})$/, '\1-\2-\3'), @user.send("#{name}")
+      end
+    end
+    
+    should 'properly return a phone number using getter method' do
+      # need to run the setters again…
+      @attribute_names.each do |name|
+        assert_send [@user, "#{name}=", generate_phone_number]
+      end
+      
+      @attribute_names.each do |name|
+        assert_match /^([0-9]{3})[-]([0-9]{3})[-]([0-9]{4})$/, @user.send(name)
+      end
+    end
+    
+    should 'return the "database stored" value if argument is passed to getter' do
+      # need to run the setters again…
+      @attribute_names.each do |name|
+        assert_send [@user, "#{name}=", generate_phone_number]
+      end
+      
+      @attribute_names.each do |name|
+        assert_match /^([0-9]{3})[-]([0-9]{3})[-]([0-9]{4})$/, @user.send(name)
+      end
+    end
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1,11 @@
+$: << File.join(File.dirname(__FILE__), '..', 'lib')
+$: << File.dirname(__FILE__)
+
+require 'rubygems'
+require 'test/unit'
+require 'active_record'
+require 'shoulda'
+require 'action_view'
+require 'simple_phone_number'
+require 'schema'
+begin; require 'redgreen'; rescue LoadError; end

data/test/validations_test.rb

@@ -0,0 +1,92 @@
+require 'test_helper'
+
+class ValidationsTest < Test::Unit::TestCase
+  context 'Setting simple_phone_number or simple_fax_number' do
+    setup do
+      @attribute_names      = %w(phone_number telephone phone_not_validated phone_with_validation_options phone_validated_elsewhere)
+      @not_validated        = %w(phone_not_validated)
+      @validated_on_update  = %w(phone_with_validation_options)
+      @auto_validated       = @attribute_names - @not_validated - @validated_on_update
+      
+      @user = User.new(:name => 'Test User')
+  
+      # generates a phone number in the form: nnn-nnn-nnnn
+      def generate_phone_number
+        "#{(x = ('000'..'999').to_a)[rand(x.length - 1)]}-#{x[rand(x.length - 1)]}-#{(y = ('0000'..'9999').to_a)[rand(y.length - 1)]}"
+      end
+      
+      def set_fields(fields)
+        fields.each do |name|
+          @user.send("#{name}=", generate_phone_number)
+        end
+      end
+    end
+
+    should 'automatically add a validation unless told not to' do
+      @auto_validated.each do |name|
+        assert_equal  false, @user.valid?
+        assert        @user.errors[name.to_s].any?
+        
+        @user.send("#{name}=", 'gibberish.')
+        assert_equal  false, @user.valid?
+        assert        @user.errors[name.to_s].any?
+        
+        @user.send("#{name}=", generate_phone_number)
+      end
+      assert @user.save
+    end
+
+    should 'not validate if told not to' do
+      set_fields @auto_validated
+      
+      @not_validated.each do |name|
+        assert  @user.valid?
+        assert  @user.errors.empty?
+        
+        @user.send("#{name}=", 'gibberish.')
+        @user.valid?
+        assert  @user.errors.empty?
+      end
+      assert @user.save
+    end
+
+    should 'apply and adhere to validation-specific options set for the default validation' do
+      set_fields @auto_validated + ['fax_validated_elsewhere']
+      
+      # test that validation fails on :update
+      assert @user.save
+      assert_equal false, @user.valid?
+      assert @user.errors[:phone_with_validation_options]
+      
+      # test invalid data
+      @user.phone_with_validation_options = 'gibberish.'
+      assert_equal false, @user.valid?
+      assert @user.errors[:phone_with_validation_options].any?
+      
+      # test our custom error message
+      assert_equal ['is so not a valid phone number!'], @user.errors[:phone_with_validation_options]
+      
+      # test our custom error :if option
+      @user.name = nil
+      assert @user.valid?
+      
+      # test saving valid record
+      @user.name = 'Test User'
+      @user.phone_with_validation_options = generate_phone_number
+      assert @user.save
+    end
+
+    should 'respond to validates_simple_phone_number and adhere to specified options' do
+      set_fields @auto_validated - ['phone_validated_elsewhere']
+      
+      # test our custom error message
+      assert_equal false, @user.valid?
+      assert @user.errors[:phone_validated_elsewhere].any?
+      assert_equal ["didn't pass validations elsewhere"], @user.errors[:phone_validated_elsewhere]
+      
+      # test saving valid record
+      @user.phone_validated_elsewhere = generate_phone_number
+      assert @user.save
+    end
+  end
+end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 8
-  version: 0.1.8
+  - 9
+  version: 0.1.9
 platform: ruby
 authors: 
 - Andrew Kennedy
@@ -91,5 +91,7 @@ rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Validate and set phone number format
-test_files: []
-
+test_files: 
+- test/attributes_test.rb
+- test/test_helper.rb
+- test/validations_test.rb