simple_params 1.5.1 → 1.5.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NjI2NzEzZDRlYTRkMjRmMDY2ZjJjYmMxNzBjMWJlNDhkZTQzYzExNg==
+    NDE2OTkyZTFiMjYzYTQ1NmVlNzI4OWUyNzM3MGMyZjEyNzRjOGUyNg==
   data.tar.gz: !binary |-
-    YjQ5OTg0NmVjNWFkNjAzNTA1ODI1ZDMzMDkwMjg4YjZmNjM3NmVhYg==
+    NTMxMGU3ZWE5NTY4ZmI2OGMyZDk0ZjZiOTIxNGJmMmI0NjgxNjRhMw==
 SHA512:
   metadata.gz: !binary |-
-    YzNhMzcxZGM2MTM3MTkxOWViODM1Mjk2YWUyYWEzMzViYmY0MDE4NTFkNTRk
-    MWU5NDNhY2I5NWQyMDNiYTcwM2Y4NThjYTVhZjYwN2Y2YzNlNGQ2ZmRmOGJh
-    NjIyODVhYmJkMjBiZDUyYjFhOTAyZTYzZWQyYjQ3OTg3MmQ0MWY=
+    OTJmMzRhNTFlOWI0YjAwZjU1N2E1NDhjYTkzZWJjZTczMWMxODQyOWRkNmYw
+    NjRhZjU2OTNlNDI4MzAwZGM0ZTJiMTNhMWEyMDEzODE0MzBkZWMxZmE0YTA0
+    ZjI0MmJhNGY1MWZkZGE2NTQwMDZkMWZkNGQyNGE1NzE3YTdhZTY=
   data.tar.gz: !binary |-
-    ZDhjM2Y4NDhlZTQyODY5NTFjY2RhNTY2YWY1MGIzMGM0ZDNlM2VjYTg0OGI4
-    YmUzYTI5MDU2NTE2ZGY2MThkYWY2NjI1MjNkZjM3ZTFkNDUwNDVmYzkwNjQy
-    ZTk3NTQxZDZjMmZiMDZlZDE3OWFjNDAzNDI5OTc0MzljZWEzOWY=
+    ZGZkZmI0NmI4NzY3MWJhYWQwNjRiZDk1NDBkOWNjNDk2ODc3OTFmYzQwYzIz
+    N2JmNDk5MTZkYzZiNDE5MjI2ZDJhYTc5ZTFlODk3MmJjMjllZTA5NzBmNDYy
+    NzY2NTJhNWMzZTc5N2FlMzRiM2YxMWRlNjUwZjkxM2U0OTJjOTk=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    simple_params (1.5.0)
+    simple_params (1.5.1)
       activemodel (>= 3.0, < 5.0)
       shoulda-matchers (~> 2.8)
       virtus (>= 1.0.0)

data/lib/simple_params/concerns/rails_helpers.rb

@@ -61,6 +61,7 @@ module SimpleParams
           send("#{name}=", value)
         end
 
+        # TODO: This needs more testing
         singular_key = singularized_key(name)
         define_method("build_#{singular_key}") do |value={}|
           klass.new(value, self, name)

data/lib/simple_params/params.rb

@@ -75,12 +75,12 @@ module SimpleParams
           else
             # This logic basically sets the nested class to an instance of itself, unless
             #  it is optional.
-            init = if opts[:optional]
-              nil
+            init_value = if opts[:optional]
+              klass.hash? ? nil : []
             else 
               klass_instance = klass.new({}, self, name)
+              klass.hash? ? klass_instance : [klass_instance]
             end
-            init_value = klass.hash? ? init : [init]
             instance_variable_set("@#{name}", init_value)
           end
         end

data/lib/simple_params/version.rb

@@ -1,3 +1,3 @@
 module SimpleParams
-  VERSION = "1.5.1"
+  VERSION = "1.5.2"
 end

data/spec/acceptance_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 
 class AcceptanceParams < SimpleParams::Params
+  with_rails_helpers
   allow_undefined_params
   param :reference, type: :object, optional: true
   param :name
@@ -24,18 +25,15 @@ class AcceptanceParams < SimpleParams::Params
   end
 
   nested_array :dogs do
-    with_rails_helpers
     param :name
     param :age, type: :integer, validations: { inclusion: { in: 1..20 } }
   end
 
   nested_array :cats, with_ids: true do
-    with_rails_helpers
     param :name
   end
 
   nested_array :birds, optional: true, with_ids: true do
-    with_rails_helpers
     param :name
   end
 
@@ -73,6 +71,13 @@ describe SimpleParams::Params do
     end
   end
 
+  describe "rails_helpers", rails_helpers: true do
+    it "can build optional class" do
+      klass = AcceptanceParams.new.build_phone
+      klass.should be_a(AcceptanceParams::Phone)
+    end
+  end
+
   describe "original_params", original_params: true do
     it "returns symbolized params hash" do
       params = AcceptanceParams.new(name: "Tom", address: { "street" => "1 Main St."} )
@@ -120,7 +125,8 @@ describe SimpleParams::Params do
           city: nil,
           zip_code: nil,
           state: "North Carolina",
-          company: nil
+          company: nil,
+          _destroy: false
         },
         phone: nil,
         dogs: [
@@ -160,6 +166,33 @@ describe SimpleParams::Params do
       name = nested.class.name
       name.should eq("AcceptanceParams::Address")
     end
+
+    describe "params assignment" do
+      let(:params) do
+        {
+          dogs: [
+            { name: "Max", age: 12 },
+            { name: "Spot", age: 4 },
+            { name: "Pants", age: 6, _destroy: true },
+          ],
+          cats: {
+            "0" => { name: "Paws" },
+            "1" => { name: "Turbo", _destroy: "1" },
+            "2" => { name: "Felix" }
+          }
+        }
+      end
+
+      subject { AcceptanceParams.new(params) }
+
+      it "builds correct number of dogs" do
+        subject.dogs.count.should eq(2)
+      end
+
+      it "builds correct number of cats" do
+        subject.cats.count.should eq(2)
+      end
+    end
   end
 
   describe "accessors", accessors: true do
@@ -233,10 +266,10 @@ describe SimpleParams::Params do
       params.attributes.should eq([:reference, :name, :date_of_birth, :current_time, :age, :color, :sibling_names, :address, :phone, :dogs, :cats, :birds])
     end
 
-    it "returns array of attribute symbols for nested class", failing: true do
+    it "returns array of attribute symbols for nested class" do
       params = AcceptanceParams::Address.new({}, nil, "address")
       params.parent_attribute_name.should eq(:address)
-      params.attributes.should eq([:street, :city, :zip_code, :state, :company])
+      params.attributes.should eq([:street, :city, :zip_code, :state, :company, :_destroy])
     end
 
     it "initializes attributes correctly" do
@@ -352,31 +385,31 @@ describe SimpleParams::Params do
         params.errors[:dogs][1][:age].should eq(["is not included in the list", "can't be blank"])
       end
 
-      # it "initializes birds as empty", failing: true do
-      #   params = AcceptanceParams.new
-      #   params.birds.should be_empty
-      # end
-
-      # it "allows absense of optional params", failing: true do
-      #   params = AcceptanceParams.new(
-      #     name: "test",
-      #     address: {
-      #       street: "1 Main St.",
-      #       city: "Asheville",
-      #       zip_code: "28806"
-      #     },
-      #     dogs: [
-      #       { name: "spot", age: 13 }
-      #     ],
-      #     cats: {
-      #       "0" => {
-      #         name: "Purr"
-      #       }
-      #     },
-      #   )
-      #   params.birds.should be_empty
-      #   params.should be_valid
-      # end
+      it "initializes birds as nil" do
+        params = AcceptanceParams.new
+        params.birds.should be_empty
+      end
+
+      it "allows absense of optional params" do
+        params = AcceptanceParams.new(
+          name: "test",
+          address: {
+            street: "1 Main St.",
+            city: "Asheville",
+            zip_code: "28806"
+          },
+          dogs: [
+            { name: "spot", age: 13 }
+          ],
+          cats: {
+            "0" => {
+              name: "Purr"
+            }
+          },
+        )
+        params.birds.should be_empty
+        params.should be_valid
+      end
     end
 
     describe "#validate!" do
@@ -603,9 +636,11 @@ describe SimpleParams::Params do
           param :zip_code, String, desc: '', required: false
           param :state, String, desc: '', required: false
           param :company, String, desc: '', required: false
+          param :_destroy, Boolean, desc:'', required: false
         end
         param :phone, Hash, desc: '', required: false do
           param :phone_number, String, desc: '', required: true
+          param :_destroy, Boolean, desc:'', required: false
         end
         param :dogs, Array, desc: '', required: true do
           param :name, String, desc: '', required: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_params
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - brycesenz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-02 00:00:00.000000000 Z
+date: 2015-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel