simple_params 1.4.0 → 1.4.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    N2FhZWYzZTAzNmJhMmE3YjYxOThlNDhkMzM5NzlhYmQxNTMxOTQ5OQ==
+    ZjFhZmVhOTFiODE2NWY3MjJkYjA1OTczYWQ3ZjMxNGRmMWQ5YzAyZQ==
   data.tar.gz: !binary |-
-    OWQ3NmQwYzA2OGZlNTNkNTM4MTY3ZjQ5M2FjNDU3YWU0ODRkZTE5ZQ==
+    ZGUxNTExNTRmYWUzMmYxNDA2MzQyNDkxNTllNTU3OTU4MDFiZjJhMw==
 SHA512:
   metadata.gz: !binary |-
-    ZDQwMDY2MzZjMTAxNmI1OTAzM2Q5M2VjY2M3YjgzY2E5NzI4ODM1Njk3YTYw
-    MzQxZWI0N2VjNDg3YTA3Y2MxOGVlMGMxYWM1OWJlNGQ2MzJhYjM1MzExMjU2
-    YWEwMTk5M2Q4NmE1ZTY0YWJkZWFmZjIyY2JkNWE4MWViYWQ1Y2I=
+    MjRlMGQzZjc0OWM4NDQwMjMzNGZlNjIxODMzNWRiYWU3ZDhiYTBkZDA0MjM4
+    NzM4OTRkM2M2ZmZiMGU2NWFlMTllYjA0ZThiMTc5NDgyMjhhMDQ5NTJkZTkz
+    YmI5MzZlYzlmODkxM2E4ZGU1MTk2YjcyMjgzMDQyY2Q3M2VhM2Y=
   data.tar.gz: !binary |-
-    NzQ1N2U2MWMxNTg4OGQwMWViYmZlOTFlOGQ2ZjMyNjQyY2JjMDJlZDYwZDBm
-    NjJiNWQzZDdkMzYxMThlYTViNDMyNTM3NGNlZjc1ZmQ2Yjg3YWI4MzBiMmVi
-    MTU5N2QyMTM1ZWFmMDQwZGQ3OGZmMDRiMzJhODc2NzE5ODJlNWE=
+    ZTM0ZjlmMTJmNjI3MWE0NzIzYmM0NzljZjkyOTI0MDYzYTE3YWQ1ZTVlMmVh
+    ZjhlMWQ3ZGNlMmE4N2UyMTk0MjhlZjAyNmQxNWI0NjIxY2U4MjNjNzIyOWUx
+    ZmExMjgxNjc1YjY4YzQ5Yjc1NDU3NGEyYmZmNTJjYjkyOGIyNTA=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    simple_params (1.3.6)
+    simple_params (1.4.0)
       activemodel (>= 3.0, < 5.0)
       shoulda-matchers (~> 2.8)
       virtus (>= 1.0.0)

data/lib/simple_params/params.rb

@@ -97,7 +97,16 @@ module SimpleParams
                 array
               end
             else
-              initializer.map { |val| klass.new(val, self) }
+              initializer.map do |val|
+                destroyed = if val.has_key?(:_destroy)
+                  val[:_destroy]
+                elsif val.has_key?("_destroy")
+                  val["_destroy"]
+                end
+                unless [true, "1"].include?(destroyed)
+                  klass.new(val, self)
+                end
+              end.compact
             end
           else
             klass.new(initializer, self)

data/lib/simple_params/version.rb

@@ -1,3 +1,3 @@
 module SimpleParams
-  VERSION = "1.4.0"
+  VERSION = "1.4.1"
 end

data/spec/acceptance_spec.rb

@@ -24,6 +24,7 @@ class AcceptanceParams < SimpleParams::Params
   end
 
   nested_array :dogs do
+    with_rails_helpers
     param :name
     param :age, type: :integer, validations: { inclusion: { in: 1..20 } }
   end
@@ -114,7 +115,8 @@ describe SimpleParams::Params do
         dogs: [
           {
             name: "Spot",
-            age: 8
+            age: 8,
+            _destroy: false
           }
         ],
         cats: [
@@ -423,6 +425,52 @@ describe SimpleParams::Params do
         end
       end
 
+      context "with destroyed dog" do
+        let(:params) do
+          {
+            name: "Tom", 
+            age: 41,
+            address: { 
+              street: "1 Main St.",
+              city: "Chicago",
+              state: "IL",
+              zip_code: 33440
+            },
+            phone: {
+              phone_number: "234"
+            },
+            dogs: [
+              {
+                name: "Spot",
+                age: 6
+              },
+              {
+                name: "Max",
+                age: 4,
+                _destroy: true
+              }
+            ],
+            cats: [
+              "0" => {
+                name: "Fuzzball"
+              }
+            ]
+          }
+        end
+
+        it "is valid after multiple times" do
+          acceptance_params = AcceptanceParams.new(params)
+          acceptance_params.valid?
+          acceptance_params.should be_valid
+          acceptance_params.should be_valid
+        end
+
+        it "only assigns 1 dog" do
+          acceptance_params = AcceptanceParams.new(params)
+          acceptance_params.dogs.count.should eq(1)
+        end
+      end
+
       context "with destroyed cat" do
         let(:params) do
           {
@@ -462,7 +510,7 @@ describe SimpleParams::Params do
           acceptance_params.should be_valid
         end
 
-        it "only assigns 1 cat", failing: true do
+        it "only assigns 1 cat" do
           acceptance_params = AcceptanceParams.new(params)
           acceptance_params.cats.count.should eq(1)
         end
@@ -514,6 +562,7 @@ describe SimpleParams::Params do
         param :dogs, Array, desc: '', required: true do
           param :name, String, desc: '', required: true
           param :age, Integer, desc: '', required: true
+          param :_destroy, Boolean, desc:'', required: false
         end
         param :cats, Array, desc:'', required: true do
           param :name, String, desc:'', required: true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_params
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - brycesenz