simple_params 1.1.1 → 1.1.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZjljZmQxYWFkNjdhMzhhNDNiOWRmMDk3Yjg2Y2UxNGZhNDUxMTQzNQ==
+    ZGYzNDdhM2YxYjQzNzI3NWEzOTlkMGRjNDA2M2NiN2NmZjA2ZGFjOQ==
   data.tar.gz: !binary |-
-    MDBlNzRiODJmY2I5YjBmOTQ3NWI5MTRhZTE0ODRjMjY5ZmYzYmUwNA==
+    OGM2ODA5ZWI2ZTVjMDFlY2EwMzhmY2Y2ODM0ZTY5MmY5YjFmYTA0MA==
 SHA512:
   metadata.gz: !binary |-
-    NzM0ZTZmNzI4MmFhMTA4ZTk2ZDYxYTYyNjg1ZmFlYzRhNzc1ZmZkM2Q5ZTJh
-    MWM4Yjg5NGFiZDY5MGEwNDg1YWI2MmJiZDk5ZDRiM2MwYzQ3MjQyYWMyN2Vk
-    NTZkY2Q0Y2I0MTYwYjBjZWQyOGZkYzY5NjhjZmU5Njg5N2JkMjI=
+    YWQzNjllOTcyYjAxNDM5NWNhYmI0ZjM0ZmVlMjFlMGE4MWU0ZjIwMDIzNmFi
+    ZmNmZjY1NDYyMTg5MDYyYjhjZDI5ZjE0MDU5MmI2YjUwYzBjMjg3M2Q1NzVi
+    MzcxMDFlOWY3MDAwZjM1MGNhMGI3ZDJjZWFjOTg2YmYyMGVjYTE=
   data.tar.gz: !binary |-
-    OTU4OGJkNDUxNTRmYTczNWUwYWFkMjgzMGZmN2Q1YjY0ZGRkMjY5YzNlZjQ4
-    OWIyMGEzYjY0Y2QwMjhjMDgxMjFiNjBhZDk0MTgyYjFkYmUyODcxYTY3MTgx
-    MDkwYjAzMTRkZjE4OTk2ZjM1ZmZiYWQ0NGQzMDA1Mzg5M2MzYWI=
+    YTRmNmQ0YzdmMmRjYWNlOTU5ZGNmZDJjZWNjOTRkZDEyZGNkOGUzOGNjZTRk
+    MTAyMGE0ZjlmNWU2MDJjOGNjOGVkOTFhMjc4MjM2NGY3NmZhY2JlNzc3OWM5
+    MWJjZTgwNThjMTg3NjBmNzFjN2ViOGIzYTI5M2VlYzc5MTQzYjk=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    simple_params (1.1.0)
+    simple_params (1.1.1)
       activemodel (>= 3.0, < 5.0)
       shoulda-matchers (~> 2.8)
       virtus (>= 1.0.0)

data/lib/simple_params/validations.rb

@@ -10,16 +10,24 @@ module SimpleParams
       current_context, self.validation_context = validation_context, context
       errors.clear
       run_validations!
+
+      nested_hash_validations = []
       nested_hashes.each do |key, value|
         nested_class = send("#{key}") 
-        nested_class.valid?
+        nested_hash_validations << nested_class.valid?
       end
 
+
+      nested_array_validations = []
       nested_arrays.each do |key, array|
         nested_array = send("#{key}") 
-        nested_array.each { |a| a.valid? }
+        nested_array_validations = nested_array.map { |a| a.valid? }
       end
-      errors.empty?
+
+      errors.empty? && 
+      nested_hash_validations.all? &&
+      nested_array_validations.flatten.all?
+
     ensure
       self.validation_context = current_context
     end

data/lib/simple_params/version.rb

@@ -1,3 +1,3 @@
 module SimpleParams
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/spec/acceptance_spec.rb

@@ -184,7 +184,6 @@ describe SimpleParams::Params do
     end
   end
 
-
   describe "attributes", attributes: true do
     it "returns array of attribute symbols" do
       params = AcceptanceParams.new
@@ -279,7 +278,7 @@ describe SimpleParams::Params do
       params.errors[:color].should eq(["is not included in the list"])
     end
 
-    describe "nested params", nested: true do
+    describe "nested hashes", nested_hash: true do
       it "validates presence of required param" do
         params.should_not be_valid
         params.errors[:address][:street].should eq(["can't be blank"])
@@ -291,6 +290,19 @@ describe SimpleParams::Params do
       end
     end
 
+    describe "nested arrays", nested_array: true do
+      it "validates presence of required param" do
+        params = AcceptanceParams.new(
+          dogs: [
+            { name: "Max", age: 11 },
+            { name: "Spot" }
+          ]
+        )
+        params.should_not be_valid
+        params.errors[:dogs][1][:age].should eq(["is not included in the list", "can't be blank"])
+      end
+    end
+
     describe "#validate!" do
       let(:params) { AcceptanceParams.new }
 

data/spec/params_spec.rb

@@ -83,7 +83,7 @@ describe SimpleParams::Params do
     end
   end
 
-  describe "accessors", accessors: true do
+  describe "raw_values", raw_values: true do
     let(:params) { DummyParams.new(dogs: [{}]) }
 
     it "can access raw values for non-formatted param" do
@@ -170,35 +170,63 @@ describe SimpleParams::Params do
   end
 
   describe "validations", validations: true do
-    let(:params) do
-      DummyParams.new(
-        name: nil,
-        age: 30,
-        address: {
-          city: "Greenville"
-        },
-        dogs: [
-          { name: "Spot", age: 12 },
-          { age: 14 }
-        ]
-      )
-    end
+    context "with multiple invalid params" do
+      let(:params) do
+        DummyParams.new(
+          name: nil,
+          age: 30,
+          address: {
+            city: "Greenville"
+          },
+          dogs: [
+            { name: "Spot", age: 12 },
+            { age: 14 }
+          ]
+        )
+      end
 
-    it "validates required params" do
-      params.should_not be_valid
-      params.errors[:name].should eq(["can't be blank"])
-    end
+      it "validates required params" do
+        params.should_not be_valid
+        params.errors[:name].should eq(["can't be blank"])
+      end
 
-    it "validates nested params" do
-      params.should_not be_valid
-      params.address.errors[:street].should eq(["can't be blank"])
-      params.errors[:address][:street].should eq(["can't be blank"])
+      it "validates nested params" do
+        params.should_not be_valid
+        params.address.errors[:street].should eq(["can't be blank"])
+        params.errors[:address][:street].should eq(["can't be blank"])
+      end
+
+      it "validates nested arrays" do
+        params.should_not be_valid
+        params.errors[:dogs][0][:name].should eq([])
+        params.errors[:dogs][1][:name].should eq(["can't be blank"])
+      end
     end
 
-    it "validates nested arrays" do
-      params.should_not be_valid
-      params.errors[:dogs][0][:name].should eq([])
-      params.errors[:dogs][1][:name].should eq(["can't be blank"])
+    context "with only invalid nested array", fail: true do
+      let(:params) do
+        DummyParams.new(
+          name: "Bill",
+          age: 30,
+          address: {
+            street: "1 Main St.",
+            city: "Greenville"
+          },
+          phone: {
+            phone_number: "8085551212"
+          },
+          dogs: [
+            { name: "Spot", age: 12 },
+            { age: 14 }
+          ]
+        )
+      end
+
+      it "validates nested arrays" do
+        params.should_not be_valid
+        params.errors[:dogs][0][:name].should eq([])
+        params.errors[:dogs][1][:name].should eq(["can't be blank"])
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_params
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - brycesenz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-26 00:00:00.000000000 Z
+date: 2015-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel