simple_messenger 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 77da1ce00f5c0a237fef690def25a3fd35d6f952
-  data.tar.gz: e92f498bb0bf4da6a72803b9fb37a8a0d16c3167
+  metadata.gz: d03271126de37de605426a31de7fe08efaa5248f
+  data.tar.gz: e012d77158181055a5236d712f47889a0674280e
 SHA512:
-  metadata.gz: 0c26d9adbc6fde8a2486d641d0011ec06d1579efcd86a33a491c093382951f01d36bc38cc3e47ff641107d70b74fc85d4254aae2648632795bc32c7d4a309029
-  data.tar.gz: 9ec7d27c57379da9cc9f51a5abab79f8aaad385ac0e7f063928ec597f8c4291939ff8a1b9cba2aac330cd1ad7cefab779c525c819a98316c593a9a12b9601b92
+  metadata.gz: 72593e79e848e4e9ed74c701d0dc65db56283d62bb6b2d0df6a079525b11227eacb56435f0bb27ba84e14e0068fea8dde6f2f813fff0accfd81e59dafce8f64a
+  data.tar.gz: c4bd158a0e84f8d7d93e0e2320887a46192300645f2315ff57fc80b7cbc301cd6076fe6758acbbf0e6e6a0434ff795538c33a26d1d10e7baaec0c3654e576b2c

data/.gitignore

@@ -16,3 +16,4 @@ test/tmp
 test/version_tmp
 tmp
 .project
+/nbproject

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+## v0.0.2
+
+* bugs
+	* Fixed bug in read()? where it was returning the wrong result
+
+## v0.0.1
+
+* initial release

data/lib/simple_messenger/message_additions.rb

@@ -11,12 +11,12 @@ module SimpleMessenger
       # Using ARel find all the messages where the model is sender or receiver.
       feature_model.scope :all_for, ->(model) {
         feature_model.where(
-             ((feature_model.arel_table[:sender_id].eq model.id).
-          and(feature_model.arel_table[:sender_type].eq model.class.to_s)).
-           or((feature_model.arel_table[:receiver_id].eq model.id).
-          and(feature_model.arel_table[:receiver_type].eq model.class.to_s))
-         )
-       }
+          ((feature_model.arel_table[:sender_id].eq model.id).
+              and(feature_model.arel_table[:sender_type].eq model.class.to_s)).
+            or((feature_model.arel_table[:receiver_id].eq model.id).
+              and(feature_model.arel_table[:receiver_type].eq model.class.to_s))
+        )
+      }
 
       # Find a conversations between 2 models by joining all_for on both.
       feature_model.scope :between, ->(models) {
@@ -24,7 +24,7 @@ module SimpleMessenger
       }
 
       feature_model.validates_presence_of :sender_id, :sender_type,
-                                          :receiver_id, :receiver_type
+        :receiver_id, :receiver_type
 
       # When given an array of messages, this will return a list of all the ids of the
       # models that have interacted together. Useful for creating a list of objects
@@ -50,7 +50,7 @@ module SimpleMessenger
       # in a conversation. Without the check for the user being the recipient,
       # the messages that she sent would return true.
       def read?(obj)
-        obj == receiver && viewed?
+        obj != receiver || viewed?
       end
 
       # This will return the other member in the communication then the one

data/lib/simple_messenger/version.rb

@@ -1,3 +1,3 @@
 module SimpleMessenger
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/message_spec.rb

@@ -91,12 +91,12 @@ describe Message do
   end
 
   context "instance methods" do
-    specify { @message.read?(@user1).should be_false }
+    specify { @message.read?(@user1).should be_true } # Message is sent by @user1
     specify { @message.read?(@user2).should be_false }
 
     it "should act as viewed when applicable" do
       @message.viewed = true
-      @message.read?(@user1).should be_false
+      @message.read?(@user1).should be_true
       @message.read?(@user2).should be_true
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_messenger
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Kainage
@@ -103,6 +103,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md