simple_hashtag 0.1.6 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eec58dc17a78471028537ef4fc03ea4a446db720
-  data.tar.gz: 50e1b28583c8993d4e43cedeaaaa1685cd971c4f
+  metadata.gz: 92cf359e8763bc3f5110ceecae2df02a19de730e
+  data.tar.gz: 2745a7c66d0eb823ff9d36291fb081f95b8dc6e8
 SHA512:
-  metadata.gz: 98b8e1d7a86a89236b1d60841902cad7fd44f9c06279320dddb660d6c177317b248b7d4b5ba7b90d296b4bceedf5a6ce911a4ff58a285c309658dd067cfddbfc
-  data.tar.gz: 2b5291d27256460be5efda4a3c389928ae40fe4f7c38ca450bec62d8cb8d18b7b4dfc4fa96780aa7aa4afdf5c53e457efba0e9029119bba49ee33f3c4c508d29
+  metadata.gz: 8310a4c6ae2144c15bde96ff7bcba20ed8f422e8d03d375dc0327ef36e16ce5463bcf2c52ef23b91cd319695c76e9f2476a2cd3d9f4d24d1987ad9a9a5df65e2
+  data.tar.gz: d0236caaa76693f6244f6b1f8edaf6864e5fc1dc3267b60175344c40e790078057ebf2de94f3f6fc3d1b47b1b94668f369292a9d4c48c3afababe77a8446ba32

data/README.md

@@ -142,8 +142,6 @@ Improvements for this method are listed in the Todo section below.
 ## Gotchas
 ### Association Query
 The association between a Hashtag and your models is a polymorphic many-to-many.
-When querying the polymorphic association from the other side (tag.hashtaggables),
-we perform a DB query for each hashtaggable, resulting in an n+1 query.
 
 The object returned by the query is an array, not an Arel query, so you can't chain (i.e.: to specify the order), and should do it by hand:
 
@@ -153,15 +151,6 @@ posts_and_picts = hashtag.hattaggables
 posts_and_picts.sort_by! { |p| p.created_at }
 ```
 
-To avoid the N+1 query problem, use the hashtagged_ids_for_type(type) method
-to retrieve the IDs for the items instead:
-
-```ruby
-hashtag = SimpleHashtag.find_by_name("RubyRocks")
-@comment_ids = @hashtag.hashtagged_ids_for_type("Comment") if @hashtag
-@comments = Comment.where(:id => @hashtagged_elements)
-```
-
 ### find_by
 
 To preserve coherence, Hashtags are stored downcased.

data/lib/simple_hashtag/hashtag.rb

@@ -28,17 +28,24 @@ module SimpleHashtag
     end
 
     def hashtaggables
-      self.hashtaggings.collect { |h| h.hashtaggable }
+      self.hashtaggings.includes(:hashtaggable).collect { |h| h.hashtaggable }
     end
 
-    def hashtagged_ids_for_type(type)
-      hashtagged_ids ||= Array.new
+    def hashtagged_types
+      self.hashtaggings.pluck(:hashtaggable_type).uniq
+    end
+
+    def hashtagged_ids_by_types
+      hashtagged_ids ||= {}
       self.hashtaggings.each do |h|
-        if h.hashtaggable_type == type
-          hashtagged_ids << h.hashtaggable_id
-        end
+        hashtagged_ids[h.hashtaggable_type] ||= Array.new
+        hashtagged_ids[h.hashtaggable_type] << h.hashtaggable_id
       end
-      return hashtagged_ids
+      hashtagged_ids
+    end
+
+    def hashtagged_ids_for_type(type)
+      hashtagged_ids_by_types[type]
     end
 
     def to_s

data/lib/simple_hashtag/version.rb

@@ -1,3 +1,3 @@
 module SimpleHashtag
-  VERSION = "0.1.6"
+  VERSION = "0.1.8"
 end

data/spec/simple_hashtag_spec.rb

@@ -41,14 +41,25 @@ describe SimpleHashtag do
       tag.name.should eq "weirdcase"
     end
 
-    it "knows about its hashtaggables" do
-      Post.create(body: "I thought up an ending for my #book.")
-      Picture.create(caption: "Some who have read the #book.")
-
-      tag = SimpleHashtag::Hashtag.find_by_name("book")
-      tag.hashtaggables.size.should eq 2
-      tag.hashtaggables.first.body.should eq "I thought up an ending for my #book."
-      tag.hashtaggables.last.caption.should eq "Some who have read the #book."
+    context "knows about its hashtaggables" do
+      before do
+        Post.create(body: "I thought up an ending for my #book.")
+        Picture.create(caption: "Some who have read the #book.")
+      end
+      it "their numbers" do
+        tag = SimpleHashtag::Hashtag.find_by_name("book")
+        tag.hashtaggables.size.should eq 2
+        tag.hashtaggables.first.body.should eq "I thought up an ending for my #book."
+        tag.hashtaggables.last.caption.should eq "Some who have read the #book."
+      end
+
+      it "their types" do
+        tag = SimpleHashtag::Hashtag.find_by_name("book")
+        tag.hashtagged_types.size.should eq 2
+        tag.hashtagged_types.should eq ["Post", "Picture"]
+        tag.hashtagged_ids_for_type("Post").should include(Post.last.id)
+        tag.hashtagged_ids_for_type("Picture").should include(Picture.last.id)
+      end
     end
 
     it "can clean the DB from orphan tags" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_hashtag
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.8
 platform: ruby
 authors:
 - Raphael Campardou