simple_feature_flags 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d732d5d2141046aac302cce21de1487ca8c2d3526a64f7ad1845fc964ab8bec
-  data.tar.gz: 98677ad0f773881b575c7e3e3bb1c28b857544bdb6dbe370f8ad1d9f739848f0
+  metadata.gz: 3caaf6b1bc76049e0debeb5a1d5b549bd1853328fb7bf8833469be0c3de666ca
+  data.tar.gz: 3e3a2f901936c0f6bad14a0a1efe75b171a1feb64de2e728c8bfadeda777262c
 SHA512:
-  metadata.gz: 003561d885bf3e8ea25c6210c1f727453561c761a22bd08607d5b6e4cbfc36182b168b7ffa901d9c4ebc4e71b3499d1a7d4469ec1fd746c8b62ab4dab47a1abc
-  data.tar.gz: a7bc11c251004a5acfb190f435c993d2c8fd02136581ca74035abbdac174ed3345a6ef7f893048698196c437f22fbd925c14a28917f5bffcd18dc243618b9415
+  metadata.gz: dadda81140cd5cc53845d1e0b2396df2258a87a779b9e770e9699e66f81fcb0f8acdd66887cf53d4186f225700e5e76ea5c2e15f10097443c68191201247eb59
+  data.tar.gz: 2e52191291340ce433c6e65ebfd71fd6cebbb1e1e77dc9893086fe0b7412f91753a756074a699fdfc2065a93158c892cdea87610a11a8bb953a22a260239e6af

data/.vscode/settings.json

@@ -4,6 +4,7 @@
     "autorun",
     "bindir",
     "concat",
+    "featurable",
     "flushdb",
     "hget",
     "hgetall",

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    simple_feature_flags (1.0.0)
+    simple_feature_flags (1.1.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -66,14 +66,14 @@ This initializer in turn makes use of the generated config file `config/simple_f
 :mandatory:
 # example flag - it will be created with these properties if there is no such flag in Redis/RAM
 # - name: example
-#   active: 'true' # 'false' is the default value
+#   active: 'globally' # %w[globally partially false] 'false' is the default value
 #   description: example
 
 - name: example_flag
   description: This is an example flag which will be automatically added when you start your app (it will be disabled)
 
 - name: example_active_flag
-  active: 'true'
+  active: 'globally'
   description: This is an example flag which will be automatically added when you start your app (it will be enabled)
 
 # nothing will happen if flag that is to be removed does not exist in Redis/RAM
@@ -133,10 +133,14 @@ Activates a feature in the global scope
 
 ```ruby
 FEATURE_FLAGS.active?(:feature_name) #=> false
+FEATURE_FLAGS.active_globally?(:feature_name) #=> false
+FEATURE_FLAGS.active_partially?(:feature_name) #=> false
 
-FEATURE_FLAGS.activate(:feature_name)
+FEATURE_FLAGS.activate(:feature_name) # or FEATURE_FLAGS.activate_globally(:feature_name)
 
 FEATURE_FLAGS.active?(:feature_name) #=> true
+FEATURE_FLAGS.active_globally?(:feature_name) #=> true
+FEATURE_FLAGS.active_partially?(:feature_name) #=> false
 ```
 
 #### Deactivate a feature
@@ -154,64 +158,75 @@ FEATURE_FLAGS.active?(:feature_name) #=> false
 #### Activate a feature for a particular record/object
 
 ```ruby
+FEATURE_FLAGS.active_partially?(:feature_name) #=> true
+FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> false
+FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
+
 FEATURE_FLAGS.activate_for(:feature_name, User.first) #=> true
+
+FEATURE_FLAGS.active_partially?(:feature_name) #=> true
 FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> true
 FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
 ```
 
-Note that the flag itself has to be `active` in the global scope for any record/object specific settings to work.
+Note that the flag itself has to be active `partially` for any record/object specific settings to work.
 When the flag is `deactivated` it is completely turned off globally and for every specific record/object.
 
 ```ruby
 # The flag is deactivated in the global scope to begin with
 FEATURE_FLAGS.active?(:feature_name) #=> false
+FEATURE_FLAGS.active_partially?(:feature_name) #=> false
+FEATURE_FLAGS.active_globally?(:feature_name) #=> false
+
+FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> false
+FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
 
 # We activate it for the first User
 FEATURE_FLAGS.activate_for(:feature_name, User.first)
 
 FEATURE_FLAGS.active?(:feature_name) #=> false
+FEATURE_FLAGS.active_partially?(:feature_name) #=> false
+FEATURE_FLAGS.active_globally?(:feature_name) #=> false
+
 # It is globally `deactivated` though, so the feature stays inactive for all users
 FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> false
+FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
 
-# Once we activate the flag in the global scope, record specific settings will be applied
-FEATURE_FLAGS.activate(:feature_name)
+# Once we activate the flag partially, record specific settings will be applied
+FEATURE_FLAGS.activate_partially(:feature_name)
 
 FEATURE_FLAGS.active?(:feature_name) #=> true
+FEATURE_FLAGS.active_partially?(:feature_name) #=> true
+FEATURE_FLAGS.active_globally?(:feature_name) #=> false
+
 FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> true
 FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
 
 FEATURE_FLAGS.deactivate(:feature_name)
 
 FEATURE_FLAGS.active?(:feature_name) #=> false
+FEATURE_FLAGS.active_partially?(:feature_name) #=> false
+FEATURE_FLAGS.active_globally?(:feature_name) #=> false
+
 FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> false
 FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
 ```
 
-There is a convenience method `activate_for!`, which activates the feature in the global scope and for specific records/objects at the same time
+There is a convenience method `activate_for!`, which activates the feature partially and for specific records/objects at the same time
 
 ```ruby
 # The flag is deactivated in the global scope to begin with
 FEATURE_FLAGS.active?(:feature_name) #=> false
+FEATURE_FLAGS.active_partially?(:feature_name) #=> false
+FEATURE_FLAGS.active_globally?(:feature_name) #=> false
 
 # We activate it in the global scope and for the first User
 FEATURE_FLAGS.activate_for!(:feature_name, User.first)
 
 FEATURE_FLAGS.active?(:feature_name) #=> true
-FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> true
-FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
-```
-
-A feature that is `active` in the global scope is inactive for all specific records, unless it has been activated for them.
-
-```ruby
-# The flag is active in the global scope to begin with
-FEATURE_FLAGS.active?(:feature_name) #=> true
-FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> false
-FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
-
-FEATURE_FLAGS.activate_for(:feature_name, User.first)
+FEATURE_FLAGS.active_partially?(:feature_name) #=> true
+FEATURE_FLAGS.active_globally?(:feature_name) #=> false
 
-FEATURE_FLAGS.active?(:feature_name) #=> true
 FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> true
 FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
 ```
@@ -233,23 +248,32 @@ FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
 #### Activate the feature for every record
 
 ```ruby
-# The flag is active in the global scope to begin with
+# The flag is active partially
 FEATURE_FLAGS.active?(:feature_name) #=> true
+FEATURE_FLAGS.active_partially?(:feature_name) #=> true
+FEATURE_FLAGS.active_globally?(:feature_name) #=> false
+
 # It is also enabled for the first user
 FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> true
 FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
 
 # We force it onto every user
-FEATURE_FLAGS.activate!(:feature_name)
+FEATURE_FLAGS.activate(:feature_name)
 
 FEATURE_FLAGS.active?(:feature_name) #=> true
+FEATURE_FLAGS.active_partially?(:feature_name) #=> false
+FEATURE_FLAGS.active_globally?(:feature_name) #=> true
+
 FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> true
 FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> true
 
 # We can easily return to the previous settings
-FEATURE_FLAGS.activate(:feature_name)
+FEATURE_FLAGS.activate_partially(:feature_name)
 
 FEATURE_FLAGS.active?(:feature_name) #=> true
+FEATURE_FLAGS.active_partially?(:feature_name) #=> false
+FEATURE_FLAGS.active_globally?(:feature_name) #=> true
+
 FEATURE_FLAGS.active_for?(:feature_name, User.first) #=> true
 FEATURE_FLAGS.active_for?(:feature_name, User.last) #=> false
 ```
@@ -277,22 +301,32 @@ end
 
 # or using a block
 
-# this code will run only when the :feature_name flag is active
+# this code will run only when the :feature_name flag is active (either partially or globally)
 FEATURE_FLAGS.when_active(:feature_name) do
   number += 1
 end
 
-# feature flags that don't exist will return false
-FEATURE_FLAGS.active?(:non_existant) #=> false
+# this code will run only when the :feature_name flag is active globally
+FEATURE_FLAGS.when_active_globally(:feature_name) do
+  number += 1
+end
 
-if FEATURE_FLAGS.active_for?(:feature_name, User.first)
+# this code will run only when the :feature_name flag is active partially (only for specific records/users)
+FEATURE_FLAGS.when_active_partially(:feature_name) do
   number += 1
 end
 
-# this code will run only if the :feature_name flag is active for the first User
+# this code will run only if the :feature_name flag is active partially for the first User
 FEATURE_FLAGS.when_active_for(:feature_name, User.first) do
   number += 1
 end
+
+# feature flags that don't exist will return false
+FEATURE_FLAGS.active?(:non_existant) #=> false
+
+if FEATURE_FLAGS.active_for?(:feature_name, User.first)
+  number += 1
+end
 ```
 
 #### Adding feature flags
@@ -302,11 +336,27 @@ You can add new feature flags programmatically, though we highly encourage you t
 In case you'd like to add flags programmatically
 ```ruby
 FEATURE_FLAGS.add(:feature_name, 'Description')
+
 FEATURE_FLAGS.active?(:feature_name) #=> false
+FEATURE_FLAGS.active_partially?(:feature_name) #=> false
+FEATURE_FLAGS.active_globally?(:feature_name) #=> false
+FEATURE_FLAGS.active_for?(:feature_active_partially, User.first) #=> false
+
+# add a new globally active flag
+FEATURE_FLAGS.add(:active_feature, 'Description', :globally)
+
+FEATURE_FLAGS.active?(:active_feature) #=> true
+FEATURE_FLAGS.active_partially?(:active_feature) #=> false
+FEATURE_FLAGS.active_globally?(:active_feature) #=> true
+FEATURE_FLAGS.active_for?(:active_feature, User.first) #=> true
 
-# add a new active flag
-FEATURE_FLAGS.add(:active_feature_name, 'Description', true)
-FEATURE_FLAGS.active?(:active_feature_name) #=> true
+# add a new partially active flag
+FEATURE_FLAGS.add(:feature_active_partially, 'Description', :partially)
+
+FEATURE_FLAGS.active?(:feature_active_partially) #=> true
+FEATURE_FLAGS.active_partially?(:feature_active_partially) #=> true
+FEATURE_FLAGS.active_globally?(:feature_active_partially) #=> false
+FEATURE_FLAGS.active_for?(:feature_active_partially, User.first) #=> false
 ```
 
 #### Removing feature flags
@@ -316,7 +366,10 @@ You can remove feature flags programmatically, though we highly encourage you to
 In case you'd like to remove flags programmatically
 ```ruby
 FEATURE_FLAGS.remove(:feature_name)
-FEATURE_FLAGS.active?(:feature_name) #=> false
+
+FEATURE_FLAGS.active?(:feature_active_partially) #=> false
+FEATURE_FLAGS.active_partially?(:feature_active_partially) #=> false
+FEATURE_FLAGS.active_globally?(:feature_active_partially) #=> false
 ```
 
 

data/exe/simple_feature_flags

@@ -3,7 +3,6 @@
 
 $LOAD_PATH.unshift("#{__dir__}/../lib")
 
-require 'byebug'
 require 'simple_feature_flags'
 
 ::SimpleFeatureFlags::Cli::Runner.new.run

data/lib/example_files/config/initializers/simple_feature_flags.rb

@@ -2,8 +2,8 @@
 # Redis has 16 DBs (0 to 15)
 
 FEATURE_FLAGS = if ::Rails.env.test?
-                  # Use TestRamStorage in tests to make them faster
-                  ::SimpleFeatureFlags::TestRamStorage.new("#{::Rails.root.to_s}/config/simple_feature_flags.yml")
+                  # Use RamStorage in tests to make them faster
+                  ::SimpleFeatureFlags::RamStorage.new("#{::Rails.root.to_s}/config/simple_feature_flags.yml")
                 else
                   redis = ::Redis.new(host: '127.0.0.1', port: 6379, db: 0)
                   # We recommend using the `redis-namespace` gem to avoid key conflicts with Sidekiq or Resque

data/lib/example_files/config/simple_feature_flags.yml

@@ -3,17 +3,17 @@
 :mandatory:
 # example flag - it will be created with these properties if there is no such flag in Redis/RAM
 # - name: example
-#   active: 'true' # 'false' is the default value
+#   active: 'globally' # %w[globally partially false] 'false' is the default value
 #   description: example
 
 - name: example_flag
   description: This is an example flag which will be automatically added when you start your app (it will be disabled)
 
 - name: example_active_flag
-  active: 'true'
+  active: 'globally'
   description: This is an example flag which will be automatically added when you start your app (it will be enabled)
 
 # nothing will happen if flag that is to be removed does not exist in Redis/RAM
 # An array of Feature Flag names that will be removed on app startup
 :remove:
-- flag_to_be_removed
+- flag_to_be_removed

data/lib/simple_feature_flags.rb

@@ -2,14 +2,26 @@
 
 require 'json'
 
+Dir[File.expand_path('simple_feature_flags/*.rb', __dir__)].sort.each { |file| require file }
+
 module SimpleFeatureFlags
   NOT_PRESENT = ::Object.new.freeze
+  UI_GEM = 'simple_feature_flags-ui'
+  UI_CLASS_NAME = '::SimpleFeatureFlags::Ui'
+  WEB_UI_CLASS_NAME = '::SimpleFeatureFlags::Ui::Web'
+
+  ACTIVE_GLOBALLY = ['globally', :globally, 'true', true].freeze
+  ACTIVE_PARTIALLY = ['partially', :partially].freeze
 
   class NoSuchCommandError < StandardError; end
 
   class IncorrectWorkingDirectoryError < StandardError; end
 
   class FlagNotDefinedError < StandardError; end
-end
 
-Dir[File.expand_path('simple_feature_flags/*.rb', __dir__)].sort.each { |file| require file }
+  CONFIG = Configuration.new
+
+  def self.configure(&block)
+    block.call(CONFIG)
+  end
+end

data/lib/simple_feature_flags/cli/command/generate.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'fileutils'
-require 'byebug'
 
 module SimpleFeatureFlags
   module Cli
@@ -37,6 +36,41 @@ module SimpleFeatureFlags
           puts '----------'
           puts "- #{::File.join(destination_dir, 'config')}"
           print_dir_tree(example_config_dir, 1)
+
+          return unless options.ui
+
+          file_gsub(routes_rb, /.routes.draw do/) do |match|
+            "#{match}\n  mount #{WEB_UI_CLASS_NAME}.new => '/admin/simple_feature_flags'\n"
+          end
+
+          ui_config_line = <<~CONF
+            #{UI_CLASS_NAME}.configure do |config|
+              config.instance = FEATURE_FLAGS
+              config.featurable_class_names = %w[User]
+            end
+          CONF
+
+          file_append(initializer_file, ui_config_line)
+          file_append(gemfile, %(gem '#{UI_GEM}'))
+
+          puts "\nModified:"
+          puts '----------'
+          puts "* #{routes_rb}"
+          puts "* #{gemfile}"
+
+          puts "\nBundling..."
+          system 'bundle'
+        end
+
+        def file_gsub(file_path, regexp, &block)
+          new_content = File.read(file_path).gsub(regexp, &block)
+          File.open(file_path, 'wb') { |file| file.write(new_content) }
+        end
+
+        def file_append(file_path, line)
+          new_content = File.read(file_path)
+          new_content = "#{new_content}\n#{line}\n"
+          File.open(file_path, 'wb') { |file| file.write(new_content) }
         end
 
         def print_dir_tree(dir, embed_level = 0)
@@ -54,6 +88,18 @@ module SimpleFeatureFlags
           end
         end
 
+        def initializer_file
+          ::File.join(destination_dir, 'config', 'initializers', 'simple_feature_flags.rb')
+        end
+
+        def gemfile
+          ::File.join(destination_dir, 'Gemfile')
+        end
+
+        def routes_rb
+          ::File.join(destination_dir, 'config', 'routes.rb')
+        end
+
         def example_config_dir
           ::File.join(::File.expand_path(__dir__), '..', '..', '..', 'example_files', 'config')
         end

data/lib/simple_feature_flags/cli/options.rb

@@ -5,10 +5,11 @@ require 'optparse'
 module SimpleFeatureFlags
   module Cli
     class Options
-      attr_reader :opt_parser, :generate, :help, :rails
+      attr_reader :opt_parser, :generate, :help, :rails, :ui
 
       def initialize(args)
         @rails = true
+        @ui = false
 
         @opt_parser = ::OptionParser.new do |opts|
           opts.banner = 'Usage: simple_feature_flags [options]'
@@ -31,6 +32,7 @@ module SimpleFeatureFlags
           opts.separator ''
           opts.separator 'Modifiers:'
 
+          opts.on('--[no-]ui', '--[no-]web-ui', "Add the #{UI_GEM} gem and mount it in routes") { |u| @ui = u }
           opts.on('--[no-]rails', 'Use generators suited for Rails apps') { |r| @rails = r }
         end
 

data/lib/simple_feature_flags/configuration.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module SimpleFeatureFlags
+  class Configuration
+    attr_accessor :default_id_method
+
+    def initialize
+      @default_id_method = :id
+    end
+  end
+end

data/lib/simple_feature_flags/ram_storage.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'yaml'
+
 module SimpleFeatureFlags
   class RamStorage
     attr_reader :file, :mandatory_flags, :flags
@@ -13,15 +15,34 @@ module SimpleFeatureFlags
       import_flags_from_file
     end
 
-    def active?(feature, _ignore_file = false)
-      __active__(feature)
+    def active(feature)
+      case flags.dig(feature.to_sym, 'active')
+      when 'globally', :globally
+        :globally
+      when 'partially', :partially
+        :partially
+      when 'true', true
+        true
+      when 'false', false
+        false
+      end
+    end
+
+    def active?(feature)
+      return true if active(feature)
+
+      false
     end
 
     def active_globally?(feature)
-      flags.dig(feature.to_sym, 'active') == 'globally'
+      ACTIVE_GLOBALLY.include? flags.dig(feature.to_sym, 'active')
     end
 
-    def active_for?(feature, object, object_id_method = :id)
+    def active_partially?(feature)
+      ACTIVE_PARTIALLY.include? flags.dig(feature.to_sym, 'active')
+    end
+
+    def active_for?(feature, object, object_id_method = CONFIG.default_id_method)
       return false unless active?(feature)
       return true if active_globally?(feature)
 
@@ -43,19 +64,31 @@ module SimpleFeatureFlags
       flags.dig(feature.to_sym, 'description')
     end
 
-    def when_active(feature, ignore_file = false, &block)
-      return unless active?(feature, ignore_file)
+    def when_active(feature, &block)
+      return unless active?(feature)
+
+      block.call
+    end
+
+    def when_active_globally(feature, &block)
+      return unless active_globally?(feature)
+
+      block.call
+    end
+
+    def when_active_partially(feature, &block)
+      return unless active_partially?(feature)
 
       block.call
     end
 
-    def when_active_for(feature, object, object_id_method = :id, &block)
+    def when_active_for(feature, object, object_id_method = CONFIG.default_id_method, &block)
       return unless active_for?(feature, object, object_id_method)
 
       block.call
     end
 
-    def activate!(feature)
+    def activate(feature)
       return false unless exists?(feature)
 
       flags[feature.to_sym]['active'] = 'globally'
@@ -63,15 +96,17 @@ module SimpleFeatureFlags
       true
     end
 
-    def activate(feature)
+    alias activate_globally activate
+
+    def activate_partially(feature)
       return false unless exists?(feature)
 
-      flags[feature.to_sym]['active'] = 'true'
+      flags[feature.to_sym]['active'] = 'partially'
 
       true
     end
 
-    def activate_for(feature, objects, object_id_method = :id)
+    def activate_for(feature, objects, object_id_method = CONFIG.default_id_method)
       return false unless exists?(feature)
 
       objects = [objects] unless objects.is_a? ::Array
@@ -81,7 +116,7 @@ module SimpleFeatureFlags
       to_activate_hash.each do |klass, ids|
         (active_objects_hash[klass] = ids) && next unless active_objects_hash[klass]
 
-        active_objects_hash[klass].concat(ids).sort!
+        active_objects_hash[klass].concat(ids).uniq!.sort!
       end
 
       flags[feature.to_sym]['active_for_objects'] = active_objects_hash
@@ -89,10 +124,10 @@ module SimpleFeatureFlags
       true
     end
 
-    def activate_for!(feature, objects, object_id_method = :id)
+    def activate_for!(feature, objects, object_id_method = CONFIG.default_id_method)
       return false unless activate_for(feature, objects, object_id_method)
 
-      activate(feature)
+      activate_partially(feature)
     end
 
     def deactivate!(feature)
@@ -116,7 +151,7 @@ module SimpleFeatureFlags
       flags.dig(feature.to_sym, 'active_for_objects') || {}
     end
 
-    def deactivate_for(feature, objects, object_id_method = :id)
+    def deactivate_for(feature, objects, object_id_method = CONFIG.default_id_method)
       return false unless exists?(feature)
 
       active_objects_hash = active_objects(feature)
@@ -190,16 +225,12 @@ module SimpleFeatureFlags
 
     private
 
-    def objects_to_hash(objects, object_id_method = :id)
+    def objects_to_hash(objects, object_id_method = CONFIG.default_id_method)
       objects = [objects] unless objects.is_a? ::Array
 
       objects.group_by { |ob| ob.class.to_s }.transform_values { |arr| arr.map(&object_id_method) }
     end
 
-    def __active__(feature)
-      %w[true globally].include? flags.dig(feature.to_sym, 'active')
-    end
-
     def import_flags_from_file
       changes = YAML.load_file(file)
       changes = { mandatory: [], remove: [] } unless changes.is_a? ::Hash

data/lib/simple_feature_flags/redis_storage.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'yaml'
+
 module SimpleFeatureFlags
   class RedisStorage
     attr_reader :file, :redis, :mandatory_flags
@@ -12,20 +14,34 @@ module SimpleFeatureFlags
       import_flags_from_file
     end
 
-    def active?(feature, _ignore_file = false)
-      __active__(feature)
-    end
-
-    def active_globally?(feature)
+    def active(feature)
       case redis.hget(feature.to_s, 'active')
       when 'globally'
+        :globally
+      when 'partially'
+        :partially
+      when 'true'
         true
-      else
+      when 'false'
         false
       end
     end
 
-    def active_for?(feature, object, object_id_method = :id)
+    def active?(feature)
+      return true if active(feature)
+
+      false
+    end
+
+    def active_globally?(feature)
+      ACTIVE_GLOBALLY.include? redis.hget(feature.to_s, 'active')
+    end
+
+    def active_partially?(feature)
+      ACTIVE_PARTIALLY.include? redis.hget(feature.to_s, 'active')
+    end
+
+    def active_for?(feature, object, object_id_method = CONFIG.default_id_method)
       return false unless active?(feature)
       return true if active_globally?(feature)
 
@@ -47,19 +63,31 @@ module SimpleFeatureFlags
       redis.hget(feature.to_s, 'description')
     end
 
-    def when_active(feature, _ignore_file = false, &block)
+    def when_active(feature, &block)
       return unless active?(feature)
 
       block.call
     end
 
-    def when_active_for(feature, object, object_id_method = :id, &block)
+    def when_active_globally(feature, &block)
+      return unless active_globally?(feature)
+
+      block.call
+    end
+
+    def when_active_partially(feature, &block)
+      return unless active_partially?(feature)
+
+      block.call
+    end
+
+    def when_active_for(feature, object, object_id_method = CONFIG.default_id_method, &block)
       return unless active_for?(feature, object, object_id_method)
 
       block.call
     end
 
-    def activate!(feature)
+    def activate(feature)
       return false unless exists?(feature)
 
       redis.hset(feature.to_s, 'active', 'globally')
@@ -67,17 +95,17 @@ module SimpleFeatureFlags
       true
     end
 
-    alias activate_globally activate!
+    alias activate_globally activate
 
-    def activate(feature)
+    def activate_partially(feature)
       return false unless exists?(feature)
 
-      redis.hset(feature.to_s, 'active', 'true')
+      redis.hset(feature.to_s, 'active', 'partially')
 
       true
     end
 
-    def activate_for(feature, objects, object_id_method = :id)
+    def activate_for(feature, objects, object_id_method = CONFIG.default_id_method)
       return false unless exists?(feature)
 
       objects = [objects] unless objects.is_a? ::Array
@@ -87,7 +115,7 @@ module SimpleFeatureFlags
       to_activate_hash.each do |klass, ids|
         (active_objects_hash[klass] = ids) && next unless active_objects_hash[klass]
 
-        active_objects_hash[klass].concat(ids).sort!
+        active_objects_hash[klass].concat(ids).uniq!.sort!
       end
 
       redis.hset(feature.to_s, 'active_for_objects', active_objects_hash.to_json)
@@ -95,10 +123,10 @@ module SimpleFeatureFlags
       true
     end
 
-    def activate_for!(feature, objects, object_id_method = :id)
+    def activate_for!(feature, objects, object_id_method = CONFIG.default_id_method)
       return false unless activate_for(feature, objects, object_id_method)
 
-      activate(feature)
+      activate_partially(feature)
     end
 
     def deactivate!(feature)
@@ -124,7 +152,7 @@ module SimpleFeatureFlags
       {}
     end
 
-    def deactivate_for(feature, objects, object_id_method = :id)
+    def deactivate_for(feature, objects, object_id_method = CONFIG.default_id_method)
       return false unless exists?(feature)
 
       active_objects_hash = active_objects(feature)
@@ -203,23 +231,14 @@ module SimpleFeatureFlags
 
     private
 
-    def objects_to_hash(objects, object_id_method = :id)
+    def objects_to_hash(objects, object_id_method = CONFIG.default_id_method)
       objects = [objects] unless objects.is_a? ::Array
 
       objects.group_by { |ob| ob.class.to_s }.transform_values { |arr| arr.map(&object_id_method) }
     end
 
-    def __active__(feature)
-      case redis.hget(feature.to_s, 'active')
-      when 'true', 'globally'
-        true
-      when 'false'
-        false
-      end
-    end
-
     def import_flags_from_file
-      changes = YAML.load_file(file)
+      changes = ::YAML.load_file(file)
       changes = { mandatory: [], remove: [] } unless changes.is_a? ::Hash
 
       changes[:mandatory].each do |el|

data/lib/simple_feature_flags/test_ram_storage.rb

@@ -2,10 +2,10 @@
 
 module SimpleFeatureFlags
   class TestRamStorage < RamStorage
-    def active?(feature, ignore_file = false)
-      raise(FlagNotDefinedError, "Feature Flag `#{feature}` is not defined as mandatory in #{file}") if !ignore_file && !mandatory_flags.include?(feature.to_s)
+    def active?(feature)
+      raise(FlagNotDefinedError, "Feature Flag `#{feature}` is not defined as mandatory in #{file}") unless mandatory_flags.include?(feature.to_s)
 
-      __active__(feature)
+      super
     end
   end
 end

data/lib/simple_feature_flags/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SimpleFeatureFlags
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_feature_flags
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Espago
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-08-14 00:00:00.000000000 Z
+date: 2021-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -169,6 +169,7 @@ files:
 - lib/simple_feature_flags/cli/command/generate.rb
 - lib/simple_feature_flags/cli/options.rb
 - lib/simple_feature_flags/cli/runner.rb
+- lib/simple_feature_flags/configuration.rb
 - lib/simple_feature_flags/ram_storage.rb
 - lib/simple_feature_flags/redis_storage.rb
 - lib/simple_feature_flags/test_ram_storage.rb