simple_eav 0.3.0 → 0.4.0

data/lib/simple_eav.rb

@@ -16,10 +16,24 @@ module SimpleEav
     self.class.simple_eav_column
   end
 
+  private
+  def associations_of_class
+    self.class.reflect_on_all_associations.map{|assoc| assoc.name.to_sym }
+  end
+
   def actual_columns_of_table
     self.class.columns.map{|col| col.name.to_sym }
   end
 
+  public
+  def reserved_attributes
+    associations_of_class + actual_columns_of_table
+  end
+
+  def reserved_attribute?(attribute)
+    reserved_attributes.include?(attribute)
+  end
+
   def simple_eav_attributes
     _attributes = self.send(simple_eav_column.to_sym)
     _attributes.is_a?(Hash) ? _attributes : {}
@@ -35,7 +49,7 @@ module SimpleEav
     # - remove undefined columns to prevent UnknownAttribute::Error from being thrown
     simple_eav_attrs = read_attribute(simple_eav_column.to_sym) || {}
     _attributes.each do |column,value|
-      next if actual_columns_of_table.include?(column)
+      next if reserved_attribute?(column.to_sym)
       simple_eav_attrs[column] = value
       _attributes.delete(column)
     end
@@ -44,7 +58,8 @@ module SimpleEav
   end
 
   def respond_to?(method, include_private=false)
-    super || simple_eav_attributes.has_key?(method)
+    return true if super(method, include_private)
+    simple_eav_attributes.has_key?(method)
   end
 
   def method_missing(method, *args, &block)

data/lib/version.rb

@@ -1,3 +1,3 @@
 module SimpleEav
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/spec/db/schema.rb

@@ -7,4 +7,9 @@ ActiveRecord::Schema.define do
     t.datetime 'created_at'
     t.datetime 'updated_at'
   end
+  
+  create_table 'children', :force => true do |t|
+    t.string   'name'
+    t.belongs_to :person
+  end
 end

data/spec/lib/simple_eav_spec.rb

@@ -12,10 +12,61 @@ describe SimpleEav do
     end
   end
 
+  describe "Reserved attributes" do
+    before(:each) do
+      @child = Child.create
+      @person = Person.create(:child=>@child)
+    end
+    it "knows the associations of the object" do
+      @person.send(:associations_of_class).should include(:child)
+    end
+    it "knows the reserved attributes" do
+      @person.should_receive(:associations_of_class).and_return([:child])
+      @person.should_receive(:actual_columns_of_table).and_return([:name])
+      @person.reserved_attributes.should eql([:child, :name])
+    end
+    it "does not accept reserved attributes for eav" do
+      @person.should_receive(:reserved_attributes).and_return([:name, :number])
+      @person.reserved_attribute?(:name).should be_true
+    end
+  end
+
   describe "Expected ActiveRecord behavior" do
-    it "handles an empty string of attributes" do
-      person = Person.create(:simple_attributes=>'')
-      person.should_not be_new_record
+    describe "common" do
+      it "handles an empty string of attributes" do
+        person = Person.create(:simple_attributes=>'')
+        person.should_not be_new_record
+      end
+      it "sets all of the attributes" do
+        person = Person.create!({
+          :age=>99,
+          :simple_attributes=>{
+            :name=>'John'
+          }
+        })
+        person.age.should eql(99)
+        person.name.should eql('John')
+      end
+    end
+    describe "associations" do
+      before(:each) do
+        @child = Child.create
+        @person = Person.create(:child=>@child)
+      end
+      it "assigns the has_one" do
+        @person.simple_eav_attributes.should_not have_key(:child)
+        @person.child.should eql(@child)
+      end
+    end
+    describe "serialization" do
+      it "serializes and deserializes the simple_eav attributes" do
+        person = Person.new({:simple_attributes=>{
+          :name=>'John'
+        }})
+        person.save!
+        person.reload
+        person.name.should eql('John')
+      end
     end
     describe "given a hash of undefined attributes" do
       it "creates a person with a name" do
@@ -52,24 +103,6 @@ describe SimpleEav do
         person.simple_eav_attributes.should have_key :new_age
       end
     end
-    it "sets all of the attributes" do
-      person = Person.create!({
-        :age=>99,
-        :simple_attributes=>{
-          :name=>'John'
-        }
-      })
-      person.age.should eql(99)
-      person.name.should eql('John')
-    end
-    it "serializes and deserializes the simple_eav attributes" do
-      person = Person.new({:simple_attributes=>{
-        :name=>'John'
-      }})
-      person.save!
-      person.reload
-      person.name.should eql('John')
-    end
   end
   
   describe "#method_missing" do
@@ -79,6 +112,25 @@ describe SimpleEav do
     end
   end
 
+  describe "#respond_to" do
+    before(:each) do
+      @person = Person.new
+    end
+
+    it "the defined attribute `age` is responded to" do
+      @person.respond_to?(:age).should be_true
+    end
+
+    it "the custome attribute `name` is responded to" do
+      @person.name = 'John'
+      @person.respond_to?(:name).should be_true
+    end
+
+    it "someone else's name is not responded to" do
+      @person.respond_to?(:someone_elses_name).should be_false
+    end
+  end
+
   describe "A missing attribute" do
     before( :each ) do
       @person = Person.new
@@ -122,15 +174,6 @@ describe SimpleEav do
         @person.name = 'Joe'
         @person.name.should eql('Joe')
       end
-
-      it "who responds to his name" do
-        @person.name = 'John'
-        @person.respond_to?(:name).should be_true
-      end
-
-      it "who doesn't respond to someone else's name" do
-        @person.respond_to?(:someone_elses_name).should be_false
-      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -16,6 +16,7 @@ load('db/schema.rb')
 
 $:.push File.expand_path("../lib", __FILE__)
 require 'support/person'
+require 'support/child'
 
 RSpec.configure do |config|
   config.mock_with :rspec

data/spec/support/child.rb

@@ -0,0 +1,3 @@
+class Child < ActiveRecord::Base
+  belongs_to :person
+end

data/spec/support/person.rb

@@ -3,6 +3,8 @@ require 'simple_eav'
 
 class Person < ActiveRecord::Base
   include SimpleEav
-
   configure_simple_eav :simple_attributes
+  
+  has_one :child
 end
+

metadata

@@ -2,7 +2,7 @@
 name: simple_eav
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Tim Linquist
@@ -10,7 +10,8 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-07-30 00:00:00 Z
+date: 2011-08-03 00:00:00 -07:00
+default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activerecord
@@ -78,7 +79,9 @@ files:
 - spec/db/schema.rb
 - spec/lib/simple_eav_spec.rb
 - spec/spec_helper.rb
+- spec/support/child.rb
 - spec/support/person.rb
+has_rdoc: true
 homepage: http://github.com/timo3377/simple_eav
 licenses: []
 
@@ -102,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.3
+rubygems_version: 1.5.0
 signing_key: 
 specification_version: 3
 summary: A simple alternative to acts_as_eav_model.
@@ -110,4 +113,5 @@ test_files:
 - spec/db/schema.rb
 - spec/lib/simple_eav_spec.rb
 - spec/spec_helper.rb
+- spec/support/child.rb
 - spec/support/person.rb