simple_eav 0.1.0 → 0.2.0

data/lib/simple_eav.rb

@@ -5,9 +5,7 @@ module SimpleEav
       serialize @@column
     end
 
-    def simple_eav_column
-      @@column if defined? @@column
-    end
+    def simple_eav_column; @@column end
   end
 
   def self.included(base)
@@ -15,7 +13,7 @@ module SimpleEav
   end
 
   def simple_eav_column
-    self.class.simple_eav_column
+    self.class.simple_eav_column 
   end
   
   def actual_columns_of_table
@@ -33,8 +31,8 @@ module SimpleEav
   def attributes=(_attributes={})
     #Iterate over each attribute:
     # - skip columns that are actually defined in the db
-    # - remove undefined columns to prevent UnknownAttribute::Error from being thrown
-    simple_eav_attrs = read_attribute(:simple_eav_column) || {}
+    # - remove undefined columns to prevent UnknownAttribute::Error from being thrown    
+    simple_eav_attrs = read_attribute(simple_eav_column.to_sym) || {}
     _attributes.each do |column,value|
       next if actual_columns_of_table.include?(column)
       simple_eav_attrs[column] = value 
@@ -50,7 +48,7 @@ module SimpleEav
 
   def method_missing(method, *args, &block)
     if method.to_s =~ /=$/
-      _attributes = self.simple_eav_attributes
+      _attributes = read_attribute(simple_eav_column.to_sym) || {}
       setter = method.to_s.gsub(/=/, '')
       _attributes[setter.to_sym] = args.shift
       self.simple_eav_attributes = _attributes

data/lib/version.rb

@@ -1,3 +1,3 @@
 module SimpleEav
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/lib/simple_eav_spec.rb

@@ -67,6 +67,13 @@ describe SimpleEav do
       person.name.should eql('John')
     end
   end
+  
+  describe "#method_missing" do
+    it "does not reference the eav_column directly (causes stack overflow error)" do
+      person = Person.new
+      lambda{ person.name = 'John' }.should_not raise_error(SystemStackError)
+    end
+  end
 
   describe "A missing attribute" do
     before( :each ) do
@@ -83,6 +90,18 @@ describe SimpleEav do
       end
     end
   end
+  
+  describe "Adding an attribute with existing attributes" do
+    before(:each) do
+      @person = Person.create! :name=>'Jim'
+    end
+    
+    it "updates the attributes without removing the old" do
+      @person.update_attributes :cell_number => 911
+      @person.name.should eql('Jim')
+      @person.cell_number.should eql(911)
+    end
+  end
 
   describe "A custom attribute" do
     describe "John is a Person" do

metadata

@@ -2,7 +2,7 @@
 name: simple_eav
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors: 
 - Tim Linquist
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-16 00:00:00 -07:00
+date: 2011-07-19 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency