simple_currency 1.0.2 → 1.1.1

data/Gemfile

@@ -1,6 +1,6 @@
 source :gemcutter
 
-gem "json"
+gem "crack"
 
 group :test do
   gem "rspec", ">= 2.0.0.beta.20"

data/Gemfile.lock

@@ -31,13 +31,12 @@ GEM
     arel (1.0.1)
       activesupport (~> 3.0.0)
     builder (2.1.2)
+    crack (0.1.8)
     diff-lcs (1.1.2)
     erubis (2.6.6)
       abstract (>= 1.0.0)
     fakeweb (1.3.0)
     i18n (0.4.1)
-    json (1.4.6)
-    json (1.4.6-java)
     mail (2.2.5)
       activesupport (>= 2.3.6)
       mime-types
@@ -81,7 +80,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  crack
   fakeweb
-  json
   rails
   rspec (>= 2.0.0.beta.20)

data/README.rdoc

@@ -1,8 +1,34 @@
 = simple_currency
 
-A really simple currency converter using Xurrency API.
+A really simple currency converter using Xurrency and XavierMedia APIs.
 Compatible with Ruby 1.8, 1.9 and JRuby.
 
+== Usage
+
+Just require it and all your numeric stuff gets this fancy DSL for free:
+
+  30.eur.to_usd
+  # => 38.08
+
+  150.eur.to_usd
+  # => 190.4
+  239.usd.to_eur
+  # => 187.98 
+  # These don't even hit the Internets!
+  # (They take advantage of Rails cache)
+
+  70.usd.to_chf
+  # => 71.9
+
+But what if you want to do the currency exchange according to a specific date
+in the past? Just do this:
+
+  # You can use any time or date object
+  42.eur.at(1.year.ago).to_usd
+  # => 60.12
+  42.eur.at(Time.parse('2009-09-01')).to_usd
+  # => 60.12
+
 == Installation
 
 === Rails 3
@@ -21,21 +47,6 @@ And manually require it as well:
 
   require "simple_currency"
 
-== Usage
-
-Now all your numeric stuff gets this fancy DSL for free:
-
-  30.eur.to_usd
-  # => 38.08
-
-  150.eur.to_usd
-  # => 190.4
-  # This one doesn't even hit Xurrency API,
-  # it takes advantage of Rails cache!
-
-  70.usd.to_chf
-  # => 71.9
-
 == Note on Patches/Pull Requests
  
 * Fork the project.

data/Rakefile

@@ -6,13 +6,13 @@ begin
   require 'jeweler'
   Jeweler::Tasks.new do |gem|
     gem.name = "simple_currency"
-    gem.summary = "A really simple currency converter using the Xurrency API."
-    gem.description = "A really simple currency converter using the Xurrency API. It's Ruby 1.8, 1.9 and JRuby compatible, and it also takes advantage of Rails cache when available."
+    gem.summary = "A really simple currency converter using the Xurrency and XavierMedia APIs."
+    gem.description = "A really simple currency converter using the Xurrency and XavierMedia APIs. It's Ruby 1.8, 1.9 and JRuby compatible, and it also takes advantage of Rails cache when available."
     gem.email = "info@codegram.com"
     gem.homepage = "http://github.com/codegram/simple_currency"
     gem.authors = ["Oriol Gual", "Josep M. Bach", "Josep Jaume Rey"]
 
-    gem.add_dependency 'json', ">= 1.4.3"
+    gem.add_dependency 'crack', ">= 0.1.8"
 
     gem.add_development_dependency "jeweler", '>= 1.4.0'
     gem.add_development_dependency "rspec", '>= 2.0.0.beta.20'

data/VERSION

@@ -1 +1 @@
-1.0.2
+1.1.1

data/lib/simple_currency/currency_convertible.rb

@@ -1,6 +1,6 @@
 require 'open-uri'
 require 'timeout'
-require 'json'
+require 'crack'
 
 module CurrencyConvertible
 
@@ -15,75 +15,212 @@ module CurrencyConvertible
     super(method,*args,&block)
   end
 
+  # Historical exchange lookup
+  def at(exchange = nil)
+    begin
+      @exchange_date = exchange.send(:to_date)
+    rescue
+      raise "Must use 'at' with a time or date object"
+    end
+    self
+  end
+
   private
-    
+   
+    # Called from first currency metamethod to set the original currency.
+    # 
+    # 30.eur # => Calls _from and sets @original to 'eur'
+    #
     def _from(currency)
+      @exchange_date = nil
       @original = currency
       self
     end
 
+    # Called from last currency metamethod to set the target currency.
+    # 
+    #   30.eur.to_usd 
+    #   # => Calls _to and returns the final value, say 38.08
+    #
     def _to(target)
       raise unless @original # Must be called after a _from have set the @original currency
 
+      return 0.0 if self == 0 # Obviously
+
       original = @original
 
-      negative = (self < 0)
-      amount = self.abs
+      amount = self
 
       # Check if there's a cached exchange rate for today
-      if defined?(Rails) && cached_amount = check_cache(original, target, amount)
-        return cached_amount
-      end
+      return cached_amount(original, target, amount) if cached_rate(original, target)
 
-      # If not, perform a call to the api
-      json_response = call_api(original, target, amount)
-      return nil unless json_response && parsed_response = JSON.parse(json_response)
-      raise parsed_response["message"] if parsed_response["status"] != "ok"
+      # If not, perform calls to APIs, deal with caches...
+      result = exchange(original, target, amount.abs)
 
-      result = sprintf("%.2f", parsed_response["result"]["value"]).to_f
+      # Cache methods
+      cache_currency_methods(original, target)
 
-      # Cache exchange rate for today only
-      Rails.cache.write("#{original}_#{target}_#{Time.now.to_a[3..5].join('-')}", calculate_rate(amount,result)) if defined?(Rails)
+      result
+    end
 
-      # Cache the _from method for faster reuse
-      self.class.send(:define_method, original.to_sym) do
-          _from(original)
-      end unless self.respond_to?(original.to_sym)
+    # Main method (called by _to) which calls Xavier or Xurrency strategies
+    # and returns a nice result.
+    #
+    def exchange(original, target, amount)
+      negative = (self < 0)
 
-      # Cache the _to method for faster reuse
-      self.class.send(:define_method, :"to_#{target}") do
-          _to(target)
-      end unless self.respond_to?(:"to_#{target}")
+      result = @exchange_date ? call_xavier_api(original, target, amount) : call_xurrency_api(original, target, amount)
+
+      # Round result to 2 decimals
+      result = sprintf("%.2f", result).to_f
 
       return -(result) if negative
       result
     end
 
-    def check_cache(original, target, amount)
-      if rate = Rails.cache.read("#{original}_#{target}_#{Time.now.to_a[3..5].join('-')}")
-        result = (amount * rate).to_f
-        return result = (result * 100).round.to_f / 100
-      end
-      nil
-    end
-
-    def call_api(original, target, amount)
+    ## 
+    # API call strategies
+    ##
+   
+    # Calls Xurrency API to perform the exchange without a specific date (assuming today)
+    #
+    def call_xurrency_api(original, target, amount)
       api_url = "http://xurrency.com/api/#{[original, target, amount].join('/')}"
       uri = URI.parse(api_url)
 
       retries = 10
+      json_response = nil
       begin
         Timeout::timeout(1){
-          uri.open.read || nil # Returns the raw response
+          json_response = uri.open.read || nil # Returns the raw response
         }
       rescue Timeout::Error
         retries -= 1
         retries > 0 ? sleep(0.42) && retry : raise
       end
+
+      return nil unless json_response && parsed_response = Crack::JSON.parse(json_response)
+      raise parsed_response['message'] if parsed_response['status'] != 'ok'
+
+      result = parsed_response['result']['value'].to_f
+      cache_rate(original, target, (result / amount))
+      result
     end
 
-    def calculate_rate(amount,result)
-      (result / amount).to_f
+    # Calls Xavier API to perform the exchange with a specific date.
+    # This method is called when using :at method, like this:
+    #
+    #   30.eur.at(1.year.ago).to_usd
+    #
+    def call_xavier_api(original, target, amount)
+
+      # Check if there is any cached XML for the specified date
+      if defined?(Rails)
+        parsed_response = Rails.cache.read("xaviermedia_#{stringified_exchange_date}")
+      end
+
+      unless parsed_response # Unless there is a cached XML response, ask for it
+        date = @exchange_date
+        args = [date.year, date.month.to_s.rjust(2, '0'), date.day.to_s.rjust(2,'0')]
+        api_url = "http://api.finance.xaviermedia.com/api/#{args.join('/')}.xml"
+        uri = URI.parse(api_url)
+
+        retries = 10
+        xml_response = nil
+        begin
+          Timeout::timeout(1){
+            # Returns the raw response or
+            # raises OpenURI::HTTPError when no data available
+            xml_response = uri.open.read || nil
+          }
+        rescue Timeout::Error
+          retries -= 1
+          retries > 0 ? sleep(0.42) && retry : raise
+        end
+
+        return nil unless xml_response && parsed_response = Crack::XML.parse(xml_response)["xavierresponse"]["exchange_rates"]["fx"]
+
+        # Cache successful XML response for later reuse
+        if defined?(Rails)
+          Rails.cache.write("xaviermedia_#{stringified_exchange_date}", parsed_response)
+        end
+      end
+
+      # Calculate the exchange rate from the XML
+      if parsed_response.first['basecurrency'].downcase == original
+        rate = parsed_response.select{|element| element["currency_code"].downcase == target}.first['rate'].to_f
+      elsif parsed_response.first['basecurrency'].downcase == target
+        target_rate = parsed_response.select{|element| element["currency_code"].downcase == original}.first['rate'].to_f
+        rate = 1 / target_rate if target_rate
+      else
+        original_rate = parsed_response.select{|element| element["currency_code"].downcase == original}.first['rate'].to_f
+        target_rate = parsed_response.select{|element| element["currency_code"].downcase == target}.first['rate'].to_f
+        rate = target_rate / original_rate
+      end
+
+      if rate
+        cache_rate(original, target, rate)
+        return amount * rate
+      end
+      nil
+    end
+
+    # Caches currency methods to avoid method missing abuse.
+    #
+    def cache_currency_methods(original, target)
+      # Cache the _from method for faster reuse
+      self.class.send(:define_method, original.to_sym) do
+          _from(original)
+      end unless self.respond_to?(original.to_sym)
+
+      # Cache the _to method for faster reuse
+      self.class.send(:define_method, :"to_#{target}") do
+          _to(target)
+      end unless self.respond_to?(:"to_#{target}")
+    end
+
+    ##
+    # Cache helper methods (only useful in a Rails app)
+    ##
+
+    # Returns a suitable string-like date (like "25-8-2010"),
+    # aware of possible @exchange_date set by :at method
+    #
+    def stringified_exchange_date
+      value = (@exchange_date || Time.now.send(:to_date))
+      [value.day, value.month, value.year].join('-')
+    end
+
+    # Writes rate to the cache.
+    #
+    def cache_rate(original, target, rate)
+      Rails.cache.write("#{original}_#{target}_#{stringified_exchange_date}", rate) if defined?(Rails)
+    end
+
+    # Tries to either get rate or calculate the inverse rate from cache.
+    #
+    # First looks for an "usd_eur_25-8-2010" entry in the cache,
+    # and if it does not find it, it looks for "eur_usd_25-8-2010" and
+    # inverts it.
+    #
+    def cached_rate(original, target)
+      if defined?(Rails)
+        unless rate = Rails.cache.read("#{original}_#{target}_#{stringified_exchange_date}")
+          rate = (1.0 / Rails.cache.read("#{target}_#{original}_#{stringified_exchange_date}")) rescue nil
+        end
+        rate
+      end
+    end
+
+    # Checks if there's a cached rate and calculates the result
+    # from the amount (or returns nil).
+    #
+    def cached_amount(original, target, amount)
+      if rate = cached_rate(original, target)
+        result = (amount * rate).to_f
+        return result = (result * 100).round.to_f / 100
+      end
+      nil
     end
 
 end

data/simple_currency.gemspec

@@ -5,12 +5,12 @@
 
 Gem::Specification.new do |s|
   s.name = %q{simple_currency}
-  s.version = "1.0.2"
+  s.version = "1.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Oriol Gual", "Josep M. Bach", "Josep Jaume Rey"]
-  s.date = %q{2010-08-31}
-  s.description = %q{A really simple currency converter using the Xurrency API. It's Ruby 1.8, 1.9 and JRuby compatible, and it also takes advantage of Rails cache when available.}
+  s.date = %q{2010-09-01}
+  s.description = %q{A really simple currency converter using the Xurrency and XavierMedia APIs. It's Ruby 1.8, 1.9 and JRuby compatible, and it also takes advantage of Rails cache when available.}
   s.email = %q{info@codegram.com}
   s.extra_rdoc_files = [
     "LICENSE",
@@ -34,13 +34,14 @@ Gem::Specification.new do |s|
      "lib/simple_currency/currency_convertible.rb",
      "simple_currency.gemspec",
      "spec/simple_currency_spec.rb",
-     "spec/spec_helper.rb"
+     "spec/spec_helper.rb",
+     "spec/support/xavier.xml"
   ]
   s.homepage = %q{http://github.com/codegram/simple_currency}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
   s.rubygems_version = %q{1.3.6}
-  s.summary = %q{A really simple currency converter using the Xurrency API.}
+  s.summary = %q{A really simple currency converter using the Xurrency and XavierMedia APIs.}
   s.test_files = [
     "spec/simple_currency_spec.rb",
      "spec/spec_helper.rb"
@@ -51,14 +52,14 @@ Gem::Specification.new do |s|
     s.specification_version = 3
 
     if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<json>, [">= 1.4.3"])
+      s.add_runtime_dependency(%q<crack>, [">= 0.1.8"])
       s.add_development_dependency(%q<jeweler>, [">= 1.4.0"])
       s.add_development_dependency(%q<rspec>, [">= 2.0.0.beta.20"])
       s.add_development_dependency(%q<fakeweb>, [">= 1.3.0"])
       s.add_development_dependency(%q<rails>, [">= 3.0.0"])
       s.add_development_dependency(%q<bundler>, [">= 1.0.0"])
     else
-      s.add_dependency(%q<json>, [">= 1.4.3"])
+      s.add_dependency(%q<crack>, [">= 0.1.8"])
       s.add_dependency(%q<jeweler>, [">= 1.4.0"])
       s.add_dependency(%q<rspec>, [">= 2.0.0.beta.20"])
       s.add_dependency(%q<fakeweb>, [">= 1.3.0"])
@@ -66,7 +67,7 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<bundler>, [">= 1.0.0"])
     end
   else
-    s.add_dependency(%q<json>, [">= 1.4.3"])
+    s.add_dependency(%q<crack>, [">= 0.1.8"])
     s.add_dependency(%q<jeweler>, [">= 1.4.0"])
     s.add_dependency(%q<rspec>, [">= 2.0.0.beta.20"])
     s.add_dependency(%q<fakeweb>, [">= 1.3.0"])

data/spec/simple_currency_spec.rb

@@ -2,89 +2,195 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe "SimpleCurrency" do
 
-  def mock_uri(from_currency, to_currency, amount, result, options = {})
-    args = [from_currency, to_currency, amount]
+  describe "in its basic behavior" do
 
-    response = "{\"result\":{\"value\":#{result},\"target\":\"#{to_currency}\",\"base\":\"#{from_currency}\"},\"status\":\"ok\"}"
+    it "enhances instances of Numeric with currency methods" do
+      expect { 30.eur && 30.usd && 30.gbp }.to_not raise_error
+    end
 
-    response = "{\"message\":\"#{options[:fail_with]}\", \"status\":\"fail\"\}" if options[:fail_with]
+    it "handles zero values (by returning them straight away)" do
+      0.usd.to_eur.should == 0.0 
+    end
 
-    FakeWeb.register_uri(:get, "http://xurrency.com/api/#{args.join('/')}", :body => response)
   end
 
-  it "enhances instances of Numeric with currency methods" do
-    expect { 30.eur && 30.usd && 30.gbp }.to_not raise_error
-  end
+  context "using Xurrency API for right-now exchange" do
 
-  it "returns a converted amount from one currency to another" do
-    mock_uri('eur', 'usd', 2, 1.542)
-    2.eur.to_usd.should == 1.54
+    it "returns a converted amount from one currency to another" do
+      mock_xurrency_api('eur', 'usd', 2, 1.542)
+      2.eur.to_usd.should == 1.54
 
-    mock_uri('gbp', 'chf', 2, 3.4874)
-    2.gbp.to_chf.should == 3.49
-  end
+      mock_xurrency_api('gbp', 'chf', 2, 3.4874)
+      2.gbp.to_chf.should == 3.49
+    end
+
+    it "caches methods for faster reuse" do
+      mock_xurrency_api('usd', 'eur', 1, 1.5)
 
-  it "caches methods for faster reuse" do
-    mock_uri('usd', 'eur', 1, 1.5)
+      1.usd.to_eur.should == 1.5
 
-    1.usd.to_eur.should == 1.5
+      8.should respond_to(:usd)
+      8.should respond_to(:to_eur)
+    end
 
-    8.should respond_to(:usd)
-    8.should respond_to(:to_eur)
-  end
+    it "raises any error returned by the api call" do
+      mock_xurrency_api('usd', 'xxx', 1, 1.5, :fail_with => "The currencies are not valid")
+      mock_xurrency_api('usd', 'eur', 1_000_000_000, 1.5, :fail_with => "The amount should be between 0 and 999999999")
+
+      expect {1.usd.to_xxx}.to raise_error("The currencies are not valid")
+      expect {1_000_000_000.usd.to_eur}.to raise_error("The amount should be between 0 and 999999999")
+    end
+
+    it "handles a negative value returning a negative as well" do
+      mock_xurrency_api('usd', 'eur', 1, 1.5)
 
-  it "raises any error returned by the api call" do
-    mock_uri('usd', 'xxx', 1, 1.5, :fail_with => "The currencies are not valid")
-    mock_uri('usd', 'eur', 1_000_000_000, 1.5, :fail_with => "The amount should be between 0 and 999999999")
+      -1.usd.to_eur.should == -1.5
+    end
 
-    expect {1.usd.to_xxx}.to raise_error("The currencies are not valid")
-    expect {1_000_000_000.usd.to_eur}.to raise_error("The amount should be between 0 and 999999999")
   end
 
-  it "handles a negative value returning a negative as well" do
-    mock_uri('usd', 'eur', 1, 1.5)
+  context "using XavierMedia API for exchange with historical date" do
+
+    let(:the_past) { Time.parse('2010-08-25')}
+    let(:the_ancient_past) { Time.parse('1964-08-25')}
+
+    it "enhances instances of Numeric with :at method" do
+      expect { 30.eur.at(Time.now) }.to_not raise_error
+      expect { 30.usd.at("no date")}.to raise_error("Must use 'at' with a time or date object")
+      expect { 30.gbp.at(:whatever_arg) }.to raise_error("Must use 'at' with a time or date object")
+    end
+
+    it "returns a converted amount from one currency to another" do
+      mock_xavier_api(the_past)
+      2.eur.at(the_past).to_usd.should == 2.54
+      2.usd.at(the_past).to_eur.should == 1.58
+      2.gbp.at(the_past).to_usd.should == 3.07
+    end
+
+    it "raises an error when no data available" do
+      mock_xavier_api(the_past, :fail => true)  # Currency does not exist!
+      mock_xavier_api(the_ancient_past, :fail => true) # Too old!
+
+      expect {1.usd.at(the_past).to_xxx}.to raise_error(OpenURI::HTTPError)
+      expect {1.usd.at(the_ancient_past).to_eur}.to raise_error(OpenURI::HTTPError)
+    end
 
-    -1.usd.to_eur.should == -1.5
   end
 
-  context "when Rails is present" do
+  context "when Rails (and its cache goodness) is present" do
+
+    let(:now) { Time.parse('2010-08-30') }
 
     before(:all) do
       require 'rails'
     end
 
-    it "caches the exchange rate" do
+    context "using Xurrency API for right-now exchange" do
 
-      Rails.stub_chain("cache.write").and_return(true)
-      Rails.stub_chain("cache.read").and_return(1.5)
+      before(:each) do
+        Time.stub(:now).and_return(now)
 
-      mock_uri('usd', 'eur', 1, 1.5)
-      1.usd.to_eur.should == 1.5
+        Rails.stub_chain("cache.read").and_return(false)
+        Rails.stub_chain("cache.write").and_return(true)
+      end
 
-      URI.should_not_receive(:parse)
-      2.usd.to_eur.should == 3
-    end
+      it "reads the exchange rate from the cache" do
+        Rails.stub_chain("cache.read").and_return(1.5)
 
-    it "ensures the cache is valid only for today" do
-      now = Time.parse('2010-08-30')
+        mock_xurrency_api('usd', 'eur', 1, 1.5)
+        1.usd.to_eur.should == 1.5
 
-      Time.stub(:now).and_return(now)
+        URI.should_not_receive(:parse)
+        2.usd.to_eur.should == 3
+      end
 
-      Rails.stub_chain("cache.write").and_return(true)
-      Rails.stub_chain("cache.read").with('usd_eur_30-8-2010').and_return(1.5)
+      it "reads the inverse exchange rate from the cache" do
+        Rails.stub_chain("cache.read").with('usd_eur_30-8-2010').and_return(1.5)
+        Rails.stub_chain("cache.read").with('gbp_eur_30-8-2010').and_return(3)
+        Rails.stub_chain("cache.read").with('gbp_usd_30-8-2010').and_return(false)
 
-      mock_uri('usd', 'eur', 1, 1.5)
-      1.usd.to_eur.should == 1.5
+        mock_xurrency_api('usd', 'eur', 1, 1.5)
+        mock_xurrency_api('gbp', 'eur', 1, 3)
+
+        1.usd.to_eur.should == 1.5
+        1.gbp.to_eur.should == 3
+
+        URI.should_not_receive(:parse)
+        3.eur.to_usd.should == 2
+        3.eur.to_gbp.should == 1
+      end
+
+      it "caches the exchange rate" do
+        Rails.stub_chain("cache.read").with('usd_eur_30-8-2010').and_return(false)
+
+        Rails.cache.should_receive(:write).with('usd_eur_30-8-2010', 1.5)
+
+        mock_xurrency_api('usd', 'eur', 1, 1.5)
+        1.usd.to_eur.should == 1.5
+      end
 
-      Time.stub(:now).and_return(now + 86400) # One day later
-      Rails.stub_chain("cache.read").with('usd_eur_31-8-2010').and_return(nil)
+      it "ensures the cache is valid only for today" do
+        Rails.stub_chain("cache.read").with('usd_eur_30-8-2010').and_return(1.5)
 
-      # Exchange rate has changed next day, so forget cache rate!
-      mock_uri('usd', 'eur', 2, 4)
-      2.usd.to_eur.should == 4
+        mock_xurrency_api('usd', 'eur', 1, 1.5)
+        1.usd.to_eur.should == 1.5
+
+        Time.stub(:now).and_return(now + 86400) # One day later
+        Rails.stub_chain("cache.read").with('usd_eur_31-8-2010').and_return(nil)
+
+        # Exchange rate has changed next day, so forget cache rate!
+        mock_xurrency_api('usd', 'eur', 2, 4)
+        2.usd.to_eur.should == 4
+      end
 
     end
 
-  end
+    context "using XavierMedia API for exchange with historical date" do
+
+      let(:the_past) { Time.parse('2010-08-25') }
+
+      before(:each) do
+        Rails.stub_chain("cache.read").and_return(false)
+        Rails.stub_chain("cache.write").and_return(true)
+
+        mock_xavier_api(the_past)
+      end
 
+      it "reads the exchange rate from the cache" do
+        Rails.stub_chain("cache.read").with('usd_eur_25-8-2010').and_return(0.79)
+
+        URI.should_not_receive(:parse)
+        1.usd.at(the_past).to_eur.should == 0.79
+        2.usd.at(the_past).to_eur.should == 1.58
+      end
+
+      it "caches the exchange rate with full precision" do
+        Rails.cache.should_receive(:write).with('eur_jpy_25-8-2010', 107.07).ordered
+        Rails.cache.should_receive(:write).with("eur_usd_25-8-2010", 1.268).ordered
+        Rails.cache.should_receive(:write).with("eur_huf_25-8-2010", 287.679993).ordered
+
+        1.eur.at(the_past).to_jpy
+        1.eur.at(the_past).to_usd
+        2.eur.at(the_past).to_huf
+      end
+
+      it "caches the XML response" do
+        Rails.cache.should_receive(:write).with('xaviermedia_25-8-2010', an_instance_of(Array)).and_return(true)
+
+        1.eur.at(the_past).to_usd
+      end
+
+      it "uses the base currency (EUR) cache to calculate other rates" do
+        1.eur.at(the_past).to_jpy.should == 107.07
+
+        Rails.stub_chain("cache.read").with('xaviermedia_25-8-2010').and_return(Crack::XML.parse(fixture('xavier.xml'))["xavierresponse"]["exchange_rates"]["fx"])
+
+        URI.should_not_receive(:parse)
+
+        1.usd.at(the_past).to_eur.should == 0.79
+        1.eur.at(the_past).to_gbp.should == 0.82
+        2.gbp.at(the_past).to_usd.should == 3.07
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -7,3 +7,32 @@ require 'fakeweb'
 require 'simple_currency'
 require 'rspec'
 require 'rspec/autorun'
+
+module HelperMethods
+  def fixture(name)
+    File.read(File.dirname(__FILE__) +  "/support/#{name}")
+  end
+
+  def mock_xurrency_api(from_currency, to_currency, amount, result, options = {})
+    args = [from_currency, to_currency, amount]
+
+    response = "{\"result\":{\"value\":#{result},\"target\":\"#{to_currency}\",\"base\":\"#{from_currency}\"},\"status\":\"ok\"}"
+
+    response = "{\"message\":\"#{options[:fail_with]}\", \"status\":\"fail\"\}" if options[:fail_with]
+
+    FakeWeb.register_uri(:get, "http://xurrency.com/api/#{args.join('/')}", :body => response)
+  end
+
+  def mock_xavier_api(date, options = {})
+    date = date.send(:to_date)
+    args = [date.year, date.month.to_s.rjust(2, '0'), date.day.to_s.rjust(2,'0')]
+
+    response = {:body => fixture("xavier.xml")}
+    response = {:body => "No exchange rate available", :status => ["404", "Not Found"]} if options[:fail]
+
+    FakeWeb.register_uri(:get, "http://api.finance.xaviermedia.com/api/#{args.join('/')}.xml", response)
+  end
+
+end
+
+RSpec.configuration.include(HelperMethods)

data/spec/support/xavier.xml

@@ -0,0 +1,156 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<?xml-stylesheet href="http://api.finance.xaviermedia.com/style/daily_rates.xsl" type="text/xsl"?>
+<xavierresponse responsecode="200">
+  <fx_date>2010-08-31</fx_date>
+  <title>Xavier Finance - Exchange rates for 2010-08-31</title>
+  <link>http://finance.xaviermedia.com/</link>
+  <exchange_rates>
+    <basecurrency>EUR</basecurrency>
+    <fx_date>2010-08-31</fx_date>
+    <fx basecurrency="EUR">
+	<currency_code>EUR</currency_code>
+	<rate>1.0</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>USD</currency_code>
+	<rate>1.268000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>JPY</currency_code>
+	<rate>107.070000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>GBP</currency_code>
+	<rate>0.824800</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>CYP</currency_code>
+	<rate>0.000000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>CZK</currency_code>
+	<rate>24.850000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>DKK</currency_code>
+	<rate>7.444800</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>EEK</currency_code>
+	<rate>15.646600</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>HUF</currency_code>
+	<rate>287.679993</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>LTL</currency_code>
+	<rate>3.452800</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>MTL</currency_code>
+	<rate>0.000000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>PLN</currency_code>
+	<rate>4.013500</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>SEK</currency_code>
+	<rate>9.389000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>SIT</currency_code>
+	<rate>0.000000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>SKK</currency_code>
+	<rate>0.000000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>CHF</currency_code>
+	<rate>1.293500</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>ISK</currency_code>
+	<rate>0.000000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>NOK</currency_code>
+	<rate>8.024500</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>BGN</currency_code>
+	<rate>1.955800</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>HRK</currency_code>
+	<rate>7.272500</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>ROL</currency_code>
+	<rate>0.000000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>RON</currency_code>
+	<rate>4.256800</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>RUB</currency_code>
+	<rate>39.103802</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>TRL</currency_code>
+	<rate>0.000000</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>AUD</currency_code>
+	<rate>1.430400</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>CAD</currency_code>
+	<rate>1.348900</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>CNY</currency_code>
+	<rate>8.631800</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>HKD</currency_code>
+	<rate>9.865300</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>IDR</currency_code>
+	<rate>11471.820</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>KRW</currency_code>
+	<rate>1520.050049</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>MYR</currency_code>
+	<rate>3.993600</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>NZD</currency_code>
+	<rate>1.818700</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>PHP</currency_code>
+	<rate>57.456001</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>SGD</currency_code>
+	<rate>1.719300</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>THB</currency_code>
+	<rate>39.669998</rate>
+    </fx>
+    <fx basecurrency="EUR">
+	<currency_code>ZAR</currency_code>
+	<rate>9.404400</rate>
+    </fx>
+  </exchange_rates>
+</xavierresponse>
+	

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 1
-  - 0
-  - 2
-  version: 1.0.2
+  - 1
+  - 1
+  version: 1.1.1
 platform: ruby
 authors: 
 - Oriol Gual
@@ -16,21 +16,21 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-31 00:00:00 +02:00
+date: 2010-09-01 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: json
+  name: crack
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
         segments: 
+        - 0
         - 1
-        - 4
-        - 3
-        version: 1.4.3
+        - 8
+        version: 0.1.8
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
@@ -105,7 +105,7 @@ dependencies:
         version: 1.0.0
   type: :development
   version_requirements: *id006
-description: A really simple currency converter using the Xurrency API. It's Ruby 1.8, 1.9 and JRuby compatible, and it also takes advantage of Rails cache when available.
+description: A really simple currency converter using the Xurrency and XavierMedia APIs. It's Ruby 1.8, 1.9 and JRuby compatible, and it also takes advantage of Rails cache when available.
 email: info@codegram.com
 executables: []
 
@@ -133,6 +133,7 @@ files:
 - simple_currency.gemspec
 - spec/simple_currency_spec.rb
 - spec/spec_helper.rb
+- spec/support/xavier.xml
 has_rdoc: true
 homepage: http://github.com/codegram/simple_currency
 licenses: []
@@ -162,7 +163,7 @@ rubyforge_project:
 rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
-summary: A really simple currency converter using the Xurrency API.
+summary: A really simple currency converter using the Xurrency and XavierMedia APIs.
 test_files: 
 - spec/simple_currency_spec.rb
 - spec/spec_helper.rb