simple_command 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3544ff81fdeafe60042fd5a29e4a3c5fb26b6091
-  data.tar.gz: e7d4c7ab4d38ba73ce1ba4967b2ededf94b8b53c
+  metadata.gz: dabb8a7bf076158513db0079c22a32a62c9be279
+  data.tar.gz: bfe07f08f8a996b159774cbaa140068f1c345006
 SHA512:
-  metadata.gz: 0a1087bc60e810ba53ea0554f762f78e4d4f2359d167a2788e92d9d6cd64b290b57228fba4b6f4c407bc8e682a4bc654b8652542de3798457a4310dbf921f0a2
-  data.tar.gz: ba370480e93a8578499231f5ac784f59820a6239089865d2a5bcd6b91dd22ea7767229608a86a08024321fff29dde495d2d0d172009869737779fa871b9defeb
+  metadata.gz: 5ddb4a9d44224a97779d648d761cd4e9f45409fbd7c16964224535ee03160d12fc9e4b8222a1ff0473709ea6b51cbcbcfdbf7b2f354fe694a883e9967f42dfab
+  data.tar.gz: 9caa9600dbeda9e0de74f96e83fd541f6c28cd68ea48c24fc6b27ea9c7a7ad27019e1c908fca116dd99cd2c18b1c69afa1aeaabcf7dc634471cb5b6ecdac616f

data/README.md

@@ -44,7 +44,7 @@ class AuthenticateUser
     if user = User.authenticate(@email, @password)
       return user
     else
-      add_error(authentication: I18n.t "authenticate_user.failure")
+      errors.add_error(authentication: I18n.t "authenticate_user.failure")
     end
     nil
   end

data/lib/simple_command.rb

@@ -32,19 +32,7 @@ module SimpleCommand
   end
 
   def errors
-    @errors ||= {}
-  end
-
-  def add_error(key, value)
-    errors[key] ||= []
-    errors[key] << value
-    errors[key].uniq!
-  end
-
-  def add_errors(errors_hash)
-    errors_hash.each do |key, values|
-      values.each { |value| add_error key, value }
-    end
+    @errors ||= Errors.new
   end
 
   private

data/lib/simple_command/errors.rb

@@ -1,3 +1,17 @@
 module SimpleCommand
   class NotImplementedError < ::StandardError; end
+
+  class Errors < Hash
+    def add_error(key, value)
+      self[key] ||= []
+      self[key] << value
+      self[key].uniq!
+    end
+
+    def add_errors(errors_hash)
+      errors_hash.each do |key, values|
+        values.each { |value| add_error key, value }
+      end
+    end
+  end
 end

data/lib/simple_command/version.rb

@@ -1,3 +1,3 @@
 module SimpleCommand
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/spec/simple_command/errors_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe SimpleCommand::Errors do
+  let(:errors) { SimpleCommand::Errors.new }
+
+  describe '#add_error' do
+    before do
+      errors.add_error :some_error, 'some error description'
+    end
+
+    it 'adds the error' do
+      expect(errors[:some_error]).to eq(['some error description'])
+    end
+
+    it 'adds the same error only once' do
+      errors.add_error :some_error, 'some error description'
+      expect(errors[:some_error]).to eq(['some error description'])
+    end
+  end
+
+  describe '#add_errors' do
+    let(:errors_list) do
+      {
+        some_error: ['some error description'],
+        another_error: ['another error description']
+      }
+    end
+
+    before do
+      errors.add_errors errors_list
+    end
+
+    it 'populates itself with the added errors' do
+      expect(errors[:some_error]).to eq(errors_list[:some_error])
+      expect(errors[:another_error]).to eq(errors_list[:another_error])
+    end
+  end
+end

data/spec/simple_command_spec.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 
 describe SimpleCommand do
   let(:command) { SuccessCommand.new(2) }
-  let(:fail_command) { FailCommand.new(2) }
 
   describe '.perform' do
     before do
@@ -41,7 +40,8 @@ describe SimpleCommand do
     end
 
     it 'is false if something went wrong' do
-      expect(fail_command.perform.success?).to be_falsy
+      command.errors.add_error(:some_error, 'some message')
+      expect(command.perform.success?).to be_falsy
     end
 
     context 'when perform is not called yet' do
@@ -69,7 +69,8 @@ describe SimpleCommand do
     end
 
     it 'is true if something went wrong' do
-      expect(fail_command.perform.failure?).to be_truthy
+      command.errors.add_error(:some_error, 'some message')
+      expect(command.perform.failure?).to be_truthy
     end
 
     context 'when perform is not called yet' do
@@ -79,57 +80,24 @@ describe SimpleCommand do
     end
   end
 
-  describe '#add_error' do
-    before do
-      command.add_error :some_error, 'some error description'
-    end
-
-    it 'adds the error' do
-      expect(command.errors[:some_error]).to eq(['some error description'])
-    end
-
-    it 'adds the same error only once' do
-      command.add_error :some_error, 'some error description'
-      expect(command.errors[:some_error]).to eq(['some error description'])
-    end
-  end
-
-  describe '#add_errors' do
-    let(:errors) do
-      {
-        some_error: ['some error description'],
-        another_error: ['another error description']
-      }
-    end
-
-    before do
-      command.add_errors errors
-    end
-
-    it 'populates #errors with the added errors' do
-      expect(command.errors[:some_error]).to eq(errors[:some_error])
-      expect(command.errors[:another_error]).to eq(errors[:another_error])
-    end
-  end
-
   describe '#errors' do
-    let(:errors) { command.perform.errors }
-
-    it 'returns an Hash' do
-      expect(errors).to be_a(Hash)
+    it 'returns an SimpleCommand::Errors' do
+      expect(command.errors).to be_a(SimpleCommand::Errors)
     end
 
     context 'with no errors' do
-      it 'returns an empty Hash' do
-        expect(errors).to be_empty
+      it 'is empty' do
+        expect(command.errors).to be_empty
       end
     end
 
     context 'with errors' do
-      let(:errors) { fail_command.perform.errors }
+      before do
+        command.errors.add_error(:some_error, 'some message')
+      end
 
       it 'has a key with error message' do
-        expect(errors[:wrong_math]).to_not be_nil
+        expect(command.errors[:some_error]).to eq(['some message'])
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_command
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Andrea Pavoni
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-10 00:00:00.000000000 Z
+date: 2015-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -71,9 +71,9 @@ files:
 - lib/simple_command/errors.rb
 - lib/simple_command/version.rb
 - simple_command.gemspec
-- spec/factories/fail_command.rb
 - spec/factories/missed_perform_command.rb
 - spec/factories/success_command.rb
+- spec/simple_command/errors_spec.rb
 - spec/simple_command_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/nebulab/simple_command
@@ -96,13 +96,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Easy way to build and manage commands (service objects)
 test_files:
-- spec/factories/fail_command.rb
 - spec/factories/missed_perform_command.rb
 - spec/factories/success_command.rb
+- spec/simple_command/errors_spec.rb
 - spec/simple_command_spec.rb
 - spec/spec_helper.rb

data/spec/factories/fail_command.rb

@@ -1,11 +0,0 @@
-class FailCommand
-  prepend SimpleCommand
-
-  def initialize(input)
-    @input = input
-  end
-
-  def perform
-    add_error(:wrong_math, 'Math is not an opinion')
-  end
-end