simple_active_link_to 1.0.4 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5196cc1a406bf131cfb61681ae45e7864728268c133c2119ae40c4a216cb72b3
-  data.tar.gz: 55f77caa6c4affa3eb4c27b64d85310e81e8f99b950bd2e06a820b89e35ae7fa
+  metadata.gz: 4ee7d38d7d8e2969e92e9b321691ae59909aa9eea01dc99d32bfd038c17aaa51
+  data.tar.gz: 00be5598705e2cfdf357bacc4cc84a1fd0c517130774ef0c56ce5f753c94c0be
 SHA512:
-  metadata.gz: b286eceb0d2524868adc437ed090fa796f6698cd1da59d112336bfd4ebbe6fbc989642264ea6f8802e6100f90321a944a8e3b1d9193413cbf0702b0477113cc3
-  data.tar.gz: ac412b3ee3c47d1554aec4bb55015eae311b7a2824a2f14eed01d4821038462dcdde9dc023899b8b17be4a2ac621358fd5c6775a01f9b0579a42e9d05451752f
+  metadata.gz: 4c742be3260769116b75cab5c24491f0a67fcb9982bc6b49109c87ad107d2a912c25005f90dac0dcf552f4ce7dd6fd0bce2bfa226ef7890d11448546afb3244b
+  data.tar.gz: 10979d2be24cae63f91cae04b229affb84bd338cb4ada349e1414fcb58a7ae8a166f420844eb4da41985de98e08afd47266b30cbe4079612361971bf220e1e6e

data/.github/workflows/gem.yml

@@ -2,9 +2,13 @@ name: Ruby Gem
 
 on:
   push:
-    branches: [ master ]
+    branches: [ master, dev ]
+    paths-ignore:
+      - "**/README.md"
   pull_request:
-    branches: [ master ]
+    branches: [ master, dev ]
+    paths-ignore:
+      - "**/README.md"
 
 jobs:
   tests:
@@ -12,17 +16,28 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [2.5, 2.6, 2.7]
-        rails: ['5.0', '5.1', '5.2', '6.0']
+        ruby: [2.5, 2.6, 2.7, 3.0]
+        rails: ['5.0', '5.1', '5.2', '6.0', '6.1']
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby 2.5
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby }}
-    - name: Bundle install
-      run: bundle install
-      env:
-        BUNDLE_GEMFILE: "test/gemfiles/${{ matrix.rails }}.gemfile"
-    - run: bundle exec rake
-
+      - uses: actions/checkout@v2
+      - name: always-upload-cache
+        # You may pin to the exact commit or the version.
+        # uses: pat-s/always-upload-cache@8bf65902d2f73eea094eb913323ef6fb84f4bcb8
+        uses: pat-s/always-upload-cache@v2.1.3
+        with:
+          # A list of files, directories, and wildcard patterns to cache and restore
+          path: $(pwd)/vendor/bundle
+          key: ${{ runner.os }}-gems-${{ hashFiles('test/gemfiles/*.gemfile') }}
+          restore-keys: |
+            ${{ runner.os }}-gems-
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - name: Bundle install
+        run: |
+          bundle config path $(pwd)/vendor/bundle
+          bundle install --jobs 4 --retry 3
+        env:
+          BUNDLE_GEMFILE: "test/gemfiles/${{ matrix.rails }}.gemfile"
+      - run: bundle exec rake

data/.gitignore

@@ -1,2 +1,4 @@
+.bundle
+
 .DS_Store
 Gemfile.lock

data/README.md

@@ -2,17 +2,17 @@
 
 `simple_active_link_to` is a wrapper for [link_to](http://api.rubyonrails.org/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to), with active state by adding an extra css class `active` by default.
 
-This project is fork of [active_link_to](https://github.com/comfy/active_link_to), but without wrap tag, and some code improvement.
+This gem works like [active_link_to](https://github.com/comfy/active_link_to), but with additional ```active_disable``` option and without wrap tag.
 
 [![Gem Version](https://img.shields.io/gem/v/simple_active_link_to.svg?style=flat)](http://rubygems.org/gems/simple_active_link_to)
 [![Gem Downloads](https://img.shields.io/gem/dt/simple_active_link_to.svg?style=flat)](http://rubygems.org/gems/simple_active_link_to)
 
-Tested with ruby >= 2.5.x <= 2.7.x and rails >= 5.0 <= 6.0
+Tested with ruby 2.5 to 2.7 and rails 5.0 to 6.1
 
 ## Installation
 add `gem 'simple_active_link_to'` to Gemfile and run `bundle install`.
 
-or using `bundle add` command
+or if you want to add with bundle command
 
 `bundle add simple_active_link_to`
 
@@ -125,6 +125,14 @@ simple_active_link_to 'Users', users_path, active_disable: true
 # => <span class="active">Users</span>
 ```
 
+or you want to append it with hash (`#`) at the end of url, it will be useful when you use Turbolinks
+and don't want the link load the page content
+
+```ruby
+simple_active_link_to 'Users', users_path, active_disable: :hash
+# => <a href="/users" class="active">Users</a>
+```
+
 ## Helper Methods
 You may directly use methods that `simple_active_link_to` relies on.
 

data/lib/simple_active_link_to/simple_active_link_to.rb

@@ -12,7 +12,7 @@ module SimpleActiveLinkTo
   #   :active         => Boolean | Symbol | Regex | Controller/Action Pair
   #   :class_active   => String
   #   :class_inactive => String
-  #   :active_disable => Boolean
+  #   :active_disable => Boolean | :hash
   # Example usage:
   #   simple_active_link_to('/users', class_active: 'enabled')
   def simple_active_link_to(name = nil, options = nil, html_options = nil, &block)
@@ -41,7 +41,12 @@ module SimpleActiveLinkTo
 
     if is_active_link?(url, active_options[:active])
       link_options[:'aria-current'] = 'page'
-      return content_tag(:span, name, link_options) if active_options[:active_disable] == true
+      case active_options[:active_disable]
+      when true
+        return content_tag(:span, name, link_options) 
+      when :hash
+        url += "#"
+      end
     end
 
     link_to(name, url, link_options)

data/lib/simple_active_link_to/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SimpleActiveLinkTo
-  VERSION = "1.0.4"
+  VERSION = "1.1.0"
 end

data/test/gemfiles/6.1.gemfile

@@ -0,0 +1,5 @@
+source 'http://rubygems.org'
+
+gemspec path: "../../"
+
+gem "actionpack", "~> 6.1.0"

data/test/simple_active_link_to_test.rb

@@ -9,6 +9,10 @@ class SimpleActiveLinkToTest < MiniTest::Test
     refute is_active_link?('/', false)
   end
 
+  def test_is_active_link_handle_empty_string
+    assert is_active_link?('', true)
+  end
+
   def test_is_active_link_symbol_inclusive
     set_path('/root')
     assert is_active_link?('/root', :inclusive)
@@ -186,12 +190,18 @@ class SimpleActiveLinkToTest < MiniTest::Test
     assert_html link, 'a.off[href="/other"]', 'label'
   end
 
-  def test_active_link_to_with_active_disable
+  def test_active_link_to_with_active_disable_as_true
     set_path('/root')
     link = simple_active_link_to('label', '/root', active_disable: true)
     assert_html link, 'span.active', 'label'
   end
 
+  def test_active_link_to_with_active_disable_as_hash
+    set_path('/root')
+    link = simple_active_link_to('label', '/root', active_disable: :hash)
+    assert_html link, 'a.active[href="/root#"]', 'label'
+  end
+
   def test_should_not_modify_passed_params
     set_path('/root')
     params = {class: 'testing', active: :inclusive}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: simple_active_link_to
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.1.0
 platform: ruby
 authors:
 - Fajarullah
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-24 00:00:00.000000000 Z
+date: 2021-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -117,6 +117,7 @@ files:
 - test/gemfiles/5.1.gemfile
 - test/gemfiles/5.2.gemfile
 - test/gemfiles/6.0.gemfile
+- test/gemfiles/6.1.gemfile
 - test/simple_active_link_to_test.rb
 - test/test_helper.rb
 homepage: http://github.com/frullah/simple_active_link_to
@@ -138,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: ActionView helper to render currently active links