simple_action 1.6.4 → 2.0.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NzZkM2MxNDg3NjZiMjFhYTM3ZThhMWJmOTAwZDE1NzkyMTIyZjMyOQ==
-  data.tar.gz: !binary |-
-    MzYzNzllZWI4Yjg4ZGE4MTAzNWJhYTEzZWYzOWNmOWI1ZmQ0ZTQ5MA==
+SHA1:
+  metadata.gz: e48238302c56cd2c7e2116bb064547d8f00401ff
+  data.tar.gz: ed86459c2dc9493d81c613bd2e7684f34f02ff04
 SHA512:
-  metadata.gz: !binary |-
-    MGEwYWM2NmZhZjQzYWVlNjk3MDNmYzE5NmIyYTI2NzY3NDdhOWUzNDAwNmIy
-    MTI0MjZhYzlhZDlhMjM1ZjA3NTdhYmZiYTZhZGIzNWEwNWZiODI3OGE1ZGU4
-    ZTdiMjZhMDk0ZDk2MDk3MGQzYjg0OTVkODY4MmY5ZDFmZTg0ZTM=
-  data.tar.gz: !binary |-
-    NTRkNzhmODM5MTM3NDE0MmM3MGYwZmEzNDU5NDljNDE0YzE0ZmM1NDY4MmRm
-    MWM0MzA3NDAwMGY3YmUyYjRiNmJmNzJlZDQwN2UwYjQ0MGI2ZDhiMWQxODQ1
-    MWUyMTE0YmNjZDdiMTI2ZWRhMDcxM2EwZjQ0YTY4N2EyYzU0YzQ=
+  metadata.gz: 193c641c1a86313edfcb44008357368374accd55379daecb09ec972844e4e347ad1c00077797ad81d0c0440ab116f972dc5b0266d64d4d8db06b8fa10c9f5d9b
+  data.tar.gz: b55b0fce68d357545fc4fe96f5c3d6a2e307f477cb5846c0d074cfe4ebacd092cb744a509a5a0e08fcbeaa25c018529091863f30b02483bf1a23afa0d7664747

data/.ruby-version

@@ -1 +1 @@
-ruby-1.9.3-p545
+2.4.1

data/Appraisals

@@ -0,0 +1,7 @@
+appraise 'simple_params-1' do
+  gem 'simple_params', '>= 1.0', '< 2.0'
+end
+
+appraise 'simple_params-2' do
+  gem 'simple_params', '>= 2.0', '< 3.0'
+end

data/Gemfile.lock

@@ -1,38 +1,40 @@
 PATH
   remote: .
   specs:
-    simple_action (1.6.3)
-      simple_params (>= 1.6.9, < 2.0)
+    simple_action (1.6.4)
+      simple_params
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (4.2.6)
-      activesupport (= 4.2.6)
-      builder (~> 3.1)
-    activesupport (4.2.6)
+    activemodel (5.1.4)
+      activesupport (= 5.1.4)
+    activesupport (5.1.4)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
     axiom-types (0.1.1)
       descendants_tracker (~> 0.0.4)
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
-    builder (3.2.2)
     coderay (1.1.0)
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
+    concurrent-ruby (1.0.5)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.2.5)
     equalizer (0.0.11)
-    i18n (0.7.0)
+    i18n (0.9.0)
+      concurrent-ruby (~> 1.0)
     ice_nine (0.11.2)
-    json (1.8.3)
     method_source (0.8.2)
-    minitest (5.9.0)
+    minitest (5.10.3)
     pry (0.10.1)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
@@ -46,15 +48,16 @@ GEM
     rspec-expectations (2.99.2)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.99.3)
-    shoulda-matchers (2.8.0)
-      activesupport (>= 3.0.0)
-    simple_params (1.6.9)
-      activemodel (>= 3.0, < 5.0)
-      shoulda-matchers (~> 2.8)
+    shoulda-matchers (3.1.2)
+      activesupport (>= 4.0.0)
+    simple_params (2.0.1)
+      activemodel (>= 3.0, <= 6.0)
+      shoulda-matchers (>= 2.8)
       virtus (>= 1.0.0)
     slop (3.6.0)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.4)
       thread_safe (~> 0.1)
     virtus (1.0.5)
       axiom-types (~> 0.1)
@@ -66,6 +69,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  appraisal
   bundler (~> 1.5)
   pry
   rake (~> 10.1)
@@ -73,4 +77,4 @@ DEPENDENCIES
   simple_action!
 
 BUNDLED WITH
-   1.11.2
+   1.15.4

data/gemfiles/.bundle/config

@@ -0,0 +1,2 @@
+---
+BUNDLE_RETRY: "1"

data/gemfiles/simple_params_1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "simple_params", ">= 1.0", "< 2.0"
+
+gemspec path: "../"

data/gemfiles/simple_params_1.gemfile.lock

@@ -0,0 +1,81 @@
+PATH
+  remote: ..
+  specs:
+    simple_action (1.6.4)
+      simple_params
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (4.2.10)
+      activesupport (= 4.2.10)
+      builder (~> 3.1)
+    activesupport (4.2.10)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    axiom-types (0.1.1)
+      descendants_tracker (~> 0.0.4)
+      ice_nine (~> 0.11.0)
+      thread_safe (~> 0.3, >= 0.3.1)
+    builder (3.2.3)
+    coderay (1.1.2)
+    coercible (1.0.0)
+      descendants_tracker (~> 0.0.1)
+    concurrent-ruby (1.0.5)
+    descendants_tracker (0.0.4)
+      thread_safe (~> 0.3, >= 0.3.1)
+    diff-lcs (1.3)
+    equalizer (0.0.11)
+    i18n (0.9.0)
+      concurrent-ruby (~> 1.0)
+    ice_nine (0.11.2)
+    method_source (0.9.0)
+    minitest (5.10.3)
+    pry (0.11.2)
+      coderay (~> 1.1.0)
+      method_source (~> 0.9.0)
+    rake (10.5.0)
+    rspec (2.99.0)
+      rspec-core (~> 2.99.0)
+      rspec-expectations (~> 2.99.0)
+      rspec-mocks (~> 2.99.0)
+    rspec-core (2.99.2)
+    rspec-expectations (2.99.2)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.99.4)
+    shoulda-matchers (2.8.0)
+      activesupport (>= 3.0.0)
+    simple_params (1.6.9)
+      activemodel (>= 3.0, < 5.0)
+      shoulda-matchers (~> 2.8)
+      virtus (>= 1.0.0)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.4)
+      thread_safe (~> 0.1)
+    virtus (1.0.5)
+      axiom-types (~> 0.1)
+      coercible (~> 1.0)
+      descendants_tracker (~> 0.0, >= 0.0.3)
+      equalizer (~> 0.0, >= 0.0.9)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  bundler (~> 1.5)
+  pry
+  rake (~> 10.1)
+  rspec (~> 2.6)
+  simple_action!
+  simple_params (>= 1.0, < 2.0)
+
+BUNDLED WITH
+   1.15.4

data/gemfiles/simple_params_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "simple_params", ">= 2.0", "< 3.0"
+
+gemspec path: "../"

data/gemfiles/simple_params_2.gemfile.lock

@@ -0,0 +1,79 @@
+PATH
+  remote: ..
+  specs:
+    simple_action (1.6.4)
+      simple_params
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (5.1.4)
+      activesupport (= 5.1.4)
+    activesupport (5.1.4)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    axiom-types (0.1.1)
+      descendants_tracker (~> 0.0.4)
+      ice_nine (~> 0.11.0)
+      thread_safe (~> 0.3, >= 0.3.1)
+    coderay (1.1.2)
+    coercible (1.0.0)
+      descendants_tracker (~> 0.0.1)
+    concurrent-ruby (1.0.5)
+    descendants_tracker (0.0.4)
+      thread_safe (~> 0.3, >= 0.3.1)
+    diff-lcs (1.3)
+    equalizer (0.0.11)
+    i18n (0.9.0)
+      concurrent-ruby (~> 1.0)
+    ice_nine (0.11.2)
+    method_source (0.9.0)
+    minitest (5.10.3)
+    pry (0.11.2)
+      coderay (~> 1.1.0)
+      method_source (~> 0.9.0)
+    rake (10.5.0)
+    rspec (2.99.0)
+      rspec-core (~> 2.99.0)
+      rspec-expectations (~> 2.99.0)
+      rspec-mocks (~> 2.99.0)
+    rspec-core (2.99.2)
+    rspec-expectations (2.99.2)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.99.4)
+    shoulda-matchers (3.1.2)
+      activesupport (>= 4.0.0)
+    simple_params (2.0.1)
+      activemodel (>= 3.0, <= 6.0)
+      shoulda-matchers (>= 2.8)
+      virtus (>= 1.0.0)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.4)
+      thread_safe (~> 0.1)
+    virtus (1.0.5)
+      axiom-types (~> 0.1)
+      coercible (~> 1.0)
+      descendants_tracker (~> 0.0, >= 0.0.3)
+      equalizer (~> 0.0, >= 0.0.9)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  bundler (~> 1.5)
+  pry
+  rake (~> 10.1)
+  rspec (~> 2.6)
+  simple_action!
+  simple_params (>= 2.0, < 3.0)
+
+BUNDLED WITH
+   1.15.4

data/lib/simple_action/version.rb

@@ -1,3 +1,3 @@
 module SimpleAction
-  VERSION = "1.6.4"
+  VERSION = "2.0.0"
 end

data/simple_action.gemspec

@@ -4,23 +4,24 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'simple_action/version'
 
 Gem::Specification.new do |spec|
-  spec.name = "simple_action"
+  spec.name = 'simple_action'
   spec.version = SimpleAction::VERSION
-  spec.authors = ["brycesenz"]
-  spec.email = ["bryce.senz@gmail.com"]
+  spec.authors = ['brycesenz']
+  spec.email = ['bryce.senz@gmail.com']
   spec.description = %q{Simple Service Object class for services & API endpoints}
   spec.summary = %q{A DSL for specifying services objects, including parameters and execution}
-  spec.homepage = "https://github.com/brycesenz/simple_action"
-  spec.license = "MIT"
+  spec.homepage = 'https://github.com/brycesenz/simple_action'
+  spec.license = 'MIT'
 
   spec.files = `git ls-files`.split($/)
   spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "simple_params", ">= 1.6.9", "< 2.0"
-  spec.add_development_dependency "bundler", "~> 1.5"
-  spec.add_development_dependency "rake", "~> 10.1"
-  spec.add_development_dependency "rspec", "~> 2.6"
-  spec.add_development_dependency "pry"
+  spec.add_dependency 'simple_params'
+  spec.add_development_dependency 'appraisal'
+  spec.add_development_dependency 'bundler', '~> 1.5'
+  spec.add_development_dependency 'rake', '~> 10.1'
+  spec.add_development_dependency 'rspec', '~> 2.6'
+  spec.add_development_dependency 'pry'
 end

data/spec/acceptance_spec.rb

@@ -1,303 +1,612 @@
 require 'spec_helper'
 
 describe "SimpleAction acceptance spec" do
-  class SimpleActionAcceptance < SimpleAction::Service
-    params do
-      param :name, type: :string
-      param :date_of_birth, type: :date, optional: true
-      validate :name_has_vowels, if: :name
+  context "with non-namespaced class" do
+    class SimpleActionAcceptance < SimpleAction::Service
+      params do
+        param :name, type: :string
+        param :date_of_birth, type: :date, optional: true
+        validate :name_has_vowels, if: :name
+
+        nested_hash :address, optional: true do
+          param :street, optional: true
+        end
 
-      nested_hash :address, optional: true do
-        param :street, optional: true
-      end
+        nested_array :phones, with_ids: true do
+          param :phone_number
+        end
 
-      nested_array :phones, with_ids: true do
-        param :phone_number
+        def name_has_vowels
+          unless name.scan(/[aeiou]/).count >= 1
+            errors.add(:name, "must contain at least one vowel")
+          end
+        end
       end
 
-      def name_has_vowels
-        unless name.scan(/[aeiou]/).count >= 1
-          errors.add(:name, "must contain at least one vowel")
+      def execute
+        name.gsub!(/[^a-zA-Z ]/,'')
+        errors.add(:name, "can't be outlier") if name == "outlier"
+
+        formatted_name = if date_of_birth.present?
+          name.upcase + ' ' + date_of_birth.strftime("%m/%d/%Y")
+        else
+          name.upcase
         end
+
+        formatted_name + " with #{phones.count} phones."
       end
     end
 
-    def execute
-      name.gsub!(/[^a-zA-Z ]/,'')
-      errors.add(:name, "can't be outlier") if name == "outlier"
-
-      formatted_name = if date_of_birth.present?
-        name.upcase + ' ' + date_of_birth.strftime("%m/%d/%Y")
-      else
-        name.upcase
+    describe "#model_name", model_name: true do
+      it "equals class name" do
+        SimpleActionAcceptance.model_name.should eq("SimpleActionAcceptance")
       end
-
-      formatted_name + " with #{phones.count} phones."
     end
-  end
 
-  describe "#model_name", model_name: true do
-    it "equals class name" do
-      SimpleActionAcceptance.model_name.should eq("SimpleActionAcceptance")
-    end
-  end
-
-  describe "#validators_on", validators_on: true do
-    it "equals class name" do
-      SimpleActionAcceptance.validators_on.should eq([])
+    describe "#validators_on", validators_on: true do
+      it "equals class name" do
+        SimpleActionAcceptance.validators_on.should eq([])
+      end
     end
-  end
 
-  describe "params #model_name", params_model_name: true do
-    it "equals class name::Params" do
-      SimpleActionAcceptance.new.params.model_name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams")
+    describe "params #model_name", params_model_name: true do
+      it "equals class name::Params" do
+        SimpleActionAcceptance.new.params.model_name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams")
+      end
     end
-  end
 
-  describe "params accessors", params: true do
-    let(:instance) { SimpleActionAcceptance.new }
+    describe "params accessors", params: true do
+      let(:instance) { SimpleActionAcceptance.new }
 
-    it "allows setters and getters on param vars" do
-      instance.name = "Bob"
-      expect(instance.name).to eq("Bob")
-    end
+      it "allows setters and getters on param vars" do
+        instance.name = "Bob"
+        expect(instance.name).to eq("Bob")
+      end
 
-    it "allows setters and getters on nested_hash" do
-      instance.address = { street: "1 Main St." }
-      expect(instance.address.street).to eq("1 Main St.")
-    end
+      it "allows setters and getters on nested_hash" do
+        instance.address = { street: "1 Main St." }
+        expect(instance.address.street).to eq("1 Main St.")
+      end
 
-    it "allows setters and getters on nested_hash using _attributes" do
-      instance.address_attributes = { street: "1 Main St." }
-      expect(instance.address.street).to eq("1 Main St.")
-    end
+      it "allows setters and getters on nested_hash using _attributes" do
+        instance.address_attributes = { street: "1 Main St." }
+        expect(instance.address.street).to eq("1 Main St.")
+      end
 
-    it "responds to build_ methods" do
-      address = instance.build_address
-      address.class.name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams::Address")
+      it "responds to build_ methods" do
+        address = instance.build_address
+        address.class.name.should eq("SimpleActionAcceptance::SimpleActionAcceptanceParams::Address")
+      end
     end
-  end
 
-  describe "class methods", class_methods: true do
-    describe "reflect_on_association", reflect_on_association: true do
-      it "returns Address class for :address" do
-        address_klass = SimpleActionAcceptance.reflect_on_association(:address)
-        address_klass.klass.should eq(SimpleActionAcceptance::SimpleActionAcceptanceParams::Address)
+    describe "class methods", class_methods: true do
+      describe "reflect_on_association", reflect_on_association: true do
+        it "returns Address class for :address" do
+          address_klass = SimpleActionAcceptance.reflect_on_association(:address)
+          address_klass.klass.should eq(SimpleActionAcceptance::SimpleActionAcceptanceParams::Address)
+        end
       end
     end
-  end
 
-  describe "acceptance cases" do
-    context "with nil params" do
-      let(:params) do
-        {
-          name: nil
-        }
-      end
+    describe "acceptance cases" do
+      context "with nil params" do
+        let(:params) do
+          {
+            name: nil
+          }
+        end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
 
-        it { should_not be_valid }
-        it { should_not be_success }
+          it { should_not be_valid }
+          it { should_not be_success }
 
-        it "should have name error" do
-          subject.errors[:name].should eq(["can't be blank"])
+          it "should have name error" do
+            subject.errors[:name].should eq(["can't be blank"])
+          end
         end
-      end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
 
-        it { should be_nil }
+        describe "effects" do
+        end
       end
 
-      describe "effects" do
+      context "with invalid params" do
+        let!(:name) { "sdfg" }
+
+        let(:params) do
+          {
+            name: name
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["must contain at least one vowel"])
+          end
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
+
+        describe "effects" do
+          it "does not alter name" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("sdfg")
+          end
+        end
       end
-    end
 
-    context "with invalid params" do
-      let!(:name) { "sdfg" }
+      context "with valid params" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should eq("BILLY with 1 phones.") }
+        end
 
-      let(:params) do
-        {
-          name: name
-        }
+        describe "effects" do
+          it "strips numbers from name" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
+        end
       end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+      context "with date coercion params" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            "date_of_birth(3i)" => "5",
+            "date_of_birth(2i)" => "6",
+            "date_of_birth(1i)" => "1984",
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
 
-        it { should_not be_valid }
-        it { should_not be_success }
+          it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        end
 
-        it "should have name error" do
-          subject.errors[:name].should eq(["must contain at least one vowel"])
+        describe "effects" do
+          it "strips numbers from name" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
         end
       end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+      context "with destroyed phones" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            date_of_birth: Date.new(1984, 6, 5),
+            phones: {
+              "0" => {
+                phone_number: "8005551210",
+                _destroy: "1"
+              },
+              "1" => {
+                phone_number: "8005551212"
+              }
+            }
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        end
 
-        it { should be_nil }
+        describe "effects" do
+          it "strips numbers from name" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
+        end
       end
 
-      describe "effects" do
-        it "does not alter name" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("sdfg")
+      context "with outlier case" do
+        let!(:name) { "outlier12" }
+
+        let(:params) do
+          {
+            name: name,
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { SimpleActionAcceptance.run(params) }
+
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["can't be outlier"])
+          end
+        end
+
+        describe "result" do
+          subject { SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
+
+        describe "effects" do
+          it "alter names" do
+            SimpleActionAcceptance.run(params)
+            name.should eq("outlier")
+          end
         end
       end
     end
+  end
 
-    context "with valid params" do
-      let!(:name) { "billy12" }
+  context "with namespaced class" do
+    module MyModule
+    end
 
-      let(:params) do
-        {
-          name: name,
-          phones: [
-            "0" => {
-              phone_number: "8005551212"
-            }
-          ]
-        }
-      end
+    class MyModule::SimpleActionAcceptance < ::SimpleAction::Service
+      params do
+        param :name, type: :string
+        param :date_of_birth, type: :date, optional: true
+        validate :name_has_vowels, if: :name
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+        nested_hash :address, optional: true do
+          param :street, optional: true
+        end
+
+        nested_array :phones, with_ids: true do
+          param :phone_number
+        end
 
-        it { should be_valid }
-        it { should be_success }
+        def name_has_vowels
+          unless name.scan(/[aeiou]/).count >= 1
+            errors.add(:name, "must contain at least one vowel")
+          end
+        end
       end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+      def execute
+        name.gsub!(/[^a-zA-Z ]/,'')
+        errors.add(:name, "can't be outlier") if name == "outlier"
+
+        formatted_name = if date_of_birth.present?
+          name.upcase + ' ' + date_of_birth.strftime("%m/%d/%Y")
+        else
+          name.upcase
+        end
 
-        it { should eq("BILLY with 1 phones.") }
+        formatted_name + " with #{phones.count} phones."
       end
+    end
 
-      describe "effects" do
-        it "strips numbers from name" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("billy")
-        end
+    describe "#model_name", model_name: true do
+      it "equals class name" do
+        MyModule::SimpleActionAcceptance.model_name.should eq("MyModule::SimpleActionAcceptance")
       end
     end
 
-    context "with date coercion params" do
-      let!(:name) { "billy12" }
-
-      let(:params) do
-        {
-          name: name,
-          "date_of_birth(3i)" => "5",
-          "date_of_birth(2i)" => "6",
-          "date_of_birth(1i)" => "1984",
-          phones: [
-            "0" => {
-              phone_number: "8005551212"
-            }
-          ]
-        }
+    describe "#validators_on", validators_on: true do
+      it "equals class name" do
+        MyModule::SimpleActionAcceptance.validators_on.should eq([])
+      end
+    end
+
+    describe "params #model_name", params_model_name: true do
+      it "equals class name::Params" do
+        MyModule::SimpleActionAcceptance.new.params.model_name.should eq("MyModule::SimpleActionAcceptance::SimpleActionAcceptanceParams")
       end
+    end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+    describe "params accessors", params: true do
+      let(:instance) { MyModule::SimpleActionAcceptance.new }
+
+      it "allows setters and getters on param vars" do
+        instance.name = "Bob"
+        expect(instance.name).to eq("Bob")
+      end
 
-        it { should be_valid }
-        it { should be_success }
+      it "allows setters and getters on nested_hash" do
+        instance.address = { street: "1 Main St." }
+        expect(instance.address.street).to eq("1 Main St.")
       end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+      it "allows setters and getters on nested_hash using _attributes" do
+        instance.address_attributes = { street: "1 Main St." }
+        expect(instance.address.street).to eq("1 Main St.")
+      end
 
-        it { should eq("BILLY 06/05/1984 with 1 phones.") }
+      it "responds to build_ methods" do
+        address = instance.build_address
+        address.class.name.should eq("MyModule::SimpleActionAcceptance::SimpleActionAcceptanceParams::Address")
       end
+    end
 
-      describe "effects" do
-        it "strips numbers from name" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("billy")
+    describe "class methods", class_methods: true do
+      describe "reflect_on_association", reflect_on_association: true do
+        it "returns Address class for :address" do
+          address_klass = MyModule::SimpleActionAcceptance.reflect_on_association(:address)
+          address_klass.klass.should eq(MyModule::SimpleActionAcceptance::SimpleActionAcceptanceParams::Address)
         end
       end
     end
 
-    context "with destroyed phones" do
-      let!(:name) { "billy12" }
-
-      let(:params) do
-        {
-          name: name,
-          date_of_birth: Date.new(1984, 6, 5),
-          phones: {
-            "0" => {
-              phone_number: "8005551210",
-              _destroy: "1"
-            },
-            "1" => {
-              phone_number: "8005551212"
-            }
+    describe "acceptance cases" do
+      context "with nil params" do
+        let(:params) do
+          {
+            name: nil
           }
-        }
-      end
+        end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
 
-        it { should be_valid }
-        it { should be_success }
-      end
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["can't be blank"])
+          end
+        end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
 
-        it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        describe "effects" do
+        end
       end
 
-      describe "effects" do
-        it "strips numbers from name" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("billy")
+      context "with invalid params" do
+        let!(:name) { "sdfg" }
+
+        let(:params) do
+          {
+            name: name
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
+
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["must contain at least one vowel"])
+          end
+        end
+
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
+
+        describe "effects" do
+          it "does not alter name" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("sdfg")
+          end
         end
       end
-    end
 
-    context "with outlier case" do
-      let!(:name) { "outlier12" }
+      context "with valid params" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
 
-      let(:params) do
-        {
-          name: name,
-          phones: [
-            "0" => {
-              phone_number: "8005551212"
-            }
-          ]
-        }
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should eq("BILLY with 1 phones.") }
+        end
+
+        describe "effects" do
+          it "strips numbers from name" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
+        end
       end
 
-      describe "outcome" do
-        subject { SimpleActionAcceptance.run(params) }
+      context "with date coercion params" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            "date_of_birth(3i)" => "5",
+            "date_of_birth(2i)" => "6",
+            "date_of_birth(1i)" => "1984",
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
 
-        it { should_not be_valid }
-        it { should_not be_success }
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        end
 
-        it "should have name error" do
-          subject.errors[:name].should eq(["can't be outlier"])
+        describe "effects" do
+          it "strips numbers from name" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
         end
       end
 
-      describe "result" do
-        subject { SimpleActionAcceptance.run(params).result }
+      context "with destroyed phones" do
+        let!(:name) { "billy12" }
+
+        let(:params) do
+          {
+            name: name,
+            date_of_birth: Date.new(1984, 6, 5),
+            phones: {
+              "0" => {
+                phone_number: "8005551210",
+                _destroy: "1"
+              },
+              "1" => {
+                phone_number: "8005551212"
+              }
+            }
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
+
+          it { should be_valid }
+          it { should be_success }
+        end
+
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
 
-        it { should be_nil }
+          it { should eq("BILLY 06/05/1984 with 1 phones.") }
+        end
+
+        describe "effects" do
+          it "strips numbers from name" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("billy")
+          end
+        end
       end
 
-      describe "effects" do
-        it "alter names" do
-          SimpleActionAcceptance.run(params)
-          name.should eq("outlier")
+      context "with outlier case" do
+        let!(:name) { "outlier12" }
+
+        let(:params) do
+          {
+            name: name,
+            phones: [
+              "0" => {
+                phone_number: "8005551212"
+              }
+            ]
+          }
+        end
+
+        describe "outcome" do
+          subject { MyModule::SimpleActionAcceptance.run(params) }
+
+          it { should_not be_valid }
+          it { should_not be_success }
+
+          it "should have name error" do
+            subject.errors[:name].should eq(["can't be outlier"])
+          end
+        end
+
+        describe "result" do
+          subject { MyModule::SimpleActionAcceptance.run(params).result }
+
+          it { should be_nil }
+        end
+
+        describe "effects" do
+          it "alter names" do
+            MyModule::SimpleActionAcceptance.run(params)
+            name.should eq("outlier")
+          end
         end
       end
     end

metadata

@@ -1,89 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: simple_action
 version: !ruby/object:Gem::Version
-  version: 1.6.4
+  version: 2.0.0
 platform: ruby
 authors:
 - brycesenz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-11 00:00:00.000000000 Z
+date: 2017-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple_params
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.9
-    - - <
-      - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.9
-    - - <
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.6'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Simple Service Object class for services & API endpoints
@@ -93,14 +101,20 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .ruby-gemset
-- .ruby-version
+- ".gitignore"
+- ".rspec"
+- ".ruby-gemset"
+- ".ruby-version"
+- Appraisals
 - Gemfile
 - Gemfile.lock
 - LICENSE
 - README.md
+- gemfiles/.bundle/config
+- gemfiles/simple_params_1.gemfile
+- gemfiles/simple_params_1.gemfile.lock
+- gemfiles/simple_params_2.gemfile
+- gemfiles/simple_params_2.gemfile.lock
 - lib/simple_action.rb
 - lib/simple_action/concerns/accepts_params.rb
 - lib/simple_action/concerns/delegates_to_params.rb
@@ -131,17 +145,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A DSL for specifying services objects, including parameters and execution