simple_action 1.3.6 → 1.4.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YzFlM2UwNjk5Mjk0YjdhNGUwNGNkMTczOTQyZDEyMzUwMzA5MzFlNg==
+    NjU0MDE2YjEyMmQ0Yjk0ZDcyN2E1NTI5ODFhYTAzMThiYTliMDJmOQ==
   data.tar.gz: !binary |-
-    OTNhNjkyZWMzMGZmMTU5Y2RiZjc4MTE5N2UyMjk3MjQxYTQ3NzBhZQ==
+    MTU0NTJlYTlmMzQ1MDA4MTNkNmRhNjBjNjczM2MxNDdhNDUyOGJmMA==
 SHA512:
   metadata.gz: !binary |-
-    ODM5ZmNiNjc4NWJjMjFkN2RlZGRkYzIxMTE5NDVhZTRlODUwNDViZGJhYWI3
-    MWFlZDdhN2EwMWZjYWNmZGM0ZWQ3NDY4ZjQ1ZTViMDNkZWY5ZjMyYzk1NTEz
-    MTM5M2Y4ZWNhOWY5YThmZDY0YjU0M2I3MjQwMmYxNDhkODY5YTI=
+    YjQzMjM1NmMzMTI2Y2VkMmFiYThlMWQ3MGRhMWJkZDQzNjVhZjlhOTliMDQy
+    MGFmNTY3ZDAzODA2M2ZiZDIyYjZkZTkwZjZkOTU1ZGM4ZWYwNzI1YjZmN2Qy
+    YzRkZWFiZmI3MmI5NTdhYTQ5OGJhYmM0NjJmMjEyODQxZTQyNjg=
   data.tar.gz: !binary |-
-    M2RmYzk3ODFjZWQ1YzdhMzU4NDIwMjVmMzc4ZmZmYTIzNjQ4MDI1NzJmMGU4
-    ZWRhYzY2NDkwMTliNGVmMThkMzRkNWExYzlhYWM0ODExNGMyYzQ3OWM1ODcx
-    YmZlMGU3MjNkMzBmYzc4NDIyNTFiODYwMmQ1MTk5ZTgxOWJlODc=
+    YTlhNzIyYTdmMThlNzY2YmE4YjljODk5YThmZGZjZmYxNGZkMWViNjY2MzA3
+    MGMwNGZmNGEzOGNlNGYwYWQ5ODVlMWQxMDBmZTRhMDE4NWMyZTdjNjY4ZWFi
+    MjViOGIzN2VmOTc0YzM2YzYzNTg5ZTAwZjg5YjE0ZTgyZGJiODE=

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    simple_action (1.3.5)
-      simple_params (>= 1.3.6, < 2.0)
+    simple_action (1.3.6)
+      simple_params (>= 1.4, < 2.0)
 
 GEM
   remote: https://rubygems.org/
@@ -48,7 +48,7 @@ GEM
     rspec-mocks (2.99.3)
     shoulda-matchers (2.8.0)
       activesupport (>= 3.0.0)
-    simple_params (1.3.6)
+    simple_params (1.4.0)
       activemodel (>= 3.0, < 5.0)
       shoulda-matchers (~> 2.8)
       virtus (>= 1.0.0)

data/lib/simple_action/version.rb

@@ -1,3 +1,3 @@
 module SimpleAction
-  VERSION = "1.3.6"
+  VERSION = "1.4.0"
 end

data/simple_action.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "simple_params", ">= 1.3.6", "< 2.0"
+  spec.add_dependency "simple_params", ">= 1.4", "< 2.0"
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake", "~> 10.1"
   spec.add_development_dependency "rspec", "~> 2.6"

data/spec/acceptance_spec.rb

@@ -24,13 +24,15 @@ describe "SimpleAction acceptance spec" do
 
     def execute
       name.gsub!(/[^a-zA-Z ]/,'')
-      if name == "outlier"
-        errors.add(:name, "can't be outlier")
-      elsif date_of_birth.present?
+      errors.add(:name, "can't be outlier") if name == "outlier"
+
+      formatted_name = if date_of_birth.present?
         name.upcase + ' ' + date_of_birth.strftime("%m/%d/%Y")
       else
         name.upcase
       end
+
+      formatted_name + " with #{phones.count} phones."
     end
   end
 
@@ -79,7 +81,7 @@ describe "SimpleAction acceptance spec" do
     end
   end
 
-  describe "outcome" do
+  describe "acceptance cases" do
     context "with nil params" do
       let(:params) do
         {
@@ -166,7 +168,7 @@ describe "SimpleAction acceptance spec" do
       describe "result" do
         subject { SimpleActionAcceptance.run(params).result }
 
-        it { should eq("BILLY") }
+        it { should eq("BILLY with 1 phones.") }
       end
 
       describe "effects" do
@@ -204,7 +206,7 @@ describe "SimpleAction acceptance spec" do
       describe "result" do
         subject { SimpleActionAcceptance.run(params).result }
 
-        it { should eq("BILLY 06/05/1984") }
+        it { should eq("BILLY 06/05/1984 with 1 phones.") }
       end
 
       describe "effects" do
@@ -244,7 +246,7 @@ describe "SimpleAction acceptance spec" do
       describe "result" do
         subject { SimpleActionAcceptance.run(params).result }
 
-        it { should eq("BILLY 06/05/1984") }
+        it { should eq("BILLY 06/05/1984 with 1 phones.") }
       end
 
       describe "effects" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: simple_action
 version: !ruby/object:Gem::Version
-  version: 1.3.6
+  version: 1.4.0
 platform: ruby
 authors:
 - brycesenz
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: '1.4'
     - - <
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: '1.4'
     - - <
       - !ruby/object:Gem::Version
         version: '2.0'